All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] ibmvscsis: Fix cleaning up pointers
@ 2017-05-09 16:50 ` Bryant G. Ly
  0 siblings, 0 replies; 5+ messages in thread
From: Bryant G. Ly @ 2017-05-09 16:50 UTC (permalink / raw)
  To: nab
  Cc: mikecyr, mikecyr, seroyer, linux-scsi, target-devel,
	Bryant G. Ly, stable

This patch is dependent on:
'commit 25e78531268e ("ibmvscsis: Do not send aborted task response")'
This patch cleans up some pointers after usage.

Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
Reviewed-by: Michael Cyr <mikecyr@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> # v4.8+
---
 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index d390325..ee64241 100644
--- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
+++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -1170,6 +1170,8 @@ static struct ibmvscsis_cmd *ibmvscsis_get_free_cmd(struct scsi_info *vscsi)
 		cmd = list_first_entry_or_null(&vscsi->free_cmd,
 					       struct ibmvscsis_cmd, list);
 		if (cmd) {
+			if (cmd->abort_cmd)
+				cmd->abort_cmd = NULL;
 			cmd->flags &= ~(DELAY_SEND);
 			list_del(&cmd->list);
 			cmd->iue = iue;
@@ -1774,6 +1776,7 @@ static void ibmvscsis_send_messages(struct scsi_info *vscsi)
 				if (cmd->abort_cmd) {
 					retry = true;
 					cmd->abort_cmd->flags &= ~(DELAY_SEND);
+					cmd->abort_cmd = NULL;
 				}
 
 				/*
-- 
2.5.4 (Apple Git-61)

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH v1] ibmvscsis: Fix cleaning up pointers
@ 2017-05-09 16:50 ` Bryant G. Ly
  0 siblings, 0 replies; 5+ messages in thread
From: Bryant G. Ly @ 2017-05-09 16:50 UTC (permalink / raw)
  To: nab
  Cc: mikecyr, mikecyr, seroyer, linux-scsi, target-devel,
	Bryant G. Ly, stable

This patch is dependent on:
'commit 25e78531268e ("ibmvscsis: Do not send aborted task response")'
This patch cleans up some pointers after usage.

Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
Reviewed-by: Michael Cyr <mikecyr@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> # v4.8+
---
 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index d390325..ee64241 100644
--- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
+++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -1170,6 +1170,8 @@ static struct ibmvscsis_cmd *ibmvscsis_get_free_cmd(struct scsi_info *vscsi)
 		cmd = list_first_entry_or_null(&vscsi->free_cmd,
 					       struct ibmvscsis_cmd, list);
 		if (cmd) {
+			if (cmd->abort_cmd)
+				cmd->abort_cmd = NULL;
 			cmd->flags &= ~(DELAY_SEND);
 			list_del(&cmd->list);
 			cmd->iue = iue;
@@ -1774,6 +1776,7 @@ static void ibmvscsis_send_messages(struct scsi_info *vscsi)
 				if (cmd->abort_cmd) {
 					retry = true;
 					cmd->abort_cmd->flags &= ~(DELAY_SEND);
+					cmd->abort_cmd = NULL;
 				}
 
 				/*
-- 
2.5.4 (Apple Git-61)

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH v1] ibmvscsis: Fix cleaning up pointers
  2017-05-09 16:50 ` Bryant G. Ly
  (?)
@ 2017-05-10  3:45 ` Nicholas A. Bellinger
  2017-05-11 15:40   ` Bryant G. Ly
  -1 siblings, 1 reply; 5+ messages in thread
From: Nicholas A. Bellinger @ 2017-05-10  3:45 UTC (permalink / raw)
  To: Bryant G. Ly; +Cc: mikecyr, mikecyr, seroyer, linux-scsi, target-devel, stable

On Tue, 2017-05-09 at 11:50 -0500, Bryant G. Ly wrote:
> This patch is dependent on:
> 'commit 25e78531268e ("ibmvscsis: Do not send aborted task response")'
> This patch cleans up some pointers after usage.
> 
> Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
> Reviewed-by: Michael Cyr <mikecyr@linux.vnet.ibm.com>
> Cc: <stable@vger.kernel.org> # v4.8+
> ---
>  drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied, with a more verbose commit message.

Thanks for splitting this out into an incremental patch.

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v1] ibmvscsis: Fix cleaning up pointers
  2017-05-10  3:45 ` Nicholas A. Bellinger
@ 2017-05-11 15:40   ` Bryant G. Ly
  2017-05-11 17:21     ` Nicholas A. Bellinger
  0 siblings, 1 reply; 5+ messages in thread
From: Bryant G. Ly @ 2017-05-11 15:40 UTC (permalink / raw)
  To: Nicholas A. Bellinger
  Cc: mikecyr, mikecyr, seroyer, linux-scsi, target-devel, stable

On 5/9/17 10:45 PM, Nicholas A. Bellinger wrote:

> On Tue, 2017-05-09 at 11:50 -0500, Bryant G. Ly wrote:
>> This patch is dependent on:
>> 'commit 25e78531268e ("ibmvscsis: Do not send aborted task response")'
>> This patch cleans up some pointers after usage.
>>
>> Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
>> Reviewed-by: Michael Cyr <mikecyr@linux.vnet.ibm.com>
>> Cc: <stable@vger.kernel.org> # v4.8+
>> ---
>>   drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +++
>>   1 file changed, 3 insertions(+)
> Applied, with a more verbose commit message.
>
> Thanks for splitting this out into an incremental patch.
>
No problem, did you end up forgetting it once you reverted Bart's VERIFY/WRITE VERIFY patch?

It seems to be missing from your for-next now.

-Bryant

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v1] ibmvscsis: Fix cleaning up pointers
  2017-05-11 15:40   ` Bryant G. Ly
@ 2017-05-11 17:21     ` Nicholas A. Bellinger
  0 siblings, 0 replies; 5+ messages in thread
From: Nicholas A. Bellinger @ 2017-05-11 17:21 UTC (permalink / raw)
  To: Bryant G. Ly; +Cc: mikecyr, mikecyr, seroyer, linux-scsi, target-devel, stable

On Thu, 2017-05-11 at 10:40 -0500, Bryant G. Ly wrote:
> On 5/9/17 10:45 PM, Nicholas A. Bellinger wrote:
> 
> > On Tue, 2017-05-09 at 11:50 -0500, Bryant G. Ly wrote:
> >> This patch is dependent on:
> >> 'commit 25e78531268e ("ibmvscsis: Do not send aborted task response")'
> >> This patch cleans up some pointers after usage.
> >>
> >> Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
> >> Reviewed-by: Michael Cyr <mikecyr@linux.vnet.ibm.com>
> >> Cc: <stable@vger.kernel.org> # v4.8+
> >> ---
> >>   drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +++
> >>   1 file changed, 3 insertions(+)
> > Applied, with a more verbose commit message.
> >
> > Thanks for splitting this out into an incremental patch.
> >
> No problem, did you end up forgetting it once you reverted Bart's VERIFY/WRITE VERIFY patch?
> 
> It seems to be missing from your for-next now.
> 

Yep, going to include it post -rc1 with your latest patch.

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-11 17:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-09 16:50 [PATCH v1] ibmvscsis: Fix cleaning up pointers Bryant G. Ly
2017-05-09 16:50 ` Bryant G. Ly
2017-05-10  3:45 ` Nicholas A. Bellinger
2017-05-11 15:40   ` Bryant G. Ly
2017-05-11 17:21     ` Nicholas A. Bellinger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.