* [PATCH] dmaengine: usb-dmac: Fix DMAOR AE bit definition
@ 2017-05-15 8:49 Yoshihiro Shimoda
2017-05-15 9:05 ` Geert Uytterhoeven
2017-05-16 4:29 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Yoshihiro Shimoda @ 2017-05-15 8:49 UTC (permalink / raw)
To: vinod.koul
Cc: dmaengine, linux-renesas-soc, Hiroyuki Yokoyama, stable,
Yoshihiro Shimoda
From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
This patch fixes the register definition of AE (Address Error flag) bit.
Fixes: 0c1c8ff32fa2 ("dmaengine: usb-dmac: Add Renesas USB DMA Controller (USB-DMAC) driver")
Cc: <stable@vger.kernel.org> # v4.1+
Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
[Shimoda: add Fixes and Cc tags in the commit log]
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
drivers/dma/sh/usb-dmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
index 72c6497..31a1451 100644
--- a/drivers/dma/sh/usb-dmac.c
+++ b/drivers/dma/sh/usb-dmac.c
@@ -117,7 +117,7 @@ struct usb_dmac {
#define USB_DMASWR 0x0008
#define USB_DMASWR_SWR (1 << 0)
#define USB_DMAOR 0x0060
-#define USB_DMAOR_AE (1 << 2)
+#define USB_DMAOR_AE (1 << 1)
#define USB_DMAOR_DME (1 << 0)
#define USB_DMASAR 0x0000
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: usb-dmac: Fix DMAOR AE bit definition
2017-05-15 8:49 [PATCH] dmaengine: usb-dmac: Fix DMAOR AE bit definition Yoshihiro Shimoda
@ 2017-05-15 9:05 ` Geert Uytterhoeven
2017-05-16 4:29 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2017-05-15 9:05 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Vinod Koul, dmaengine, Linux-Renesas, Hiroyuki Yokoyama, stable
On Mon, May 15, 2017 at 10:49 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
>
> This patch fixes the register definition of AE (Address Error flag) bit.
>
> Fixes: 0c1c8ff32fa2 ("dmaengine: usb-dmac: Add Renesas USB DMA Controller (USB-DMAC) driver")
> Cc: <stable@vger.kernel.org> # v4.1+
> Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
> [Shimoda: add Fixes and Cc tags in the commit log]
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
This matches my documentation, where the AE bit in the DMAOR register
is indeed different for USB-DMAC, compared to SYS-DMAC and AUDIO-DMAC.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: usb-dmac: Fix DMAOR AE bit definition
2017-05-15 8:49 [PATCH] dmaengine: usb-dmac: Fix DMAOR AE bit definition Yoshihiro Shimoda
2017-05-15 9:05 ` Geert Uytterhoeven
@ 2017-05-16 4:29 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2017-05-16 4:29 UTC (permalink / raw)
To: Yoshihiro Shimoda; +Cc: dmaengine, linux-renesas-soc, Hiroyuki Yokoyama, stable
On Mon, May 15, 2017 at 05:49:52PM +0900, Yoshihiro Shimoda wrote:
> From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
>
> This patch fixes the register definition of AE (Address Error flag) bit.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-16 4:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-15 8:49 [PATCH] dmaengine: usb-dmac: Fix DMAOR AE bit definition Yoshihiro Shimoda
2017-05-15 9:05 ` Geert Uytterhoeven
2017-05-16 4:29 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.