All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xen.org
Cc: linux-kernel@vger.kernel.org, sstabellini@kernel.org,
	jgross@suse.com, boris.ostrovsky@oracle.com,
	Stefano Stabellini <stefano@aporeto.com>
Subject: [PATCH 09/18] xen/pvcalls: implement bind command
Date: Mon, 15 May 2017 13:36:01 -0700	[thread overview]
Message-ID: <1494880570-14209-9-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1494880570-14209-1-git-send-email-sstabellini@kernel.org>

Allocate a socket. Track the allocated passive sockets with a new data
structure named sockpass_mapping. It contains an unbound workqueue to
schedule delayed work for the accept and poll commands. It also has a
reqcopy field to be used to store a copy of a request for delayed work.
Reads/writes to it are protected by a lock (the "copy_lock" spinlock).
Initialize the workqueue in pvcalls_back_bind.

Implement the bind command with inet_bind.

The pass_sk_data_ready event handler will be added later.

Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
CC: boris.ostrovsky@oracle.com
CC: jgross@suse.com
---
 drivers/xen/pvcalls-back.c | 89 +++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 88 insertions(+), 1 deletion(-)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index 9ac1cf2..ff4634d 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -82,6 +82,18 @@ struct sock_mapping {
 	void (*saved_data_ready)(struct sock *sk);
 };
 
+struct sockpass_mapping {
+	struct list_head list;
+	struct pvcalls_back_priv *priv;
+	struct socket *sock;
+	uint64_t id;
+	struct xen_pvcalls_request reqcopy;
+	spinlock_t copy_lock;
+	struct workqueue_struct *wq;
+	struct work_struct register_work;
+	void (*saved_data_ready)(struct sock *sk);
+};
+
 static irqreturn_t pvcalls_back_conn_event(int irq, void *sock_map);
 static int pvcalls_back_release_active(struct xenbus_device *dev,
 				       struct pvcalls_back_priv *priv,
@@ -249,10 +261,85 @@ static int pvcalls_back_release(struct xenbus_device *dev,
 	return 0;
 }
 
+static void __pvcalls_back_accept(struct work_struct *work)
+{
+}
+
+static void pvcalls_pass_sk_data_ready(struct sock *sock)
+{
+}
+
 static int pvcalls_back_bind(struct xenbus_device *dev,
 			     struct xen_pvcalls_request *req)
 {
-	return 0;
+	struct pvcalls_back_priv *priv;
+	int ret, err;
+	struct socket *sock;
+	struct sockpass_mapping *map = NULL;
+	struct xen_pvcalls_response *rsp;
+
+	if (dev == NULL)
+		return 0;
+	priv = dev_get_drvdata(&dev->dev);
+
+	map = kzalloc(sizeof(*map), GFP_KERNEL);
+	if (map == NULL) {
+		ret = -ENOMEM;
+		goto out;
+	}
+
+	INIT_WORK(&map->register_work, __pvcalls_back_accept);
+	spin_lock_init(&map->copy_lock);
+	map->wq = alloc_workqueue("pvcalls_wq", WQ_UNBOUND, 1);
+	if (!map->wq) {
+		ret = -ENOMEM;
+		kfree(map);
+		goto out;
+	}
+
+	ret = sock_create(AF_INET, SOCK_STREAM, 0, &sock);
+	if (ret < 0) {
+		destroy_workqueue(map->wq);
+		kfree(map);
+		goto out;
+	}
+
+	ret = inet_bind(sock, (struct sockaddr *)&req->u.bind.addr,
+			req->u.bind.len);
+	if (ret < 0) {
+		destroy_workqueue(map->wq);
+		kfree(map);
+		goto out;
+	}
+
+	map->priv = priv;
+	map->sock = sock;
+	map->id = req->u.bind.id;
+
+	down_write(&priv->pvcallss_lock);
+	err = radix_tree_insert(&priv->socketpass_mappings, map->id,
+				map);
+	up_write(&priv->pvcallss_lock);
+	if (err) {
+		ret = err;
+		destroy_workqueue(map->wq);
+		kfree(map);
+		goto out;
+	}
+
+	lock_sock(sock->sk);
+	map->saved_data_ready = sock->sk->sk_data_ready;
+	sock->sk->sk_user_data = map;
+	sock->sk->sk_data_ready = pvcalls_pass_sk_data_ready;
+	release_sock(sock->sk);
+
+out:
+	rsp = RING_GET_RESPONSE(&priv->ring, priv->ring.rsp_prod_pvt++);
+	rsp->req_id = req->req_id;
+	rsp->cmd = req->cmd;
+	rsp->u.bind.id = req->u.bind.id;
+	rsp->ret = ret;
+	return 1;
 }
 
 static int pvcalls_back_listen(struct xenbus_device *dev,
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xen.org
Cc: jgross@suse.com, Stefano Stabellini <stefano@aporeto.com>,
	boris.ostrovsky@oracle.com, sstabellini@kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 09/18] xen/pvcalls: implement bind command
Date: Mon, 15 May 2017 13:36:01 -0700	[thread overview]
Message-ID: <1494880570-14209-9-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1494880570-14209-1-git-send-email-sstabellini@kernel.org>

Allocate a socket. Track the allocated passive sockets with a new data
structure named sockpass_mapping. It contains an unbound workqueue to
schedule delayed work for the accept and poll commands. It also has a
reqcopy field to be used to store a copy of a request for delayed work.
Reads/writes to it are protected by a lock (the "copy_lock" spinlock).
Initialize the workqueue in pvcalls_back_bind.

Implement the bind command with inet_bind.

The pass_sk_data_ready event handler will be added later.

Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
CC: boris.ostrovsky@oracle.com
CC: jgross@suse.com
---
 drivers/xen/pvcalls-back.c | 89 +++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 88 insertions(+), 1 deletion(-)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index 9ac1cf2..ff4634d 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -82,6 +82,18 @@ struct sock_mapping {
 	void (*saved_data_ready)(struct sock *sk);
 };
 
+struct sockpass_mapping {
+	struct list_head list;
+	struct pvcalls_back_priv *priv;
+	struct socket *sock;
+	uint64_t id;
+	struct xen_pvcalls_request reqcopy;
+	spinlock_t copy_lock;
+	struct workqueue_struct *wq;
+	struct work_struct register_work;
+	void (*saved_data_ready)(struct sock *sk);
+};
+
 static irqreturn_t pvcalls_back_conn_event(int irq, void *sock_map);
 static int pvcalls_back_release_active(struct xenbus_device *dev,
 				       struct pvcalls_back_priv *priv,
@@ -249,10 +261,85 @@ static int pvcalls_back_release(struct xenbus_device *dev,
 	return 0;
 }
 
+static void __pvcalls_back_accept(struct work_struct *work)
+{
+}
+
+static void pvcalls_pass_sk_data_ready(struct sock *sock)
+{
+}
+
 static int pvcalls_back_bind(struct xenbus_device *dev,
 			     struct xen_pvcalls_request *req)
 {
-	return 0;
+	struct pvcalls_back_priv *priv;
+	int ret, err;
+	struct socket *sock;
+	struct sockpass_mapping *map = NULL;
+	struct xen_pvcalls_response *rsp;
+
+	if (dev == NULL)
+		return 0;
+	priv = dev_get_drvdata(&dev->dev);
+
+	map = kzalloc(sizeof(*map), GFP_KERNEL);
+	if (map == NULL) {
+		ret = -ENOMEM;
+		goto out;
+	}
+
+	INIT_WORK(&map->register_work, __pvcalls_back_accept);
+	spin_lock_init(&map->copy_lock);
+	map->wq = alloc_workqueue("pvcalls_wq", WQ_UNBOUND, 1);
+	if (!map->wq) {
+		ret = -ENOMEM;
+		kfree(map);
+		goto out;
+	}
+
+	ret = sock_create(AF_INET, SOCK_STREAM, 0, &sock);
+	if (ret < 0) {
+		destroy_workqueue(map->wq);
+		kfree(map);
+		goto out;
+	}
+
+	ret = inet_bind(sock, (struct sockaddr *)&req->u.bind.addr,
+			req->u.bind.len);
+	if (ret < 0) {
+		destroy_workqueue(map->wq);
+		kfree(map);
+		goto out;
+	}
+
+	map->priv = priv;
+	map->sock = sock;
+	map->id = req->u.bind.id;
+
+	down_write(&priv->pvcallss_lock);
+	err = radix_tree_insert(&priv->socketpass_mappings, map->id,
+				map);
+	up_write(&priv->pvcallss_lock);
+	if (err) {
+		ret = err;
+		destroy_workqueue(map->wq);
+		kfree(map);
+		goto out;
+	}
+
+	lock_sock(sock->sk);
+	map->saved_data_ready = sock->sk->sk_data_ready;
+	sock->sk->sk_user_data = map;
+	sock->sk->sk_data_ready = pvcalls_pass_sk_data_ready;
+	release_sock(sock->sk);
+
+out:
+	rsp = RING_GET_RESPONSE(&priv->ring, priv->ring.rsp_prod_pvt++);
+	rsp->req_id = req->req_id;
+	rsp->cmd = req->cmd;
+	rsp->u.bind.id = req->u.bind.id;
+	rsp->ret = ret;
+	return 1;
 }
 
 static int pvcalls_back_listen(struct xenbus_device *dev,
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-05-15 20:39 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15 20:35 [PATCH 00/18] introduce the Xen PV Calls backend Stefano Stabellini
2017-05-15 20:35 ` [PATCH 01/18] xen: introduce the pvcalls interface header Stefano Stabellini
2017-05-15 20:35   ` [PATCH 02/18] xen/pvcalls: introduce the pvcalls xenbus backend Stefano Stabellini
2017-05-15 20:35   ` Stefano Stabellini
2017-05-15 20:35   ` [PATCH 03/18] xen/pvcalls: initialize the module and register the " Stefano Stabellini
2017-05-15 20:35     ` Stefano Stabellini
2017-05-16  1:28     ` Boris Ostrovsky
2017-05-16 20:05       ` Stefano Stabellini
2017-05-16 20:05       ` Stefano Stabellini
2017-05-16 20:22         ` Stefano Stabellini
2017-05-16 20:22         ` Stefano Stabellini
2017-05-16  1:28     ` Boris Ostrovsky
2017-05-16  6:40     ` Juergen Gross
2017-05-16 19:58       ` Stefano Stabellini
2017-05-16 19:58       ` Stefano Stabellini
2017-05-17  5:21         ` Juergen Gross
2017-05-17  5:21         ` Juergen Gross
2017-05-18 21:18           ` Stefano Stabellini
2017-05-19 22:33             ` Stefano Stabellini
2017-05-19 22:33             ` Stefano Stabellini
2017-05-18 21:18           ` Stefano Stabellini
2017-05-16  6:40     ` Juergen Gross
2017-05-15 20:35   ` [PATCH 04/18] xen/pvcalls: xenbus state handling Stefano Stabellini
2017-05-15 20:35     ` Stefano Stabellini
2017-05-16  1:34     ` Boris Ostrovsky
2017-05-16  1:34       ` Boris Ostrovsky
2017-05-16 20:11       ` Stefano Stabellini
2017-05-16 20:11       ` Stefano Stabellini
2017-05-15 20:35   ` [PATCH 05/18] xen/pvcalls: connect to a frontend Stefano Stabellini
2017-05-15 20:35     ` Stefano Stabellini
2017-05-16  1:52     ` Boris Ostrovsky
2017-05-16  1:52     ` Boris Ostrovsky
2017-05-16 20:23       ` Stefano Stabellini
2017-05-16 20:23       ` Stefano Stabellini
2017-05-16 20:38         ` Stefano Stabellini
2017-05-16 20:38         ` Stefano Stabellini
2017-05-15 20:35   ` [PATCH 06/18] xen/pvcalls: handle commands from the frontend Stefano Stabellini
2017-05-15 20:35     ` Stefano Stabellini
2017-05-16  2:06     ` Boris Ostrovsky
2017-05-16 20:57       ` Stefano Stabellini
2017-05-16 20:57       ` Stefano Stabellini
2017-05-16  2:06     ` Boris Ostrovsky
2017-05-15 20:35   ` [PATCH 07/18] xen/pvcalls: implement socket command Stefano Stabellini
2017-05-15 20:35     ` Stefano Stabellini
2017-05-16  2:12     ` Boris Ostrovsky
2017-05-16 20:45       ` Stefano Stabellini
2017-05-16 20:45       ` Stefano Stabellini
2017-05-16  2:12     ` Boris Ostrovsky
2017-05-15 20:36   ` [PATCH 08/18] xen/pvcalls: implement connect command Stefano Stabellini
2017-05-16  2:36     ` Boris Ostrovsky
2017-05-16 21:02       ` Stefano Stabellini
2017-05-16 21:02       ` Stefano Stabellini
2017-05-16 21:56         ` Boris Ostrovsky
2017-05-16 21:56         ` Boris Ostrovsky
2017-05-18 19:10           ` Stefano Stabellini
2017-05-18 20:19             ` Boris Ostrovsky
2017-05-18 20:19             ` Boris Ostrovsky
2017-05-18 19:10           ` Stefano Stabellini
2017-05-16  2:36     ` Boris Ostrovsky
2017-05-15 20:36   ` Stefano Stabellini
2017-05-15 20:36   ` Stefano Stabellini [this message]
2017-05-15 20:36     ` [PATCH 09/18] xen/pvcalls: implement bind command Stefano Stabellini
2017-05-15 20:36   ` [PATCH 10/18] xen/pvcalls: implement listen command Stefano Stabellini
2017-05-15 20:36   ` Stefano Stabellini
2017-05-15 20:36   ` [PATCH 11/18] xen/pvcalls: implement accept command Stefano Stabellini
2017-05-15 20:36     ` Stefano Stabellini
2017-05-15 20:36   ` [PATCH 12/18] xen/pvcalls: implement poll command Stefano Stabellini
2017-05-15 20:36     ` Stefano Stabellini
2017-05-15 20:36   ` [PATCH 13/18] xen/pvcalls: implement release command Stefano Stabellini
2017-05-15 20:36     ` Stefano Stabellini
2017-05-15 20:36   ` [PATCH 14/18] xen/pvcalls: disconnect and module_exit Stefano Stabellini
2017-05-15 20:36   ` Stefano Stabellini
2017-05-15 20:36   ` [PATCH 15/18] xen/pvcalls: introduce the ioworker Stefano Stabellini
2017-05-15 20:36   ` Stefano Stabellini
2017-05-15 20:36   ` [PATCH 16/18] xen/pvcalls: implement read Stefano Stabellini
2017-05-15 20:36     ` Stefano Stabellini
2017-05-15 20:36   ` [PATCH 17/18] xen/pvcalls: implement write Stefano Stabellini
2017-05-15 20:36   ` Stefano Stabellini
2017-05-15 20:36   ` [PATCH 18/18] xen: introduce a Kconfig option to enable the pvcalls backend Stefano Stabellini
2017-05-15 20:36     ` Stefano Stabellini
2017-05-15 20:35 ` [PATCH 01/18] xen: introduce the pvcalls interface header Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494880570-14209-9-git-send-email-sstabellini@kernel.org \
    --to=sstabellini@kernel.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefano@aporeto.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.