All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "ovl: do not set overlay.opaque on non-dir create" has been added to the 4.11-stable tree
@ 2017-05-17 15:56 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-05-17 15:56 UTC (permalink / raw)
  To: amir73il, gregkh, mszeredi; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    ovl: do not set overlay.opaque on non-dir create

to the 4.11-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ovl-do-not-set-overlay.opaque-on-non-dir-create.patch
and it can be found in the queue-4.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 4a99f3c83dc493c8ea84693d78cd792839c8aa64 Mon Sep 17 00:00:00 2001
From: Amir Goldstein <amir73il@gmail.com>
Date: Mon, 24 Apr 2017 22:26:40 +0300
Subject: ovl: do not set overlay.opaque on non-dir create

From: Amir Goldstein <amir73il@gmail.com>

commit 4a99f3c83dc493c8ea84693d78cd792839c8aa64 upstream.

The optimization for opaque dir create was wrongly being applied
also to non-dir create.

Fixes: 97c684cc9110 ("ovl: create directories inside merged parent opaque")
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/overlayfs/dir.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/overlayfs/dir.c
+++ b/fs/overlayfs/dir.c
@@ -210,7 +210,7 @@ static int ovl_create_upper(struct dentr
 	if (err)
 		goto out_dput;
 
-	if (ovl_type_merge(dentry->d_parent)) {
+	if (ovl_type_merge(dentry->d_parent) && d_is_dir(newdentry)) {
 		/* Setting opaque here is just an optimization, allow to fail */
 		ovl_set_opaque(dentry, newdentry);
 	}


Patches currently in stable-queue which might be from amir73il@gmail.com are

queue-4.11/ovl-do-not-set-overlay.opaque-on-non-dir-create.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-05-17 15:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-17 15:56 Patch "ovl: do not set overlay.opaque on non-dir create" has been added to the 4.11-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.