All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "ALSA: timer: Fix leak in events via snd_timer_user_ccallback" has been added to the 3.18-stable tree
@ 2017-05-18 12:22 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-05-18 12:22 UTC (permalink / raw)
  To: kangjielu, amit.pundir, gregkh, kjlu, tiwai; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    ALSA: timer: Fix leak in events via snd_timer_user_ccallback

to the 3.18-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     alsa-timer-fix-leak-in-events-via-snd_timer_user_ccallback.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 9a47e9cff994f37f7f0dbd9ae23740d0f64f9fe6 Mon Sep 17 00:00:00 2001
From: Kangjie Lu <kangjielu@gmail.com>
Date: Tue, 3 May 2016 16:44:20 -0400
Subject: ALSA: timer: Fix leak in events via snd_timer_user_ccallback
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Kangjie Lu <kangjielu@gmail.com>

commit 9a47e9cff994f37f7f0dbd9ae23740d0f64f9fe6 upstream.

The stack object “r1” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.

Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 sound/core/timer.c |    1 +
 1 file changed, 1 insertion(+)

--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -1260,6 +1260,7 @@ static void snd_timer_user_ccallback(str
 		tu->tstamp = *tstamp;
 	if ((tu->filter & (1 << event)) == 0 || !tu->tread)
 		return;
+	memset(&r1, 0, sizeof(r1));
 	r1.event = event;
 	r1.tstamp = *tstamp;
 	r1.val = resolution;


Patches currently in stable-queue which might be from kangjielu@gmail.com are

queue-3.18/alsa-timer-fix-leak-in-events-via-snd_timer_user_ccallback.patch
queue-3.18/alsa-timer-fix-leak-in-sndrv_timer_ioctl_params.patch
queue-3.18/alsa-timer-fix-leak-in-events-via-snd_timer_user_tinterrupt.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-05-18 12:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-18 12:22 Patch "ALSA: timer: Fix leak in events via snd_timer_user_ccallback" has been added to the 3.18-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.