* [PATCH] ath10k : Fix channel survey dump
@ 2017-04-26 14:41 ` Venkateswara Rao Naralasetty
0 siblings, 0 replies; 14+ messages in thread
From: Venkateswara Rao Naralasetty @ 2017-04-26 14:41 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Venkateswara Rao Naralasetty
Channel active/busy time are showing incorrect
(less than previous or sometimes zero) for
successive survey dump command.
example:
Survey data from wlan0
frequency: 5180 MHz [in use]
channel active time: 54995 ms
channel busy time: 432 ms
channel receive time: 0 ms
channel transmit time: 59 ms
Survey data from wlan0
frequency: 5180 MHz [in use]
channel active time: 32592 ms
channel busy time: 254 ms
channel receive time: 0 ms
channel transmit time: 0 ms
This patch fix this issue by assigning 'wmi_bss_survey_req_type'
as 'WMI_BSS_SURVEY_REQ_TYPE_READ'.
Firmware ver 10.4-3.4-00082
Hardware QCA4019
Signed-off-by: Venkateswara Rao Naralasetty <c_vnaral@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 9977829..87a9b55 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -6621,7 +6621,7 @@ static void ath10k_reconfig_complete(struct ieee80211_hw *hw,
struct ieee80211_channel *channel)
{
int ret;
- enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;
+ enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ;
lockdep_assert_held(&ar->conf_mutex);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] ath10k : Fix channel survey dump
@ 2017-04-26 14:41 ` Venkateswara Rao Naralasetty
0 siblings, 0 replies; 14+ messages in thread
From: Venkateswara Rao Naralasetty @ 2017-04-26 14:41 UTC (permalink / raw)
To: ath10k; +Cc: Venkateswara Rao Naralasetty, linux-wireless
Channel active/busy time are showing incorrect
(less than previous or sometimes zero) for
successive survey dump command.
example:
Survey data from wlan0
frequency: 5180 MHz [in use]
channel active time: 54995 ms
channel busy time: 432 ms
channel receive time: 0 ms
channel transmit time: 59 ms
Survey data from wlan0
frequency: 5180 MHz [in use]
channel active time: 32592 ms
channel busy time: 254 ms
channel receive time: 0 ms
channel transmit time: 0 ms
This patch fix this issue by assigning 'wmi_bss_survey_req_type'
as 'WMI_BSS_SURVEY_REQ_TYPE_READ'.
Firmware ver 10.4-3.4-00082
Hardware QCA4019
Signed-off-by: Venkateswara Rao Naralasetty <c_vnaral@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 9977829..87a9b55 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -6621,7 +6621,7 @@ static void ath10k_reconfig_complete(struct ieee80211_hw *hw,
struct ieee80211_channel *channel)
{
int ret;
- enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;
+ enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ;
lockdep_assert_held(&ar->conf_mutex);
--
1.7.9.5
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] ath10k : Fix channel survey dump
2017-04-26 14:41 ` Venkateswara Rao Naralasetty
@ 2017-04-26 15:29 ` Felix Fietkau
-1 siblings, 0 replies; 14+ messages in thread
From: Felix Fietkau @ 2017-04-26 15:29 UTC (permalink / raw)
To: Venkateswara Rao Naralasetty, ath10k; +Cc: linux-wireless
On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote:
> Channel active/busy time are showing incorrect
> (less than previous or sometimes zero) for
> successive survey dump command.
>
> example:
> Survey data from wlan0
> frequency: 5180 MHz [in use]
> channel active time: 54995 ms
> channel busy time: 432 ms
> channel receive time: 0 ms
> channel transmit time: 59 ms
> Survey data from wlan0
> frequency: 5180 MHz [in use]
> channel active time: 32592 ms
> channel busy time: 254 ms
> channel receive time: 0 ms
> channel transmit time: 0 ms
>
> This patch fix this issue by assigning 'wmi_bss_survey_req_type'
> as 'WMI_BSS_SURVEY_REQ_TYPE_READ'.
>
> Firmware ver 10.4-3.4-00082
> Hardware QCA4019
>
> Signed-off-by: Venkateswara Rao Naralasetty <c_vnaral@qti.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 9977829..87a9b55 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -6621,7 +6621,7 @@ static void ath10k_reconfig_complete(struct ieee80211_hw *hw,
> struct ieee80211_channel *channel)
> {
> int ret;
> - enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;
> + enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ;
Does the firmware read the registers directly, or does it accumulate the
results in a way that can't overflow?
If you don't clear the counters on reset, the overflow will be
problematic for the current-channel stats.
I think a better approach would be to use READ_CLEAR for in-use channels
and store the sum inside the driver.
- Felix
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ath10k : Fix channel survey dump
@ 2017-04-26 15:29 ` Felix Fietkau
0 siblings, 0 replies; 14+ messages in thread
From: Felix Fietkau @ 2017-04-26 15:29 UTC (permalink / raw)
To: Venkateswara Rao Naralasetty, ath10k; +Cc: linux-wireless
On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote:
> Channel active/busy time are showing incorrect
> (less than previous or sometimes zero) for
> successive survey dump command.
>
> example:
> Survey data from wlan0
> frequency: 5180 MHz [in use]
> channel active time: 54995 ms
> channel busy time: 432 ms
> channel receive time: 0 ms
> channel transmit time: 59 ms
> Survey data from wlan0
> frequency: 5180 MHz [in use]
> channel active time: 32592 ms
> channel busy time: 254 ms
> channel receive time: 0 ms
> channel transmit time: 0 ms
>
> This patch fix this issue by assigning 'wmi_bss_survey_req_type'
> as 'WMI_BSS_SURVEY_REQ_TYPE_READ'.
>
> Firmware ver 10.4-3.4-00082
> Hardware QCA4019
>
> Signed-off-by: Venkateswara Rao Naralasetty <c_vnaral@qti.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 9977829..87a9b55 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -6621,7 +6621,7 @@ static void ath10k_reconfig_complete(struct ieee80211_hw *hw,
> struct ieee80211_channel *channel)
> {
> int ret;
> - enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;
> + enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ;
Does the firmware read the registers directly, or does it accumulate the
results in a way that can't overflow?
If you don't clear the counters on reset, the overflow will be
problematic for the current-channel stats.
I think a better approach would be to use READ_CLEAR for in-use channels
and store the sum inside the driver.
- Felix
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ath10k : Fix channel survey dump
2017-04-26 15:29 ` Felix Fietkau
@ 2017-05-19 9:17 ` Kalle Valo
-1 siblings, 0 replies; 14+ messages in thread
From: Kalle Valo @ 2017-05-19 9:17 UTC (permalink / raw)
To: nbd; +Cc: Venkateswara Naralasettty, ath10k, linux-wireless
Felix Fietkau <nbd@nbd.name> writes:
> On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote:
>> Channel active/busy time are showing incorrect
>> (less than previous or sometimes zero) for
>> successive survey dump command.
>>=20
>> example:
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 54995 ms
>> channel busy time: 432 ms
>> channel receive time: 0 ms
>> channel transmit time: 59 ms
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 32592 ms
>> channel busy time: 254 ms
>> channel receive time: 0 ms
>> channel transmit time: 0 ms
>>=20
>> This patch fix this issue by assigning 'wmi_bss_survey_req_type'
>> as 'WMI_BSS_SURVEY_REQ_TYPE_READ'.
>>=20
>> Firmware ver 10.4-3.4-00082
>> Hardware QCA4019
>>=20
>> Signed-off-by: Venkateswara Rao Naralasetty <c_vnaral@qti.qualcomm.com>
>> ---
>> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireles=
s/ath/ath10k/mac.c
>> index 9977829..87a9b55 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -6621,7 +6621,7 @@ static void ath10k_reconfig_complete(struct ieee80=
211_hw *hw,
>> struct ieee80211_channel *channel)
>> {
>> int ret;
>> - enum wmi_bss_survey_req_type type =3D WMI_BSS_SURVEY_REQ_TYPE_READ_CLE=
AR;
>> + enum wmi_bss_survey_req_type type =3D WMI_BSS_SURVEY_REQ_TYPE_READ;
>
> Does the firmware read the registers directly, or does it accumulate
> the results in a way that can't overflow? If you don't clear the
> counters on reset, the overflow will be problematic for the
> current-channel stats. I think a better approach would be to use
> READ_CLEAR for in-use channels and store the sum inside the driver.
Venkateswara, any comments?
--=20
Kalle Valo=
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ath10k : Fix channel survey dump
@ 2017-05-19 9:17 ` Kalle Valo
0 siblings, 0 replies; 14+ messages in thread
From: Kalle Valo @ 2017-05-19 9:17 UTC (permalink / raw)
To: nbd; +Cc: Venkateswara Naralasettty, linux-wireless, ath10k
Felix Fietkau <nbd@nbd.name> writes:
> On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote:
>> Channel active/busy time are showing incorrect
>> (less than previous or sometimes zero) for
>> successive survey dump command.
>>
>> example:
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 54995 ms
>> channel busy time: 432 ms
>> channel receive time: 0 ms
>> channel transmit time: 59 ms
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 32592 ms
>> channel busy time: 254 ms
>> channel receive time: 0 ms
>> channel transmit time: 0 ms
>>
>> This patch fix this issue by assigning 'wmi_bss_survey_req_type'
>> as 'WMI_BSS_SURVEY_REQ_TYPE_READ'.
>>
>> Firmware ver 10.4-3.4-00082
>> Hardware QCA4019
>>
>> Signed-off-by: Venkateswara Rao Naralasetty <c_vnaral@qti.qualcomm.com>
>> ---
>> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
>> index 9977829..87a9b55 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -6621,7 +6621,7 @@ static void ath10k_reconfig_complete(struct ieee80211_hw *hw,
>> struct ieee80211_channel *channel)
>> {
>> int ret;
>> - enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;
>> + enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ;
>
> Does the firmware read the registers directly, or does it accumulate
> the results in a way that can't overflow? If you don't clear the
> counters on reset, the overflow will be problematic for the
> current-channel stats. I think a better approach would be to use
> READ_CLEAR for in-use channels and store the sum inside the driver.
Venkateswara, any comments?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ath10k : Fix channel survey dump
2017-05-19 9:17 ` Kalle Valo
@ 2017-05-19 15:32 ` Adrian Chadd
-1 siblings, 0 replies; 14+ messages in thread
From: Adrian Chadd @ 2017-05-19 15:32 UTC (permalink / raw)
To: Kalle Valo; +Cc: nbd, Venkateswara Naralasettty, ath10k, linux-wireless
On 19 May 2017 at 02:17, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Felix Fietkau <nbd@nbd.name> writes:
>
>> On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote:
>>> Channel active/busy time are showing incorrect
>>> (less than previous or sometimes zero) for
>>> successive survey dump command.
[snip]
>> Does the firmware read the registers directly, or does it accumulate
>> the results in a way that can't overflow? If you don't clear the
>> counters on reset, the overflow will be problematic for the
>> current-channel stats. I think a better approach would be to use
>> READ_CLEAR for in-use channels and store the sum inside the driver.
>
> Venkateswara, any comments?
I just bumped into this at work. I'm thinking of teaching mac80211
about optionally summing things so each driver doesn't need another
per-channel array.
-adrian
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ath10k : Fix channel survey dump
@ 2017-05-19 15:32 ` Adrian Chadd
0 siblings, 0 replies; 14+ messages in thread
From: Adrian Chadd @ 2017-05-19 15:32 UTC (permalink / raw)
To: Kalle Valo; +Cc: Venkateswara Naralasettty, linux-wireless, ath10k, nbd
On 19 May 2017 at 02:17, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Felix Fietkau <nbd@nbd.name> writes:
>
>> On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote:
>>> Channel active/busy time are showing incorrect
>>> (less than previous or sometimes zero) for
>>> successive survey dump command.
[snip]
>> Does the firmware read the registers directly, or does it accumulate
>> the results in a way that can't overflow? If you don't clear the
>> counters on reset, the overflow will be problematic for the
>> current-channel stats. I think a better approach would be to use
>> READ_CLEAR for in-use channels and store the sum inside the driver.
>
> Venkateswara, any comments?
I just bumped into this at work. I'm thinking of teaching mac80211
about optionally summing things so each driver doesn't need another
per-channel array.
-adrian
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ath10k : Fix channel survey dump
2017-05-19 15:32 ` Adrian Chadd
@ 2017-05-22 6:11 ` Johannes Berg
-1 siblings, 0 replies; 14+ messages in thread
From: Johannes Berg @ 2017-05-22 6:11 UTC (permalink / raw)
To: Adrian Chadd, Kalle Valo
Cc: nbd, Venkateswara Naralasettty, ath10k, linux-wireless
On Fri, 2017-05-19 at 08:32 -0700, Adrian Chadd wrote:
>
> I just bumped into this at work. I'm thinking of teaching mac80211
> about optionally summing things so each driver doesn't need another
> per-channel array.
>
We could possibly even do that in cfg80211, I guess.
johannes
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] ath10k : Fix channel survey dump
@ 2017-05-22 6:11 ` Johannes Berg
0 siblings, 0 replies; 14+ messages in thread
From: Johannes Berg @ 2017-05-22 6:11 UTC (permalink / raw)
To: Adrian Chadd, Kalle Valo
Cc: Venkateswara Naralasettty, linux-wireless, ath10k, nbd
On Fri, 2017-05-19 at 08:32 -0700, Adrian Chadd wrote:
>
> I just bumped into this at work. I'm thinking of teaching mac80211
> about optionally summing things so each driver doesn't need another
> per-channel array.
>
We could possibly even do that in cfg80211, I guess.
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH] ath10k : Fix channel survey dump
2017-05-19 9:17 ` Kalle Valo
@ 2017-05-22 15:17 ` Venkateswara Naralasettty
-1 siblings, 0 replies; 14+ messages in thread
From: Venkateswara Naralasettty @ 2017-05-22 15:17 UTC (permalink / raw)
To: Kalle Valo, nbd; +Cc: ath10k, linux-wireless
-----Original Message-----
From: Kalle Valo=20
Sent: Friday, May 19, 2017 2:48 PM
To: nbd@nbd.name
Cc: Venkateswara Naralasettty <vnaralas@qti.qualcomm.com>; ath10k@lists.inf=
radead.org; linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k : Fix channel survey dump
Felix Fietkau <nbd@nbd.name> writes:
> On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote:
>> Channel active/busy time are showing incorrect (less than previous or=20
>> sometimes zero) for successive survey dump command.
>>=20
>> example:
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 54995 ms
>> channel busy time: 432 ms
>> channel receive time: 0 ms
>> channel transmit time: 59 ms
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 32592 ms
>> channel busy time: 254 ms
>> channel receive time: 0 ms
>> channel transmit time: 0 ms
>>=20
>> This patch fix this issue by assigning 'wmi_bss_survey_req_type'
>> as 'WMI_BSS_SURVEY_REQ_TYPE_READ'.
>>=20
>> Firmware ver 10.4-3.4-00082
>> Hardware QCA4019
>>=20
>> Signed-off-by: Venkateswara Rao Naralasetty=20
>> <c_vnaral@qti.qualcomm.com>
>> ---
>> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c=20
>> b/drivers/net/wireless/ath/ath10k/mac.c
>> index 9977829..87a9b55 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -6621,7 +6621,7 @@ static void ath10k_reconfig_complete(struct ieee80=
211_hw *hw,
>> struct ieee80211_channel *channel) {
>> int ret;
>> - enum wmi_bss_survey_req_type type =3D WMI_BSS_SURVEY_REQ_TYPE_READ_CLE=
AR;
>> + enum wmi_bss_survey_req_type type =3D WMI_BSS_SURVEY_REQ_TYPE_READ;
>
> Does the firmware read the registers directly, or does it accumulate=20
> the results in a way that can't overflow? If you don't clear the=20
> counters on reset, the overflow will be problematic for the=20
> current-channel stats. I think a better approach would be to use=20
> READ_CLEAR for in-use channels and store the sum inside the driver.
Venkateswara, any comments?
--
Kalle Valo
Sorry for the delayed response I held up with some other work. Currently I =
am working with firmware team to address your comments.
--
Venkatesh.
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH] ath10k : Fix channel survey dump
@ 2017-05-22 15:17 ` Venkateswara Naralasettty
0 siblings, 0 replies; 14+ messages in thread
From: Venkateswara Naralasettty @ 2017-05-22 15:17 UTC (permalink / raw)
To: Kalle Valo, nbd; +Cc: linux-wireless, ath10k
-----Original Message-----
From: Kalle Valo
Sent: Friday, May 19, 2017 2:48 PM
To: nbd@nbd.name
Cc: Venkateswara Naralasettty <vnaralas@qti.qualcomm.com>; ath10k@lists.infradead.org; linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k : Fix channel survey dump
Felix Fietkau <nbd@nbd.name> writes:
> On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote:
>> Channel active/busy time are showing incorrect (less than previous or
>> sometimes zero) for successive survey dump command.
>>
>> example:
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 54995 ms
>> channel busy time: 432 ms
>> channel receive time: 0 ms
>> channel transmit time: 59 ms
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 32592 ms
>> channel busy time: 254 ms
>> channel receive time: 0 ms
>> channel transmit time: 0 ms
>>
>> This patch fix this issue by assigning 'wmi_bss_survey_req_type'
>> as 'WMI_BSS_SURVEY_REQ_TYPE_READ'.
>>
>> Firmware ver 10.4-3.4-00082
>> Hardware QCA4019
>>
>> Signed-off-by: Venkateswara Rao Naralasetty
>> <c_vnaral@qti.qualcomm.com>
>> ---
>> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c
>> b/drivers/net/wireless/ath/ath10k/mac.c
>> index 9977829..87a9b55 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -6621,7 +6621,7 @@ static void ath10k_reconfig_complete(struct ieee80211_hw *hw,
>> struct ieee80211_channel *channel) {
>> int ret;
>> - enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;
>> + enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ;
>
> Does the firmware read the registers directly, or does it accumulate
> the results in a way that can't overflow? If you don't clear the
> counters on reset, the overflow will be problematic for the
> current-channel stats. I think a better approach would be to use
> READ_CLEAR for in-use channels and store the sum inside the driver.
Venkateswara, any comments?
--
Kalle Valo
Sorry for the delayed response I held up with some other work. Currently I am working with firmware team to address your comments.
--
Venkatesh.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH] ath10k : Fix channel survey dump
2017-05-22 15:17 ` Venkateswara Naralasettty
@ 2017-05-30 12:01 ` Venkateswara Naralasettty
-1 siblings, 0 replies; 14+ messages in thread
From: Venkateswara Naralasettty @ 2017-05-30 12:01 UTC (permalink / raw)
To: Venkateswara Naralasettty, Kalle Valo, nbd; +Cc: linux-wireless, ath10k
-----Original Message-----
From: ath10k [mailto:ath10k-bounces@lists.infradead.org] On Behalf Of Venka=
teswara Naralasettty
Sent: Monday, May 22, 2017 8:48 PM
To: Kalle Valo <kvalo@qca.qualcomm.com>; nbd@nbd.name
Cc: linux-wireless@vger.kernel.org; ath10k@lists.infradead.org
Subject: RE: [PATCH] ath10k : Fix channel survey dump
-----Original Message-----
From: Kalle Valo
Sent: Friday, May 19, 2017 2:48 PM
To: nbd@nbd.name
Cc: Venkateswara Naralasettty <vnaralas@qti.qualcomm.com>; ath10k@lists.inf=
radead.org; linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k : Fix channel survey dump
Felix Fietkau <nbd@nbd.name> writes:
> On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote:
>> Channel active/busy time are showing incorrect (less than previous or=20
>> sometimes zero) for successive survey dump command.
>>=20
>> example:
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 54995 ms
>> channel busy time: 432 ms
>> channel receive time: 0 ms
>> channel transmit time: 59 ms
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 32592 ms
>> channel busy time: 254 ms
>> channel receive time: 0 ms
>> channel transmit time: 0 ms
>>=20
>> This patch fix this issue by assigning 'wmi_bss_survey_req_type'
>> as 'WMI_BSS_SURVEY_REQ_TYPE_READ'.
>>=20
>> Firmware ver 10.4-3.4-00082
>> Hardware QCA4019
>>=20
>> Signed-off-by: Venkateswara Rao Naralasetty=20
>> <c_vnaral@qti.qualcomm.com>
>> ---
>> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c
>> b/drivers/net/wireless/ath/ath10k/mac.c
>> index 9977829..87a9b55 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -6621,7 +6621,7 @@ static void ath10k_reconfig_complete(struct ieee80=
211_hw *hw,
>> struct ieee80211_channel *channel) {
>> int ret;
>> - enum wmi_bss_survey_req_type type =3D WMI_BSS_SURVEY_REQ_TYPE_READ_CLE=
AR;
>> + enum wmi_bss_survey_req_type type =3D WMI_BSS_SURVEY_REQ_TYPE_READ;
>
> Does the firmware read the registers directly, or does it accumulate=20
> the results in a way that can't overflow? If you don't clear the=20
> counters on reset, the overflow will be problematic for the=20
> current-channel stats. I think a better approach would be to use=20
> READ_CLEAR for in-use channels and store the sum inside the driver.
Venkateswara, any comments?
--
Kalle Valo
Sorry for the delayed response I held up with some other work. Currently I =
am working with firmware team to address your comments.
--
Venkatesh.
> Firmware is not handling the overflow while accumulating the results, we=
are looking into some other options to make it in host
-Venkatesh.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
BLOCKEDlists[.]infradead[.]org/mailman/listinfo/ath10kBLOCKED
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH] ath10k : Fix channel survey dump
@ 2017-05-30 12:01 ` Venkateswara Naralasettty
0 siblings, 0 replies; 14+ messages in thread
From: Venkateswara Naralasettty @ 2017-05-30 12:01 UTC (permalink / raw)
To: Venkateswara Naralasettty, Kalle Valo, nbd; +Cc: linux-wireless, ath10k
-----Original Message-----
From: ath10k [mailto:ath10k-bounces@lists.infradead.org] On Behalf Of Venkateswara Naralasettty
Sent: Monday, May 22, 2017 8:48 PM
To: Kalle Valo <kvalo@qca.qualcomm.com>; nbd@nbd.name
Cc: linux-wireless@vger.kernel.org; ath10k@lists.infradead.org
Subject: RE: [PATCH] ath10k : Fix channel survey dump
-----Original Message-----
From: Kalle Valo
Sent: Friday, May 19, 2017 2:48 PM
To: nbd@nbd.name
Cc: Venkateswara Naralasettty <vnaralas@qti.qualcomm.com>; ath10k@lists.infradead.org; linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k : Fix channel survey dump
Felix Fietkau <nbd@nbd.name> writes:
> On 2017-04-26 16:41, Venkateswara Rao Naralasetty wrote:
>> Channel active/busy time are showing incorrect (less than previous or
>> sometimes zero) for successive survey dump command.
>>
>> example:
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 54995 ms
>> channel busy time: 432 ms
>> channel receive time: 0 ms
>> channel transmit time: 59 ms
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 32592 ms
>> channel busy time: 254 ms
>> channel receive time: 0 ms
>> channel transmit time: 0 ms
>>
>> This patch fix this issue by assigning 'wmi_bss_survey_req_type'
>> as 'WMI_BSS_SURVEY_REQ_TYPE_READ'.
>>
>> Firmware ver 10.4-3.4-00082
>> Hardware QCA4019
>>
>> Signed-off-by: Venkateswara Rao Naralasetty
>> <c_vnaral@qti.qualcomm.com>
>> ---
>> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c
>> b/drivers/net/wireless/ath/ath10k/mac.c
>> index 9977829..87a9b55 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -6621,7 +6621,7 @@ static void ath10k_reconfig_complete(struct ieee80211_hw *hw,
>> struct ieee80211_channel *channel) {
>> int ret;
>> - enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;
>> + enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ;
>
> Does the firmware read the registers directly, or does it accumulate
> the results in a way that can't overflow? If you don't clear the
> counters on reset, the overflow will be problematic for the
> current-channel stats. I think a better approach would be to use
> READ_CLEAR for in-use channels and store the sum inside the driver.
Venkateswara, any comments?
--
Kalle Valo
Sorry for the delayed response I held up with some other work. Currently I am working with firmware team to address your comments.
--
Venkatesh.
> Firmware is not handling the overflow while accumulating the results, we are looking into some other options to make it in host
-Venkatesh.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
BLOCKEDlists[.]infradead[.]org/mailman/listinfo/ath10kBLOCKED
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2017-05-30 12:02 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-26 14:41 [PATCH] ath10k : Fix channel survey dump Venkateswara Rao Naralasetty
2017-04-26 14:41 ` Venkateswara Rao Naralasetty
2017-04-26 15:29 ` Felix Fietkau
2017-04-26 15:29 ` Felix Fietkau
2017-05-19 9:17 ` Kalle Valo
2017-05-19 9:17 ` Kalle Valo
2017-05-19 15:32 ` Adrian Chadd
2017-05-19 15:32 ` Adrian Chadd
2017-05-22 6:11 ` Johannes Berg
2017-05-22 6:11 ` Johannes Berg
2017-05-22 15:17 ` Venkateswara Naralasettty
2017-05-22 15:17 ` Venkateswara Naralasettty
2017-05-30 12:01 ` Venkateswara Naralasettty
2017-05-30 12:01 ` Venkateswara Naralasettty
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.