* [PATCH] ASoC: cs4271: Remove unnecessary additional variable definition
@ 2017-05-23 15:03 Charles Keepax
2017-05-23 17:22 ` [PATCH] ASoC: cs4271: Remove unnecessary additional variable definitio Paul Handrigan
2017-05-24 17:42 ` Applied "ASoC: cs4271: Remove unnecessary additional variable definition" to the asoc tree Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Charles Keepax @ 2017-05-23 15:03 UTC (permalink / raw)
To: broonie, brian.austin; +Cc: alsa-devel, patches, lgirdwood, Paul.Handrigan
The function already defines a ret variable at the top and makes
no particular use of the shadowed definition, as such remove the
redundant definition.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
sound/soc/codecs/cs4271.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c
index e78b5f0..d882477 100644
--- a/sound/soc/codecs/cs4271.c
+++ b/sound/soc/codecs/cs4271.c
@@ -674,8 +674,6 @@ static int cs4271_common_probe(struct device *dev,
cs4271->gpio_nreset = cs4271plat->gpio_nreset;
if (gpio_is_valid(cs4271->gpio_nreset)) {
- int ret;
-
ret = devm_gpio_request(dev, cs4271->gpio_nreset,
"CS4271 Reset");
if (ret < 0)
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: cs4271: Remove unnecessary additional variable definitio
2017-05-23 15:03 [PATCH] ASoC: cs4271: Remove unnecessary additional variable definition Charles Keepax
@ 2017-05-23 17:22 ` Paul Handrigan
2017-05-24 17:42 ` Applied "ASoC: cs4271: Remove unnecessary additional variable definition" to the asoc tree Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Paul Handrigan @ 2017-05-23 17:22 UTC (permalink / raw)
To: Charles Keepax
Cc: alsa-devel, patches, brian.austin, Paul.Handrigan, lgirdwood, broonie
On Tue, 23 May 2017, Charles Keepax wrote:
> The function already defines a ret variable at the top and makes
> no particular use of the shadowed definition, as such remove the
> redundant definition.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/cs4271.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c
> index e78b5f0..d882477 100644
> --- a/sound/soc/codecs/cs4271.c
> +++ b/sound/soc/codecs/cs4271.c
> @@ -674,8 +674,6 @@ static int cs4271_common_probe(struct device *dev,
> cs4271->gpio_nreset = cs4271plat->gpio_nreset;
>
> if (gpio_is_valid(cs4271->gpio_nreset)) {
> - int ret;
> -
> ret = devm_gpio_request(dev, cs4271->gpio_nreset,
> "CS4271 Reset");
> if (ret < 0)
>
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Applied "ASoC: cs4271: Remove unnecessary additional variable definition" to the asoc tree
2017-05-23 15:03 [PATCH] ASoC: cs4271: Remove unnecessary additional variable definition Charles Keepax
2017-05-23 17:22 ` [PATCH] ASoC: cs4271: Remove unnecessary additional variable definitio Paul Handrigan
@ 2017-05-24 17:42 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2017-05-24 17:42 UTC (permalink / raw)
To: Charles Keepax
Cc: brian.austin, alsa-devel, patches, lgirdwood, Paul.Handrigan, broonie
The patch
ASoC: cs4271: Remove unnecessary additional variable definition
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 177e27133ae9c9f5cbc306feaaa53d8fbc75e45f Mon Sep 17 00:00:00 2001
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Date: Tue, 23 May 2017 16:03:39 +0100
Subject: [PATCH] ASoC: cs4271: Remove unnecessary additional variable
definition
The function already defines a ret variable at the top and makes
no particular use of the shadowed definition, as such remove the
redundant definition.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/cs4271.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c
index e78b5f055f25..d8824773dc29 100644
--- a/sound/soc/codecs/cs4271.c
+++ b/sound/soc/codecs/cs4271.c
@@ -674,8 +674,6 @@ static int cs4271_common_probe(struct device *dev,
cs4271->gpio_nreset = cs4271plat->gpio_nreset;
if (gpio_is_valid(cs4271->gpio_nreset)) {
- int ret;
-
ret = devm_gpio_request(dev, cs4271->gpio_nreset,
"CS4271 Reset");
if (ret < 0)
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-24 17:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-23 15:03 [PATCH] ASoC: cs4271: Remove unnecessary additional variable definition Charles Keepax
2017-05-23 17:22 ` [PATCH] ASoC: cs4271: Remove unnecessary additional variable definitio Paul Handrigan
2017-05-24 17:42 ` Applied "ASoC: cs4271: Remove unnecessary additional variable definition" to the asoc tree Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.