* [U-Boot] [PATCH] malloc: Turn on DEBUG when enabling unit tests
@ 2017-05-25 16:24 Pantelis Antoniou
2017-05-25 18:00 ` Tom Rini
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pantelis Antoniou @ 2017-05-25 16:24 UTC (permalink / raw)
To: u-boot
Unit tests require mallinfo which in turn requires DEBUG on
dlmalloc to be enabled.
The dependancy on CONFIG_SANDBOX is wrong.
Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
---
common/dlmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/dlmalloc.c b/common/dlmalloc.c
index adc680e..fc1e8b3 100644
--- a/common/dlmalloc.c
+++ b/common/dlmalloc.c
@@ -1,6 +1,6 @@
#include <common.h>
-#ifdef CONFIG_SANDBOX
+#if defined(CONFIG_UNIT_TEST)
#define DEBUG
#endif
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] malloc: Turn on DEBUG when enabling unit tests
2017-05-25 16:24 [U-Boot] [PATCH] malloc: Turn on DEBUG when enabling unit tests Pantelis Antoniou
@ 2017-05-25 18:00 ` Tom Rini
2017-06-01 3:11 ` Simon Glass
2017-06-06 0:22 ` [U-Boot] " Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2017-05-25 18:00 UTC (permalink / raw)
To: u-boot
On Thu, May 25, 2017 at 07:24:06PM +0300, Pantelis Antoniou wrote:
> Unit tests require mallinfo which in turn requires DEBUG on
> dlmalloc to be enabled.
>
> The dependancy on CONFIG_SANDBOX is wrong.
>
> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170525/04055f45/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] malloc: Turn on DEBUG when enabling unit tests
2017-05-25 16:24 [U-Boot] [PATCH] malloc: Turn on DEBUG when enabling unit tests Pantelis Antoniou
2017-05-25 18:00 ` Tom Rini
@ 2017-06-01 3:11 ` Simon Glass
2017-06-06 0:22 ` [U-Boot] " Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2017-06-01 3:11 UTC (permalink / raw)
To: u-boot
On 25 May 2017 at 10:24, Pantelis Antoniou
<pantelis.antoniou@konsulko.com> wrote:
> Unit tests require mallinfo which in turn requires DEBUG on
> dlmalloc to be enabled.
>
> The dependancy on CONFIG_SANDBOX is wrong.
>
> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> ---
> common/dlmalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] malloc: Turn on DEBUG when enabling unit tests
2017-05-25 16:24 [U-Boot] [PATCH] malloc: Turn on DEBUG when enabling unit tests Pantelis Antoniou
2017-05-25 18:00 ` Tom Rini
2017-06-01 3:11 ` Simon Glass
@ 2017-06-06 0:22 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2017-06-06 0:22 UTC (permalink / raw)
To: u-boot
On Thu, May 25, 2017 at 07:24:06PM +0300, Pantelis Antoniou wrote:
> Unit tests require mallinfo which in turn requires DEBUG on
> dlmalloc to be enabled.
>
> The dependancy on CONFIG_SANDBOX is wrong.
>
> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170605/a32b333e/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-06 0:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-25 16:24 [U-Boot] [PATCH] malloc: Turn on DEBUG when enabling unit tests Pantelis Antoniou
2017-05-25 18:00 ` Tom Rini
2017-06-01 3:11 ` Simon Glass
2017-06-06 0:22 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.