* [PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP
@ 2017-05-27 13:54 Guenter Roeck
2017-05-30 6:18 ` Joel Stanley
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2017-05-27 13:54 UTC (permalink / raw)
To: linux-hwmon
Cc: Joel Stanley, Jean Delvare, linux-kernel,
Jaghathiswari Rankappagounder Natarajan, Guenter Roeck
The driver uses regmap and thus has to select it to avoid build
errors such as the following.
drivers/hwmon/aspeed-pwm-tacho.c:337:21: error: variable
'aspeed_pwm_tacho_regmap_config' has initializer but incomplete type
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/hwmon/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 22d5eafd6815..5ef2814345ef 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -343,6 +343,7 @@ config SENSORS_ASB100
config SENSORS_ASPEED
tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver"
+ select REGMAP
help
This driver provides support for ASPEED AST2400/AST2500 PWM
and Fan Tacho controllers.
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP
2017-05-27 13:54 [PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP Guenter Roeck
@ 2017-05-30 6:18 ` Joel Stanley
2017-05-30 22:09 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Joel Stanley @ 2017-05-30 6:18 UTC (permalink / raw)
To: Guenter Roeck
Cc: linux-hwmon, Jean Delvare, Linux Kernel Mailing List,
Jaghathiswari Rankappagounder Natarajan
On Sat, May 27, 2017 at 11:24 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> The driver uses regmap and thus has to select it to avoid build
> errors such as the following.
>
> drivers/hwmon/aspeed-pwm-tacho.c:337:21: error: variable
> 'aspeed_pwm_tacho_regmap_config' has initializer but incomplete type
While we're at it the driver should also depend on OF.
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Joel Stanley <joel@jms.id.au>
Cheers,
Joel
> ---
> drivers/hwmon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 22d5eafd6815..5ef2814345ef 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -343,6 +343,7 @@ config SENSORS_ASB100
>
> config SENSORS_ASPEED
> tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver"
> + select REGMAP
> help
> This driver provides support for ASPEED AST2400/AST2500 PWM
> and Fan Tacho controllers.
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP
2017-05-30 6:18 ` Joel Stanley
@ 2017-05-30 22:09 ` Guenter Roeck
0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2017-05-30 22:09 UTC (permalink / raw)
To: Joel Stanley
Cc: linux-hwmon, Jean Delvare, Linux Kernel Mailing List,
Jaghathiswari Rankappagounder Natarajan
On Tue, May 30, 2017 at 03:48:22PM +0930, Joel Stanley wrote:
> On Sat, May 27, 2017 at 11:24 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> > The driver uses regmap and thus has to select it to avoid build
> > errors such as the following.
> >
> > drivers/hwmon/aspeed-pwm-tacho.c:337:21: error: variable
> > 'aspeed_pwm_tacho_regmap_config' has initializer but incomplete type
>
> While we're at it the driver should also depend on OF.
>
The driver compiles without it, so that isn't strictly necessary.
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Acked-by: Joel Stanley <joel@jms.id.au>
>
Thanks,
Guenter
> Cheers,
>
> Joel
>
>
> > ---
> > drivers/hwmon/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> > index 22d5eafd6815..5ef2814345ef 100644
> > --- a/drivers/hwmon/Kconfig
> > +++ b/drivers/hwmon/Kconfig
> > @@ -343,6 +343,7 @@ config SENSORS_ASB100
> >
> > config SENSORS_ASPEED
> > tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver"
> > + select REGMAP
> > help
> > This driver provides support for ASPEED AST2400/AST2500 PWM
> > and Fan Tacho controllers.
> > --
> > 2.7.4
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-30 22:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-27 13:54 [PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP Guenter Roeck
2017-05-30 6:18 ` Joel Stanley
2017-05-30 22:09 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.