All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] selftests: sync: Skip the test if kernel support is not found
@ 2017-05-31 10:40 Michael Ellerman
  2017-05-31 14:44 ` Gustavo Padovan
  2017-06-02 21:43 ` Shuah Khan
  0 siblings, 2 replies; 4+ messages in thread
From: Michael Ellerman @ 2017-05-31 10:40 UTC (permalink / raw)
  To: shuahkh
  Cc: linux-kselftest, emilio.lopez, gustavo.padovan, linux-kernel,
	fathi.boudra

The "Sync framework" test doesn't work if the kernel has no support,
obviously. Rather than reporting a failure, check for the kernel support
by looking for /sys/kernel/debug/sync/sw_sync, and if not found skip the
test.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 tools/testing/selftests/sync/sync_test.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c
index 9ea08d9f0b13..62fa666e501a 100644
--- a/tools/testing/selftests/sync/sync_test.c
+++ b/tools/testing/selftests/sync/sync_test.c
@@ -29,6 +29,7 @@
 #include <unistd.h>
 #include <stdlib.h>
 #include <sys/types.h>
+#include <sys/stat.h>
 #include <sys/wait.h>
 
 #include "synctest.h"
@@ -52,10 +53,22 @@ static int run_test(int (*test)(void), char *name)
 	exit(test());
 }
 
+static int sync_api_supported(void)
+{
+	struct stat sbuf;
+
+	return 0 == stat("/sys/kernel/debug/sync/sw_sync", &sbuf);
+}
+
 int main(void)
 {
 	int err = 0;
 
+	if (!sync_api_supported()) {
+		printf("SKIP: Sync framework not supported by kernel\n");
+		return 0;
+	}
+
 	printf("[RUN]\tTesting sync framework\n");
 
 	err += RUN_TEST(test_alloc_timeline);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] selftests: sync: Skip the test if kernel support is not found
  2017-05-31 10:40 [PATCH] selftests: sync: Skip the test if kernel support is not found Michael Ellerman
@ 2017-05-31 14:44 ` Gustavo Padovan
  2017-05-31 14:57   ` Shuah Khan
  2017-06-02 21:43 ` Shuah Khan
  1 sibling, 1 reply; 4+ messages in thread
From: Gustavo Padovan @ 2017-05-31 14:44 UTC (permalink / raw)
  To: Michael Ellerman, shuahkh
  Cc: linux-kselftest, emilio.lopez, linux-kernel, fathi.boudra

Hi Michael,

On 05/31/2017 07:40 PM, Michael Ellerman wrote:
> The "Sync framework" test doesn't work if the kernel has no support,
> obviously. Rather than reporting a failure, check for the kernel support
> by looking for /sys/kernel/debug/sync/sw_sync, and if not found skip the
> test.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  tools/testing/selftests/sync/sync_test.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c
> index 9ea08d9f0b13..62fa666e501a 100644
> --- a/tools/testing/selftests/sync/sync_test.c
> +++ b/tools/testing/selftests/sync/sync_test.c
> @@ -29,6 +29,7 @@
>  #include <unistd.h>
>  #include <stdlib.h>
>  #include <sys/types.h>
> +#include <sys/stat.h>
>  #include <sys/wait.h>
>  
>  #include "synctest.h"
> @@ -52,10 +53,22 @@ static int run_test(int (*test)(void), char *name)
>  	exit(test());
>  }
>  
> +static int sync_api_supported(void)
> +{
> +	struct stat sbuf;
> +
> +	return 0 == stat("/sys/kernel/debug/sync/sw_sync", &sbuf);
> +}
> +
>  int main(void)
>  {
>  	int err = 0;
>  
> +	if (!sync_api_supported()) {
> +		printf("SKIP: Sync framework not supported by kernel\n");
> +		return 0;
> +	}
> +
>  	printf("[RUN]\tTesting sync framework\n");
>  
>  	err += RUN_TEST(test_alloc_timeline);
> 

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

-- 
Gustavo Padovan
Collabora Ltd.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] selftests: sync: Skip the test if kernel support is not found
  2017-05-31 14:44 ` Gustavo Padovan
@ 2017-05-31 14:57   ` Shuah Khan
  0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2017-05-31 14:57 UTC (permalink / raw)
  To: Gustavo Padovan, Michael Ellerman
  Cc: linux-kselftest, emilio.lopez, linux-kernel, fathi.boudra, shuah Khan

On 05/31/2017 08:44 AM, Gustavo Padovan wrote:
> Hi Michael,
> 
> On 05/31/2017 07:40 PM, Michael Ellerman wrote:
>> The "Sync framework" test doesn't work if the kernel has no support,
>> obviously. Rather than reporting a failure, check for the kernel support
>> by looking for /sys/kernel/debug/sync/sw_sync, and if not found skip the
>> test.
>>
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>> ---
>>  tools/testing/selftests/sync/sync_test.c | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>>
>> diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c
>> index 9ea08d9f0b13..62fa666e501a 100644
>> --- a/tools/testing/selftests/sync/sync_test.c
>> +++ b/tools/testing/selftests/sync/sync_test.c
>> @@ -29,6 +29,7 @@
>>  #include <unistd.h>
>>  #include <stdlib.h>
>>  #include <sys/types.h>
>> +#include <sys/stat.h>
>>  #include <sys/wait.h>
>>  
>>  #include "synctest.h"
>> @@ -52,10 +53,22 @@ static int run_test(int (*test)(void), char *name)
>>  	exit(test());
>>  }
>>  
>> +static int sync_api_supported(void)
>> +{
>> +	struct stat sbuf;
>> +
>> +	return 0 == stat("/sys/kernel/debug/sync/sw_sync", &sbuf);
>> +}
>> +
>>  int main(void)
>>  {
>>  	int err = 0;
>>  
>> +	if (!sync_api_supported()) {
>> +		printf("SKIP: Sync framework not supported by kernel\n");
>> +		return 0;
>> +	}
>> +
>>  	printf("[RUN]\tTesting sync framework\n");
>>  
>>  	err += RUN_TEST(test_alloc_timeline);
>>
> 
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
> 

Thanks both. I will pull this into kselftest for 4.13-rc1

-- Shuah

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] selftests: sync: Skip the test if kernel support is not found
  2017-05-31 10:40 [PATCH] selftests: sync: Skip the test if kernel support is not found Michael Ellerman
  2017-05-31 14:44 ` Gustavo Padovan
@ 2017-06-02 21:43 ` Shuah Khan
  1 sibling, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2017-06-02 21:43 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: linux-kselftest, emilio.lopez, gustavo.padovan, linux-kernel,
	fathi.boudra, Shuah Khan, Shuah Khan

On 05/31/2017 04:40 AM, Michael Ellerman wrote:
> The "Sync framework" test doesn't work if the kernel has no support,
> obviously. Rather than reporting a failure, check for the kernel support
> by looking for /sys/kernel/debug/sync/sw_sync, and if not found skip the
> test.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Thanks. Applied to linux-kselftest next for 4.13-rc1

-- Shuah

> ---
>  tools/testing/selftests/sync/sync_test.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tools/testing/selftests/sync/sync_test.c b/tools/testing/selftests/sync/sync_test.c
> index 9ea08d9f0b13..62fa666e501a 100644
> --- a/tools/testing/selftests/sync/sync_test.c
> +++ b/tools/testing/selftests/sync/sync_test.c
> @@ -29,6 +29,7 @@
>  #include <unistd.h>
>  #include <stdlib.h>
>  #include <sys/types.h>
> +#include <sys/stat.h>
>  #include <sys/wait.h>
>  
>  #include "synctest.h"
> @@ -52,10 +53,22 @@ static int run_test(int (*test)(void), char *name)
>  	exit(test());
>  }
>  
> +static int sync_api_supported(void)
> +{
> +	struct stat sbuf;
> +
> +	return 0 == stat("/sys/kernel/debug/sync/sw_sync", &sbuf);
> +}
> +
>  int main(void)
>  {
>  	int err = 0;
>  
> +	if (!sync_api_supported()) {
> +		printf("SKIP: Sync framework not supported by kernel\n");
> +		return 0;
> +	}
> +
>  	printf("[RUN]\tTesting sync framework\n");
>  
>  	err += RUN_TEST(test_alloc_timeline);
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-02 21:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-31 10:40 [PATCH] selftests: sync: Skip the test if kernel support is not found Michael Ellerman
2017-05-31 14:44 ` Gustavo Padovan
2017-05-31 14:57   ` Shuah Khan
2017-06-02 21:43 ` Shuah Khan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.