All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keerthy <j-keerthy@ti.com>
To: <tony@atomide.com>, <milo.kim@ti.com>, <lee.jones@linaro.org>
Cc: <j-keerthy@ti.com>, <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH 2/9] mfd: tps65218: Remove redundant i2c_device_id
Date: Sun, 4 Jun 2017 14:48:37 +0530	[thread overview]
Message-ID: <1496567924-4278-3-git-send-email-j-keerthy@ti.com> (raw)
In-Reply-To: <1496567924-4278-1-git-send-email-j-keerthy@ti.com>

With the introduction of probe_new function the i2c_device_id
is no longer needed. Hence the remove the same and use probe_new
instead of probe.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---

Boot tested on am347x-gp-evm and checked for regulator registrations.

 drivers/mfd/tps65218.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
index 13834a0..53df80b 100644
--- a/drivers/mfd/tps65218.c
+++ b/drivers/mfd/tps65218.c
@@ -211,8 +211,7 @@ int tps65218_clear_bits(struct tps65218 *tps, unsigned int reg,
 };
 MODULE_DEVICE_TABLE(of, of_tps65218_match_table);
 
-static int tps65218_probe(struct i2c_client *client,
-				const struct i2c_device_id *ids)
+static int tps65218_probe(struct i2c_client *client)
 {
 	struct tps65218 *tps;
 	const struct of_device_id *match;
@@ -281,20 +280,22 @@ static int tps65218_remove(struct i2c_client *client)
 	return 0;
 }
 
+#if 0
 static const struct i2c_device_id tps65218_id_table[] = {
 	{ "tps65218", TPS65218 },
 	{ },
 };
 MODULE_DEVICE_TABLE(i2c, tps65218_id_table);
+#endif
 
 static struct i2c_driver tps65218_driver = {
 	.driver		= {
 		.name	= "tps65218",
 		.of_match_table = of_tps65218_match_table,
 	},
-	.probe		= tps65218_probe,
+	.probe_new	= tps65218_probe,
 	.remove		= tps65218_remove,
-	.id_table       = tps65218_id_table,
+	//.id_table       = tps65218_id_table,
 };
 
 module_i2c_driver(tps65218_driver);
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Keerthy <j-keerthy@ti.com>
To: tony@atomide.com, milo.kim@ti.com, lee.jones@linaro.org
Cc: j-keerthy@ti.com, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/9] mfd: tps65218: Remove redundant i2c_device_id
Date: Sun, 4 Jun 2017 14:48:37 +0530	[thread overview]
Message-ID: <1496567924-4278-3-git-send-email-j-keerthy@ti.com> (raw)
In-Reply-To: <1496567924-4278-1-git-send-email-j-keerthy@ti.com>

With the introduction of probe_new function the i2c_device_id
is no longer needed. Hence the remove the same and use probe_new
instead of probe.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---

Boot tested on am347x-gp-evm and checked for regulator registrations.

 drivers/mfd/tps65218.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
index 13834a0..53df80b 100644
--- a/drivers/mfd/tps65218.c
+++ b/drivers/mfd/tps65218.c
@@ -211,8 +211,7 @@ int tps65218_clear_bits(struct tps65218 *tps, unsigned int reg,
 };
 MODULE_DEVICE_TABLE(of, of_tps65218_match_table);
 
-static int tps65218_probe(struct i2c_client *client,
-				const struct i2c_device_id *ids)
+static int tps65218_probe(struct i2c_client *client)
 {
 	struct tps65218 *tps;
 	const struct of_device_id *match;
@@ -281,20 +280,22 @@ static int tps65218_remove(struct i2c_client *client)
 	return 0;
 }
 
+#if 0
 static const struct i2c_device_id tps65218_id_table[] = {
 	{ "tps65218", TPS65218 },
 	{ },
 };
 MODULE_DEVICE_TABLE(i2c, tps65218_id_table);
+#endif
 
 static struct i2c_driver tps65218_driver = {
 	.driver		= {
 		.name	= "tps65218",
 		.of_match_table = of_tps65218_match_table,
 	},
-	.probe		= tps65218_probe,
+	.probe_new	= tps65218_probe,
 	.remove		= tps65218_remove,
-	.id_table       = tps65218_id_table,
+	//.id_table       = tps65218_id_table,
 };
 
 module_i2c_driver(tps65218_driver);
-- 
1.9.1

  parent reply	other threads:[~2017-06-04  9:20 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-04  9:18 [PATCH 0/9] mfd: Remove redundant i2c_device_id Keerthy
2017-06-04  9:18 ` Keerthy
2017-06-04  9:18 ` [PATCH 1/9] mfd: tps65217: " Keerthy
2017-06-04  9:18   ` Keerthy
2017-06-04  9:18 ` Keerthy [this message]
2017-06-04  9:18   ` [PATCH 2/9] mfd: tps65218: " Keerthy
2017-06-04  9:18 ` [PATCH 3/9] mfd: palmas: " Keerthy
2017-06-04  9:18   ` Keerthy
2017-06-04  9:18 ` [PATCH 4/9] mfd: lp873x: " Keerthy
2017-06-04  9:18   ` Keerthy
2017-06-04  9:18 ` [PATCH 5/9] mfd: lp8788: " Keerthy
2017-06-04  9:18   ` Keerthy
2017-06-04  9:18 ` [PATCH 6/9] mfd: lp3943: " Keerthy
2017-06-04  9:18   ` Keerthy
2017-06-04  9:18 ` [PATCH 7/9] mfd: tps65086: " Keerthy
2017-06-04  9:18   ` Keerthy
2017-06-04  9:18 ` [PATCH 8/9] mfd: tps65090: " Keerthy
2017-06-04  9:18   ` Keerthy
2017-06-04  9:18 ` [PATCH 9/9] mfd: tps6586x: " Keerthy
2017-06-04  9:18   ` Keerthy
2017-06-05 10:37 ` [PATCH 0/9] mfd: " Lee Jones
2017-06-05 14:37   ` Keerthy
2017-06-05 14:37     ` Keerthy
2017-06-06  7:17     ` Lee Jones
2017-06-06  7:30       ` Keerthy
2017-06-06  7:30         ` Keerthy
2017-06-06  7:48         ` Keerthy
2017-06-06  7:48           ` Keerthy
2017-06-06 10:44           ` Tony Lindgren
2017-06-06 11:01             ` Keerthy
2017-06-06 11:01               ` Keerthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496567924-4278-3-git-send-email-j-keerthy@ti.com \
    --to=j-keerthy@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=milo.kim@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.