* [PATCH iproute2 V2] iplink: Update usage in help message
@ 2017-06-04 12:36 Tariq Toukan
2017-06-05 19:30 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Tariq Toukan @ 2017-06-04 12:36 UTC (permalink / raw)
To: Stephen Hemminger
Cc: netdev, Eran Ben Elisha, Or Gerlitz, Eli Cohen, Tariq Toukan
From: Eli Cohen <eli@mellanox.com>
Add to usage message a description of how to configure Infiniband node
and port GUIDs. Also modify the man page to emphasize the GUIDs are
configured for Infiniband VFs.
Fixes: d91fb3f4c7e4 ("Add support for configuring Infiniband GUIDs")
Signed-off-by: Eli Cohen <eli@mellanox.com>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
---
v2:
* Modified man page as well.
ip/iplink.c | 2 ++
man/man8/ip-link.8.in | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/ip/iplink.c b/ip/iplink.c
index da3f9a779351..ea112f71befc 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -91,6 +91,8 @@ void iplink_usage(void)
" [ query_rss { on | off} ]\n"
" [ state { auto | enable | disable} ] ]\n"
" [ trust { on | off} ] ]\n"
+ " [ node_guid { eui64 } ]\n"
+ " [ port_guid { eui64 } ]\n"
" [ xdp { off |\n"
" object FILE [ section NAME ] [ verbose ] |\n"
" pinned FILE } ]\n"
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
index a5ddfe7a106e..48417dbce80a 100644
--- a/man/man8/ip-link.8.in
+++ b/man/man8/ip-link.8.in
@@ -1564,10 +1564,10 @@ sent by the VF.
which may impact security and/or performance. (e.g. VF multicast promiscuous mode)
.sp
.BI node_guid " eui64"
-- configure node GUID for the VF.
+- configure node GUID for Infiniband VFs.
.sp
.BI port_guid " eui64"
-- configure port GUID for the VF.
+- configure port GUID for Infiniband VFs.
.in -8
.TP
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute2 V2] iplink: Update usage in help message
2017-06-04 12:36 [PATCH iproute2 V2] iplink: Update usage in help message Tariq Toukan
@ 2017-06-05 19:30 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2017-06-05 19:30 UTC (permalink / raw)
To: Tariq Toukan; +Cc: netdev, Eran Ben Elisha, Or Gerlitz, Eli Cohen
On Sun, 4 Jun 2017 15:36:48 +0300
Tariq Toukan <tariqt@mellanox.com> wrote:
> From: Eli Cohen <eli@mellanox.com>
>
> Add to usage message a description of how to configure Infiniband node
> and port GUIDs. Also modify the man page to emphasize the GUIDs are
> configured for Infiniband VFs.
>
> Fixes: d91fb3f4c7e4 ("Add support for configuring Infiniband GUIDs")
> Signed-off-by: Eli Cohen <eli@mellanox.com>
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Looks good, applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-05 19:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-04 12:36 [PATCH iproute2 V2] iplink: Update usage in help message Tariq Toukan
2017-06-05 19:30 ` Stephen Hemminger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.