* [PATCH] net: sched: fix mips build failure
@ 2017-06-04 21:44 Sudip Mukherjee
2017-06-05 4:50 ` Jiri Pirko
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2017-06-04 21:44 UTC (permalink / raw)
To: Jamal Hadi Salim, Cong Wang, Jiri Pirko, David S. Miller, Ralf Baechle
Cc: linux-kernel, netdev, linux-mips, Sudip Mukherjee
The build of mips ar7_defconfig was failing with the error:
../net/sched/act_api.c: In function 'tcf_action_goto_chain_init':
../net/sched/act_api.c:37:18: error:
implicit declaration of function 'tcf_chain_get'
[-Werror=implicit-function-declaration]
../net/sched/act_api.c: In function 'tcf_action_goto_chain_fini':
../net/sched/act_api.c:45:2: error:
implicit declaration of function 'tcf_chain_put'
[-Werror=implicit-function-declaration]
Add two inline helpers for the case where CONFIG_NET_CLS is not enabled.
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
---
The build log of the latest linux-next is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/238623031/
include/net/pkt_cls.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
index 537d0a0..c34ade5 100644
--- a/include/net/pkt_cls.h
+++ b/include/net/pkt_cls.h
@@ -29,6 +29,17 @@ int tcf_classify(struct sk_buff *skb, const struct tcf_proto *tp,
#else
static inline
+struct tcf_chain *tcf_chain_get(struct tcf_block *block,
+ u32 chain_index, bool create)
+{
+ return NULL;
+}
+
+static inline void tcf_chain_put(struct tcf_chain *chain)
+{
+}
+
+static inline
int tcf_block_get(struct tcf_block **p_block,
struct tcf_proto __rcu **p_filter_chain)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: sched: fix mips build failure
2017-06-04 21:44 [PATCH] net: sched: fix mips build failure Sudip Mukherjee
@ 2017-06-05 4:50 ` Jiri Pirko
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Pirko @ 2017-06-05 4:50 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Jamal Hadi Salim, Cong Wang, David S. Miller, Ralf Baechle,
linux-kernel, netdev, linux-mips
Sun, Jun 04, 2017 at 11:44:13PM CEST, sudipm.mukherjee@gmail.com wrote:
>The build of mips ar7_defconfig was failing with the error:
>../net/sched/act_api.c: In function 'tcf_action_goto_chain_init':
>../net/sched/act_api.c:37:18: error:
> implicit declaration of function 'tcf_chain_get'
> [-Werror=implicit-function-declaration]
>
>../net/sched/act_api.c: In function 'tcf_action_goto_chain_fini':
>../net/sched/act_api.c:45:2: error:
> implicit declaration of function 'tcf_chain_put'
> [-Werror=implicit-function-declaration]
>
>Add two inline helpers for the case where CONFIG_NET_CLS is not enabled.
>
>Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
I already sent a fix for this:
http://patchwork.ozlabs.org/project/netdev/list/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-05 4:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-04 21:44 [PATCH] net: sched: fix mips build failure Sudip Mukherjee
2017-06-05 4:50 ` Jiri Pirko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.