* [PATCH] drm/i915: Remove unecessary PORT3 definition.
@ 2017-06-05 22:12 Rodrigo Vivi
2017-06-05 22:28 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-06-05 23:57 ` [PATCH] " Manasi Navare
0 siblings, 2 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2017-06-05 22:12 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
Let's be picky and just use PICK directly.
So we can extend this later without creating
a new PORT_X por every new number of ports we
have to handle.
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 1329420..c3bed89 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -58,10 +58,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
#define _MMIO_TRANS(tran, a, b) _MMIO(_TRANS(tran, a, b))
#define _PORT(port, a, b) ((a) + (port)*((b)-(a)))
#define _MMIO_PORT(port, a, b) _MMIO(_PORT(port, a, b))
-#define _PIPE3(pipe, ...) _PICK(pipe, __VA_ARGS__)
-#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PIPE3(pipe, a, b, c))
-#define _PORT3(port, ...) _PICK(port, __VA_ARGS__)
-#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PORT3(pipe, a, b, c))
+#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
+#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
#define _PHY3(phy, ...) _PICK(phy, __VA_ARGS__)
#define _MMIO_PHY3(phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* ✗ Fi.CI.BAT: warning for drm/i915: Remove unecessary PORT3 definition.
2017-06-05 22:12 [PATCH] drm/i915: Remove unecessary PORT3 definition Rodrigo Vivi
@ 2017-06-05 22:28 ` Patchwork
2017-06-05 23:57 ` [PATCH] " Manasi Navare
1 sibling, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-06-05 22:28 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove unecessary PORT3 definition.
URL : https://patchwork.freedesktop.org/series/25313/
State : warning
== Summary ==
Series 25313v1 drm/i915: Remove unecessary PORT3 definition.
https://patchwork.freedesktop.org/api/1.0/series/25313/revisions/1/mbox/
Test kms_busy:
Subgroup basic-flip-default-a:
pass -> DMESG-WARN (fi-skl-6700hq) fdo#101144 +1
Test drv_module_reload:
Subgroup basic-reload-final:
pass -> DMESG-WARN (fi-skl-6770hq)
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:442s
fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:431s
fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:578s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:517s
fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:484s
fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:482s
fi-glk-2a total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:591s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:435s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:415s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:423s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:496s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:465s
fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:461s
fi-kbl-7560u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:565s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:460s
fi-skl-6700hq total:278 pass:228 dwarn:1 dfail:0 fail:27 skip:22 time:401s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:463s
fi-skl-6770hq total:278 pass:267 dwarn:1 dfail:0 fail:0 skip:10 time:499s
fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:439s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:530s
fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time:401s
30d3326ecb407cad6c03ef6a6d3805c70ba9f0a9 drm-tip: 2017y-06m-05d-15h-21m-50s UTC integration manifest
a5cfe1e drm/i915: Remove unecessary PORT3 definition.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4882/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915: Remove unecessary PORT3 definition.
2017-06-05 22:12 [PATCH] drm/i915: Remove unecessary PORT3 definition Rodrigo Vivi
2017-06-05 22:28 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2017-06-05 23:57 ` Manasi Navare
2017-06-06 15:12 ` Vivi, Rodrigo
1 sibling, 1 reply; 7+ messages in thread
From: Manasi Navare @ 2017-06-05 23:57 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
On Mon, Jun 05, 2017 at 03:12:02PM -0700, Rodrigo Vivi wrote:
> Let's be picky and just use PICK directly.
> So we can extend this later without creating
> a new PORT_X por every new number of ports we
> have to handle.
>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 1329420..c3bed89 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -58,10 +58,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
> #define _MMIO_TRANS(tran, a, b) _MMIO(_TRANS(tran, a, b))
> #define _PORT(port, a, b) ((a) + (port)*((b)-(a)))
> #define _MMIO_PORT(port, a, b) _MMIO(_PORT(port, a, b))
> -#define _PIPE3(pipe, ...) _PICK(pipe, __VA_ARGS__)
> -#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PIPE3(pipe, a, b, c))
> -#define _PORT3(port, ...) _PICK(port, __VA_ARGS__)
> -#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PORT3(pipe, a, b, c))
> +#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
> +#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
> #define _PHY3(phy, ...) _PICK(phy, __VA_ARGS__)
> #define _MMIO_PHY3(phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))
>
Directly using _PICK looks good to me so we need not define
more macros for different number of ports.
Looks good to me.
Regards
Manasi
> --
> 1.9.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Remove unecessary PORT3 definition.
2017-06-05 23:57 ` [PATCH] " Manasi Navare
@ 2017-06-06 15:12 ` Vivi, Rodrigo
0 siblings, 0 replies; 7+ messages in thread
From: Vivi, Rodrigo @ 2017-06-06 15:12 UTC (permalink / raw)
To: Navare, Manasi D; +Cc: intel-gfx
On Mon, 2017-06-05 at 16:57 -0700, Manasi Navare wrote:
> On Mon, Jun 05, 2017 at 03:12:02PM -0700, Rodrigo Vivi wrote:
> > Let's be picky and just use PICK directly.
> > So we can extend this later without creating
> > a new PORT_X por every new number of ports we
> > have to handle.
> >
> > Cc: Manasi Navare <manasi.d.navare@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index 1329420..c3bed89 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -58,10 +58,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
> > #define _MMIO_TRANS(tran, a, b) _MMIO(_TRANS(tran, a, b))
> > #define _PORT(port, a, b) ((a) + (port)*((b)-(a)))
> > #define _MMIO_PORT(port, a, b) _MMIO(_PORT(port, a, b))
> > -#define _PIPE3(pipe, ...) _PICK(pipe, __VA_ARGS__)
> > -#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PIPE3(pipe, a, b, c))
> > -#define _PORT3(port, ...) _PICK(port, __VA_ARGS__)
> > -#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PORT3(pipe, a, b, c))
> > +#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
> > +#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
> > #define _PHY3(phy, ...) _PICK(phy, __VA_ARGS__)
> > #define _MMIO_PHY3(phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))
> >
>
> Directly using _PICK looks good to me so we need not define
> more macros for different number of ports.
Does this mean rv-b? :P
>
> Looks good to me.
>
> Regards
> Manasi
>
>
> > --
> > 1.9.1
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drm/i915: Remove unecessary PORT3 definition.
@ 2017-06-06 16:06 Rodrigo Vivi
2017-06-06 18:14 ` Manasi Navare
0 siblings, 1 reply; 7+ messages in thread
From: Rodrigo Vivi @ 2017-06-06 16:06 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
Let's be picky and just use PICK directly.
So we can extend this later without creating
a new PORT_X por every new number of ports we
have to handle.
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 1329420..c3bed89 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -58,10 +58,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
#define _MMIO_TRANS(tran, a, b) _MMIO(_TRANS(tran, a, b))
#define _PORT(port, a, b) ((a) + (port)*((b)-(a)))
#define _MMIO_PORT(port, a, b) _MMIO(_PORT(port, a, b))
-#define _PIPE3(pipe, ...) _PICK(pipe, __VA_ARGS__)
-#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PIPE3(pipe, a, b, c))
-#define _PORT3(port, ...) _PICK(port, __VA_ARGS__)
-#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PORT3(pipe, a, b, c))
+#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
+#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
#define _PHY3(phy, ...) _PICK(phy, __VA_ARGS__)
#define _MMIO_PHY3(phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Remove unecessary PORT3 definition.
2017-06-06 16:06 Rodrigo Vivi
@ 2017-06-06 18:14 ` Manasi Navare
2017-06-07 14:53 ` Rodrigo Vivi
0 siblings, 1 reply; 7+ messages in thread
From: Manasi Navare @ 2017-06-06 18:14 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
Just a very tiny nitpick about correction in the
spelling of "unnecessary" in the title.
Other than that
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
On Tue, Jun 06, 2017 at 09:06:36AM -0700, Rodrigo Vivi wrote:
> Let's be picky and just use PICK directly.
> So we can extend this later without creating
> a new PORT_X por every new number of ports we
> have to handle.
>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 1329420..c3bed89 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -58,10 +58,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
> #define _MMIO_TRANS(tran, a, b) _MMIO(_TRANS(tran, a, b))
> #define _PORT(port, a, b) ((a) + (port)*((b)-(a)))
> #define _MMIO_PORT(port, a, b) _MMIO(_PORT(port, a, b))
> -#define _PIPE3(pipe, ...) _PICK(pipe, __VA_ARGS__)
> -#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PIPE3(pipe, a, b, c))
> -#define _PORT3(port, ...) _PICK(port, __VA_ARGS__)
> -#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PORT3(pipe, a, b, c))
> +#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
> +#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
> #define _PHY3(phy, ...) _PICK(phy, __VA_ARGS__)
> #define _MMIO_PHY3(phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))
>
> --
> 1.9.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: Remove unecessary PORT3 definition.
2017-06-06 18:14 ` Manasi Navare
@ 2017-06-07 14:53 ` Rodrigo Vivi
0 siblings, 0 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2017-06-07 14:53 UTC (permalink / raw)
To: Manasi Navare; +Cc: intel-gfx, Rodrigo Vivi
patch merged to dinq with the fixed spelling.
Thanks for the review
On Tue, Jun 6, 2017 at 11:14 AM, Manasi Navare
<manasi.d.navare@intel.com> wrote:
> Just a very tiny nitpick about correction in the
> spelling of "unnecessary" in the title.
>
> Other than that
>
> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
>
> On Tue, Jun 06, 2017 at 09:06:36AM -0700, Rodrigo Vivi wrote:
>> Let's be picky and just use PICK directly.
>> So we can extend this later without creating
>> a new PORT_X por every new number of ports we
>> have to handle.
>>
>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_reg.h | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>> index 1329420..c3bed89 100644
>> --- a/drivers/gpu/drm/i915/i915_reg.h
>> +++ b/drivers/gpu/drm/i915/i915_reg.h
>> @@ -58,10 +58,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
>> #define _MMIO_TRANS(tran, a, b) _MMIO(_TRANS(tran, a, b))
>> #define _PORT(port, a, b) ((a) + (port)*((b)-(a)))
>> #define _MMIO_PORT(port, a, b) _MMIO(_PORT(port, a, b))
>> -#define _PIPE3(pipe, ...) _PICK(pipe, __VA_ARGS__)
>> -#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PIPE3(pipe, a, b, c))
>> -#define _PORT3(port, ...) _PICK(port, __VA_ARGS__)
>> -#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PORT3(pipe, a, b, c))
>> +#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
>> +#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
>> #define _PHY3(phy, ...) _PICK(phy, __VA_ARGS__)
>> #define _MMIO_PHY3(phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))
>>
>> --
>> 1.9.1
>>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-06-07 14:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-05 22:12 [PATCH] drm/i915: Remove unecessary PORT3 definition Rodrigo Vivi
2017-06-05 22:28 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-06-05 23:57 ` [PATCH] " Manasi Navare
2017-06-06 15:12 ` Vivi, Rodrigo
2017-06-06 16:06 Rodrigo Vivi
2017-06-06 18:14 ` Manasi Navare
2017-06-07 14:53 ` Rodrigo Vivi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.