All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "ibmvnic: Call napi_disable instead of napi_enable in failure path" has been added to the 4.9-stable tree
@ 2017-06-15  9:13 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-06-15  9:13 UTC (permalink / raw)
  To: nfont, alexander.levin, davem, gregkh; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    ibmvnic: Call napi_disable instead of napi_enable in failure path

to the 4.9-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ibmvnic-call-napi_disable-instead-of-napi_enable-in-failure-path.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Thu Jun 15 11:12:23 CEST 2017
From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Date: Tue, 23 May 2017 21:53:38 -0400
Subject: ibmvnic: Call napi_disable instead of napi_enable in failure path

From: Nathan Fontenot <nfont@linux.vnet.ibm.com>


[ Upstream commit e722af6391949e8851310441bb0cec157d25611d ]

The failure path in ibmvnic_open() mistakenly makes a second call
to napi_enable instead of calling napi_disable. This can result
in a BUG_ON for any queues that were enabled in the previous call
to napi_enable.

Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/net/ethernet/ibm/ibmvnic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -505,7 +505,7 @@ rx_pool_alloc_failed:
 	adapter->rx_pool = NULL;
 rx_pool_arr_alloc_failed:
 	for (i = 0; i < adapter->req_rx_queues; i++)
-		napi_enable(&adapter->napi[i]);
+		napi_disable(&adapter->napi[i]);
 alloc_napi_failed:
 	return -ENOMEM;
 }


Patches currently in stable-queue which might be from nfont@linux.vnet.ibm.com are

queue-4.9/ibmvnic-call-napi_disable-instead-of-napi_enable-in-failure-path.patch
queue-4.9/ibmvnic-initialize-completion-variables-before-starting-work.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-06-15  9:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-15  9:13 Patch "ibmvnic: Call napi_disable instead of napi_enable in failure path" has been added to the 4.9-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.