[Buildroot] [PATCH v4 0/6] Board: Add Engicam i.MX6 SOMs

[Buildroot] [PATCH v4 0/6] Board: Add Engicam i.MX6 SOMs

[Jagan Teki]

From: Jagan Teki <jagan@amarulasolutions.com>

This version of series has all supported features and fixes.

This series add buildroot support for Engicam i.MX6 SOM's
- i.CoreM6 DualLite/Solo
- i.CoreM6 RQS
- GEAM6UL
- Is.IoT MX6UL

Jagan Teki (6):
  board: Add support for Engicam i.CoreM6 DualLite/Solo boards
  board: engicam: Rename defconfig engicam_imx6qdl_icore_mmc_defconfig
  board: Add support for Engicam i.CoreM6 RQS SOM
  board: engicam: Add icorem6 for i.CoreM6 support
  board: Add support for Engicam GEAM6UL SOM
  board: Add support for Engicam Is.IoT MX6UL SOM

 .gitlab-ci.yml                                     |  5 +-
 DEVELOPERS                                         |  5 +-
 board/engicam/geam6ul/genimage.cfg                 | 38 ++++++++++++
 board/engicam/geam6ul/readme.txt                   | 65 +++++++++++++++++++++
 board/engicam/{ => icorem6}/genimage.cfg           |  1 +
 board/engicam/{ => icorem6}/readme.txt             | 20 ++++---
 board/engicam/icorem6_rqs/genimage.cfg             | 39 +++++++++++++
 board/engicam/icorem6_rqs/readme.txt               | 68 ++++++++++++++++++++++
 board/engicam/isiot/genimage.cfg                   | 38 ++++++++++++
 board/engicam/isiot/readme.txt                     | 65 +++++++++++++++++++++
 ...fconfig => engicam_imx6qdl_icore_mmc_defconfig} | 12 ++--
 configs/engicam_imx6qdl_icore_rqs_mmc_defconfig    | 41 +++++++++++++
 configs/engicam_imx6ul_geam_mmc_defconfig          | 41 +++++++++++++
 configs/engicam_imx6ul_isiot_mmc_defconfig         | 41 +++++++++++++
 14 files changed, 462 insertions(+), 17 deletions(-)
 create mode 100644 board/engicam/geam6ul/genimage.cfg
 create mode 100644 board/engicam/geam6ul/readme.txt
 rename board/engicam/{ => icorem6}/genimage.cfg (95%)
 rename board/engicam/{ => icorem6}/readme.txt (72%)
 create mode 100644 board/engicam/icorem6_rqs/genimage.cfg
 create mode 100644 board/engicam/icorem6_rqs/readme.txt
 create mode 100644 board/engicam/isiot/genimage.cfg
 create mode 100644 board/engicam/isiot/readme.txt
 rename configs/{engicam_imx6q_icore_defconfig => engicam_imx6qdl_icore_mmc_defconfig} (69%)
 create mode 100644 configs/engicam_imx6qdl_icore_rqs_mmc_defconfig
 create mode 100644 configs/engicam_imx6ul_geam_mmc_defconfig
 create mode 100644 configs/engicam_imx6ul_isiot_mmc_defconfig

-- 
2.7.4

[Buildroot] [PATCH v4 1/6] board: Add support for Engicam i.CoreM6 DualLite/Solo boards

[Jagan Teki]

From: Jagan Teki <jagan@amarulasolutions.com>

Add initial support for Engicam i.CoreM6 DualLite/Solo board
with below features:
- U-Boot 2017.05-rc1
- Linux 4.11.5
- Default packages from buildroot

U-Boot 2017.05-rc1 has common u-boot defconfig for All i.CoreM6
variant boards, so this patch update the same along with
buildroot defconfig that reflect the common name.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v4:
- Update .gitlab-ci.yml
Changes for v3:
- Use kernel version 4.11.5
Changes for v2:
- Fix genimage.cfg path in readme.txt
- Remove exctra " in BR2_LINUX_KERNEL_INTREE_DTS_NAME

 .gitlab-ci.yml                                                 |  2 +-
 DEVELOPERS                                                     |  2 +-
 board/engicam/genimage.cfg                                     |  1 +
 board/engicam/readme.txt                                       |  6 ++++--
 ...m_imx6q_icore_defconfig => engicam_imx6qdl_icore_defconfig} | 10 +++++-----
 5 files changed, 12 insertions(+), 9 deletions(-)
 rename configs/{engicam_imx6q_icore_defconfig => engicam_imx6qdl_icore_defconfig} (74%)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 45c9b87..36ef1d1 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -89,7 +89,7 @@ ci20_defconfig: *defconfig
 ci40_defconfig: *defconfig
 csky_gx6605s_defconfig: *defconfig
 cubieboard2_defconfig: *defconfig
-engicam_imx6q_icore_defconfig: *defconfig
+engicam_imx6qdl_icore_defconfig: *defconfig
 firefly_rk3288_defconfig: *defconfig
 firefly_rk3288_demo_defconfig: *defconfig
 freescale_imx28evk_defconfig: *defconfig
diff --git a/DEVELOPERS b/DEVELOPERS
index f86a5dc..9a8b586 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -837,7 +837,7 @@ F:	package/keepalived/
 
 N:	Jagan Teki <jagan@amarulasolutions.com>
 F:	board/engicam/
-F:	configs/engicam_imx6q_icore_defconfig
+F:	configs/engicam_imx6qdl_icore_defconfig
 
 N:	James Knight <james.knight@rockwellcollins.com>
 F:	package/atkmm/
diff --git a/board/engicam/genimage.cfg b/board/engicam/genimage.cfg
index 43c81cf..cdccc90 100644
--- a/board/engicam/genimage.cfg
+++ b/board/engicam/genimage.cfg
@@ -2,6 +2,7 @@ image boot.vfat {
 	vfat {
 		files = {
 			"uImage",
+			"imx6dl-icore.dtb",
 			"imx6q-icore.dtb"
 		}
 	}
diff --git a/board/engicam/readme.txt b/board/engicam/readme.txt
index eb7503f..d02c3af 100644
--- a/board/engicam/readme.txt
+++ b/board/engicam/readme.txt
@@ -5,7 +5,7 @@ Buildroot for Engicam i.MX6 SOM platforms:
 This file documents the Buildroot support for all Engicam i.MX6 SOM
 platform boards.
 
-i.CoreM6 Quad/Dual SOM Starter kits:
+i.CoreM6 Quad/Dual/DualLite/Solo SOM Starter kits:
 https://www.engicam.com/vis-prod/101120
 
 This configuration uses U-Boot mainline and kernel mainline.
@@ -17,7 +17,7 @@ First, configure Buildroot for the Engicam i.MX SOM's:
 
 - for i.CoreM6 Quad/Dual:
 
-  make engicam_imx6q_icore_defconfig
+  make engicam_imx6qdl_icore_defconfig
 
 Build all components:
 
@@ -26,6 +26,8 @@ Build all components:
 You will find the following files in output/images/:
 - for i.CoreM6 Quad/Dual:
   - imx6q-icore.dtb
+- for i.CoreM6 DualLite/Solo:
+  - imx6dl-icore.dtb
   - rootfs.ext4
   - rootfs.tar
   - sdcard.img
diff --git a/configs/engicam_imx6q_icore_defconfig b/configs/engicam_imx6qdl_icore_defconfig
similarity index 74%
rename from configs/engicam_imx6q_icore_defconfig
rename to configs/engicam_imx6qdl_icore_defconfig
index 63454ee..ffb3546 100644
--- a/configs/engicam_imx6q_icore_defconfig
+++ b/configs/engicam_imx6qdl_icore_defconfig
@@ -14,8 +14,8 @@ BR2_TARGET_GENERIC_GETTY_PORT="ttymxc3"
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05"
-BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6q_icore_mmc"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05-rc1"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6qdl_icore_mmc"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
@@ -25,15 +25,15 @@ BR2_TARGET_UBOOT_SPL_NAME="SPL"
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.11"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.11.5"
 BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
 BR2_LINUX_KERNEL_UIMAGE=y
 BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x10008000"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-icore"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6dl-icore imx6q-icore"
 
 # Filesystem
-BR2_TARGET_GENERIC_ISSUE="Welcome to Engicam i.CoreM6 Quad/Dual Starter Kit"
+BR2_TARGET_GENERIC_ISSUE="Welcome to Engicam i.CoreM6 Quad/Dual/DualLite/Solo Starter Kit"
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
 BR2_PACKAGE_HOST_GENIMAGE=y
-- 
2.7.4

[Buildroot] [PATCH v4 2/6] board: engicam: Rename defconfig engicam_imx6qdl_icore_mmc_defconfig

[Jagan Teki]

From: Jagan Teki <jagan@amarulasolutions.com>

Since the board have support for nand, better to explicitly
name it with mmc.

engicam_imx6qdl_icore_defconfig => engicam_imx6qdl_icore_mmc_defconfig

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v4:
- Update .gitlab-ci.yml
Changes for v3:
- none
Changes for v2:
- Fix genimage.cfg path in readme.txt

 .gitlab-ci.yml                                                          | 2 +-
 DEVELOPERS                                                              | 2 +-
 board/engicam/readme.txt                                                | 2 +-
 ...icam_imx6qdl_icore_defconfig => engicam_imx6qdl_icore_mmc_defconfig} | 0
 4 files changed, 3 insertions(+), 3 deletions(-)
 rename configs/{engicam_imx6qdl_icore_defconfig => engicam_imx6qdl_icore_mmc_defconfig} (100%)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 36ef1d1..c4bf90d 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -89,7 +89,7 @@ ci20_defconfig: *defconfig
 ci40_defconfig: *defconfig
 csky_gx6605s_defconfig: *defconfig
 cubieboard2_defconfig: *defconfig
-engicam_imx6qdl_icore_defconfig: *defconfig
+engicam_imx6qdl_icore_mmc_defconfig: *defconfig
 firefly_rk3288_defconfig: *defconfig
 firefly_rk3288_demo_defconfig: *defconfig
 freescale_imx28evk_defconfig: *defconfig
diff --git a/DEVELOPERS b/DEVELOPERS
index 9a8b586..85d81dc 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -837,7 +837,7 @@ F:	package/keepalived/
 
 N:	Jagan Teki <jagan@amarulasolutions.com>
 F:	board/engicam/
-F:	configs/engicam_imx6qdl_icore_defconfig
+F:	configs/engicam_imx6qdl_icore_mmc_defconfig
 
 N:	James Knight <james.knight@rockwellcollins.com>
 F:	package/atkmm/
diff --git a/board/engicam/readme.txt b/board/engicam/readme.txt
index d02c3af..0ef108d 100644
--- a/board/engicam/readme.txt
+++ b/board/engicam/readme.txt
@@ -17,7 +17,7 @@ First, configure Buildroot for the Engicam i.MX SOM's:
 
 - for i.CoreM6 Quad/Dual:
 
-  make engicam_imx6qdl_icore_defconfig
+  make engicam_imx6qdl_icore_mmc_defconfig
 
 Build all components:
 
diff --git a/configs/engicam_imx6qdl_icore_defconfig b/configs/engicam_imx6qdl_icore_mmc_defconfig
similarity index 100%
rename from configs/engicam_imx6qdl_icore_defconfig
rename to configs/engicam_imx6qdl_icore_mmc_defconfig
-- 
2.7.4

[Buildroot] [PATCH v4 3/6] board: Add support for Engicam i.CoreM6 RQS SOM

[Jagan Teki]

From: Jagan Teki <jagan@amarulasolutions.com>

Add initial support for Engicam i.CoreM6 Quad/Dual/DualLite/Solo RQS
board with below features:
- U-Boot 2017.07-rc1
- Linux 4.11.5
- Default packages from buildroot

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v4:
- Update .gitlab-ci.yml
Changes for v3:
- Use kernel version 4.11.5
Changes for v2:
- Fix genimage.cfg path in readme.txt

 .gitlab-ci.yml                                  |  1 +
 DEVELOPERS                                      |  1 +
 board/engicam/icorem6_rqs/genimage.cfg          | 39 ++++++++++++++
 board/engicam/icorem6_rqs/readme.txt            | 68 +++++++++++++++++++++++++
 configs/engicam_imx6qdl_icore_rqs_mmc_defconfig | 41 +++++++++++++++
 5 files changed, 150 insertions(+)
 create mode 100644 board/engicam/icorem6_rqs/genimage.cfg
 create mode 100644 board/engicam/icorem6_rqs/readme.txt
 create mode 100644 configs/engicam_imx6qdl_icore_rqs_mmc_defconfig

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index c4bf90d..ca51f35 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -90,6 +90,7 @@ ci40_defconfig: *defconfig
 csky_gx6605s_defconfig: *defconfig
 cubieboard2_defconfig: *defconfig
 engicam_imx6qdl_icore_mmc_defconfig: *defconfig
+engicam_imx6qdl_icore_rqs_mmc_defconfig: *defconfig
 firefly_rk3288_defconfig: *defconfig
 firefly_rk3288_demo_defconfig: *defconfig
 freescale_imx28evk_defconfig: *defconfig
diff --git a/DEVELOPERS b/DEVELOPERS
index 85d81dc..feec989 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -838,6 +838,7 @@ F:	package/keepalived/
 N:	Jagan Teki <jagan@amarulasolutions.com>
 F:	board/engicam/
 F:	configs/engicam_imx6qdl_icore_mmc_defconfig
+F:	configs/engicam_imx6qdl_icore_rqs_mmc_defconfig
 
 N:	James Knight <james.knight@rockwellcollins.com>
 F:	package/atkmm/
diff --git a/board/engicam/icorem6_rqs/genimage.cfg b/board/engicam/icorem6_rqs/genimage.cfg
new file mode 100644
index 0000000..a2ee860
--- /dev/null
+++ b/board/engicam/icorem6_rqs/genimage.cfg
@@ -0,0 +1,39 @@
+image boot.vfat {
+	vfat {
+		files = {
+			"uImage",
+			"imx6dl-icore-rqs.dtb",
+			"imx6q-icore-rqs.dtb"
+		}
+	}
+	size = 16M
+}
+
+image sdcard.img {
+	hdimage {
+	}
+
+	partition SPL {
+		in-partition-table = "no"
+		image = "SPL"
+		offset = 1024
+	}
+
+	partition u-boot-dtb {
+		in-partition-table = "no"
+		image = "u-boot-dtb.img"
+		offset = 69K
+	}
+
+	partition boot {
+		partition-type = 0xC
+		bootable = "true"
+		image = "boot.vfat"
+		offset = 8M
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext2"
+	}
+}
diff --git a/board/engicam/icorem6_rqs/readme.txt b/board/engicam/icorem6_rqs/readme.txt
new file mode 100644
index 0000000..eaf72f1
--- /dev/null
+++ b/board/engicam/icorem6_rqs/readme.txt
@@ -0,0 +1,68 @@
+*************************************************
+Buildroot for Engicam i.CoreM6 RQS SOM platforms:
+*************************************************
+
+This file documents the Buildroot support for Engicam i.CoreM6 RQS
+SOM platform boards.
+
+i.CoreM6 Quad/Dual/DualLite/Solo RQS SOM Starter kits:
+https://www.engicam.com/vis-prod/101124
+
+This configuration uses U-Boot mainline and kernel mainline.
+
+Build
+=====
+
+First, configure Buildroot for the Engicam i.CoreM6 RQS:
+
+- for i.CoreM6 RQS Quad/Dual/DualLite/Solo:
+
+  make engicam_imx6qdl_icore_rqs_mmc_defconfig
+
+Build all components:
+
+  make
+
+You will find the following files in output/images/:
+- for i.CoreM6 Quad/Dual RQS:
+  - imx6q-icore-rqs.dtb
+- for i.CoreM6 DualLite/Solo RQS:
+  - imx6dl-icore-rqs.dtb
+  - rootfs.ext4
+  - rootfs.tar
+  - sdcard.img
+  - SPL
+  - u-boot-dtb.img
+  - uImage
+
+Create a bootable SD card
+=========================
+
+To determine the device associated to the SD card have a look in the
+/proc/partitions file:
+
+  cat /proc/partitions
+
+Buildroot prepares a bootable "sdcard.img" image in the output/images/
+directory, ready to be dumped on a SD card. Launch the following
+command as root:
+
+  dd if=output/images/sdcard.img of=/dev/<your-sd-device>
+
+*** WARNING! This will destroy all the card content. Use with care! ***
+
+For details about the medium image layout, see the definition in
+board/engicam/icorem6_rqs/genimage.cfg
+
+Boot the i.CoreM6 RQS boards with SD boot:
+=========================================
+
+To boot your newly created system:
+- insert the SD card in the SD slot of the board;
+- connect 3-wire RS232 serial port J7 on board, and connect with other
+  serial end or USB cable(if serial-to-usb converter used) using
+  a terminal emulator at 115200 bps, 8n1;
+- close JM2 for sd boot.
+- power on the board.
+
+Enjoy!
diff --git a/configs/engicam_imx6qdl_icore_rqs_mmc_defconfig b/configs/engicam_imx6qdl_icore_rqs_mmc_defconfig
new file mode 100644
index 0000000..4d2698d
--- /dev/null
+++ b/configs/engicam_imx6qdl_icore_rqs_mmc_defconfig
@@ -0,0 +1,41 @@
+BR2_arm=y
+BR2_cortex_a9=y
+BR2_ARM_ENABLE_NEON=y
+BR2_ARM_ENABLE_VFP=y
+BR2_ARM_FPU_VFPV3=y
+
+# Linux headers same as kernel, a 4.11 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_11=y
+
+# System
+BR2_TARGET_GENERIC_GETTY_PORT="ttymxc3"
+
+# Bootloader
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.07-rc1"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6qdl_icore_rqs_mmc"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
+BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="SPL"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.11.5"
+BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
+BR2_LINUX_KERNEL_UIMAGE=y
+BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x10008000"
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6dl-icore-rqs imx6q-icore-rqs"
+
+# Filesystem
+BR2_TARGET_GENERIC_ISSUE="Welcome to Engicam i.CoreM6 Quad/Dual/DualLite/Solo RQS Starter Kit"
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/engicam/icorem6_rqs/genimage.cfg"
-- 
2.7.4

[Buildroot] [PATCH v4 4/6] board: engicam: Add icorem6 for i.CoreM6 support

[Jagan Teki]

From: Jagan Teki <jagan@amarulasolutions.com>

Create board/engicam/icorem6 for i.CoreM6 supported files.
and update the readme.txt so-that it can list i.CoreM6 board
details.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v4:
- Update .gitlab-ci.yml
Changes for v3:
- Use kernel version 4.11.5
Changes for v2:
- Fix genimage.cfg path in readme.txt

 board/engicam/{ => icorem6}/genimage.cfg    |  0
 board/engicam/{ => icorem6}/readme.txt      | 14 +++++++-------
 configs/engicam_imx6qdl_icore_mmc_defconfig |  2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)
 rename board/engicam/{ => icorem6}/genimage.cfg (100%)
 rename board/engicam/{ => icorem6}/readme.txt (81%)

diff --git a/board/engicam/genimage.cfg b/board/engicam/icorem6/genimage.cfg
similarity index 100%
rename from board/engicam/genimage.cfg
rename to board/engicam/icorem6/genimage.cfg
diff --git a/board/engicam/readme.txt b/board/engicam/icorem6/readme.txt
similarity index 81%
rename from board/engicam/readme.txt
rename to board/engicam/icorem6/readme.txt
index 0ef108d..a86360b 100644
--- a/board/engicam/readme.txt
+++ b/board/engicam/icorem6/readme.txt
@@ -1,8 +1,8 @@
-*****************************************
-Buildroot for Engicam i.MX6 SOM platforms:
-*****************************************
+*********************************************
+Buildroot for Engicam i.CoreM6 SOM platforms:
+*********************************************
 
-This file documents the Buildroot support for all Engicam i.MX6 SOM
+This file documents the Buildroot support for Engicam i.CoreM6
 platform boards.
 
 i.CoreM6 Quad/Dual/DualLite/Solo SOM Starter kits:
@@ -13,9 +13,9 @@ This configuration uses U-Boot mainline and kernel mainline.
 Build
 =====
 
-First, configure Buildroot for the Engicam i.MX SOM's:
+First, configure Buildroot for the Engicam i.CoreM6:
 
-- for i.CoreM6 Quad/Dual:
+- for i.CoreM6 Quad/Dual/DualLite/Solo:
 
   make engicam_imx6qdl_icore_mmc_defconfig
 
@@ -52,7 +52,7 @@ command as root:
 *** WARNING! This will destroy all the card content. Use with care! ***
 
 For details about the medium image layout, see the definition in
-board/engicam/genimage.cfg
+board/engicam/icorem6/genimage.cfg
 
 Boot the i.CoreM6 boards with SD boot:
 =====================================
diff --git a/configs/engicam_imx6qdl_icore_mmc_defconfig b/configs/engicam_imx6qdl_icore_mmc_defconfig
index ffb3546..25048c4 100644
--- a/configs/engicam_imx6qdl_icore_mmc_defconfig
+++ b/configs/engicam_imx6qdl_icore_mmc_defconfig
@@ -38,4 +38,4 @@ BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
 BR2_PACKAGE_HOST_GENIMAGE=y
 BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
-BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/engicam/genimage.cfg"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/engicam/icorem6/genimage.cfg"
-- 
2.7.4

[Buildroot] [PATCH v4 5/6] board: Add support for Engicam GEAM6UL SOM

[Jagan Teki]

From: Jagan Teki <jagan@amarulasolutions.com>

Add initial support for Engicam GEAM6UL SOM board
with below features:
- U-Boot 2017.07-rc1
- Linux 4.11.5
- Default packages from buildroot

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v4:
- Update .gitlab-ci.yml
Changes for v3:
- Use kernel version 4.11.5
- Fix readme.txt file
Changes for v2:
- Fix genimage.cfg path in readme.txt

 .gitlab-ci.yml                            |  1 +
 DEVELOPERS                                |  1 +
 board/engicam/geam6ul/genimage.cfg        | 38 ++++++++++++++++++
 board/engicam/geam6ul/readme.txt          | 65 +++++++++++++++++++++++++++++++
 configs/engicam_imx6ul_geam_mmc_defconfig | 41 +++++++++++++++++++
 5 files changed, 146 insertions(+)
 create mode 100644 board/engicam/geam6ul/genimage.cfg
 create mode 100644 board/engicam/geam6ul/readme.txt
 create mode 100644 configs/engicam_imx6ul_geam_mmc_defconfig

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index ca51f35..5a7cdc1 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -91,6 +91,7 @@ csky_gx6605s_defconfig: *defconfig
 cubieboard2_defconfig: *defconfig
 engicam_imx6qdl_icore_mmc_defconfig: *defconfig
 engicam_imx6qdl_icore_rqs_mmc_defconfig: *defconfig
+engicam_imx6ul_geam_mmc_defconfig: *defconfig
 firefly_rk3288_defconfig: *defconfig
 firefly_rk3288_demo_defconfig: *defconfig
 freescale_imx28evk_defconfig: *defconfig
diff --git a/DEVELOPERS b/DEVELOPERS
index feec989..1f2ab32 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -839,6 +839,7 @@ N:	Jagan Teki <jagan@amarulasolutions.com>
 F:	board/engicam/
 F:	configs/engicam_imx6qdl_icore_mmc_defconfig
 F:	configs/engicam_imx6qdl_icore_rqs_mmc_defconfig
+F:	configs/engicam_imx6ul_geam_mmc_defconfig
 
 N:	James Knight <james.knight@rockwellcollins.com>
 F:	package/atkmm/
diff --git a/board/engicam/geam6ul/genimage.cfg b/board/engicam/geam6ul/genimage.cfg
new file mode 100644
index 0000000..3b5a31d
--- /dev/null
+++ b/board/engicam/geam6ul/genimage.cfg
@@ -0,0 +1,38 @@
+image boot.vfat {
+	vfat {
+		files = {
+			"uImage",
+			"imx6ul-geam-kit.dtb"
+		}
+	}
+	size = 16M
+}
+
+image sdcard.img {
+	hdimage {
+	}
+
+	partition SPL {
+		in-partition-table = "no"
+		image = "SPL"
+		offset = 1024
+	}
+
+	partition u-boot-dtb {
+		in-partition-table = "no"
+		image = "u-boot-dtb.img"
+		offset = 69K
+	}
+
+	partition boot {
+		partition-type = 0xC
+		bootable = "true"
+		image = "boot.vfat"
+		offset = 8M
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext2"
+	}
+}
diff --git a/board/engicam/geam6ul/readme.txt b/board/engicam/geam6ul/readme.txt
new file mode 100644
index 0000000..09acfe6
--- /dev/null
+++ b/board/engicam/geam6ul/readme.txt
@@ -0,0 +1,65 @@
+********************************************
+Buildroot for Engicam GEAM6UL SOM platforms:
+********************************************
+
+This file documents the Buildroot support for all Engicam GEAM6UL
+SOM platform boards.
+
+GEAM6UL SOM Starter kits:
+https://www.engicam.com/vis-prod/101115
+
+This configuration uses U-Boot mainline and kernel mainline.
+
+Build
+=====
+
+First, configure Buildroot for the Engicam GEAM6UL SOM:
+
+- for GEAM6UL SOM:
+
+  make engicam_imx6ul_geam_mmc_defconfig
+
+Build all components:
+
+  make
+
+You will find the following files in output/images/:
+  - imx6ul-geam-kit.dtb
+  - rootfs.ext4
+  - rootfs.tar
+  - sdcard.img
+  - SPL
+  - u-boot-dtb.img
+  - uImage
+
+Create a bootable SD card
+=========================
+
+To determine the device associated to the SD card have a look in the
+/proc/partitions file:
+
+  cat /proc/partitions
+
+Buildroot prepares a bootable "sdcard.img" image in the output/images/
+directory, ready to be dumped on a SD card. Launch the following
+command as root:
+
+  dd if=output/images/sdcard.img of=/dev/<your-sd-device>
+
+*** WARNING! This will destroy all the card content. Use with care! ***
+
+For details about the medium image layout, see the definition in
+board/engicam/geam6ul/genimage.cfg
+
+Boot the GEAM6UL boards with SD boot:
+====================================
+
+To boot your newly created system:
+- insert the SD card in the SD slot of the board;
+- connect 3-wire RS232 serial port J28 on board, and connect with other
+  serial end or USB cable(if serial-to-usb converter used) using
+  a terminal emulator at 115200 bps, 8n1;
+- close JM3 for sd boot.
+- power on the board.
+
+Enjoy!
diff --git a/configs/engicam_imx6ul_geam_mmc_defconfig b/configs/engicam_imx6ul_geam_mmc_defconfig
new file mode 100644
index 0000000..ef50138
--- /dev/null
+++ b/configs/engicam_imx6ul_geam_mmc_defconfig
@@ -0,0 +1,41 @@
+BR2_arm=y
+BR2_cortex_a9=y
+BR2_ARM_ENABLE_NEON=y
+BR2_ARM_ENABLE_VFP=y
+BR2_ARM_FPU_VFPV3=y
+
+# Linux headers same as kernel, a 4.11 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_11=y
+
+# System
+BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
+
+# Bootloader
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.07-rc1"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6ul_geam_mmc"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
+BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="SPL"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.11.5"
+BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
+BR2_LINUX_KERNEL_UIMAGE=y
+BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x80008000"
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6ul-geam-kit"
+
+# Filesystem
+BR2_TARGET_GENERIC_ISSUE="Welcome to Engicam GEAM6UL Starter Kit"
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/engicam/geam6ul/genimage.cfg"
-- 
2.7.4

[Buildroot] [PATCH v4 6/6] board: Add support for Engicam Is.IoT MX6UL SOM

[Jagan Teki]

From: Jagan Teki <jagan@amarulasolutions.com>

Add initial support for Engicam Is.IoT MX6UL SOM board
with below features:
- U-Boot 2017.07-rc1
- Linux 4.11.5
- Default packages from buildroot

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v4:
- Update .gitlab-ci.yml
Changes for v3:
- Newly added patch

 .gitlab-ci.yml                             |  1 +
 DEVELOPERS                                 |  1 +
 board/engicam/isiot/genimage.cfg           | 38 +++++++++++++++++
 board/engicam/isiot/readme.txt             | 65 ++++++++++++++++++++++++++++++
 configs/engicam_imx6ul_isiot_mmc_defconfig | 41 +++++++++++++++++++
 5 files changed, 146 insertions(+)
 create mode 100644 board/engicam/isiot/genimage.cfg
 create mode 100644 board/engicam/isiot/readme.txt
 create mode 100644 configs/engicam_imx6ul_isiot_mmc_defconfig

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 5a7cdc1..7ab53c5 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -92,6 +92,7 @@ cubieboard2_defconfig: *defconfig
 engicam_imx6qdl_icore_mmc_defconfig: *defconfig
 engicam_imx6qdl_icore_rqs_mmc_defconfig: *defconfig
 engicam_imx6ul_geam_mmc_defconfig: *defconfig
+engicam_imx6ul_isiot_mmc_defconfig: *defconfig
 firefly_rk3288_defconfig: *defconfig
 firefly_rk3288_demo_defconfig: *defconfig
 freescale_imx28evk_defconfig: *defconfig
diff --git a/DEVELOPERS b/DEVELOPERS
index 1f2ab32..2336172 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -840,6 +840,7 @@ F:	board/engicam/
 F:	configs/engicam_imx6qdl_icore_mmc_defconfig
 F:	configs/engicam_imx6qdl_icore_rqs_mmc_defconfig
 F:	configs/engicam_imx6ul_geam_mmc_defconfig
+F:	configs/engicam_imx6ul_isiot_mmc_defconfig
 
 N:	James Knight <james.knight@rockwellcollins.com>
 F:	package/atkmm/
diff --git a/board/engicam/isiot/genimage.cfg b/board/engicam/isiot/genimage.cfg
new file mode 100644
index 0000000..f111a0a
--- /dev/null
+++ b/board/engicam/isiot/genimage.cfg
@@ -0,0 +1,38 @@
+image boot.vfat {
+	vfat {
+		files = {
+			"uImage",
+			"imx6ul-isiot-emmc.dtb"
+		}
+	}
+	size = 16M
+}
+
+image sdcard.img {
+	hdimage {
+	}
+
+	partition SPL {
+		in-partition-table = "no"
+		image = "SPL"
+		offset = 1024
+	}
+
+	partition u-boot-dtb {
+		in-partition-table = "no"
+		image = "u-boot-dtb.img"
+		offset = 69K
+	}
+
+	partition boot {
+		partition-type = 0xC
+		bootable = "true"
+		image = "boot.vfat"
+		offset = 8M
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext2"
+	}
+}
diff --git a/board/engicam/isiot/readme.txt b/board/engicam/isiot/readme.txt
new file mode 100644
index 0000000..584226a
--- /dev/null
+++ b/board/engicam/isiot/readme.txt
@@ -0,0 +1,65 @@
+********************************************
+Buildroot for Engicam Is.IoT SOM platforms:
+********************************************
+
+This file documents the Buildroot support for all Engicam Is.IoT MX6UL
+SOM platform boards.
+
+Is.IoT MX6UL SOM Starter kits:
+https://www.engicam.com/vis-prod/101122
+
+This configuration uses U-Boot mainline and kernel mainline.
+
+Build
+=====
+
+First, configure Buildroot for the Engicam Is.IoT MX6UL SOM:
+
+- for Is.IoT MX6UL SOM:
+
+  make engicam_imx6ul_isiot_mmc_defconfig
+
+Build all components:
+
+  make
+
+You will find the following files in output/images/:
+  - imx6ul-isiot-emmc.dtb
+  - rootfs.ext4
+  - rootfs.tar
+  - sdcard.img
+  - SPL
+  - u-boot-dtb.img
+  - uImage
+
+Create a bootable SD card
+=========================
+
+To determine the device associated to the SD card have a look in the
+/proc/partitions file:
+
+  cat /proc/partitions
+
+Buildroot prepares a bootable "sdcard.img" image in the output/images/
+directory, ready to be dumped on a SD card. Launch the following
+command as root:
+
+  dd if=output/images/sdcard.img of=/dev/<your-sd-device>
+
+*** WARNING! This will destroy all the card content. Use with care! ***
+
+For details about the medium image layout, see the definition in
+board/engicam/isiot/genimage.cfg
+
+Boot the Is.IoT MX6UL boards with SD boot:
+=========================================
+
+To boot your newly created system:
+- insert the SD card in the SD slot of the board;
+- connect 3-wire RS232 serial port J28 on board, and connect with other
+  serial end or USB cable(if serial-to-usb converter used) using
+  a terminal emulator at 115200 bps, 8n1;
+- close JM3 for sd boot.
+- power on the board.
+
+Enjoy!
diff --git a/configs/engicam_imx6ul_isiot_mmc_defconfig b/configs/engicam_imx6ul_isiot_mmc_defconfig
new file mode 100644
index 0000000..7ad7c94
--- /dev/null
+++ b/configs/engicam_imx6ul_isiot_mmc_defconfig
@@ -0,0 +1,41 @@
+BR2_arm=y
+BR2_cortex_a9=y
+BR2_ARM_ENABLE_NEON=y
+BR2_ARM_ENABLE_VFP=y
+BR2_ARM_FPU_VFPV3=y
+
+# Linux headers same as kernel, a 4.11 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_11=y
+
+# System
+BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
+
+# Bootloader
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.07-rc1"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6ul_isiot_mmc"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
+BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="SPL"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.11.5"
+BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
+BR2_LINUX_KERNEL_UIMAGE=y
+BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x80008000"
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6ul-isiot-emmc"
+
+# Filesystem
+BR2_TARGET_GENERIC_ISSUE="Welcome to Engicam Is.IoT eMMC Starter Kit"
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/engicam/isiot/genimage.cfg"
-- 
2.7.4

[Buildroot] [PATCH v4 0/6] Board: Add Engicam i.MX6 SOMs

[Thomas Petazzoni]

Hello,

On Mon, 19 Jun 2017 12:57:26 +0530, Jagan Teki wrote:

> Jagan Teki (6):
>   board: Add support for Engicam i.CoreM6 DualLite/Solo boards
>   board: engicam: Rename defconfig engicam_imx6qdl_icore_mmc_defconfig
>   board: Add support for Engicam i.CoreM6 RQS SOM
>   board: engicam: Add icorem6 for i.CoreM6 support
>   board: Add support for Engicam GEAM6UL SOM
>   board: Add support for Engicam Is.IoT MX6UL SOM

Thanks for this new iteration and those contributions. Since you're
regularly posting new iterations of this patch series, it would be nice
if you could create an account on patchwork, and mark yourself the
previous iterations of your patch series as "Superseded". This way, it
is easier for the maintainers to keep track of what is the latest
version of your patch series that should be considered for
review/merging.

See https://patchwork.ozlabs.org/project/buildroot/list/. You just need
to create an account with the same e-mail address as the one used to
send the patches.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v4 0/6] Board: Add Engicam i.MX6 SOMs

[Jagan Teki]

On Mon, Jun 19, 2017 at 1:11 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Mon, 19 Jun 2017 12:57:26 +0530, Jagan Teki wrote:
>
>> Jagan Teki (6):
>>   board: Add support for Engicam i.CoreM6 DualLite/Solo boards
>>   board: engicam: Rename defconfig engicam_imx6qdl_icore_mmc_defconfig
>>   board: Add support for Engicam i.CoreM6 RQS SOM
>>   board: engicam: Add icorem6 for i.CoreM6 support
>>   board: Add support for Engicam GEAM6UL SOM
>>   board: Add support for Engicam Is.IoT MX6UL SOM
>
> Thanks for this new iteration and those contributions. Since you're
> regularly posting new iterations of this patch series, it would be nice
> if you could create an account on patchwork, and mark yourself the
> previous iterations of your patch series as "Superseded". This way, it
> is easier for the maintainers to keep track of what is the latest
> version of your patch series that should be considered for
> review/merging.
>
> See https://patchwork.ozlabs.org/project/buildroot/list/. You just need
> to create an account with the same e-mail address as the one used to
> send the patches.

I've a patchwork.ozlabs account with different mail id, I guess it is
ok to reuse the same. What do you think?

thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

[Buildroot] [PATCH v4 0/6] Board: Add Engicam i.MX6 SOMs

[Thomas Petazzoni]

Hello,

On Mon, 19 Jun 2017 13:38:35 +0530, Jagan Teki wrote:

> > Thanks for this new iteration and those contributions. Since you're
> > regularly posting new iterations of this patch series, it would be nice
> > if you could create an account on patchwork, and mark yourself the
> > previous iterations of your patch series as "Superseded". This way, it
> > is easier for the maintainers to keep track of what is the latest
> > version of your patch series that should be considered for
> > review/merging.
> >
> > See https://patchwork.ozlabs.org/project/buildroot/list/. You just need
> > to create an account with the same e-mail address as the one used to
> > send the patches.  
> 
> I've a patchwork.ozlabs account with different mail id, I guess it is
> ok to reuse the same. What do you think?

It won't work: patchwork will only allow you to modify the patches for
which you are the author, by matching the email of the patchwork
account with the email of the patch author.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v4 0/6] Board: Add Engicam i.MX6 SOMs

[Jagan Teki]

On Mon, Jun 19, 2017 at 5:48 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Mon, 19 Jun 2017 13:38:35 +0530, Jagan Teki wrote:
>
>> > Thanks for this new iteration and those contributions. Since you're
>> > regularly posting new iterations of this patch series, it would be nice
>> > if you could create an account on patchwork, and mark yourself the
>> > previous iterations of your patch series as "Superseded". This way, it
>> > is easier for the maintainers to keep track of what is the latest
>> > version of your patch series that should be considered for
>> > review/merging.
>> >
>> > See https://patchwork.ozlabs.org/project/buildroot/list/. You just need
>> > to create an account with the same e-mail address as the one used to
>> > send the patches.
>>
>> I've a patchwork.ozlabs account with different mail id, I guess it is
>> ok to reuse the same. What do you think?
>
> It won't work: patchwork will only allow you to modify the patches for
> which you are the author, by matching the email of the patchwork
> account with the email of the patch author.

Created, but I can't mark "Superseded" due to permissions issue if I
select 'Delegate to'  as you or 'no change'

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

[Buildroot] [PATCH v4 0/6] Board: Add Engicam i.MX6 SOMs

[Thomas Petazzoni]

Hello,

On Mon, 19 Jun 2017 18:30:34 +0530, Jagan Teki wrote:

> > It won't work: patchwork will only allow you to modify the patches for
> > which you are the author, by matching the email of the patchwork
> > account with the email of the patch author.  
> 
> Created, but I can't mark "Superseded" due to permissions issue if I
> select 'Delegate to'  as you or 'no change'

If you can't change the state of your patches, it's because your
patchwork account e-mail doesn't match the one of the patches.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v4 1/6] board: Add support for Engicam i.CoreM6 DualLite/Solo boards

[Thomas Petazzoni]

Hello,

On Mon, 19 Jun 2017 12:57:27 +0530, Jagan Teki wrote:

> -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05"
> -BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6q_icore_mmc"
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05-rc1"

This doesn't make sense. Why are you rolling back from 2017.05 to
2017.05-rc1 ?

I assume a feature present in the -rc1 is also present in the final
release. Otherwise, it means the feature has been reverted, which is a
bad sign.

Maybe you wanted to use 2017.07-rc1 instead?

If so, could you please fix this?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v4 2/6] board: engicam: Rename defconfig engicam_imx6qdl_icore_mmc_defconfig

[Thomas Petazzoni]

Hello,

On Mon, 19 Jun 2017 12:57:28 +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
> 
> Since the board have support for nand, better to explicitly
> name it with mmc.
> 
> engicam_imx6qdl_icore_defconfig => engicam_imx6qdl_icore_mmc_defconfig
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

Unless we are going to introduce other configurations for the same
board (to support NAND booting), then I would prefer to keep the name
without the "mmc". The readme.txt can explain that the configuration
supports MMC booting.

Also, in the follow-up patches, please avoid the _mmc_ part in the
defconfig name.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v4 1/6] board: Add support for Engicam i.CoreM6 DualLite/Solo boards

[Jagan Teki]

On Tue, Jun 20, 2017 at 1:47 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Mon, 19 Jun 2017 12:57:27 +0530, Jagan Teki wrote:
>
>> -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05"
>> -BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6q_icore_mmc"
>> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05-rc1"
>
> This doesn't make sense. Why are you rolling back from 2017.05 to
> 2017.05-rc1 ?
>
> I assume a feature present in the -rc1 is also present in the final
> release. Otherwise, it means the feature has been reverted, which is a
> bad sign.
>
> Maybe you wanted to use 2017.07-rc1 instead?

Yes I need to use -rc1 because this feature is present in it. I was
trying for explicitly applying patches, but those are more.


thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

[Buildroot] [PATCH v4 2/6] board: engicam: Rename defconfig engicam_imx6qdl_icore_mmc_defconfig

[Jagan Teki]

On Tue, Jun 20, 2017 at 1:49 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Mon, 19 Jun 2017 12:57:28 +0530, Jagan Teki wrote:
>> From: Jagan Teki <jagan@amarulasolutions.com>
>>
>> Since the board have support for nand, better to explicitly
>> name it with mmc.
>>
>> engicam_imx6qdl_icore_defconfig => engicam_imx6qdl_icore_mmc_defconfig
>>
>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>
> Unless we are going to introduce other configurations for the same
> board (to support NAND booting), then I would prefer to keep the name
> without the "mmc". The readme.txt can explain that the configuration
> supports MMC booting.

I see a point where these defconfig names is in-line with U-Boot
defconfig - since like U-Boot have defconfig based on boot-modes
buildroot have similar approach.

thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

[Buildroot] [PATCH v4 1/6] board: Add support for Engicam i.CoreM6 DualLite/Solo boards

[Thomas Petazzoni]

Hello,

On Tue, 20 Jun 2017 07:55:26 +0530, Jagan Teki wrote:

> >> -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05"
> >> -BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6q_icore_mmc"
> >> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05-rc1"  
> >
> > This doesn't make sense. Why are you rolling back from 2017.05 to
> > 2017.05-rc1 ?
> >
> > I assume a feature present in the -rc1 is also present in the final
> > release. Otherwise, it means the feature has been reverted, which is a
> > bad sign.
> >
> > Maybe you wanted to use 2017.07-rc1 instead?  
> 
> Yes I need to use -rc1 because this feature is present in it. I was
> trying for explicitly applying patches, but those are more.

Did you read what I wrote? Your patch is using 2017.05-rc1, which is
most likely not what you intended, because 2017.05 final is available.
Wasn't your intention to use 2017.07-rc1.

Please re-read carefully your patch and my review. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v4 2/6] board: engicam: Rename defconfig engicam_imx6qdl_icore_mmc_defconfig

[Thomas Petazzoni]

Hello,

On Tue, 20 Jun 2017 08:00:04 +0530, Jagan Teki wrote:

> > Unless we are going to introduce other configurations for the same
> > board (to support NAND booting), then I would prefer to keep the name
> > without the "mmc". The readme.txt can explain that the configuration
> > supports MMC booting.  
> 
> I see a point where these defconfig names is in-line with U-Boot
> defconfig - since like U-Boot have defconfig based on boot-modes
> buildroot have similar approach.

There is no special reason to have the Buildroot defconfig name match
1:1 the U-Boot name, so please drop the _mmc_ part of the Buildroot
defconfig names.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v4 1/6] board: Add support for Engicam i.CoreM6 DualLite/Solo boards

[Jagan Teki]

On Tue, Jun 20, 2017 at 11:16 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Tue, 20 Jun 2017 07:55:26 +0530, Jagan Teki wrote:
>
>> >> -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05"
>> >> -BR2_TARGET_UBOOT_BOARD_DEFCONFIG="imx6q_icore_mmc"
>> >> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.05-rc1"
>> >
>> > This doesn't make sense. Why are you rolling back from 2017.05 to
>> > 2017.05-rc1 ?
>> >
>> > I assume a feature present in the -rc1 is also present in the final
>> > release. Otherwise, it means the feature has been reverted, which is a
>> > bad sign.
>> >
>> > Maybe you wanted to use 2017.07-rc1 instead?
>>
>> Yes I need to use -rc1 because this feature is present in it. I was
>> trying for explicitly applying patches, but those are more.
>
> Did you read what I wrote? Your patch is using 2017.05-rc1, which is
> most likely not what you intended, because 2017.05 final is available.
> Wasn't your intention to use 2017.07-rc1.

Sorry, my intention here is to use 2017.07-rc1, I think I sent wrong patch.

thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.