[PATCH v3] Prompt error message on missing setting for UBI and UBIFS

[PATCH v3] Prompt error message on missing setting for UBI and UBIFS

[yin.thong.choong]

From: Choong YinThong <yin.thong.choong@intel.com>

Prompt error message on missing setting in UBI and UBIFS image creation.

Choong YinThong (1):
  image_types.bbclass: Prompt error message on missing setting     in
    UBI and UBIFS

 meta/classes/image_types.bbclass | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.7.4

[PATCH v3] image_types.bbclass: Prompt error message on missing setting in UBI and UBIFS

[yin.thong.choong]

From: Choong YinThong <yin.thong.choong@intel.com>

Prompt error message to guide user add argument
MKUBIFS_ARGS and UBINIZE_ARGS in local.conf on
every UBI and UBIFS image creation.

[YOCTO #11589]

Signed-off-by: Choong YinThong <yin.thong.choong@intel.com>
---
 meta/classes/image_types.bbclass | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index 7749b00..48338ac 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -145,6 +145,14 @@ UBI_VOLNAME ?= "${MACHINE}-rootfs"
 multiubi_mkfs() {
 	local mkubifs_args="$1"
 	local ubinize_args="$2"
+    
+        # Added prompt error message for ubi and ubifs image creation.
+        if [ -z "$mkubifs_args"] || [ -z "$ubinize_args" ]; then
+            bberror "MKUBIFS_ARGS and UBINIZE_ARGS argument have to set in local.conf for UBI and UBIFS image creation."
+            bberror "Detail please visit this link http://www.linux-mtd.infradead.org/faq/ubifs.html"
+            return
+        fi
+    
 	if [ -z "$3" ]; then
 		local vname=""
 	else
-- 
2.7.4

Re: [PATCH v3] image_types.bbclass: Prompt error message on missing setting in UBI and UBIFS

[Andrea Adami]

On Mon, Jun 19, 2017 at 9:36 PM,  <yin.thong.choong@intel.com> wrote:
> From: Choong YinThong <yin.thong.choong@intel.com>
>
> Prompt error message to guide user add argument
> MKUBIFS_ARGS and UBINIZE_ARGS in local.conf on
> every UBI and UBIFS image creation.
>
> [YOCTO #11589]
>
> Signed-off-by: Choong YinThong <yin.thong.choong@intel.com>
> ---
>  meta/classes/image_types.bbclass | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 7749b00..48338ac 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -145,6 +145,14 @@ UBI_VOLNAME ?= "${MACHINE}-rootfs"
>  multiubi_mkfs() {
>         local mkubifs_args="$1"
>         local ubinize_args="$2"
> +
> +        # Added prompt error message for ubi and ubifs image creation.
> +        if [ -z "$mkubifs_args"] || [ -z "$ubinize_args" ]; then
> +            bberror "MKUBIFS_ARGS and UBINIZE_ARGS argument have to set in local.conf for UBI and UBIFS image creation."

Why in local.conf ? It is not globally valid if you do multi-machine builds.
I'd say the right place is the machine.conf in the BSP layer.

Andrea

> +            bberror "Detail please visit this link http://www.linux-mtd.infradead.org/faq/ubifs.html"
> +            return
> +        fi
> +
>         if [ -z "$3" ]; then
>                 local vname=""
>         else
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH v3] image_types.bbclass: Prompt error message on missing setting in UBI and UBIFS

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

On 20 June 2017 at 13:36, Andrea Adami <andrea.adami@gmail.com> wrote:

> > +            bberror "MKUBIFS_ARGS and UBINIZE_ARGS argument have to set
> in local.conf for UBI and UBIFS image creation."
>
> Why in local.conf ? It is not globally valid if you do multi-machine
> builds.
> I'd say the right place is the machine.conf in the BSP layer.
>

Yes, they could be set anywhere, so don't specify an explicit location.
Just "MKUBIFS_ARGS and UBINIZE_ARGS have to be set for UBI image
generation" should be sufficient.

Ross

[-- Attachment #2: Type: text/html, Size: 940 bytes --]