* [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
@ 2017-06-09 22:22 Martin Kelly
2017-06-15 16:36 ` Martin Kelly
0 siblings, 1 reply; 20+ messages in thread
From: Martin Kelly @ 2017-06-09 22:22 UTC (permalink / raw)
To: openembeded-devel, Koen Kooi, Martin Jansa
Hi all,
This patch series adds a new recipe for Open VM Tools to meta-oe. This
recipe is invaluable for using Openembedded with VMWare, as without the
tools, performance is very slow.
More information about Open VM Tools can be found here:
https://github.com/vmware/open-vm-tools
Please note that, as mentioned in the first commit, this recipe is
modified from the recipe originally found in the Open-Switch repository.
The first patch is directly from that repository, and the following
patches are modifications to it.
Original recipe:
https://github.com/open-switch/ops-build
yocto/openswitch/meta-foss-openswitch/recipes-extended/open-vm-tools/open-vm-tools_10.0.5.bb
Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
Although the original recipe packaging was Apache-licensed, I received
permission from the author (Diego Dompe) to relicense it under the MIT
license for inclusion in meta-openembedded:
https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html
https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html
--
The following changes since commit 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
Revert "rrdtool: add gettext-native dependency" (2017-06-05 11:13:09
+0200)
are available in the git repository at:
https://github.com/XevoInc/meta-openembedded
for you to fetch changes up to 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
----------------------------------------------------------------
Martin Kelly (14):
add open-vm-tools recipe
open-vm-tools: add missing pkgconfig dependency
open-vm-tools: add missing glib-2.0-native dependency
open-vm-tools: clarify and expand licensing
open-vm-tools: base_contains --> bb.utils.contains
open-vm-tools: update version to 10.1.5
open-vm-tools: don't use mspack
open-vm-tools: don't use dnet-config
open-vm-tools: add #include to fix build break
open-vm-tools: add missing X11 dependencies
open-vm-tools: remove kernel module logic
open-vm-tools: line up configure options
open-vm-tools: support FUSE
open-vm-tools: style changes
.../recipes-support/open-vm-tools/files/tools.conf | 2 +
.../open-vm-tools/files/vmtoolsd.service | 11 +++
.../open-vm-tools/0001-Fix-kernel-detection.patch | 35 +++++++++
.../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++
.../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++
.../open-vm-tools/open-vm-tools_10.1.5.bb | 90
++++++++++++++++++++++
6 files changed, 212 insertions(+)
create mode 100644 meta-oe/recipes-support/open-vm-tools/files/tools.conf
create mode 100644
meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service
create mode 100644
meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patch
create mode 100644
meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch
create mode 100644
meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patch
create mode 100644
meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb
--
2.1.4
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-09 22:22 [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe Martin Kelly
@ 2017-06-15 16:36 ` Martin Kelly
2017-06-15 16:54 ` Martin Jansa
0 siblings, 1 reply; 20+ messages in thread
From: Martin Kelly @ 2017-06-15 16:36 UTC (permalink / raw)
To: openembeded-devel, Koen Kooi, Martin Jansa
On 06/09/2017 03:22 PM, Martin Kelly wrote:
> Hi all,
>
> This patch series adds a new recipe for Open VM Tools to meta-oe. This
> recipe is invaluable for using Openembedded with VMWare, as without the
> tools, performance is very slow.
>
> More information about Open VM Tools can be found here:
>
> https://github.com/vmware/open-vm-tools
>
> Please note that, as mentioned in the first commit, this recipe is
> modified from the recipe originally found in the Open-Switch repository.
> The first patch is directly from that repository, and the following
> patches are modifications to it.
>
> Original recipe:
> https://github.com/open-switch/ops-build
> yocto/openswitch/meta-foss-openswitch/recipes-extended/open-vm-tools/open-vm-tools_10.0.5.bb
>
> Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
>
> Although the original recipe packaging was Apache-licensed, I received
> permission from the author (Diego Dompe) to relicense it under the MIT
> license for inclusion in meta-openembedded:
>
> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html
> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html
>
> --
> The following changes since commit
> 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
>
> Revert "rrdtool: add gettext-native dependency" (2017-06-05 11:13:09
> +0200)
>
> are available in the git repository at:
>
> https://github.com/XevoInc/meta-openembedded
>
> for you to fetch changes up to 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
>
> open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
>
> ----------------------------------------------------------------
> Martin Kelly (14):
> add open-vm-tools recipe
> open-vm-tools: add missing pkgconfig dependency
> open-vm-tools: add missing glib-2.0-native dependency
> open-vm-tools: clarify and expand licensing
> open-vm-tools: base_contains --> bb.utils.contains
> open-vm-tools: update version to 10.1.5
> open-vm-tools: don't use mspack
> open-vm-tools: don't use dnet-config
> open-vm-tools: add #include to fix build break
> open-vm-tools: add missing X11 dependencies
> open-vm-tools: remove kernel module logic
> open-vm-tools: line up configure options
> open-vm-tools: support FUSE
> open-vm-tools: style changes
>
> .../recipes-support/open-vm-tools/files/tools.conf | 2 +
> .../open-vm-tools/files/vmtoolsd.service | 11 +++
> .../open-vm-tools/0001-Fix-kernel-detection.patch | 35 +++++++++
> .../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++
> .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++
> .../open-vm-tools/open-vm-tools_10.1.5.bb | 90
> ++++++++++++++++++++++
> 6 files changed, 212 insertions(+)
> create mode 100644 meta-oe/recipes-support/open-vm-tools/files/tools.conf
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patch
>
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch
>
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patch
>
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb
> --
> 2.1.4
(ping)
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-15 16:36 ` Martin Kelly
@ 2017-06-15 16:54 ` Martin Jansa
2017-06-15 17:07 ` Martin Kelly
2017-06-15 17:40 ` Martin Kelly
0 siblings, 2 replies; 20+ messages in thread
From: Martin Jansa @ 2017-06-15 16:54 UTC (permalink / raw)
To: Martin Kelly; +Cc: Koen Kooi, openembeded-devel
It didn't make it to patchwork, because you've sent only the cover letter.
I've added it to master-next now.
Next time please send also individual patches. So that it gets more
visibility for other people to comment and also that I can use patchwork to
pull it in.
Regards,
On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.com> wrote:
> On 06/09/2017 03:22 PM, Martin Kelly wrote:
>
>> Hi all,
>>
>> This patch series adds a new recipe for Open VM Tools to meta-oe. This
>> recipe is invaluable for using Openembedded with VMWare, as without the
>> tools, performance is very slow.
>>
>> More information about Open VM Tools can be found here:
>>
>> https://github.com/vmware/open-vm-tools
>>
>> Please note that, as mentioned in the first commit, this recipe is
>> modified from the recipe originally found in the Open-Switch repository.
>> The first patch is directly from that repository, and the following
>> patches are modifications to it.
>>
>> Original recipe:
>> https://github.com/open-switch/ops-build
>> yocto/openswitch/meta-foss-openswitch/recipes-extended/open-vm-tools/
>> open-vm-tools_10.0.5.bb
>>
>> Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
>>
>> Although the original recipe packaging was Apache-licensed, I received
>> permission from the author (Diego Dompe) to relicense it under the MIT
>> license for inclusion in meta-openembedded:
>>
>> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html
>> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html
>>
>> --
>> The following changes since commit
>> 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
>>
>> Revert "rrdtool: add gettext-native dependency" (2017-06-05 11:13:09
>> +0200)
>>
>> are available in the git repository at:
>>
>> https://github.com/XevoInc/meta-openembedded
>>
>> for you to fetch changes up to 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
>>
>> open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
>>
>> ----------------------------------------------------------------
>> Martin Kelly (14):
>> add open-vm-tools recipe
>> open-vm-tools: add missing pkgconfig dependency
>> open-vm-tools: add missing glib-2.0-native dependency
>> open-vm-tools: clarify and expand licensing
>> open-vm-tools: base_contains --> bb.utils.contains
>> open-vm-tools: update version to 10.1.5
>> open-vm-tools: don't use mspack
>> open-vm-tools: don't use dnet-config
>> open-vm-tools: add #include to fix build break
>> open-vm-tools: add missing X11 dependencies
>> open-vm-tools: remove kernel module logic
>> open-vm-tools: line up configure options
>> open-vm-tools: support FUSE
>> open-vm-tools: style changes
>>
>> .../recipes-support/open-vm-tools/files/tools.conf | 2 +
>> .../open-vm-tools/files/vmtoolsd.service | 11 +++
>> .../open-vm-tools/0001-Fix-kernel-detection.patch | 35 +++++++++
>> .../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++
>> .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++
>> .../open-vm-tools/open-vm-tools_10.1.5.bb | 90
>> ++++++++++++++++++++++
>> 6 files changed, 212 insertions(+)
>> create mode 100644 meta-oe/recipes-support/open-v
>> m-tools/files/tools.conf
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix
>> -kernel-detection.patch
>>
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-con
>> figure.ac-don-t-use-dnet-config.patch
>>
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add
>> -include-sys-sysmacros.h.patch
>>
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb
>> --
>> 2.1.4
>>
>
> (ping)
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-15 16:54 ` Martin Jansa
@ 2017-06-15 17:07 ` Martin Kelly
2017-06-15 17:17 ` Martin Jansa
2017-06-15 17:40 ` Martin Kelly
1 sibling, 1 reply; 20+ messages in thread
From: Martin Kelly @ 2017-06-15 17:07 UTC (permalink / raw)
To: Martin Jansa; +Cc: Koen Kooi, openembeded-devel
On 06/15/2017 09:54 AM, Martin Jansa wrote:
> It didn't make it to patchwork, because you've sent only the cover
> letter. I've added it to master-next now.
>
> Next time please send also individual patches. So that it gets more
> visibility for other people to comment and also that I can use patchwork
> to pull it in.
>
> Regards,
>
Thanks, sorry about that. I was trying to use the send-pull-request
script and getting errors; somehow it couldn't figure out the branch I
was using. I tried to fix the script but eventually gave up and did a
manual pull request attempting to mimic what the script would have spit out.
> On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.com
> <mailto:mkelly@xevo.com>> wrote:
>
> On 06/09/2017 03:22 PM, Martin Kelly wrote:
>
> Hi all,
>
> This patch series adds a new recipe for Open VM Tools to
> meta-oe. This
> recipe is invaluable for using Openembedded with VMWare, as
> without the
> tools, performance is very slow.
>
> More information about Open VM Tools can be found here:
>
> https://github.com/vmware/open-vm-tools
> <https://github.com/vmware/open-vm-tools>
>
> Please note that, as mentioned in the first commit, this recipe is
> modified from the recipe originally found in the Open-Switch
> repository.
> The first patch is directly from that repository, and the following
> patches are modifications to it.
>
> Original recipe:
> https://github.com/open-switch/ops-build
> <https://github.com/open-switch/ops-build>
> yocto/openswitch/meta-foss-openswitch/recipes-extended/open-vm-tools/open-vm-tools_10.0.5.bb
> <http://open-vm-tools_10.0.5.bb>
>
> Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
>
> Although the original recipe packaging was Apache-licensed, I
> received
> permission from the author (Diego Dompe) to relicense it under
> the MIT
> license for inclusion in meta-openembedded:
>
> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html
> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html>
> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html
> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html>
>
> --
> The following changes since commit
> 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
>
> Revert "rrdtool: add gettext-native dependency" (2017-06-05
> 11:13:09
> +0200)
>
> are available in the git repository at:
>
> https://github.com/XevoInc/meta-openembedded
> <https://github.com/XevoInc/meta-openembedded>
>
> for you to fetch changes up to
> 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
>
> open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
>
> ----------------------------------------------------------------
> Martin Kelly (14):
> add open-vm-tools recipe
> open-vm-tools: add missing pkgconfig dependency
> open-vm-tools: add missing glib-2.0-native dependency
> open-vm-tools: clarify and expand licensing
> open-vm-tools: base_contains --> bb.utils.contains
> open-vm-tools: update version to 10.1.5
> open-vm-tools: don't use mspack
> open-vm-tools: don't use dnet-config
> open-vm-tools: add #include to fix build break
> open-vm-tools: add missing X11 dependencies
> open-vm-tools: remove kernel module logic
> open-vm-tools: line up configure options
> open-vm-tools: support FUSE
> open-vm-tools: style changes
>
> .../recipes-support/open-vm-tools/files/tools.conf | 2 +
> .../open-vm-tools/files/vmtoolsd.service | 11 +++
> .../open-vm-tools/0001-Fix-kernel-detection.patch | 35 +++++++++
> .../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++
> .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++
> .../open-vm-tools/open-vm-tools_10.1.5.bb
> <http://open-vm-tools_10.1.5.bb> | 90
> ++++++++++++++++++++++
> 6 files changed, 212 insertions(+)
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/files/tools.conf
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patch
>
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch
>
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patch
>
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb
> <http://open-vm-tools_10.1.5.bb>
> --
> 2.1.4
>
>
> (ping)
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-15 17:07 ` Martin Kelly
@ 2017-06-15 17:17 ` Martin Jansa
2017-06-15 17:22 ` Martin Kelly
2017-06-23 7:41 ` Paul Eggleton
0 siblings, 2 replies; 20+ messages in thread
From: Martin Jansa @ 2017-06-15 17:17 UTC (permalink / raw)
To: Martin Kelly; +Cc: Koen Kooi, openembeded-devel
No problem, I had issues with that script as well, but it works for me if I
provide all necessary params manually (when it doesn't try to figure out
anything).
On Thu, Jun 15, 2017 at 7:07 PM, Martin Kelly <mkelly@xevo.com> wrote:
> On 06/15/2017 09:54 AM, Martin Jansa wrote:
>
>> It didn't make it to patchwork, because you've sent only the cover
>> letter. I've added it to master-next now.
>>
>> Next time please send also individual patches. So that it gets more
>> visibility for other people to comment and also that I can use patchwork
>> to pull it in.
>>
>> Regards,
>>
>>
> Thanks, sorry about that. I was trying to use the send-pull-request script
> and getting errors; somehow it couldn't figure out the branch I was using.
> I tried to fix the script but eventually gave up and did a manual pull
> request attempting to mimic what the script would have spit out.
>
> On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.com
>> <mailto:mkelly@xevo.com>> wrote:
>>
>> On 06/09/2017 03:22 PM, Martin Kelly wrote:
>>
>> Hi all,
>>
>> This patch series adds a new recipe for Open VM Tools to
>> meta-oe. This
>> recipe is invaluable for using Openembedded with VMWare, as
>> without the
>> tools, performance is very slow.
>>
>> More information about Open VM Tools can be found here:
>>
>> https://github.com/vmware/open-vm-tools
>> <https://github.com/vmware/open-vm-tools>
>>
>> Please note that, as mentioned in the first commit, this recipe is
>> modified from the recipe originally found in the Open-Switch
>> repository.
>> The first patch is directly from that repository, and the
>> following
>> patches are modifications to it.
>>
>> Original recipe:
>> https://github.com/open-switch/ops-build
>> <https://github.com/open-switch/ops-build>
>> yocto/openswitch/meta-foss-openswitch/recipes-extended/open-
>> vm-tools/open-vm-tools_10.0.5.bb
>> <http://open-vm-tools_10.0.5.bb>
>>
>> Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
>>
>> Although the original recipe packaging was Apache-licensed, I
>> received
>> permission from the author (Diego Dompe) to relicense it under
>> the MIT
>> license for inclusion in meta-openembedded:
>>
>> https://lists.openswitch.net/pipermail/ops-dev/2017-April/01
>> 4715.html
>> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/0
>> 14715.html>
>> https://lists.openswitch.net/pipermail/ops-dev/2017-April/01
>> 4716.html
>>
>> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/0
>> 14716.html>
>>
>> --
>> The following changes since commit
>> 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
>>
>> Revert "rrdtool: add gettext-native dependency" (2017-06-05
>> 11:13:09
>> +0200)
>>
>> are available in the git repository at:
>>
>> https://github.com/XevoInc/meta-openembedded
>> <https://github.com/XevoInc/meta-openembedded>
>>
>> for you to fetch changes up to
>> 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
>>
>> open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
>>
>> ----------------------------------------------------------------
>> Martin Kelly (14):
>> add open-vm-tools recipe
>> open-vm-tools: add missing pkgconfig dependency
>> open-vm-tools: add missing glib-2.0-native dependency
>> open-vm-tools: clarify and expand licensing
>> open-vm-tools: base_contains --> bb.utils.contains
>> open-vm-tools: update version to 10.1.5
>> open-vm-tools: don't use mspack
>> open-vm-tools: don't use dnet-config
>> open-vm-tools: add #include to fix build break
>> open-vm-tools: add missing X11 dependencies
>> open-vm-tools: remove kernel module logic
>> open-vm-tools: line up configure options
>> open-vm-tools: support FUSE
>> open-vm-tools: style changes
>>
>> .../recipes-support/open-vm-tools/files/tools.conf | 2 +
>> .../open-vm-tools/files/vmtoolsd.service | 11 +++
>> .../open-vm-tools/0001-Fix-kernel-detection.patch | 35
>> +++++++++
>> .../0002-configure.ac-don-t-use-dnet-config.patch | 41
>> ++++++++++
>> .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++
>> .../open-vm-tools/open-vm-tools_10.1.5.bb
>> <http://open-vm-tools_10.1.5.bb> | 90
>> ++++++++++++++++++++++
>> 6 files changed, 212 insertions(+)
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/files/tools.conf
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix
>> -kernel-detection.patch
>>
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-con
>> figure.ac-don-t-use-dnet-config.patch
>>
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add
>> -include-sys-sysmacros.h.patch
>>
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb
>> <http://open-vm-tools_10.1.5.bb>
>> --
>> 2.1.4
>>
>>
>> (ping)
>>
>>
>>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-15 17:17 ` Martin Jansa
@ 2017-06-15 17:22 ` Martin Kelly
2017-06-23 7:41 ` Paul Eggleton
1 sibling, 0 replies; 20+ messages in thread
From: Martin Kelly @ 2017-06-15 17:22 UTC (permalink / raw)
To: Martin Jansa; +Cc: Koen Kooi, openembeded-devel
On 06/15/2017 10:17 AM, Martin Jansa wrote:
> No problem, I had issues with that script as well, but it works for me
> if I provide all necessary params manually (when it doesn't try to
> figure out anything).
>
Makes sense; I think the script may be too smart for its own good :).
> On Thu, Jun 15, 2017 at 7:07 PM, Martin Kelly <mkelly@xevo.com
> <mailto:mkelly@xevo.com>> wrote:
>
> On 06/15/2017 09:54 AM, Martin Jansa wrote:
>
> It didn't make it to patchwork, because you've sent only the cover
> letter. I've added it to master-next now.
>
> Next time please send also individual patches. So that it gets more
> visibility for other people to comment and also that I can use
> patchwork
> to pull it in.
>
> Regards,
>
>
> Thanks, sorry about that. I was trying to use the send-pull-request
> script and getting errors; somehow it couldn't figure out the branch
> I was using. I tried to fix the script but eventually gave up and
> did a manual pull request attempting to mimic what the script would
> have spit out.
>
> On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.com
> <mailto:mkelly@xevo.com>
> <mailto:mkelly@xevo.com <mailto:mkelly@xevo.com>>> wrote:
>
> On 06/09/2017 03:22 PM, Martin Kelly wrote:
>
> Hi all,
>
> This patch series adds a new recipe for Open VM Tools to
> meta-oe. This
> recipe is invaluable for using Openembedded with VMWare, as
> without the
> tools, performance is very slow.
>
> More information about Open VM Tools can be found here:
>
> https://github.com/vmware/open-vm-tools
> <https://github.com/vmware/open-vm-tools>
> <https://github.com/vmware/open-vm-tools
> <https://github.com/vmware/open-vm-tools>>
>
> Please note that, as mentioned in the first commit, this
> recipe is
> modified from the recipe originally found in the Open-Switch
> repository.
> The first patch is directly from that repository, and
> the following
> patches are modifications to it.
>
> Original recipe:
> https://github.com/open-switch/ops-build
> <https://github.com/open-switch/ops-build>
> <https://github.com/open-switch/ops-build
> <https://github.com/open-switch/ops-build>>
>
> yocto/openswitch/meta-foss-openswitch/recipes-extended/open-vm-tools/open-vm-tools_10.0.5.bb
> <http://open-vm-tools_10.0.5.bb>
> <http://open-vm-tools_10.0.5.bb
> <http://open-vm-tools_10.0.5.bb>>
>
> Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
>
> Although the original recipe packaging was
> Apache-licensed, I
> received
> permission from the author (Diego Dompe) to relicense it
> under
> the MIT
> license for inclusion in meta-openembedded:
>
>
> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html
> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html>
>
> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html
> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html>>
>
> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html
> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html>
>
>
> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html
> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html>>
>
> --
> The following changes since commit
> 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
>
> Revert "rrdtool: add gettext-native dependency"
> (2017-06-05
> 11:13:09
> +0200)
>
> are available in the git repository at:
>
> https://github.com/XevoInc/meta-openembedded
> <https://github.com/XevoInc/meta-openembedded>
> <https://github.com/XevoInc/meta-openembedded
> <https://github.com/XevoInc/meta-openembedded>>
>
> for you to fetch changes up to
> 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
>
> open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
>
>
> ----------------------------------------------------------------
> Martin Kelly (14):
> add open-vm-tools recipe
> open-vm-tools: add missing pkgconfig dependency
> open-vm-tools: add missing glib-2.0-native dependency
> open-vm-tools: clarify and expand licensing
> open-vm-tools: base_contains --> bb.utils.contains
> open-vm-tools: update version to 10.1.5
> open-vm-tools: don't use mspack
> open-vm-tools: don't use dnet-config
> open-vm-tools: add #include to fix build break
> open-vm-tools: add missing X11 dependencies
> open-vm-tools: remove kernel module logic
> open-vm-tools: line up configure options
> open-vm-tools: support FUSE
> open-vm-tools: style changes
>
> .../recipes-support/open-vm-tools/files/tools.conf | 2 +
> .../open-vm-tools/files/vmtoolsd.service | 11 +++
> .../open-vm-tools/0001-Fix-kernel-detection.patch | 35
> +++++++++
> .../0002-configure.ac-don-t-use-dnet-config.patch | 41
> ++++++++++
> .../0003-add-include-sys-sysmacros.h.patch | 33
> ++++++++
> .../open-vm-tools/open-vm-tools_10.1.5.bb
> <http://open-vm-tools_10.1.5.bb>
> <http://open-vm-tools_10.1.5.bb
> <http://open-vm-tools_10.1.5.bb>> | 90
> ++++++++++++++++++++++
> 6 files changed, 212 insertions(+)
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/files/tools.conf
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service
> create mode 100644
>
> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patch
>
> create mode 100644
>
> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch
>
> create mode 100644
>
> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patch
>
> create mode 100644
>
> meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb
> <http://open-vm-tools_10.1.5.bb>
> <http://open-vm-tools_10.1.5.bb
> <http://open-vm-tools_10.1.5.bb>>
> --
> 2.1.4
>
>
> (ping)
>
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-15 16:54 ` Martin Jansa
2017-06-15 17:07 ` Martin Kelly
@ 2017-06-15 17:40 ` Martin Kelly
2017-06-15 17:50 ` Martin Jansa
1 sibling, 1 reply; 20+ messages in thread
From: Martin Kelly @ 2017-06-15 17:40 UTC (permalink / raw)
To: Martin Jansa; +Cc: Koen Kooi, openembeded-devel
On 06/15/2017 09:54 AM, Martin Jansa wrote:
> It didn't make it to patchwork, because you've sent only the cover
> letter. I've added it to master-next now.
>
> Next time please send also individual patches. So that it gets more
> visibility for other people to comment and also that I can use patchwork
> to pull it in.
>
> Regards,
>
Small note: Looks like the initial commit (24b2ac) has a small typo that
should ideally be fixed before it's merged into master:
"open-vm-tools: add recipe from meat-foss-openswitch"
"meat" --> "meta"
> On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.com
> <mailto:mkelly@xevo.com>> wrote:
>
> On 06/09/2017 03:22 PM, Martin Kelly wrote:
>
> Hi all,
>
> This patch series adds a new recipe for Open VM Tools to
> meta-oe. This
> recipe is invaluable for using Openembedded with VMWare, as
> without the
> tools, performance is very slow.
>
> More information about Open VM Tools can be found here:
>
> https://github.com/vmware/open-vm-tools
> <https://github.com/vmware/open-vm-tools>
>
> Please note that, as mentioned in the first commit, this recipe is
> modified from the recipe originally found in the Open-Switch
> repository.
> The first patch is directly from that repository, and the following
> patches are modifications to it.
>
> Original recipe:
> https://github.com/open-switch/ops-build
> <https://github.com/open-switch/ops-build>
> yocto/openswitch/meta-foss-openswitch/recipes-extended/open-vm-tools/open-vm-tools_10.0.5.bb
> <http://open-vm-tools_10.0.5.bb>
>
> Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
>
> Although the original recipe packaging was Apache-licensed, I
> received
> permission from the author (Diego Dompe) to relicense it under
> the MIT
> license for inclusion in meta-openembedded:
>
> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html
> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014715.html>
> https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html
> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/014716.html>
>
> --
> The following changes since commit
> 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
>
> Revert "rrdtool: add gettext-native dependency" (2017-06-05
> 11:13:09
> +0200)
>
> are available in the git repository at:
>
> https://github.com/XevoInc/meta-openembedded
> <https://github.com/XevoInc/meta-openembedded>
>
> for you to fetch changes up to
> 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
>
> open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
>
> ----------------------------------------------------------------
> Martin Kelly (14):
> add open-vm-tools recipe
> open-vm-tools: add missing pkgconfig dependency
> open-vm-tools: add missing glib-2.0-native dependency
> open-vm-tools: clarify and expand licensing
> open-vm-tools: base_contains --> bb.utils.contains
> open-vm-tools: update version to 10.1.5
> open-vm-tools: don't use mspack
> open-vm-tools: don't use dnet-config
> open-vm-tools: add #include to fix build break
> open-vm-tools: add missing X11 dependencies
> open-vm-tools: remove kernel module logic
> open-vm-tools: line up configure options
> open-vm-tools: support FUSE
> open-vm-tools: style changes
>
> .../recipes-support/open-vm-tools/files/tools.conf | 2 +
> .../open-vm-tools/files/vmtoolsd.service | 11 +++
> .../open-vm-tools/0001-Fix-kernel-detection.patch | 35 +++++++++
> .../0002-configure.ac-don-t-use-dnet-config.patch | 41 ++++++++++
> .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++
> .../open-vm-tools/open-vm-tools_10.1.5.bb
> <http://open-vm-tools_10.1.5.bb> | 90
> ++++++++++++++++++++++
> 6 files changed, 212 insertions(+)
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/files/tools.conf
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix-kernel-detection.patch
>
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-configure.ac-don-t-use-dnet-config.patch
>
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add-include-sys-sysmacros.h.patch
>
> create mode 100644
> meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb
> <http://open-vm-tools_10.1.5.bb>
> --
> 2.1.4
>
>
> (ping)
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-15 17:40 ` Martin Kelly
@ 2017-06-15 17:50 ` Martin Jansa
2017-06-18 19:58 ` Martin Jansa
0 siblings, 1 reply; 20+ messages in thread
From: Martin Jansa @ 2017-06-15 17:50 UTC (permalink / raw)
To: Martin Kelly; +Cc: Koen Kooi, openembeded-devel
OK, I'll try to remember to fix it before merge.
I'm sorry about it, tweaking other people commits always strikes back :).
On Thu, Jun 15, 2017 at 7:40 PM, Martin Kelly <mkelly@xevo.com> wrote:
> On 06/15/2017 09:54 AM, Martin Jansa wrote:
>
>> It didn't make it to patchwork, because you've sent only the cover
>> letter. I've added it to master-next now.
>>
>> Next time please send also individual patches. So that it gets more
>> visibility for other people to comment and also that I can use patchwork
>> to pull it in.
>>
>> Regards,
>>
>>
> Small note: Looks like the initial commit (24b2ac) has a small typo that
> should ideally be fixed before it's merged into master:
>
> "open-vm-tools: add recipe from meat-foss-openswitch"
>
> "meat" --> "meta"
>
> On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.com
>> <mailto:mkelly@xevo.com>> wrote:
>>
>> On 06/09/2017 03:22 PM, Martin Kelly wrote:
>>
>> Hi all,
>>
>> This patch series adds a new recipe for Open VM Tools to
>> meta-oe. This
>> recipe is invaluable for using Openembedded with VMWare, as
>> without the
>> tools, performance is very slow.
>>
>> More information about Open VM Tools can be found here:
>>
>> https://github.com/vmware/open-vm-tools
>> <https://github.com/vmware/open-vm-tools>
>>
>> Please note that, as mentioned in the first commit, this recipe is
>> modified from the recipe originally found in the Open-Switch
>> repository.
>> The first patch is directly from that repository, and the
>> following
>> patches are modifications to it.
>>
>> Original recipe:
>> https://github.com/open-switch/ops-build
>> <https://github.com/open-switch/ops-build>
>> yocto/openswitch/meta-foss-openswitch/recipes-extended/open-
>> vm-tools/open-vm-tools_10.0.5.bb
>> <http://open-vm-tools_10.0.5.bb>
>>
>> Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
>>
>> Although the original recipe packaging was Apache-licensed, I
>> received
>> permission from the author (Diego Dompe) to relicense it under
>> the MIT
>> license for inclusion in meta-openembedded:
>>
>> https://lists.openswitch.net/pipermail/ops-dev/2017-April/01
>> 4715.html
>> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/0
>> 14715.html>
>> https://lists.openswitch.net/pipermail/ops-dev/2017-April/01
>> 4716.html
>>
>> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/0
>> 14716.html>
>>
>> --
>> The following changes since commit
>> 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
>>
>> Revert "rrdtool: add gettext-native dependency" (2017-06-05
>> 11:13:09
>> +0200)
>>
>> are available in the git repository at:
>>
>> https://github.com/XevoInc/meta-openembedded
>> <https://github.com/XevoInc/meta-openembedded>
>>
>> for you to fetch changes up to
>> 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
>>
>> open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
>>
>> ----------------------------------------------------------------
>> Martin Kelly (14):
>> add open-vm-tools recipe
>> open-vm-tools: add missing pkgconfig dependency
>> open-vm-tools: add missing glib-2.0-native dependency
>> open-vm-tools: clarify and expand licensing
>> open-vm-tools: base_contains --> bb.utils.contains
>> open-vm-tools: update version to 10.1.5
>> open-vm-tools: don't use mspack
>> open-vm-tools: don't use dnet-config
>> open-vm-tools: add #include to fix build break
>> open-vm-tools: add missing X11 dependencies
>> open-vm-tools: remove kernel module logic
>> open-vm-tools: line up configure options
>> open-vm-tools: support FUSE
>> open-vm-tools: style changes
>>
>> .../recipes-support/open-vm-tools/files/tools.conf | 2 +
>> .../open-vm-tools/files/vmtoolsd.service | 11 +++
>> .../open-vm-tools/0001-Fix-kernel-detection.patch | 35
>> +++++++++
>> .../0002-configure.ac-don-t-use-dnet-config.patch | 41
>> ++++++++++
>> .../0003-add-include-sys-sysmacros.h.patch | 33 ++++++++
>> .../open-vm-tools/open-vm-tools_10.1.5.bb
>> <http://open-vm-tools_10.1.5.bb> | 90
>> ++++++++++++++++++++++
>> 6 files changed, 212 insertions(+)
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/files/tools.conf
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix
>> -kernel-detection.patch
>>
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-con
>> figure.ac-don-t-use-dnet-config.patch
>>
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add
>> -include-sys-sysmacros.h.patch
>>
>> create mode 100644
>> meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb
>> <http://open-vm-tools_10.1.5.bb>
>> --
>> 2.1.4
>>
>>
>> (ping)
>>
>>
>>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-15 17:50 ` Martin Jansa
@ 2017-06-18 19:58 ` Martin Jansa
2017-06-18 20:28 ` Martin Jansa
2017-06-19 18:35 ` Martin Kelly
0 siblings, 2 replies; 20+ messages in thread
From: Martin Jansa @ 2017-06-18 19:58 UTC (permalink / raw)
To: Martin Kelly; +Cc: Koen Kooi, openembeded-devel
Fails to configure on qemuarm.
If arm isn't expected to be supported, can you please update
COMPATIBLE_HOST restriction?
http://errors.yoctoproject.org/Errors/Details/145599/
On Thu, Jun 15, 2017 at 7:50 PM, Martin Jansa <martin.jansa@gmail.com>
wrote:
> OK, I'll try to remember to fix it before merge.
>
> I'm sorry about it, tweaking other people commits always strikes back :).
>
> On Thu, Jun 15, 2017 at 7:40 PM, Martin Kelly <mkelly@xevo.com> wrote:
>
>> On 06/15/2017 09:54 AM, Martin Jansa wrote:
>>
>>> It didn't make it to patchwork, because you've sent only the cover
>>> letter. I've added it to master-next now.
>>>
>>> Next time please send also individual patches. So that it gets more
>>> visibility for other people to comment and also that I can use patchwork
>>> to pull it in.
>>>
>>> Regards,
>>>
>>>
>> Small note: Looks like the initial commit (24b2ac) has a small typo that
>> should ideally be fixed before it's merged into master:
>>
>> "open-vm-tools: add recipe from meat-foss-openswitch"
>>
>> "meat" --> "meta"
>>
>> On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.com
>>> <mailto:mkelly@xevo.com>> wrote:
>>>
>>> On 06/09/2017 03:22 PM, Martin Kelly wrote:
>>>
>>> Hi all,
>>>
>>> This patch series adds a new recipe for Open VM Tools to
>>> meta-oe. This
>>> recipe is invaluable for using Openembedded with VMWare, as
>>> without the
>>> tools, performance is very slow.
>>>
>>> More information about Open VM Tools can be found here:
>>>
>>> https://github.com/vmware/open-vm-tools
>>> <https://github.com/vmware/open-vm-tools>
>>>
>>> Please note that, as mentioned in the first commit, this recipe
>>> is
>>> modified from the recipe originally found in the Open-Switch
>>> repository.
>>> The first patch is directly from that repository, and the
>>> following
>>> patches are modifications to it.
>>>
>>> Original recipe:
>>> https://github.com/open-switch/ops-build
>>> <https://github.com/open-switch/ops-build>
>>> yocto/openswitch/meta-foss-openswitch/recipes-extended/open-
>>> vm-tools/open-vm-tools_10.0.5.bb
>>> <http://open-vm-tools_10.0.5.bb>
>>>
>>> Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
>>>
>>> Although the original recipe packaging was Apache-licensed, I
>>> received
>>> permission from the author (Diego Dompe) to relicense it under
>>> the MIT
>>> license for inclusion in meta-openembedded:
>>>
>>> https://lists.openswitch.net/pipermail/ops-dev/2017-April/01
>>> 4715.html
>>> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/0
>>> 14715.html>
>>> https://lists.openswitch.net/pipermail/ops-dev/2017-April/01
>>> 4716.html
>>>
>>> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/0
>>> 14716.html>
>>>
>>> --
>>> The following changes since commit
>>> 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
>>>
>>> Revert "rrdtool: add gettext-native dependency" (2017-06-05
>>> 11:13:09
>>> +0200)
>>>
>>> are available in the git repository at:
>>>
>>> https://github.com/XevoInc/meta-openembedded
>>> <https://github.com/XevoInc/meta-openembedded>
>>>
>>> for you to fetch changes up to
>>> 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
>>>
>>> open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
>>>
>>> ----------------------------------------------------------------
>>> Martin Kelly (14):
>>> add open-vm-tools recipe
>>> open-vm-tools: add missing pkgconfig dependency
>>> open-vm-tools: add missing glib-2.0-native dependency
>>> open-vm-tools: clarify and expand licensing
>>> open-vm-tools: base_contains --> bb.utils.contains
>>> open-vm-tools: update version to 10.1.5
>>> open-vm-tools: don't use mspack
>>> open-vm-tools: don't use dnet-config
>>> open-vm-tools: add #include to fix build break
>>> open-vm-tools: add missing X11 dependencies
>>> open-vm-tools: remove kernel module logic
>>> open-vm-tools: line up configure options
>>> open-vm-tools: support FUSE
>>> open-vm-tools: style changes
>>>
>>> .../recipes-support/open-vm-tools/files/tools.conf | 2 +
>>> .../open-vm-tools/files/vmtoolsd.service | 11 +++
>>> .../open-vm-tools/0001-Fix-kernel-detection.patch | 35
>>> +++++++++
>>> .../0002-configure.ac-don-t-use-dnet-config.patch | 41
>>> ++++++++++
>>> .../0003-add-include-sys-sysmacros.h.patch | 33
>>> ++++++++
>>> .../open-vm-tools/open-vm-tools_10.1.5.bb
>>> <http://open-vm-tools_10.1.5.bb> | 90
>>> ++++++++++++++++++++++
>>> 6 files changed, 212 insertions(+)
>>> create mode 100644
>>> meta-oe/recipes-support/open-vm-tools/files/tools.conf
>>> create mode 100644
>>> meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service
>>> create mode 100644
>>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix
>>> -kernel-detection.patch
>>>
>>> create mode 100644
>>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-con
>>> figure.ac-don-t-use-dnet-config.patch
>>>
>>> create mode 100644
>>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add
>>> -include-sys-sysmacros.h.patch
>>>
>>> create mode 100644
>>> meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb
>>> <http://open-vm-tools_10.1.5.bb>
>>> --
>>> 2.1.4
>>>
>>>
>>> (ping)
>>>
>>>
>>>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-18 19:58 ` Martin Jansa
@ 2017-06-18 20:28 ` Martin Jansa
2017-06-19 23:43 ` Martin Kelly
2017-06-19 18:35 ` Martin Kelly
1 sibling, 1 reply; 20+ messages in thread
From: Martin Jansa @ 2017-06-18 20:28 UTC (permalink / raw)
To: Martin Kelly; +Cc: Koen Kooi, openembeded-devel
And there is also this:
=== Incorrect PACKAGE_ARCH or sstate signatures (3) ===
Complete log:
http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/log.signatures.20170618_014055.log/
* ERROR: 3 issues were found in these recipes: open-vm-tools
* ERROR: 1 errors found in signatures.qemux86.do_configure.sigdata.log
* ERROR: 1 errors found in
signatures.qemux86.do_populate_sysroot.sigdata.log
* ERROR: 1 errors found in
signatures.qemux86.do_package_write_ipk.sigdata.log
* ERROR: open-vm-tools different signature for task
do_configure.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in
/home/jenkins/oe/world/shr-core/tmp-glibc/sstate-diff/1497786055/signatures.qemux86.do_configure.sigdata.log
* ERROR: open-vm-tools different signature for task
do_populate_sysroot.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in
/home/jenkins/oe/world/shr-core/tmp-glibc/sstate-diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log
* ERROR: open-vm-tools different signature for task
do_package_write_ipk.sigdata between qemux86copy and qemux86
* ERROR: 1 errors found in
/home/jenkins/oe/world/shr-core/tmp-glibc/sstate-diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log
* ERROR: 3 issues were found in these recipes: open-vm-tools
So it probably depends on some MACHINE specific variable without being
marked as MACHINE_ARCH.
Looking at:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb
It's depending on kernel, so it needs to be MACHINE_ARCH, also I've noticed
few more issues:
DEPENDS is there twice:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb#L24
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb#L39
What is supposed to set KERNEL_VERSION variable in:
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb#L58
?
Don't use tags in SRCREV, use git hash instead (otherwise bitbake fetcher
will reach upstream git repo every single time the recipe is parsed and
will cause failed builds when github isn't accessible).
https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb#L35
There are many hardcoded paths like /usr/lib/ or /usr/sbin/, please use
proper variables like libdir, sbindir.
Once you fix these issues please resend all changes to the ML, it's much
better to review inline than this.
Regards,
On Sun, Jun 18, 2017 at 9:58 PM, Martin Jansa <martin.jansa@gmail.com>
wrote:
> Fails to configure on qemuarm.
>
> If arm isn't expected to be supported, can you please update
> COMPATIBLE_HOST restriction?
>
> http://errors.yoctoproject.org/Errors/Details/145599/
>
> On Thu, Jun 15, 2017 at 7:50 PM, Martin Jansa <martin.jansa@gmail.com>
> wrote:
>
>> OK, I'll try to remember to fix it before merge.
>>
>> I'm sorry about it, tweaking other people commits always strikes back :).
>>
>> On Thu, Jun 15, 2017 at 7:40 PM, Martin Kelly <mkelly@xevo.com> wrote:
>>
>>> On 06/15/2017 09:54 AM, Martin Jansa wrote:
>>>
>>>> It didn't make it to patchwork, because you've sent only the cover
>>>> letter. I've added it to master-next now.
>>>>
>>>> Next time please send also individual patches. So that it gets more
>>>> visibility for other people to comment and also that I can use patchwork
>>>> to pull it in.
>>>>
>>>> Regards,
>>>>
>>>>
>>> Small note: Looks like the initial commit (24b2ac) has a small typo that
>>> should ideally be fixed before it's merged into master:
>>>
>>> "open-vm-tools: add recipe from meat-foss-openswitch"
>>>
>>> "meat" --> "meta"
>>>
>>> On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.com
>>>> <mailto:mkelly@xevo.com>> wrote:
>>>>
>>>> On 06/09/2017 03:22 PM, Martin Kelly wrote:
>>>>
>>>> Hi all,
>>>>
>>>> This patch series adds a new recipe for Open VM Tools to
>>>> meta-oe. This
>>>> recipe is invaluable for using Openembedded with VMWare, as
>>>> without the
>>>> tools, performance is very slow.
>>>>
>>>> More information about Open VM Tools can be found here:
>>>>
>>>> https://github.com/vmware/open-vm-tools
>>>> <https://github.com/vmware/open-vm-tools>
>>>>
>>>> Please note that, as mentioned in the first commit, this recipe
>>>> is
>>>> modified from the recipe originally found in the Open-Switch
>>>> repository.
>>>> The first patch is directly from that repository, and the
>>>> following
>>>> patches are modifications to it.
>>>>
>>>> Original recipe:
>>>> https://github.com/open-switch/ops-build
>>>> <https://github.com/open-switch/ops-build>
>>>> yocto/openswitch/meta-foss-openswitch/recipes-extended/open-
>>>> vm-tools/open-vm-tools_10.0.5.bb
>>>> <http://open-vm-tools_10.0.5.bb>
>>>>
>>>> Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
>>>>
>>>> Although the original recipe packaging was Apache-licensed, I
>>>> received
>>>> permission from the author (Diego Dompe) to relicense it under
>>>> the MIT
>>>> license for inclusion in meta-openembedded:
>>>>
>>>> https://lists.openswitch.net/pipermail/ops-dev/2017-April/01
>>>> 4715.html
>>>> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/0
>>>> 14715.html>
>>>> https://lists.openswitch.net/pipermail/ops-dev/2017-April/01
>>>> 4716.html
>>>>
>>>> <https://lists.openswitch.net/pipermail/ops-dev/2017-April/0
>>>> 14716.html>
>>>>
>>>> --
>>>> The following changes since commit
>>>> 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
>>>>
>>>> Revert "rrdtool: add gettext-native dependency" (2017-06-05
>>>> 11:13:09
>>>> +0200)
>>>>
>>>> are available in the git repository at:
>>>>
>>>> https://github.com/XevoInc/meta-openembedded
>>>> <https://github.com/XevoInc/meta-openembedded>
>>>>
>>>> for you to fetch changes up to
>>>> 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
>>>>
>>>> open-vm-tools: style changes (2017-06-07 22:31:34 +0000)
>>>>
>>>> ------------------------------------------------------------
>>>> ----
>>>> Martin Kelly (14):
>>>> add open-vm-tools recipe
>>>> open-vm-tools: add missing pkgconfig dependency
>>>> open-vm-tools: add missing glib-2.0-native dependency
>>>> open-vm-tools: clarify and expand licensing
>>>> open-vm-tools: base_contains --> bb.utils.contains
>>>> open-vm-tools: update version to 10.1.5
>>>> open-vm-tools: don't use mspack
>>>> open-vm-tools: don't use dnet-config
>>>> open-vm-tools: add #include to fix build break
>>>> open-vm-tools: add missing X11 dependencies
>>>> open-vm-tools: remove kernel module logic
>>>> open-vm-tools: line up configure options
>>>> open-vm-tools: support FUSE
>>>> open-vm-tools: style changes
>>>>
>>>> .../recipes-support/open-vm-tools/files/tools.conf | 2 +
>>>> .../open-vm-tools/files/vmtoolsd.service | 11 +++
>>>> .../open-vm-tools/0001-Fix-kernel-detection.patch | 35
>>>> +++++++++
>>>> .../0002-configure.ac-don-t-use-dnet-config.patch | 41
>>>> ++++++++++
>>>> .../0003-add-include-sys-sysmacros.h.patch | 33
>>>> ++++++++
>>>> .../open-vm-tools/open-vm-tools_10.1.5.bb
>>>> <http://open-vm-tools_10.1.5.bb> | 90
>>>> ++++++++++++++++++++++
>>>> 6 files changed, 212 insertions(+)
>>>> create mode 100644
>>>> meta-oe/recipes-support/open-vm-tools/files/tools.conf
>>>> create mode 100644
>>>> meta-oe/recipes-support/open-vm-tools/files/vmtoolsd.service
>>>> create mode 100644
>>>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-Fix
>>>> -kernel-detection.patch
>>>>
>>>> create mode 100644
>>>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-con
>>>> figure.ac-don-t-use-dnet-config.patch
>>>>
>>>> create mode 100644
>>>> meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-add
>>>> -include-sys-sysmacros.h.patch
>>>>
>>>> create mode 100644
>>>> meta-oe/recipes-support/open-vm-tools/open-vm-tools_10.1.5.bb
>>>> <http://open-vm-tools_10.1.5.bb>
>>>> --
>>>> 2.1.4
>>>>
>>>>
>>>> (ping)
>>>>
>>>>
>>>>
>>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-18 19:58 ` Martin Jansa
2017-06-18 20:28 ` Martin Jansa
@ 2017-06-19 18:35 ` Martin Kelly
1 sibling, 0 replies; 20+ messages in thread
From: Martin Kelly @ 2017-06-19 18:35 UTC (permalink / raw)
To: Martin Jansa; +Cc: Koen Kooi, openembeded-devel
-----Original Message-----
From: Martin Jansa <martin.jansa@gmail.com>
To: Martin Kelly <mkelly@xevo.com>
Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>, Koen
Kooi <koen@dominion.thruhere.net>
Subject: Re: [oe] [meta-oe][PATCH 00/14] new recipe: open-vm-tools
recipe
Date: Sun, 18 Jun 2017 21:58:47 +0200
Fails to configure on qemuarm.
If arm isn't expected to be supported, can you please update
COMPATIBLE_HOST restriction?
http://errors.yoctoproject.org/Errors/Details/145599/
Yes, I will fix this and the other issues you found. Thanks for finding
them.
On Thu, Jun 15, 2017 at 7:50 PM, Martin Jansa <martin.jansa@gmail.com>
wrote:
> OK, I'll try to remember to fix it before merge.
>
> I'm sorry about it, tweaking other people commits always strikes back
> :).
>
> On Thu, Jun 15, 2017 at 7:40 PM, Martin Kelly <mkelly@xevo.com>
> wrote:
> > On 06/15/2017 09:54 AM, Martin Jansa wrote:
> > > It didn't make it to patchwork, because you've sent only the
> > > cover
> > > letter. I've added it to master-next now.
> > >
> > > Next time please send also individual patches. So that it gets
> > > more
> > > visibility for other people to comment and also that I can use
> > > patchwork
> > > to pull it in.
> > >
> > > Regards,
> > >
> > >
> >
> > Small note: Looks like the initial commit (24b2ac) has a small typo
> > that should ideally be fixed before it's merged into master:
> >
> > "open-vm-tools: add recipe from meat-foss-openswitch"
> >
> > "meat" --> "meta"
> >
> > > On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.com
> > > <mailto:mkelly@xevo.com>> wrote:
> > >
> > > On 06/09/2017 03:22 PM, Martin Kelly wrote:
> > >
> > > Hi all,
> > >
> > > This patch series adds a new recipe for Open VM Tools to
> > > meta-oe. This
> > > recipe is invaluable for using Openembedded with VMWare,
> > > as
> > > without the
> > > tools, performance is very slow.
> > >
> > > More information about Open VM Tools can be found here:
> > >
> > > https://github.com/vmware/open-vm-tools
> > > <https://github.com/vmware/open-vm-tools>
> > >
> > > Please note that, as mentioned in the first commit, this
> > > recipe is
> > > modified from the recipe originally found in the Open-
> > > Switch
> > > repository.
> > > The first patch is directly from that repository, and the
> > > following
> > > patches are modifications to it.
> > >
> > > Original recipe:
> > > https://github.com/open-switch/ops-build
> > > <https://github.com/open-switch/ops-build>
> > > yocto/openswitch/meta-foss-openswitch/recipes-
> > > extended/open-vm-tools/open-vm-tools_10.0.5.bb
> > > <http://open-vm-tools_10.0.5.bb>
> > >
> > > Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
> > >
> > > Although the original recipe packaging was Apache-
> > > licensed, I
> > > received
> > > permission from the author (Diego Dompe) to relicense it
> > > under
> > > the MIT
> > > license for inclusion in meta-openembedded:
> > >
> > > https://lists.openswitch.net/pipermail/ops-dev/2017-April
> > > /014715.html
> > > <https://lists.openswitch.net/pipermail/ops-dev/2017-Apri
> > > l/014715.html>
> > > https://lists.openswitch.net/pipermail/ops-dev/2017-April
> > > /014716.html
> > >
> > > <https://lists.openswitch.net/pipermail/ops-dev/2017-Apri
> > > l/014716.html>
> > >
> > > --
> > > The following changes since commit
> > > 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
> > >
> > > Revert "rrdtool: add gettext-native dependency" (2017-
> > > 06-05
> > > 11:13:09
> > > +0200)
> > >
> > > are available in the git repository at:
> > >
> > > https://github.com/XevoInc/meta-openembedded
> > > <https://github.com/XevoInc/meta-openembedded>
> > >
> > > for you to fetch changes up to
> > > 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
> > >
> > > open-vm-tools: style changes (2017-06-07 22:31:34
> > > +0000)
> > >
> > > -------------------------------------------------------
> > > ---------
> > > Martin Kelly (14):
> > > add open-vm-tools recipe
> > > open-vm-tools: add missing pkgconfig dependency
> > > open-vm-tools: add missing glib-2.0-native
> > > dependency
> > > open-vm-tools: clarify and expand licensing
> > > open-vm-tools: base_contains --> bb.utils.contains
> > > open-vm-tools: update version to 10.1.5
> > > open-vm-tools: don't use mspack
> > > open-vm-tools: don't use dnet-config
> > > open-vm-tools: add #include to fix build break
> > > open-vm-tools: add missing X11 dependencies
> > > open-vm-tools: remove kernel module logic
> > > open-vm-tools: line up configure options
> > > open-vm-tools: support FUSE
> > > open-vm-tools: style changes
> > >
> > > .../recipes-support/open-vm-tools/files/tools.conf | 2
> > > +
> > > .../open-vm-tools/files/vmtoolsd.service | 11
> > > +++
> > > .../open-vm-tools/0001-Fix-kernel-detection.patch | 35
> > > +++++++++
> > > .../0002-configure.ac-don-t-use-dnet-config.patch | 41
> > > ++++++++++
> > > .../0003-add-include-sys-sysmacros.h.patch | 33
> > > ++++++++
> > > .../open-vm-tools/open-vm-tools_10.1.5.bb
> > > <http://open-vm-tools_10.1.5.bb> | 90
> > > ++++++++++++++++++++++
> > > 6 files changed, 212 insertions(+)
> > > create mode 100644
> > > meta-oe/recipes-support/open-vm-tools/files/tools.conf
> > > create mode 100644
> > > meta-oe/recipes-support/open-vm-
> > > tools/files/vmtoolsd.service
> > > create mode 100644
> > > meta-oe/recipes-support/open-vm-tools/open-vm-tools/0001-
> > > Fix-kernel-detection.patch
> > >
> > > create mode 100644
> > > meta-oe/recipes-support/open-vm-tools/open-vm-tools/0002-
> > > configure.ac-don-t-use-dnet-config.patch
> > >
> > > create mode 100644
> > > meta-oe/recipes-support/open-vm-tools/open-vm-tools/0003-
> > > add-include-sys-sysmacros.h.patch
> > >
> > > create mode 100644
> > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > tools_10.1.5.bb
> > > <http://open-vm-tools_10.1.5.bb>
> > > --
> > > 2.1.4
> > >
> > >
> > > (ping)
> > >
> > >
> > >
> >
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-18 20:28 ` Martin Jansa
@ 2017-06-19 23:43 ` Martin Kelly
2017-06-22 17:15 ` Martin Kelly
0 siblings, 1 reply; 20+ messages in thread
From: Martin Kelly @ 2017-06-19 23:43 UTC (permalink / raw)
To: martin.jansa; +Cc: koen, openembedded-devel
On Sun, 2017-06-18 at 22:28 +0200, Martin Jansa wrote:
> And there is also this:
>
> === Incorrect PACKAGE_ARCH or sstate signatures (3) ===
>
> Complete log: http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/lo
> g.signatures.20170618_014055.log/
> * ERROR: 3 issues were found in these recipes: open-vm-tools
>
> * ERROR: 1 errors found in
> signatures.qemux86.do_configure.sigdata.log
> * ERROR: 1 errors found in
> signatures.qemux86.do_populate_sysroot.sigdata.log
> * ERROR: 1 errors found in
> signatures.qemux86.do_package_write_ipk.sigdata.log
>
> * ERROR: open-vm-tools different signature for task
> do_configure.sigdata between qemux86copy and qemux86
> * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> glibc/sstate-
> diff/1497786055/signatures.qemux86.do_configure.sigdata.log
> * ERROR: open-vm-tools different signature for task
> do_populate_sysroot.sigdata between qemux86copy and qemux86
> * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> glibc/sstate-
> diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log
> * ERROR: open-vm-tools different signature for task
> do_package_write_ipk.sigdata between qemux86copy and qemux86
> * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> glibc/sstate-
> diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log
> * ERROR: 3 issues were found in these recipes: open-vm-tools
>
> So it probably depends on some MACHINE specific variable without
> being marked as MACHINE_ARCH.
>
> Looking at:
> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab
> 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-
> tools_10.1.5.bb
>
> It's depending on kernel, so it needs to be MACHINE_ARCH, also I've
> noticed few more issues:
>
Thanks for all the feedback. I believe I've now fixed all the issues
you outlined.
I dropped the kernel dependency entirely, as we're no longer building
the kernel modules (they all got upstreamed). Thus I suspect the issue
is no longer present with my latest changes.
That said, I can't repro the sstate errors on my local machine. Could
you provide repro steps so I can verify this is fixed before I send new
patches?
> DEPENDS is there twice:
> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab
> 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-
> tools_10.1.5.bb#L24
> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab
> 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-
> tools_10.1.5.bb#L39
>
> What is supposed to set KERNEL_VERSION variable in:
> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab
> 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-
> tools_10.1.5.bb#L58
> ?
>
> Don't use tags in SRCREV, use git hash instead (otherwise bitbake
> fetcher will reach upstream git repo every single time the recipe is
> parsed and will cause failed builds when github isn't accessible).
> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2ab
> 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-vm-
> tools_10.1.5.bb#L35
>
> There are many hardcoded paths like /usr/lib/ or /usr/sbin/, please
> use proper variables like libdir, sbindir.
>
> Once you fix these issues please resend all changes to the ML, it's
> much better to review inline than this.
>
> Regards,
>
>
> On Sun, Jun 18, 2017 at 9:58 PM, Martin Jansa <martin.jansa@gmail.com
> > wrote:
> > Fails to configure on qemuarm.
> >
> > If arm isn't expected to be supported, can you please update
> > COMPATIBLE_HOST restriction?
> >
> > http://errors.yoctoproject.org/Errors/Details/145599/
> >
> > On Thu, Jun 15, 2017 at 7:50 PM, Martin Jansa <martin.jansa@gmail.c
> > om> wrote:
> > > OK, I'll try to remember to fix it before merge.
> > >
> > > I'm sorry about it, tweaking other people commits always strikes
> > > back :).
> > >
> > > On Thu, Jun 15, 2017 at 7:40 PM, Martin Kelly <mkelly@xevo.com>
> > > wrote:
> > > > On 06/15/2017 09:54 AM, Martin Jansa wrote:
> > > > > It didn't make it to patchwork, because you've sent only the
> > > > > cover
> > > > > letter. I've added it to master-next now.
> > > > >
> > > > > Next time please send also individual patches. So that it
> > > > > gets more
> > > > > visibility for other people to comment and also that I can
> > > > > use patchwork
> > > > > to pull it in.
> > > > >
> > > > > Regards,
> > > > >
> > > > >
> > > >
> > > > Small note: Looks like the initial commit (24b2ac) has a small
> > > > typo that should ideally be fixed before it's merged into
> > > > master:
> > > >
> > > > "open-vm-tools: add recipe from meat-foss-openswitch"
> > > >
> > > > "meat" --> "meta"
> > > >
> > > > > On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.co
> > > > > m
> > > > > <mailto:mkelly@xevo.com>> wrote:
> > > > >
> > > > > On 06/09/2017 03:22 PM, Martin Kelly wrote:
> > > > >
> > > > > Hi all,
> > > > >
> > > > > This patch series adds a new recipe for Open VM Tools
> > > > > to
> > > > > meta-oe. This
> > > > > recipe is invaluable for using Openembedded with
> > > > > VMWare, as
> > > > > without the
> > > > > tools, performance is very slow.
> > > > >
> > > > > More information about Open VM Tools can be found
> > > > > here:
> > > > >
> > > > > https://github.com/vmware/open-vm-tools
> > > > > <https://github.com/vmware/open-vm-tools>
> > > > >
> > > > > Please note that, as mentioned in the first commit,
> > > > > this recipe is
> > > > > modified from the recipe originally found in the
> > > > > Open-Switch
> > > > > repository.
> > > > > The first patch is directly from that repository, and
> > > > > the following
> > > > > patches are modifications to it.
> > > > >
> > > > > Original recipe:
> > > > > https://github.com/open-switch/ops-build
> > > > > <https://github.com/open-switch/ops-build>
> > > > > yocto/openswitch/meta-foss-openswitch/recipes-
> > > > > extended/open-vm-tools/open-vm-tools_10.0.5.bb
> > > > > <http://open-vm-tools_10.0.5.bb>
> > > > >
> > > > > Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
> > > > >
> > > > > Although the original recipe packaging was Apache-
> > > > > licensed, I
> > > > > received
> > > > > permission from the author (Diego Dompe) to relicense
> > > > > it under
> > > > > the MIT
> > > > > license for inclusion in meta-openembedded:
> > > > >
> > > > > https://lists.openswitch.net/pipermail/ops-dev/2017-A
> > > > > pril/014715.html
> > > > > <https://lists.openswitch.net/pipermail/ops-dev/2017-
> > > > > April/014715.html>
> > > > > https://lists.openswitch.net/pipermail/ops-dev/2017-A
> > > > > pril/014716.html
> > > > >
> > > > > <https://lists.openswitch.net/pipermail/ops-dev/2017-
> > > > > April/014716.html>
> > > > >
> > > > > --
> > > > > The following changes since commit
> > > > > 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
> > > > >
> > > > > Revert "rrdtool: add gettext-native dependency"
> > > > > (2017-06-05
> > > > > 11:13:09
> > > > > +0200)
> > > > >
> > > > > are available in the git repository at:
> > > > >
> > > > > https://github.com/XevoInc/meta-openembedded
> > > > > <https://github.com/XevoInc/meta-openembedded>
> > > > >
> > > > > for you to fetch changes up to
> > > > > 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
> > > > >
> > > > > open-vm-tools: style changes (2017-06-07 22:31:34
> > > > > +0000)
> > > > >
> > > > > ---------------------------------------------------
> > > > > -------------
> > > > > Martin Kelly (14):
> > > > > add open-vm-tools recipe
> > > > > open-vm-tools: add missing pkgconfig dependency
> > > > > open-vm-tools: add missing glib-2.0-native
> > > > > dependency
> > > > > open-vm-tools: clarify and expand licensing
> > > > > open-vm-tools: base_contains -->
> > > > > bb.utils.contains
> > > > > open-vm-tools: update version to 10.1.5
> > > > > open-vm-tools: don't use mspack
> > > > > open-vm-tools: don't use dnet-config
> > > > > open-vm-tools: add #include to fix build break
> > > > > open-vm-tools: add missing X11 dependencies
> > > > > open-vm-tools: remove kernel module logic
> > > > > open-vm-tools: line up configure options
> > > > > open-vm-tools: support FUSE
> > > > > open-vm-tools: style changes
> > > > >
> > > > > .../recipes-support/open-vm-tools/files/tools.conf
> > > > > | 2 +
> > > > > .../open-vm-tools/files/vmtoolsd.service |
> > > > > 11 +++
> > > > > .../open-vm-tools/0001-Fix-kernel-detection.patch |
> > > > > 35 +++++++++
> > > > > .../0002-configure.ac-don-t-use-dnet-config.patch |
> > > > > 41 ++++++++++
> > > > > .../0003-add-include-sys-sysmacros.h.patch |
> > > > > 33 ++++++++
> > > > > .../open-vm-tools/open-vm-tools_10.1.5.bb
> > > > > <http://open-vm-tools_10.1.5.bb> | 90
> > > > > ++++++++++++++++++++++
> > > > > 6 files changed, 212 insertions(+)
> > > > > create mode 100644
> > > > > meta-oe/recipes-support/open-vm-
> > > > > tools/files/tools.conf
> > > > > create mode 100644
> > > > > meta-oe/recipes-support/open-vm-
> > > > > tools/files/vmtoolsd.service
> > > > > create mode 100644
> > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > tools/0001-Fix-kernel-detection.patch
> > > > >
> > > > > create mode 100644
> > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > tools/0002-configure.ac-don-t-use-dnet-config.patch
> > > > >
> > > > > create mode 100644
> > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > tools/0003-add-include-sys-sysmacros.h.patch
> > > > >
> > > > > create mode 100644
> > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > tools_10.1.5.bb
> > > > > <http://open-vm-tools_10.1.5.bb>
> > > > > --
> > > > > 2.1.4
> > > > >
> > > > >
> > > > > (ping)
> > > > >
> > > > >
> > > > >
> > > >
> > >
> > >
> >
> >
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-19 23:43 ` Martin Kelly
@ 2017-06-22 17:15 ` Martin Kelly
2017-06-22 17:32 ` Martin Jansa
0 siblings, 1 reply; 20+ messages in thread
From: Martin Kelly @ 2017-06-22 17:15 UTC (permalink / raw)
To: martin.jansa; +Cc: koen, openembedded-devel
(ping) I apologize for the top-post but did not want to have the ping
lost in the noise.
On Mon, 2017-06-19 at 16:43 -0700, Martin Kelly wrote:
> On Sun, 2017-06-18 at 22:28 +0200, Martin Jansa wrote:
> > And there is also this:
> >
> > === Incorrect PACKAGE_ARCH or sstate signatures (3) ===
> >
> > Complete log: http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/
> > lo
> > g.signatures.20170618_014055.log/
> > * ERROR: 3 issues were found in these recipes: open-vm-tools
> >
> > * ERROR: 1 errors found in
> > signatures.qemux86.do_configure.sigdata.log
> > * ERROR: 1 errors found in
> > signatures.qemux86.do_populate_sysroot.sigdata.log
> > * ERROR: 1 errors found in
> > signatures.qemux86.do_package_write_ipk.sigdata.log
> >
> > * ERROR: open-vm-tools different signature for task
> > do_configure.sigdata between qemux86copy and qemux86
> > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> > glibc/sstate-
> > diff/1497786055/signatures.qemux86.do_configure.sigdata.log
> > * ERROR: open-vm-tools different signature for task
> > do_populate_sysroot.sigdata between qemux86copy and qemux86
> > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> > glibc/sstate-
> > diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log
> > * ERROR: open-vm-tools different signature for task
> > do_package_write_ipk.sigdata between qemux86copy and qemux86
> > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> > glibc/sstate-
> > diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log
> > * ERROR: 3 issues were found in these recipes: open-vm-tools
> >
> > So it probably depends on some MACHINE specific variable without
> > being marked as MACHINE_ARCH.
> >
> > Looking at:
> > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > ab
> > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > vm-
> > tools_10.1.5.bb
> >
> > It's depending on kernel, so it needs to be MACHINE_ARCH, also I've
> > noticed few more issues:
> >
>
> Thanks for all the feedback. I believe I've now fixed all the issues
> you outlined.
>
> I dropped the kernel dependency entirely, as we're no longer building
> the kernel modules (they all got upstreamed). Thus I suspect the
> issue
> is no longer present with my latest changes.
>
> That said, I can't repro the sstate errors on my local machine. Could
> you provide repro steps so I can verify this is fixed before I send
> new
> patches?
>
> > DEPENDS is there twice:
> > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > ab
> > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > vm-
> > tools_10.1.5.bb#L24
> > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > ab
> > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > vm-
> > tools_10.1.5.bb#L39
> >
> > What is supposed to set KERNEL_VERSION variable in:
> > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > ab
> > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > vm-
> > tools_10.1.5.bb#L58
> > ?
> >
> > Don't use tags in SRCREV, use git hash instead (otherwise bitbake
> > fetcher will reach upstream git repo every single time the recipe
> > is
> > parsed and will cause failed builds when github isn't accessible).
> > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > ab
> > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > vm-
> > tools_10.1.5.bb#L35
> >
> > There are many hardcoded paths like /usr/lib/ or /usr/sbin/, please
> > use proper variables like libdir, sbindir.
> >
> > Once you fix these issues please resend all changes to the ML, it's
> > much better to review inline than this.
> >
> > Regards,
> >
> >
> > On Sun, Jun 18, 2017 at 9:58 PM, Martin Jansa <martin.jansa@gmail.c
> > om
> > > wrote:
> > > Fails to configure on qemuarm.
> > >
> > > If arm isn't expected to be supported, can you please update
> > > COMPATIBLE_HOST restriction?
> > >
> > > http://errors.yoctoproject.org/Errors/Details/145599/
> > >
> > > On Thu, Jun 15, 2017 at 7:50 PM, Martin Jansa <martin.jansa@gmail
> > > .c
> > > om> wrote:
> > > > OK, I'll try to remember to fix it before merge.
> > > >
> > > > I'm sorry about it, tweaking other people commits always
> > > > strikes
> > > > back :).
> > > >
> > > > On Thu, Jun 15, 2017 at 7:40 PM, Martin Kelly <mkelly@xevo.com>
> > > > wrote:
> > > > > On 06/15/2017 09:54 AM, Martin Jansa wrote:
> > > > > > It didn't make it to patchwork, because you've sent only
> > > > > > the
> > > > > > cover
> > > > > > letter. I've added it to master-next now.
> > > > > >
> > > > > > Next time please send also individual patches. So that it
> > > > > > gets more
> > > > > > visibility for other people to comment and also that I can
> > > > > > use patchwork
> > > > > > to pull it in.
> > > > > >
> > > > > > Regards,
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > Small note: Looks like the initial commit (24b2ac) has a
> > > > > small
> > > > > typo that should ideally be fixed before it's merged into
> > > > > master:
> > > > >
> > > > > "open-vm-tools: add recipe from meat-foss-openswitch"
> > > > >
> > > > > "meat" --> "meta"
> > > > >
> > > > > > On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.
> > > > > > co
> > > > > > m
> > > > > > <mailto:mkelly@xevo.com>> wrote:
> > > > > >
> > > > > > On 06/09/2017 03:22 PM, Martin Kelly wrote:
> > > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > This patch series adds a new recipe for Open VM
> > > > > > Tools
> > > > > > to
> > > > > > meta-oe. This
> > > > > > recipe is invaluable for using Openembedded with
> > > > > > VMWare, as
> > > > > > without the
> > > > > > tools, performance is very slow.
> > > > > >
> > > > > > More information about Open VM Tools can be found
> > > > > > here:
> > > > > >
> > > > > > https://github.com/vmware/open-vm-tools
> > > > > > <https://github.com/vmware/open-vm-tools>
> > > > > >
> > > > > > Please note that, as mentioned in the first commit,
> > > > > > this recipe is
> > > > > > modified from the recipe originally found in the
> > > > > > Open-Switch
> > > > > > repository.
> > > > > > The first patch is directly from that repository,
> > > > > > and
> > > > > > the following
> > > > > > patches are modifications to it.
> > > > > >
> > > > > > Original recipe:
> > > > > > https://github.com/open-switch/ops-build
> > > > > > <https://github.com/open-switch/ops-build>
> > > > > > yocto/openswitch/meta-foss-openswitch/recipes-
> > > > > > extended/open-vm-tools/open-vm-tools_10.0.5.bb
> > > > > > <http://open-vm-tools_10.0.5.bb>
> > > > > >
> > > > > > Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
> > > > > >
> > > > > > Although the original recipe packaging was Apache-
> > > > > > licensed, I
> > > > > > received
> > > > > > permission from the author (Diego Dompe) to
> > > > > > relicense
> > > > > > it under
> > > > > > the MIT
> > > > > > license for inclusion in meta-openembedded:
> > > > > >
> > > > > > https://lists.openswitch.net/pipermail/ops-dev/2017
> > > > > > -A
> > > > > > pril/014715.html
> > > > > > <https://lists.openswitch.net/pipermail/ops-dev/201
> > > > > > 7-
> > > > > > April/014715.html>
> > > > > > https://lists.openswitch.net/pipermail/ops-dev/2017
> > > > > > -A
> > > > > > pril/014716.html
> > > > > >
> > > > > > <https://lists.openswitch.net/pipermail/ops-dev/201
> > > > > > 7-
> > > > > > April/014716.html>
> > > > > >
> > > > > > --
> > > > > > The following changes since commit
> > > > > > 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
> > > > > >
> > > > > > Revert "rrdtool: add gettext-native dependency"
> > > > > > (2017-06-05
> > > > > > 11:13:09
> > > > > > +0200)
> > > > > >
> > > > > > are available in the git repository at:
> > > > > >
> > > > > > https://github.com/XevoInc/meta-openembedded
> > > > > > <https://github.com/XevoInc/meta-openembedded>
> > > > > >
> > > > > > for you to fetch changes up to
> > > > > > 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
> > > > > >
> > > > > > open-vm-tools: style changes (2017-06-07 22:31:34
> > > > > > +0000)
> > > > > >
> > > > > > ---------------------------------------------------
> > > > > > -------------
> > > > > > Martin Kelly (14):
> > > > > > add open-vm-tools recipe
> > > > > > open-vm-tools: add missing pkgconfig
> > > > > > dependency
> > > > > > open-vm-tools: add missing glib-2.0-native
> > > > > > dependency
> > > > > > open-vm-tools: clarify and expand licensing
> > > > > > open-vm-tools: base_contains -->
> > > > > > bb.utils.contains
> > > > > > open-vm-tools: update version to 10.1.5
> > > > > > open-vm-tools: don't use mspack
> > > > > > open-vm-tools: don't use dnet-config
> > > > > > open-vm-tools: add #include to fix build
> > > > > > break
> > > > > > open-vm-tools: add missing X11 dependencies
> > > > > > open-vm-tools: remove kernel module logic
> > > > > > open-vm-tools: line up configure options
> > > > > > open-vm-tools: support FUSE
> > > > > > open-vm-tools: style changes
> > > > > >
> > > > > > .../recipes-support/open-vm-tools/files/tools.conf
> > > > > > > 2 +
> > > > > >
> > > > > > .../open-vm-tools/files/vmtoolsd.service
> > > > > > |
> > > > > > 11 +++
> > > > > > .../open-vm-tools/0001-Fix-kernel-detection.patch
> > > > > > |
> > > > > > 35 +++++++++
> > > > > > .../0002-configure.ac-don-t-use-dnet-config.patch
> > > > > > |
> > > > > > 41 ++++++++++
> > > > > > .../0003-add-include-sys-sysmacros.h.patch
> > > > > > |
> > > > > > 33 ++++++++
> > > > > > .../open-vm-tools/open-vm-tools_10.1.5.bb
> > > > > > <http://open-vm-tools_10.1.5.bb> | 90
> > > > > > ++++++++++++++++++++++
> > > > > > 6 files changed, 212 insertions(+)
> > > > > > create mode 100644
> > > > > > meta-oe/recipes-support/open-vm-
> > > > > > tools/files/tools.conf
> > > > > > create mode 100644
> > > > > > meta-oe/recipes-support/open-vm-
> > > > > > tools/files/vmtoolsd.service
> > > > > > create mode 100644
> > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > tools/0001-Fix-kernel-detection.patch
> > > > > >
> > > > > > create mode 100644
> > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > tools/0002-configure.ac-don-t-use-dnet-config.patch
> > > > > >
> > > > > > create mode 100644
> > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > tools/0003-add-include-sys-sysmacros.h.patch
> > > > > >
> > > > > > create mode 100644
> > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > tools_10.1.5.bb
> > > > > > <http://open-vm-tools_10.1.5.bb>
> > > > > > --
> > > > > > 2.1.4
> > > > > >
> > > > > >
> > > > > > (ping)
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> >
> >
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-22 17:15 ` Martin Kelly
@ 2017-06-22 17:32 ` Martin Jansa
2017-06-22 18:21 ` Martin Kelly
0 siblings, 1 reply; 20+ messages in thread
From: Martin Jansa @ 2017-06-22 17:32 UTC (permalink / raw)
To: Martin Kelly; +Cc: koen, openembedded-devel
It basically just calls this script:
openembedded-core/scripts/sstate-diff-machines.sh --machines="qemux86copy
qemux86 qemuarm" --targets=world --tmpdir=tmp-glibc/ --analyze 2>&1 | tee
${LOGDIR}/signatures.log
see:
https://github.com/shr-project/jenkins-jobs/blob/master/jenkins-job.sh#L258
for qemux86copy you either need to add meta-selftest layer from oe-core or
apply:
http://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/master&id=9d45c08641b868322af4bebc2f095340cf4dac3f
Sorry I didn't reply earlier, I think it's resolved by dropped kernel
dependency and I didn't notice the question about reproducing it.
Regards,
On Thu, Jun 22, 2017 at 7:15 PM, Martin Kelly <mkelly@xevo.com> wrote:
> (ping) I apologize for the top-post but did not want to have the ping
> lost in the noise.
>
> On Mon, 2017-06-19 at 16:43 -0700, Martin Kelly wrote:
> > On Sun, 2017-06-18 at 22:28 +0200, Martin Jansa wrote:
> > > And there is also this:
> > >
> > > === Incorrect PACKAGE_ARCH or sstate signatures (3) ===
> > >
> > > Complete log: http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/
> > > lo
> > > g.signatures.20170618_014055.log/
> > > * ERROR: 3 issues were found in these recipes: open-vm-tools
> > >
> > > * ERROR: 1 errors found in
> > > signatures.qemux86.do_configure.sigdata.log
> > > * ERROR: 1 errors found in
> > > signatures.qemux86.do_populate_sysroot.sigdata.log
> > > * ERROR: 1 errors found in
> > > signatures.qemux86.do_package_write_ipk.sigdata.log
> > >
> > > * ERROR: open-vm-tools different signature for task
> > > do_configure.sigdata between qemux86copy and qemux86
> > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> > > glibc/sstate-
> > > diff/1497786055/signatures.qemux86.do_configure.sigdata.log
> > > * ERROR: open-vm-tools different signature for task
> > > do_populate_sysroot.sigdata between qemux86copy and qemux86
> > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> > > glibc/sstate-
> > > diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log
> > > * ERROR: open-vm-tools different signature for task
> > > do_package_write_ipk.sigdata between qemux86copy and qemux86
> > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> > > glibc/sstate-
> > > diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log
> > > * ERROR: 3 issues were found in these recipes: open-vm-tools
> > >
> > > So it probably depends on some MACHINE specific variable without
> > > being marked as MACHINE_ARCH.
> > >
> > > Looking at:
> > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > > ab
> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > vm-
> > > tools_10.1.5.bb
> > >
> > > It's depending on kernel, so it needs to be MACHINE_ARCH, also I've
> > > noticed few more issues:
> > >
> >
> > Thanks for all the feedback. I believe I've now fixed all the issues
> > you outlined.
> >
> > I dropped the kernel dependency entirely, as we're no longer building
> > the kernel modules (they all got upstreamed). Thus I suspect the
> > issue
> > is no longer present with my latest changes.
> >
> > That said, I can't repro the sstate errors on my local machine. Could
> > you provide repro steps so I can verify this is fixed before I send
> > new
> > patches?
> >
> > > DEPENDS is there twice:
> > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > > ab
> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > vm-
> > > tools_10.1.5.bb#L24
> > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > > ab
> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > vm-
> > > tools_10.1.5.bb#L39
> > >
> > > What is supposed to set KERNEL_VERSION variable in:
> > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > > ab
> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > vm-
> > > tools_10.1.5.bb#L58
> > > ?
> > >
> > > Don't use tags in SRCREV, use git hash instead (otherwise bitbake
> > > fetcher will reach upstream git repo every single time the recipe
> > > is
> > > parsed and will cause failed builds when github isn't accessible).
> > > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > > ab
> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > vm-
> > > tools_10.1.5.bb#L35
> > >
> > > There are many hardcoded paths like /usr/lib/ or /usr/sbin/, please
> > > use proper variables like libdir, sbindir.
> > >
> > > Once you fix these issues please resend all changes to the ML, it's
> > > much better to review inline than this.
> > >
> > > Regards,
> > >
> > >
> > > On Sun, Jun 18, 2017 at 9:58 PM, Martin Jansa <martin.jansa@gmail.c
> > > om
> > > > wrote:
> > > > Fails to configure on qemuarm.
> > > >
> > > > If arm isn't expected to be supported, can you please update
> > > > COMPATIBLE_HOST restriction?
> > > >
> > > > http://errors.yoctoproject.org/Errors/Details/145599/
> > > >
> > > > On Thu, Jun 15, 2017 at 7:50 PM, Martin Jansa <martin.jansa@gmail
> > > > .c
> > > > om> wrote:
> > > > > OK, I'll try to remember to fix it before merge.
> > > > >
> > > > > I'm sorry about it, tweaking other people commits always
> > > > > strikes
> > > > > back :).
> > > > >
> > > > > On Thu, Jun 15, 2017 at 7:40 PM, Martin Kelly <mkelly@xevo.com>
> > > > > wrote:
> > > > > > On 06/15/2017 09:54 AM, Martin Jansa wrote:
> > > > > > > It didn't make it to patchwork, because you've sent only
> > > > > > > the
> > > > > > > cover
> > > > > > > letter. I've added it to master-next now.
> > > > > > >
> > > > > > > Next time please send also individual patches. So that it
> > > > > > > gets more
> > > > > > > visibility for other people to comment and also that I can
> > > > > > > use patchwork
> > > > > > > to pull it in.
> > > > > > >
> > > > > > > Regards,
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > > Small note: Looks like the initial commit (24b2ac) has a
> > > > > > small
> > > > > > typo that should ideally be fixed before it's merged into
> > > > > > master:
> > > > > >
> > > > > > "open-vm-tools: add recipe from meat-foss-openswitch"
> > > > > >
> > > > > > "meat" --> "meta"
> > > > > >
> > > > > > > On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.
> > > > > > > co
> > > > > > > m
> > > > > > > <mailto:mkelly@xevo.com>> wrote:
> > > > > > >
> > > > > > > On 06/09/2017 03:22 PM, Martin Kelly wrote:
> > > > > > >
> > > > > > > Hi all,
> > > > > > >
> > > > > > > This patch series adds a new recipe for Open VM
> > > > > > > Tools
> > > > > > > to
> > > > > > > meta-oe. This
> > > > > > > recipe is invaluable for using Openembedded with
> > > > > > > VMWare, as
> > > > > > > without the
> > > > > > > tools, performance is very slow.
> > > > > > >
> > > > > > > More information about Open VM Tools can be found
> > > > > > > here:
> > > > > > >
> > > > > > > https://github.com/vmware/open-vm-tools
> > > > > > > <https://github.com/vmware/open-vm-tools>
> > > > > > >
> > > > > > > Please note that, as mentioned in the first commit,
> > > > > > > this recipe is
> > > > > > > modified from the recipe originally found in the
> > > > > > > Open-Switch
> > > > > > > repository.
> > > > > > > The first patch is directly from that repository,
> > > > > > > and
> > > > > > > the following
> > > > > > > patches are modifications to it.
> > > > > > >
> > > > > > > Original recipe:
> > > > > > > https://github.com/open-switch/ops-build
> > > > > > > <https://github.com/open-switch/ops-build>
> > > > > > > yocto/openswitch/meta-foss-openswitch/recipes-
> > > > > > > extended/open-vm-tools/open-vm-tools_10.0.5.bb
> > > > > > > <http://open-vm-tools_10.0.5.bb>
> > > > > > >
> > > > > > > Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
> > > > > > >
> > > > > > > Although the original recipe packaging was Apache-
> > > > > > > licensed, I
> > > > > > > received
> > > > > > > permission from the author (Diego Dompe) to
> > > > > > > relicense
> > > > > > > it under
> > > > > > > the MIT
> > > > > > > license for inclusion in meta-openembedded:
> > > > > > >
> > > > > > > https://lists.openswitch.net/pipermail/ops-dev/2017
> > > > > > > -A
> > > > > > > pril/014715.html
> > > > > > > <https://lists.openswitch.net/pipermail/ops-dev/201
> > > > > > > 7-
> > > > > > > April/014715.html>
> > > > > > > https://lists.openswitch.net/pipermail/ops-dev/2017
> > > > > > > -A
> > > > > > > pril/014716.html
> > > > > > >
> > > > > > > <https://lists.openswitch.net/pipermail/ops-dev/201
> > > > > > > 7-
> > > > > > > April/014716.html>
> > > > > > >
> > > > > > > --
> > > > > > > The following changes since commit
> > > > > > > 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
> > > > > > >
> > > > > > > Revert "rrdtool: add gettext-native dependency"
> > > > > > > (2017-06-05
> > > > > > > 11:13:09
> > > > > > > +0200)
> > > > > > >
> > > > > > > are available in the git repository at:
> > > > > > >
> > > > > > > https://github.com/XevoInc/meta-openembedded
> > > > > > > <https://github.com/XevoInc/meta-openembedded>
> > > > > > >
> > > > > > > for you to fetch changes up to
> > > > > > > 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
> > > > > > >
> > > > > > > open-vm-tools: style changes (2017-06-07 22:31:34
> > > > > > > +0000)
> > > > > > >
> > > > > > > ---------------------------------------------------
> > > > > > > -------------
> > > > > > > Martin Kelly (14):
> > > > > > > add open-vm-tools recipe
> > > > > > > open-vm-tools: add missing pkgconfig
> > > > > > > dependency
> > > > > > > open-vm-tools: add missing glib-2.0-native
> > > > > > > dependency
> > > > > > > open-vm-tools: clarify and expand licensing
> > > > > > > open-vm-tools: base_contains -->
> > > > > > > bb.utils.contains
> > > > > > > open-vm-tools: update version to 10.1.5
> > > > > > > open-vm-tools: don't use mspack
> > > > > > > open-vm-tools: don't use dnet-config
> > > > > > > open-vm-tools: add #include to fix build
> > > > > > > break
> > > > > > > open-vm-tools: add missing X11 dependencies
> > > > > > > open-vm-tools: remove kernel module logic
> > > > > > > open-vm-tools: line up configure options
> > > > > > > open-vm-tools: support FUSE
> > > > > > > open-vm-tools: style changes
> > > > > > >
> > > > > > > .../recipes-support/open-vm-tools/files/tools.conf
> > > > > > > > 2 +
> > > > > > >
> > > > > > > .../open-vm-tools/files/vmtoolsd.service
> > > > > > > |
> > > > > > > 11 +++
> > > > > > > .../open-vm-tools/0001-Fix-kernel-detection.patch
> > > > > > > |
> > > > > > > 35 +++++++++
> > > > > > > .../0002-configure.ac-don-t-use-dnet-config.patch
> > > > > > > |
> > > > > > > 41 ++++++++++
> > > > > > > .../0003-add-include-sys-sysmacros.h.patch
> > > > > > > |
> > > > > > > 33 ++++++++
> > > > > > > .../open-vm-tools/open-vm-tools_10.1.5.bb
> > > > > > > <http://open-vm-tools_10.1.5.bb> | 90
> > > > > > > ++++++++++++++++++++++
> > > > > > > 6 files changed, 212 insertions(+)
> > > > > > > create mode 100644
> > > > > > > meta-oe/recipes-support/open-vm-
> > > > > > > tools/files/tools.conf
> > > > > > > create mode 100644
> > > > > > > meta-oe/recipes-support/open-vm-
> > > > > > > tools/files/vmtoolsd.service
> > > > > > > create mode 100644
> > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > > tools/0001-Fix-kernel-detection.patch
> > > > > > >
> > > > > > > create mode 100644
> > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > > tools/0002-configure.ac-don-t-use-dnet-config.patch
> > > > > > >
> > > > > > > create mode 100644
> > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > > tools/0003-add-include-sys-sysmacros.h.patch
> > > > > > >
> > > > > > > create mode 100644
> > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > > tools_10.1.5.bb
> > > > > > > <http://open-vm-tools_10.1.5.bb>
> > > > > > > --
> > > > > > > 2.1.4
> > > > > > >
> > > > > > >
> > > > > > > (ping)
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> > >
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-22 17:32 ` Martin Jansa
@ 2017-06-22 18:21 ` Martin Kelly
2017-06-23 10:33 ` Martin Jansa
0 siblings, 1 reply; 20+ messages in thread
From: Martin Kelly @ 2017-06-22 18:21 UTC (permalink / raw)
To: Martin Jansa; +Cc: koen, openembedded-devel
On 06/22/2017 10:32 AM, Martin Jansa wrote:
> It basically just calls this script:
>
> openembedded-core/scripts/sstate-diff-machines.sh
> --machines="qemux86copy qemux86 qemuarm" --targets=world
> --tmpdir=tmp-glibc/ --analyze 2>&1 | tee ${LOGDIR}/signatures.log
>
> see:
> https://github.com/shr-project/jenkins-jobs/blob/master/jenkins-job.sh#L258
>
> for qemux86copy you either need to add meta-selftest layer from oe-core
> or apply:
> http://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/master&id=9d45c08641b868322af4bebc2f095340cf4dac3f
>
> Sorry I didn't reply earlier, I think it's resolved by dropped kernel
> dependency and I didn't notice the question about reproducing it.
>
I'm trying to run the script, but I'm just getting output suggesting
everything is OK, even with the old change that I know has issues. I'm
guessing I need to manually run through some steps that simulate what
Jenkins would have done before running this script ("bitbake world" on
several arches with a particular directory structure?).
It seems to me we have a few options:
- Try to troubleshoot how to manually run the tests
- Submit the fixed-up version and hope it works. I agree that dropping
the kernel dependency will probably fix the issue.
- If you know how to trigger the Jenkins build manually, you could test
it on my new branch before I submit:
https://github.com/xevoinc/meta-openembedded/tree/open-vm-tools-v2
I'm happy with any of these; let me know what you think.
>
> On Thu, Jun 22, 2017 at 7:15 PM, Martin Kelly <mkelly@xevo.com
> <mailto:mkelly@xevo.com>> wrote:
>
> (ping) I apologize for the top-post but did not want to have the ping
> lost in the noise.
>
> On Mon, 2017-06-19 at 16:43 -0700, Martin Kelly wrote:
> > On Sun, 2017-06-18 at 22:28 +0200, Martin Jansa wrote:
> > > And there is also this:
> > >
> > > === Incorrect PACKAGE_ARCH or sstate signatures (3) ===
> > >
> > > Complete log:
> http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/
> <http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/>
> > > lo
> > > g.signatures.20170618_014055.log/
> > > * ERROR: 3 issues were found in these recipes: open-vm-tools
> > >
> > > * ERROR: 1 errors found in
> > > signatures.qemux86.do_configure.sigdata.log
> > > * ERROR: 1 errors found in
> > > signatures.qemux86.do_populate_sysroot.sigdata.log
> > > * ERROR: 1 errors found in
> > > signatures.qemux86.do_package_write_ipk.sigdata.log
> > >
> > > * ERROR: open-vm-tools different signature for task
> > > do_configure.sigdata between qemux86copy and qemux86
> > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> > > glibc/sstate-
> > > diff/1497786055/signatures.qemux86.do_configure.sigdata.log
> > > * ERROR: open-vm-tools different signature for task
> > > do_populate_sysroot.sigdata between qemux86copy and qemux86
> > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> > > glibc/sstate-
> > > diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log
> > > * ERROR: open-vm-tools different signature for task
> > > do_package_write_ipk.sigdata between qemux86copy and qemux86
> > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> > > glibc/sstate-
> > > diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log
> > > * ERROR: 3 issues were found in these recipes: open-vm-tools
> > >
> > > So it probably depends on some MACHINE specific variable without
> > > being marked as MACHINE_ARCH.
> > >
> > > Looking at:
> > >
> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
> > > ab
> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > vm-
> > > tools_10.1.5.bb <http://tools_10.1.5.bb>
> > >
> > > It's depending on kernel, so it needs to be MACHINE_ARCH, also I've
> > > noticed few more issues:
> > >
> >
> > Thanks for all the feedback. I believe I've now fixed all the issues
> > you outlined.
> >
> > I dropped the kernel dependency entirely, as we're no longer building
> > the kernel modules (they all got upstreamed). Thus I suspect the
> > issue
> > is no longer present with my latest changes.
> >
> > That said, I can't repro the sstate errors on my local machine. Could
> > you provide repro steps so I can verify this is fixed before I send
> > new
> > patches?
> >
> > > DEPENDS is there twice:
> > >
> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
> > > ab
> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > vm-
> > > tools_10.1.5.bb#L24 <http://tools_10.1.5.bb#L24>
> > >
> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
> > > ab
> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > vm-
> > > tools_10.1.5.bb#L39 <http://tools_10.1.5.bb#L39>
> > >
> > > What is supposed to set KERNEL_VERSION variable in:
> > >
> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
> > > ab
> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > vm-
> > > tools_10.1.5.bb#L58 <http://tools_10.1.5.bb#L58>
> > > ?
> > >
> > > Don't use tags in SRCREV, use git hash instead (otherwise bitbake
> > > fetcher will reach upstream git repo every single time the recipe
> > > is
> > > parsed and will cause failed builds when github isn't accessible).
> > >
> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
> > > ab
> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > vm-
> > > tools_10.1.5.bb#L35 <http://tools_10.1.5.bb#L35>
> > >
> > > There are many hardcoded paths like /usr/lib/ or /usr/sbin/, please
> > > use proper variables like libdir, sbindir.
> > >
> > > Once you fix these issues please resend all changes to the ML, it's
> > > much better to review inline than this.
> > >
> > > Regards,
> > >
> > >
> > > On Sun, Jun 18, 2017 at 9:58 PM, Martin Jansa <martin.jansa@gmail.c
> > > om
> > > > wrote:
> > > > Fails to configure on qemuarm.
> > > >
> > > > If arm isn't expected to be supported, can you please update
> > > > COMPATIBLE_HOST restriction?
> > > >
> > > > http://errors.yoctoproject.org/Errors/Details/145599/
> <http://errors.yoctoproject.org/Errors/Details/145599/>
> > > >
> > > > On Thu, Jun 15, 2017 at 7:50 PM, Martin Jansa <martin.jansa@gmail
> > > > .c
> > > > om> wrote:
> > > > > OK, I'll try to remember to fix it before merge.
> > > > >
> > > > > I'm sorry about it, tweaking other people commits always
> > > > > strikes
> > > > > back :).
> > > > >
> > > > > On Thu, Jun 15, 2017 at 7:40 PM, Martin Kelly
> <mkelly@xevo.com <mailto:mkelly@xevo.com>>
> > > > > wrote:
> > > > > > On 06/15/2017 09:54 AM, Martin Jansa wrote:
> > > > > > > It didn't make it to patchwork, because you've sent only
> > > > > > > the
> > > > > > > cover
> > > > > > > letter. I've added it to master-next now.
> > > > > > >
> > > > > > > Next time please send also individual patches. So that it
> > > > > > > gets more
> > > > > > > visibility for other people to comment and also that I can
> > > > > > > use patchwork
> > > > > > > to pull it in.
> > > > > > >
> > > > > > > Regards,
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > > Small note: Looks like the initial commit (24b2ac) has a
> > > > > > small
> > > > > > typo that should ideally be fixed before it's merged into
> > > > > > master:
> > > > > >
> > > > > > "open-vm-tools: add recipe from meat-foss-openswitch"
> > > > > >
> > > > > > "meat" --> "meta"
> > > > > >
> > > > > > > On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.
> > > > > > > co
> > > > > > > m
> > > > > > > <mailto:mkelly@xevo.com <mailto:mkelly@xevo.com>>> wrote:
> > > > > > >
> > > > > > > On 06/09/2017 03:22 PM, Martin Kelly wrote:
> > > > > > >
> > > > > > > Hi all,
> > > > > > >
> > > > > > > This patch series adds a new recipe for Open VM
> > > > > > > Tools
> > > > > > > to
> > > > > > > meta-oe. This
> > > > > > > recipe is invaluable for using Openembedded with
> > > > > > > VMWare, as
> > > > > > > without the
> > > > > > > tools, performance is very slow.
> > > > > > >
> > > > > > > More information about Open VM Tools can be found
> > > > > > > here:
> > > > > > >
> > > > > > > https://github.com/vmware/open-vm-tools
> <https://github.com/vmware/open-vm-tools>
> > > > > > > <https://github.com/vmware/open-vm-tools
> <https://github.com/vmware/open-vm-tools>>
> > > > > > >
> > > > > > > Please note that, as mentioned in the first commit,
> > > > > > > this recipe is
> > > > > > > modified from the recipe originally found in the
> > > > > > > Open-Switch
> > > > > > > repository.
> > > > > > > The first patch is directly from that repository,
> > > > > > > and
> > > > > > > the following
> > > > > > > patches are modifications to it.
> > > > > > >
> > > > > > > Original recipe:
> > > > > > > https://github.com/open-switch/ops-build
> <https://github.com/open-switch/ops-build>
> > > > > > > <https://github.com/open-switch/ops-build
> <https://github.com/open-switch/ops-build>>
> > > > > > > yocto/openswitch/meta-foss-openswitch/recipes-
> > > > > > > extended/open-vm-tools/open-vm-tools_10.0.5.bb
> <http://open-vm-tools_10.0.5.bb>
> > > > > > > <http://open-vm-tools_10.0.5.bb
> <http://open-vm-tools_10.0.5.bb>>
> > > > > > >
> > > > > > > Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
> > > > > > >
> > > > > > > Although the original recipe packaging was Apache-
> > > > > > > licensed, I
> > > > > > > received
> > > > > > > permission from the author (Diego Dompe) to
> > > > > > > relicense
> > > > > > > it under
> > > > > > > the MIT
> > > > > > > license for inclusion in meta-openembedded:
> > > > > > >
> > > > > > >
> https://lists.openswitch.net/pipermail/ops-dev/2017
> <https://lists.openswitch.net/pipermail/ops-dev/2017>
> > > > > > > -A
> > > > > > > pril/014715.html
> > > > > > >
> <https://lists.openswitch.net/pipermail/ops-dev/201
> <https://lists.openswitch.net/pipermail/ops-dev/201>
> > > > > > > 7-
> > > > > > > April/014715.html>
> > > > > > >
> https://lists.openswitch.net/pipermail/ops-dev/2017
> <https://lists.openswitch.net/pipermail/ops-dev/2017>
> > > > > > > -A
> > > > > > > pril/014716.html
> > > > > > >
> > > > > > >
> <https://lists.openswitch.net/pipermail/ops-dev/201
> <https://lists.openswitch.net/pipermail/ops-dev/201>
> > > > > > > 7-
> > > > > > > April/014716.html>
> > > > > > >
> > > > > > > --
> > > > > > > The following changes since commit
> > > > > > > 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
> > > > > > >
> > > > > > > Revert "rrdtool: add gettext-native dependency"
> > > > > > > (2017-06-05
> > > > > > > 11:13:09
> > > > > > > +0200)
> > > > > > >
> > > > > > > are available in the git repository at:
> > > > > > >
> > > > > > > https://github.com/XevoInc/meta-openembedded
> <https://github.com/XevoInc/meta-openembedded>
> > > > > > > <https://github.com/XevoInc/meta-openembedded
> <https://github.com/XevoInc/meta-openembedded>>
> > > > > > >
> > > > > > > for you to fetch changes up to
> > > > > > > 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
> > > > > > >
> > > > > > > open-vm-tools: style changes (2017-06-07 22:31:34
> > > > > > > +0000)
> > > > > > >
> > > > > > > ---------------------------------------------------
> > > > > > > -------------
> > > > > > > Martin Kelly (14):
> > > > > > > add open-vm-tools recipe
> > > > > > > open-vm-tools: add missing pkgconfig
> > > > > > > dependency
> > > > > > > open-vm-tools: add missing glib-2.0-native
> > > > > > > dependency
> > > > > > > open-vm-tools: clarify and expand licensing
> > > > > > > open-vm-tools: base_contains -->
> > > > > > > bb.utils.contains
> > > > > > > open-vm-tools: update version to 10.1.5
> > > > > > > open-vm-tools: don't use mspack
> > > > > > > open-vm-tools: don't use dnet-config
> > > > > > > open-vm-tools: add #include to fix build
> > > > > > > break
> > > > > > > open-vm-tools: add missing X11 dependencies
> > > > > > > open-vm-tools: remove kernel module logic
> > > > > > > open-vm-tools: line up configure options
> > > > > > > open-vm-tools: support FUSE
> > > > > > > open-vm-tools: style changes
> > > > > > >
> > > > > > > .../recipes-support/open-vm-tools/files/tools.conf
> > > > > > > > 2 +
> > > > > > >
> > > > > > > .../open-vm-tools/files/vmtoolsd.service
> > > > > > > |
> > > > > > > 11 +++
> > > > > > > .../open-vm-tools/0001-Fix-kernel-detection.patch
> > > > > > > |
> > > > > > > 35 +++++++++
> > > > > > > .../0002-configure.ac-don-t-use-dnet-config.patch
> > > > > > > |
> > > > > > > 41 ++++++++++
> > > > > > > .../0003-add-include-sys-sysmacros.h.patch
> > > > > > > |
> > > > > > > 33 ++++++++
> > > > > > > .../open-vm-tools/open-vm-tools_10.1.5.bb
> <http://open-vm-tools_10.1.5.bb>
> > > > > > > <http://open-vm-tools_10.1.5.bb
> <http://open-vm-tools_10.1.5.bb>> | 90
> > > > > > > ++++++++++++++++++++++
> > > > > > > 6 files changed, 212 insertions(+)
> > > > > > > create mode 100644
> > > > > > > meta-oe/recipes-support/open-vm-
> > > > > > > tools/files/tools.conf
> > > > > > > create mode 100644
> > > > > > > meta-oe/recipes-support/open-vm-
> > > > > > > tools/files/vmtoolsd.service
> > > > > > > create mode 100644
> > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > > tools/0001-Fix-kernel-detection.patch
> > > > > > >
> > > > > > > create mode 100644
> > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > > tools/0002-configure.ac-don-t-use-dnet-config.patch
> > > > > > >
> > > > > > > create mode 100644
> > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > > tools/0003-add-include-sys-sysmacros.h.patch
> > > > > > >
> > > > > > > create mode 100644
> > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > > tools_10.1.5.bb <http://tools_10.1.5.bb>
> > > > > > > <http://open-vm-tools_10.1.5.bb
> <http://open-vm-tools_10.1.5.bb>>
> > > > > > > --
> > > > > > > 2.1.4
> > > > > > >
> > > > > > >
> > > > > > > (ping)
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> > >
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-15 17:17 ` Martin Jansa
2017-06-15 17:22 ` Martin Kelly
@ 2017-06-23 7:41 ` Paul Eggleton
2017-06-23 17:20 ` Darren Hart
1 sibling, 1 reply; 20+ messages in thread
From: Paul Eggleton @ 2017-06-23 7:41 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-devel
On Thursday, 15 June 2017 7:17:18 PM CEST Martin Jansa wrote:
> No problem, I had issues with that script as well, but it works for me if I
> provide all necessary params manually (when it doesn't try to figure out
> anything).
Which issues have you been experiencing with send-pull-request? Have you
reported these as bugs?
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-22 18:21 ` Martin Kelly
@ 2017-06-23 10:33 ` Martin Jansa
2017-06-23 23:51 ` Martin Kelly
0 siblings, 1 reply; 20+ messages in thread
From: Martin Jansa @ 2017-06-23 10:33 UTC (permalink / raw)
To: Martin Kelly; +Cc: koen, openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 19997 bytes --]
On Thu, Jun 22, 2017 at 11:21:16AM -0700, Martin Kelly wrote:
> On 06/22/2017 10:32 AM, Martin Jansa wrote:
> > It basically just calls this script:
> >
> > openembedded-core/scripts/sstate-diff-machines.sh
> > --machines="qemux86copy qemux86 qemuarm" --targets=world
> > --tmpdir=tmp-glibc/ --analyze 2>&1 | tee ${LOGDIR}/signatures.log
> >
> > see:
> > https://github.com/shr-project/jenkins-jobs/blob/master/jenkins-job.sh#L258
> >
> > for qemux86copy you either need to add meta-selftest layer from oe-core
> > or apply:
> > http://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/master&id=9d45c08641b868322af4bebc2f095340cf4dac3f
> >
> > Sorry I didn't reply earlier, I think it's resolved by dropped kernel
> > dependency and I didn't notice the question about reproducing it.
> >
>
> I'm trying to run the script, but I'm just getting output suggesting
> everything is OK, even with the old change that I know has issues. I'm
> guessing I need to manually run through some steps that simulate what
> Jenkins would have done before running this script ("bitbake world" on
> several arches with a particular directory structure?).
It doesn't do anything special before or after the script (you don't
need to build anything in order to compare signatures).
The whole jenkins setup is described here:
http://www.openembedded.org/wiki/Bitbake_World_Status_Setup
You can even call jenkins-job.sh manually if you really want, you just
need to export JOB_NAME="oe_world_workspace-compare-signatures"
> It seems to me we have a few options:
> - Try to troubleshoot how to manually run the tests
> - Submit the fixed-up version and hope it works. I agree that dropping
> the kernel dependency will probably fix the issue.
> - If you know how to trigger the Jenkins build manually, you could test
> it on my new branch before I submit:
> https://github.com/xevoinc/meta-openembedded/tree/open-vm-tools-v2
>
> I'm happy with any of these; let me know what you think.
Just submit the fixed-up version and I'll include it in next master-next
run on jenkins.
For the create-pull-request issue we discussed earlier I'm using
following parameters:
scripts/create-pull-request -u contrib -b ${B} -i ${B} -p "PATCH][${R}][RESEND" -r origin/${R} -s "Backports for ${R}" -o pull-${R}
Where R is release, e.g. morty and
B is e.g. B=jansa/${R}-backports
While branches are on openembedded-core-contrib repository:
http://git.openembedded.org/openembedded-core-contrib
and "contrib" is the git remote for it:
OE @ ~/openembedded-core $ git remote -v | grep contrib
contrib git+ssh://git@git.openembedded.org/openembedded-core-contrib (fetch)
contrib git+ssh://git@git.openembedded.org/openembedded-core-contrib (push)
and since this change:
commit 98faa3ec872e06774b5870fcfb52f3ff91494779
Author: Robert Yang <liezhi.yang@windriver.com>
Date: Tue Apr 5 19:31:27 2016 -0700
create-pull-request: fix for newer git
Fixed when git > 2.1.0:
I also need to specify local branch name with -l or it will wrongly
assume HEAD and fail with:
NOTE: Assuming local branch HEAD, use -l to override.
warn: No match for commit 9d45c08641b868322af4bebc2f095340cf4dac3f found
at git://git.openembedded.org/openembedded-core-contrib
warn: Are you sure you pushed 'jansa/morty-backports' there?
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your diff.renameLimit variable to at least
1151 and retry the command.
ERROR: git request-pull reported an error
So currently my script calls it as:
scripts/create-pull-request -u contrib -l ${B} -b ${B} -i ${B} -p "PATCH][${R}][RESEND" -r origin/${R} -s "Backports for ${R}" -o pull-${R}
>
> >
> > On Thu, Jun 22, 2017 at 7:15 PM, Martin Kelly <mkelly@xevo.com
> > <mailto:mkelly@xevo.com>> wrote:
> >
> > (ping) I apologize for the top-post but did not want to have the ping
> > lost in the noise.
> >
> > On Mon, 2017-06-19 at 16:43 -0700, Martin Kelly wrote:
> > > On Sun, 2017-06-18 at 22:28 +0200, Martin Jansa wrote:
> > > > And there is also this:
> > > >
> > > > === Incorrect PACKAGE_ARCH or sstate signatures (3) ===
> > > >
> > > > Complete log:
> > http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/
> > <http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/>
> > > > lo
> > > > g.signatures.20170618_014055.log/
> > > > * ERROR: 3 issues were found in these recipes: open-vm-tools
> > > >
> > > > * ERROR: 1 errors found in
> > > > signatures.qemux86.do_configure.sigdata.log
> > > > * ERROR: 1 errors found in
> > > > signatures.qemux86.do_populate_sysroot.sigdata.log
> > > > * ERROR: 1 errors found in
> > > > signatures.qemux86.do_package_write_ipk.sigdata.log
> > > >
> > > > * ERROR: open-vm-tools different signature for task
> > > > do_configure.sigdata between qemux86copy and qemux86
> > > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> > > > glibc/sstate-
> > > > diff/1497786055/signatures.qemux86.do_configure.sigdata.log
> > > > * ERROR: open-vm-tools different signature for task
> > > > do_populate_sysroot.sigdata between qemux86copy and qemux86
> > > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> > > > glibc/sstate-
> > > > diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log
> > > > * ERROR: open-vm-tools different signature for task
> > > > do_package_write_ipk.sigdata between qemux86copy and qemux86
> > > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
> > > > glibc/sstate-
> > > > diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log
> > > > * ERROR: 3 issues were found in these recipes: open-vm-tools
> > > >
> > > > So it probably depends on some MACHINE specific variable without
> > > > being marked as MACHINE_ARCH.
> > > >
> > > > Looking at:
> > > >
> > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
> > > > ab
> > > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > > vm-
> > > > tools_10.1.5.bb <http://tools_10.1.5.bb>
> > > >
> > > > It's depending on kernel, so it needs to be MACHINE_ARCH, also I've
> > > > noticed few more issues:
> > > >
> > >
> > > Thanks for all the feedback. I believe I've now fixed all the issues
> > > you outlined.
> > >
> > > I dropped the kernel dependency entirely, as we're no longer building
> > > the kernel modules (they all got upstreamed). Thus I suspect the
> > > issue
> > > is no longer present with my latest changes.
> > >
> > > That said, I can't repro the sstate errors on my local machine. Could
> > > you provide repro steps so I can verify this is fixed before I send
> > > new
> > > patches?
> > >
> > > > DEPENDS is there twice:
> > > >
> > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
> > > > ab
> > > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > > vm-
> > > > tools_10.1.5.bb#L24 <http://tools_10.1.5.bb#L24>
> > > >
> > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
> > > > ab
> > > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > > vm-
> > > > tools_10.1.5.bb#L39 <http://tools_10.1.5.bb#L39>
> > > >
> > > > What is supposed to set KERNEL_VERSION variable in:
> > > >
> > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
> > > > ab
> > > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > > vm-
> > > > tools_10.1.5.bb#L58 <http://tools_10.1.5.bb#L58>
> > > > ?
> > > >
> > > > Don't use tags in SRCREV, use git hash instead (otherwise bitbake
> > > > fetcher will reach upstream git repo every single time the recipe
> > > > is
> > > > parsed and will cause failed builds when github isn't accessible).
> > > >
> > https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
> > <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
> > > > ab
> > > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
> > > > vm-
> > > > tools_10.1.5.bb#L35 <http://tools_10.1.5.bb#L35>
> > > >
> > > > There are many hardcoded paths like /usr/lib/ or /usr/sbin/, please
> > > > use proper variables like libdir, sbindir.
> > > >
> > > > Once you fix these issues please resend all changes to the ML, it's
> > > > much better to review inline than this.
> > > >
> > > > Regards,
> > > >
> > > >
> > > > On Sun, Jun 18, 2017 at 9:58 PM, Martin Jansa <martin.jansa@gmail.c
> > > > om
> > > > > wrote:
> > > > > Fails to configure on qemuarm.
> > > > >
> > > > > If arm isn't expected to be supported, can you please update
> > > > > COMPATIBLE_HOST restriction?
> > > > >
> > > > > http://errors.yoctoproject.org/Errors/Details/145599/
> > <http://errors.yoctoproject.org/Errors/Details/145599/>
> > > > >
> > > > > On Thu, Jun 15, 2017 at 7:50 PM, Martin Jansa <martin.jansa@gmail
> > > > > .c
> > > > > om> wrote:
> > > > > > OK, I'll try to remember to fix it before merge.
> > > > > >
> > > > > > I'm sorry about it, tweaking other people commits always
> > > > > > strikes
> > > > > > back :).
> > > > > >
> > > > > > On Thu, Jun 15, 2017 at 7:40 PM, Martin Kelly
> > <mkelly@xevo.com <mailto:mkelly@xevo.com>>
> > > > > > wrote:
> > > > > > > On 06/15/2017 09:54 AM, Martin Jansa wrote:
> > > > > > > > It didn't make it to patchwork, because you've sent only
> > > > > > > > the
> > > > > > > > cover
> > > > > > > > letter. I've added it to master-next now.
> > > > > > > >
> > > > > > > > Next time please send also individual patches. So that it
> > > > > > > > gets more
> > > > > > > > visibility for other people to comment and also that I can
> > > > > > > > use patchwork
> > > > > > > > to pull it in.
> > > > > > > >
> > > > > > > > Regards,
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > Small note: Looks like the initial commit (24b2ac) has a
> > > > > > > small
> > > > > > > typo that should ideally be fixed before it's merged into
> > > > > > > master:
> > > > > > >
> > > > > > > "open-vm-tools: add recipe from meat-foss-openswitch"
> > > > > > >
> > > > > > > "meat" --> "meta"
> > > > > > >
> > > > > > > > On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.
> > > > > > > > co
> > > > > > > > m
> > > > > > > > <mailto:mkelly@xevo.com <mailto:mkelly@xevo.com>>> wrote:
> > > > > > > >
> > > > > > > > On 06/09/2017 03:22 PM, Martin Kelly wrote:
> > > > > > > >
> > > > > > > > Hi all,
> > > > > > > >
> > > > > > > > This patch series adds a new recipe for Open VM
> > > > > > > > Tools
> > > > > > > > to
> > > > > > > > meta-oe. This
> > > > > > > > recipe is invaluable for using Openembedded with
> > > > > > > > VMWare, as
> > > > > > > > without the
> > > > > > > > tools, performance is very slow.
> > > > > > > >
> > > > > > > > More information about Open VM Tools can be found
> > > > > > > > here:
> > > > > > > >
> > > > > > > > https://github.com/vmware/open-vm-tools
> > <https://github.com/vmware/open-vm-tools>
> > > > > > > > <https://github.com/vmware/open-vm-tools
> > <https://github.com/vmware/open-vm-tools>>
> > > > > > > >
> > > > > > > > Please note that, as mentioned in the first commit,
> > > > > > > > this recipe is
> > > > > > > > modified from the recipe originally found in the
> > > > > > > > Open-Switch
> > > > > > > > repository.
> > > > > > > > The first patch is directly from that repository,
> > > > > > > > and
> > > > > > > > the following
> > > > > > > > patches are modifications to it.
> > > > > > > >
> > > > > > > > Original recipe:
> > > > > > > > https://github.com/open-switch/ops-build
> > <https://github.com/open-switch/ops-build>
> > > > > > > > <https://github.com/open-switch/ops-build
> > <https://github.com/open-switch/ops-build>>
> > > > > > > > yocto/openswitch/meta-foss-openswitch/recipes-
> > > > > > > > extended/open-vm-tools/open-vm-tools_10.0.5.bb
> > <http://open-vm-tools_10.0.5.bb>
> > > > > > > > <http://open-vm-tools_10.0.5.bb
> > <http://open-vm-tools_10.0.5.bb>>
> > > > > > > >
> > > > > > > > Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
> > > > > > > >
> > > > > > > > Although the original recipe packaging was Apache-
> > > > > > > > licensed, I
> > > > > > > > received
> > > > > > > > permission from the author (Diego Dompe) to
> > > > > > > > relicense
> > > > > > > > it under
> > > > > > > > the MIT
> > > > > > > > license for inclusion in meta-openembedded:
> > > > > > > >
> > > > > > > >
> > https://lists.openswitch.net/pipermail/ops-dev/2017
> > <https://lists.openswitch.net/pipermail/ops-dev/2017>
> > > > > > > > -A
> > > > > > > > pril/014715.html
> > > > > > > >
> > <https://lists.openswitch.net/pipermail/ops-dev/201
> > <https://lists.openswitch.net/pipermail/ops-dev/201>
> > > > > > > > 7-
> > > > > > > > April/014715.html>
> > > > > > > >
> > https://lists.openswitch.net/pipermail/ops-dev/2017
> > <https://lists.openswitch.net/pipermail/ops-dev/2017>
> > > > > > > > -A
> > > > > > > > pril/014716.html
> > > > > > > >
> > > > > > > >
> > <https://lists.openswitch.net/pipermail/ops-dev/201
> > <https://lists.openswitch.net/pipermail/ops-dev/201>
> > > > > > > > 7-
> > > > > > > > April/014716.html>
> > > > > > > >
> > > > > > > > --
> > > > > > > > The following changes since commit
> > > > > > > > 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
> > > > > > > >
> > > > > > > > Revert "rrdtool: add gettext-native dependency"
> > > > > > > > (2017-06-05
> > > > > > > > 11:13:09
> > > > > > > > +0200)
> > > > > > > >
> > > > > > > > are available in the git repository at:
> > > > > > > >
> > > > > > > > https://github.com/XevoInc/meta-openembedded
> > <https://github.com/XevoInc/meta-openembedded>
> > > > > > > > <https://github.com/XevoInc/meta-openembedded
> > <https://github.com/XevoInc/meta-openembedded>>
> > > > > > > >
> > > > > > > > for you to fetch changes up to
> > > > > > > > 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
> > > > > > > >
> > > > > > > > open-vm-tools: style changes (2017-06-07 22:31:34
> > > > > > > > +0000)
> > > > > > > >
> > > > > > > > ---------------------------------------------------
> > > > > > > > -------------
> > > > > > > > Martin Kelly (14):
> > > > > > > > add open-vm-tools recipe
> > > > > > > > open-vm-tools: add missing pkgconfig
> > > > > > > > dependency
> > > > > > > > open-vm-tools: add missing glib-2.0-native
> > > > > > > > dependency
> > > > > > > > open-vm-tools: clarify and expand licensing
> > > > > > > > open-vm-tools: base_contains -->
> > > > > > > > bb.utils.contains
> > > > > > > > open-vm-tools: update version to 10.1.5
> > > > > > > > open-vm-tools: don't use mspack
> > > > > > > > open-vm-tools: don't use dnet-config
> > > > > > > > open-vm-tools: add #include to fix build
> > > > > > > > break
> > > > > > > > open-vm-tools: add missing X11 dependencies
> > > > > > > > open-vm-tools: remove kernel module logic
> > > > > > > > open-vm-tools: line up configure options
> > > > > > > > open-vm-tools: support FUSE
> > > > > > > > open-vm-tools: style changes
> > > > > > > >
> > > > > > > > .../recipes-support/open-vm-tools/files/tools.conf
> > > > > > > > > 2 +
> > > > > > > >
> > > > > > > > .../open-vm-tools/files/vmtoolsd.service
> > > > > > > > |
> > > > > > > > 11 +++
> > > > > > > > .../open-vm-tools/0001-Fix-kernel-detection.patch
> > > > > > > > |
> > > > > > > > 35 +++++++++
> > > > > > > > .../0002-configure.ac-don-t-use-dnet-config.patch
> > > > > > > > |
> > > > > > > > 41 ++++++++++
> > > > > > > > .../0003-add-include-sys-sysmacros.h.patch
> > > > > > > > |
> > > > > > > > 33 ++++++++
> > > > > > > > .../open-vm-tools/open-vm-tools_10.1.5.bb
> > <http://open-vm-tools_10.1.5.bb>
> > > > > > > > <http://open-vm-tools_10.1.5.bb
> > <http://open-vm-tools_10.1.5.bb>> | 90
> > > > > > > > ++++++++++++++++++++++
> > > > > > > > 6 files changed, 212 insertions(+)
> > > > > > > > create mode 100644
> > > > > > > > meta-oe/recipes-support/open-vm-
> > > > > > > > tools/files/tools.conf
> > > > > > > > create mode 100644
> > > > > > > > meta-oe/recipes-support/open-vm-
> > > > > > > > tools/files/vmtoolsd.service
> > > > > > > > create mode 100644
> > > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > > > tools/0001-Fix-kernel-detection.patch
> > > > > > > >
> > > > > > > > create mode 100644
> > > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > > > tools/0002-configure.ac-don-t-use-dnet-config.patch
> > > > > > > >
> > > > > > > > create mode 100644
> > > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > > > tools/0003-add-include-sys-sysmacros.h.patch
> > > > > > > >
> > > > > > > > create mode 100644
> > > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
> > > > > > > > tools_10.1.5.bb <http://tools_10.1.5.bb>
> > > > > > > > <http://open-vm-tools_10.1.5.bb
> > <http://open-vm-tools_10.1.5.bb>>
> > > > > > > > --
> > > > > > > > 2.1.4
> > > > > > > >
> > > > > > > >
> > > > > > > > (ping)
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> >
> >
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-23 7:41 ` Paul Eggleton
@ 2017-06-23 17:20 ` Darren Hart
0 siblings, 0 replies; 20+ messages in thread
From: Darren Hart @ 2017-06-23 17:20 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-devel
On Fri, Jun 23, 2017 at 09:41:08AM +0200, Paul Eggleton wrote:
> On Thursday, 15 June 2017 7:17:18 PM CEST Martin Jansa wrote:
> > No problem, I had issues with that script as well, but it works for me if I
> > provide all necessary params manually (when it doesn't try to figure out
> > anything).
>
> Which issues have you been experiencing with send-pull-request? Have you
> reported these as bugs?
I had also reached out, but hadn't subscribed to the list yet. He said he would
respin the patches and provide specifics on the failure he experienced.
If I recall, it can still be picking about certain remotes, but I thought github
was one that it handled well. So I'm looking forward to seeing the report. Happy
to help once we have some details.
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
2017-06-23 10:33 ` Martin Jansa
@ 2017-06-23 23:51 ` Martin Kelly
0 siblings, 0 replies; 20+ messages in thread
From: Martin Kelly @ 2017-06-23 23:51 UTC (permalink / raw)
To: Martin Jansa; +Cc: koen, Darren Hart, openembedded-devel
On 06/23/2017 03:33 AM, Martin Jansa wrote:
> On Thu, Jun 22, 2017 at 11:21:16AM -0700, Martin Kelly wrote:
>> On 06/22/2017 10:32 AM, Martin Jansa wrote:
>>> It basically just calls this script:
>>>
>>> openembedded-core/scripts/sstate-diff-machines.sh
>>> --machines="qemux86copy qemux86 qemuarm" --targets=world
>>> --tmpdir=tmp-glibc/ --analyze 2>&1 | tee ${LOGDIR}/signatures.log
>>>
>>> see:
>>> https://github.com/shr-project/jenkins-jobs/blob/master/jenkins-job.sh#L258
>>>
>>> for qemux86copy you either need to add meta-selftest layer from oe-core
>>> or apply:
>>> http://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/master&id=9d45c08641b868322af4bebc2f095340cf4dac3f
>>>
>>> Sorry I didn't reply earlier, I think it's resolved by dropped kernel
>>> dependency and I didn't notice the question about reproducing it.
>>>
>>
>> I'm trying to run the script, but I'm just getting output suggesting
>> everything is OK, even with the old change that I know has issues. I'm
>> guessing I need to manually run through some steps that simulate what
>> Jenkins would have done before running this script ("bitbake world" on
>> several arches with a particular directory structure?).
>
> It doesn't do anything special before or after the script (you don't
> need to build anything in order to compare signatures).
>
> The whole jenkins setup is described here:
> http://www.openembedded.org/wiki/Bitbake_World_Status_Setup
>
> You can even call jenkins-job.sh manually if you really want, you just
> need to export JOB_NAME="oe_world_workspace-compare-signatures"
>
>
>> It seems to me we have a few options:
>> - Try to troubleshoot how to manually run the tests
>> - Submit the fixed-up version and hope it works. I agree that dropping
>> the kernel dependency will probably fix the issue.
>> - If you know how to trigger the Jenkins build manually, you could test
>> it on my new branch before I submit:
>> https://github.com/xevoinc/meta-openembedded/tree/open-vm-tools-v2
>>
>> I'm happy with any of these; let me know what you think.
>
> Just submit the fixed-up version and I'll include it in next master-next
> run on jenkins.
>
> For the create-pull-request issue we discussed earlier I'm using
> following parameters:
>
> scripts/create-pull-request -u contrib -b ${B} -i ${B} -p "PATCH][${R}][RESEND" -r origin/${R} -s "Backports for ${R}" -o pull-${R}
>
> Where R is release, e.g. morty and
> B is e.g. B=jansa/${R}-backports
>
> While branches are on openembedded-core-contrib repository:
> http://git.openembedded.org/openembedded-core-contrib
> and "contrib" is the git remote for it:
> OE @ ~/openembedded-core $ git remote -v | grep contrib
> contrib git+ssh://git@git.openembedded.org/openembedded-core-contrib (fetch)
> contrib git+ssh://git@git.openembedded.org/openembedded-core-contrib (push)
>
> and since this change:
> commit 98faa3ec872e06774b5870fcfb52f3ff91494779
> Author: Robert Yang <liezhi.yang@windriver.com>
> Date: Tue Apr 5 19:31:27 2016 -0700
>
> create-pull-request: fix for newer git
>
> Fixed when git > 2.1.0:
>
> I also need to specify local branch name with -l or it will wrongly
> assume HEAD and fail with:
> NOTE: Assuming local branch HEAD, use -l to override.
> warn: No match for commit 9d45c08641b868322af4bebc2f095340cf4dac3f found
> at git://git.openembedded.org/openembedded-core-contrib
> warn: Are you sure you pushed 'jansa/morty-backports' there?
> warning: inexact rename detection was skipped due to too many files.
> warning: you may want to set your diff.renameLimit variable to at least
> 1151 and retry the command.
> ERROR: git request-pull reported an error
>
> So currently my script calls it as:
> scripts/create-pull-request -u contrib -l ${B} -b ${B} -i ${B} -p "PATCH][${R}][RESEND" -r origin/${R} -s "Backports for ${R}" -o pull-${R}
>
Thanks, I finally got the invocation to work and sent it off. I think I
recall hitting the note about "Assuming local branch HEAD", so I
probably needed to add -l.
>>
>>>
>>> On Thu, Jun 22, 2017 at 7:15 PM, Martin Kelly <mkelly@xevo.com
>>> <mailto:mkelly@xevo.com>> wrote:
>>>
>>> (ping) I apologize for the top-post but did not want to have the ping
>>> lost in the noise.
>>>
>>> On Mon, 2017-06-19 at 16:43 -0700, Martin Kelly wrote:
>>> > On Sun, 2017-06-18 at 22:28 +0200, Martin Jansa wrote:
>>> > > And there is also this:
>>> > >
>>> > > === Incorrect PACKAGE_ARCH or sstate signatures (3) ===
>>> > >
>>> > > Complete log:
>>> http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/
>>> <http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/>
>>> > > lo
>>> > > g.signatures.20170618_014055.log/
>>> > > * ERROR: 3 issues were found in these recipes: open-vm-tools
>>> > >
>>> > > * ERROR: 1 errors found in
>>> > > signatures.qemux86.do_configure.sigdata.log
>>> > > * ERROR: 1 errors found in
>>> > > signatures.qemux86.do_populate_sysroot.sigdata.log
>>> > > * ERROR: 1 errors found in
>>> > > signatures.qemux86.do_package_write_ipk.sigdata.log
>>> > >
>>> > > * ERROR: open-vm-tools different signature for task
>>> > > do_configure.sigdata between qemux86copy and qemux86
>>> > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
>>> > > glibc/sstate-
>>> > > diff/1497786055/signatures.qemux86.do_configure.sigdata.log
>>> > > * ERROR: open-vm-tools different signature for task
>>> > > do_populate_sysroot.sigdata between qemux86copy and qemux86
>>> > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
>>> > > glibc/sstate-
>>> > > diff/1497786055/signatures.qemux86.do_populate_sysroot.sigdata.log
>>> > > * ERROR: open-vm-tools different signature for task
>>> > > do_package_write_ipk.sigdata between qemux86copy and qemux86
>>> > > * ERROR: 1 errors found in /home/jenkins/oe/world/shr-core/tmp-
>>> > > glibc/sstate-
>>> > > diff/1497786055/signatures.qemux86.do_package_write_ipk.sigdata.log
>>> > > * ERROR: 3 issues were found in these recipes: open-vm-tools
>>> > >
>>> > > So it probably depends on some MACHINE specific variable without
>>> > > being marked as MACHINE_ARCH.
>>> > >
>>> > > Looking at:
>>> > >
>>> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
>>> <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
>>> > > ab
>>> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
>>> > > vm-
>>> > > tools_10.1.5.bb <http://tools_10.1.5.bb>
>>> > >
>>> > > It's depending on kernel, so it needs to be MACHINE_ARCH, also I've
>>> > > noticed few more issues:
>>> > >
>>> >
>>> > Thanks for all the feedback. I believe I've now fixed all the issues
>>> > you outlined.
>>> >
>>> > I dropped the kernel dependency entirely, as we're no longer building
>>> > the kernel modules (they all got upstreamed). Thus I suspect the
>>> > issue
>>> > is no longer present with my latest changes.
>>> >
>>> > That said, I can't repro the sstate errors on my local machine. Could
>>> > you provide repro steps so I can verify this is fixed before I send
>>> > new
>>> > patches?
>>> >
>>> > > DEPENDS is there twice:
>>> > >
>>> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
>>> <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
>>> > > ab
>>> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
>>> > > vm-
>>> > > tools_10.1.5.bb#L24 <http://tools_10.1.5.bb#L24>
>>> > >
>>> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
>>> <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
>>> > > ab
>>> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
>>> > > vm-
>>> > > tools_10.1.5.bb#L39 <http://tools_10.1.5.bb#L39>
>>> > >
>>> > > What is supposed to set KERNEL_VERSION variable in:
>>> > >
>>> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
>>> <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
>>> > > ab
>>> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
>>> > > vm-
>>> > > tools_10.1.5.bb#L58 <http://tools_10.1.5.bb#L58>
>>> > > ?
>>> > >
>>> > > Don't use tags in SRCREV, use git hash instead (otherwise bitbake
>>> > > fetcher will reach upstream git repo every single time the recipe
>>> > > is
>>> > > parsed and will cause failed builds when github isn't accessible).
>>> > >
>>> https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2
>>> <https://github.com/XevoInc/meta-openembedded/blob/402d1b3917195beb2>
>>> > > ab
>>> > > 7cac5dc94aaed8992b5a1/meta-oe/recipes-support/open-vm-tools/open-
>>> > > vm-
>>> > > tools_10.1.5.bb#L35 <http://tools_10.1.5.bb#L35>
>>> > >
>>> > > There are many hardcoded paths like /usr/lib/ or /usr/sbin/, please
>>> > > use proper variables like libdir, sbindir.
>>> > >
>>> > > Once you fix these issues please resend all changes to the ML, it's
>>> > > much better to review inline than this.
>>> > >
>>> > > Regards,
>>> > >
>>> > >
>>> > > On Sun, Jun 18, 2017 at 9:58 PM, Martin Jansa <martin.jansa@gmail.c
>>> > > om
>>> > > > wrote:
>>> > > > Fails to configure on qemuarm.
>>> > > >
>>> > > > If arm isn't expected to be supported, can you please update
>>> > > > COMPATIBLE_HOST restriction?
>>> > > >
>>> > > > http://errors.yoctoproject.org/Errors/Details/145599/
>>> <http://errors.yoctoproject.org/Errors/Details/145599/>
>>> > > >
>>> > > > On Thu, Jun 15, 2017 at 7:50 PM, Martin Jansa <martin.jansa@gmail
>>> > > > .c
>>> > > > om> wrote:
>>> > > > > OK, I'll try to remember to fix it before merge.
>>> > > > >
>>> > > > > I'm sorry about it, tweaking other people commits always
>>> > > > > strikes
>>> > > > > back :).
>>> > > > >
>>> > > > > On Thu, Jun 15, 2017 at 7:40 PM, Martin Kelly
>>> <mkelly@xevo.com <mailto:mkelly@xevo.com>>
>>> > > > > wrote:
>>> > > > > > On 06/15/2017 09:54 AM, Martin Jansa wrote:
>>> > > > > > > It didn't make it to patchwork, because you've sent only
>>> > > > > > > the
>>> > > > > > > cover
>>> > > > > > > letter. I've added it to master-next now.
>>> > > > > > >
>>> > > > > > > Next time please send also individual patches. So that it
>>> > > > > > > gets more
>>> > > > > > > visibility for other people to comment and also that I can
>>> > > > > > > use patchwork
>>> > > > > > > to pull it in.
>>> > > > > > >
>>> > > > > > > Regards,
>>> > > > > > >
>>> > > > > > >
>>> > > > > >
>>> > > > > >
>>> > > > > > Small note: Looks like the initial commit (24b2ac) has a
>>> > > > > > small
>>> > > > > > typo that should ideally be fixed before it's merged into
>>> > > > > > master:
>>> > > > > >
>>> > > > > > "open-vm-tools: add recipe from meat-foss-openswitch"
>>> > > > > >
>>> > > > > > "meat" --> "meta"
>>> > > > > >
>>> > > > > > > On Thu, Jun 15, 2017 at 6:36 PM, Martin Kelly <mkelly@xevo.
>>> > > > > > > co
>>> > > > > > > m
>>> > > > > > > <mailto:mkelly@xevo.com <mailto:mkelly@xevo.com>>> wrote:
>>> > > > > > >
>>> > > > > > > On 06/09/2017 03:22 PM, Martin Kelly wrote:
>>> > > > > > >
>>> > > > > > > Hi all,
>>> > > > > > >
>>> > > > > > > This patch series adds a new recipe for Open VM
>>> > > > > > > Tools
>>> > > > > > > to
>>> > > > > > > meta-oe. This
>>> > > > > > > recipe is invaluable for using Openembedded with
>>> > > > > > > VMWare, as
>>> > > > > > > without the
>>> > > > > > > tools, performance is very slow.
>>> > > > > > >
>>> > > > > > > More information about Open VM Tools can be found
>>> > > > > > > here:
>>> > > > > > >
>>> > > > > > > https://github.com/vmware/open-vm-tools
>>> <https://github.com/vmware/open-vm-tools>
>>> > > > > > > <https://github.com/vmware/open-vm-tools
>>> <https://github.com/vmware/open-vm-tools>>
>>> > > > > > >
>>> > > > > > > Please note that, as mentioned in the first commit,
>>> > > > > > > this recipe is
>>> > > > > > > modified from the recipe originally found in the
>>> > > > > > > Open-Switch
>>> > > > > > > repository.
>>> > > > > > > The first patch is directly from that repository,
>>> > > > > > > and
>>> > > > > > > the following
>>> > > > > > > patches are modifications to it.
>>> > > > > > >
>>> > > > > > > Original recipe:
>>> > > > > > > https://github.com/open-switch/ops-build
>>> <https://github.com/open-switch/ops-build>
>>> > > > > > > <https://github.com/open-switch/ops-build
>>> <https://github.com/open-switch/ops-build>>
>>> > > > > > > yocto/openswitch/meta-foss-openswitch/recipes-
>>> > > > > > > extended/open-vm-tools/open-vm-tools_10.0.5.bb
>>> <http://open-vm-tools_10.0.5.bb>
>>> > > > > > > <http://open-vm-tools_10.0.5.bb
>>> <http://open-vm-tools_10.0.5.bb>>
>>> > > > > > >
>>> > > > > > > Commit 9008de2d8e100f3f868c66765742bca9fa98f3f9
>>> > > > > > >
>>> > > > > > > Although the original recipe packaging was Apache-
>>> > > > > > > licensed, I
>>> > > > > > > received
>>> > > > > > > permission from the author (Diego Dompe) to
>>> > > > > > > relicense
>>> > > > > > > it under
>>> > > > > > > the MIT
>>> > > > > > > license for inclusion in meta-openembedded:
>>> > > > > > >
>>> > > > > > >
>>> https://lists.openswitch.net/pipermail/ops-dev/2017
>>> <https://lists.openswitch.net/pipermail/ops-dev/2017>
>>> > > > > > > -A
>>> > > > > > > pril/014715.html
>>> > > > > > >
>>> <https://lists.openswitch.net/pipermail/ops-dev/201
>>> <https://lists.openswitch.net/pipermail/ops-dev/201>
>>> > > > > > > 7-
>>> > > > > > > April/014715.html>
>>> > > > > > >
>>> https://lists.openswitch.net/pipermail/ops-dev/2017
>>> <https://lists.openswitch.net/pipermail/ops-dev/2017>
>>> > > > > > > -A
>>> > > > > > > pril/014716.html
>>> > > > > > >
>>> > > > > > >
>>> <https://lists.openswitch.net/pipermail/ops-dev/201
>>> <https://lists.openswitch.net/pipermail/ops-dev/201>
>>> > > > > > > 7-
>>> > > > > > > April/014716.html>
>>> > > > > > >
>>> > > > > > > --
>>> > > > > > > The following changes since commit
>>> > > > > > > 41cf832cc9abd6f2293a6d612463a34a53a9a52a:
>>> > > > > > >
>>> > > > > > > Revert "rrdtool: add gettext-native dependency"
>>> > > > > > > (2017-06-05
>>> > > > > > > 11:13:09
>>> > > > > > > +0200)
>>> > > > > > >
>>> > > > > > > are available in the git repository at:
>>> > > > > > >
>>> > > > > > > https://github.com/XevoInc/meta-openembedded
>>> <https://github.com/XevoInc/meta-openembedded>
>>> > > > > > > <https://github.com/XevoInc/meta-openembedded
>>> <https://github.com/XevoInc/meta-openembedded>>
>>> > > > > > >
>>> > > > > > > for you to fetch changes up to
>>> > > > > > > 402d1b3917195beb2ab7cac5dc94aaed8992b5a1:
>>> > > > > > >
>>> > > > > > > open-vm-tools: style changes (2017-06-07 22:31:34
>>> > > > > > > +0000)
>>> > > > > > >
>>> > > > > > > ---------------------------------------------------
>>> > > > > > > -------------
>>> > > > > > > Martin Kelly (14):
>>> > > > > > > add open-vm-tools recipe
>>> > > > > > > open-vm-tools: add missing pkgconfig
>>> > > > > > > dependency
>>> > > > > > > open-vm-tools: add missing glib-2.0-native
>>> > > > > > > dependency
>>> > > > > > > open-vm-tools: clarify and expand licensing
>>> > > > > > > open-vm-tools: base_contains -->
>>> > > > > > > bb.utils.contains
>>> > > > > > > open-vm-tools: update version to 10.1.5
>>> > > > > > > open-vm-tools: don't use mspack
>>> > > > > > > open-vm-tools: don't use dnet-config
>>> > > > > > > open-vm-tools: add #include to fix build
>>> > > > > > > break
>>> > > > > > > open-vm-tools: add missing X11 dependencies
>>> > > > > > > open-vm-tools: remove kernel module logic
>>> > > > > > > open-vm-tools: line up configure options
>>> > > > > > > open-vm-tools: support FUSE
>>> > > > > > > open-vm-tools: style changes
>>> > > > > > >
>>> > > > > > > .../recipes-support/open-vm-tools/files/tools.conf
>>> > > > > > > > 2 +
>>> > > > > > >
>>> > > > > > > .../open-vm-tools/files/vmtoolsd.service
>>> > > > > > > |
>>> > > > > > > 11 +++
>>> > > > > > > .../open-vm-tools/0001-Fix-kernel-detection.patch
>>> > > > > > > |
>>> > > > > > > 35 +++++++++
>>> > > > > > > .../0002-configure.ac-don-t-use-dnet-config.patch
>>> > > > > > > |
>>> > > > > > > 41 ++++++++++
>>> > > > > > > .../0003-add-include-sys-sysmacros.h.patch
>>> > > > > > > |
>>> > > > > > > 33 ++++++++
>>> > > > > > > .../open-vm-tools/open-vm-tools_10.1.5.bb
>>> <http://open-vm-tools_10.1.5.bb>
>>> > > > > > > <http://open-vm-tools_10.1.5.bb
>>> <http://open-vm-tools_10.1.5.bb>> | 90
>>> > > > > > > ++++++++++++++++++++++
>>> > > > > > > 6 files changed, 212 insertions(+)
>>> > > > > > > create mode 100644
>>> > > > > > > meta-oe/recipes-support/open-vm-
>>> > > > > > > tools/files/tools.conf
>>> > > > > > > create mode 100644
>>> > > > > > > meta-oe/recipes-support/open-vm-
>>> > > > > > > tools/files/vmtoolsd.service
>>> > > > > > > create mode 100644
>>> > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
>>> > > > > > > tools/0001-Fix-kernel-detection.patch
>>> > > > > > >
>>> > > > > > > create mode 100644
>>> > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
>>> > > > > > > tools/0002-configure.ac-don-t-use-dnet-config.patch
>>> > > > > > >
>>> > > > > > > create mode 100644
>>> > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
>>> > > > > > > tools/0003-add-include-sys-sysmacros.h.patch
>>> > > > > > >
>>> > > > > > > create mode 100644
>>> > > > > > > meta-oe/recipes-support/open-vm-tools/open-vm-
>>> > > > > > > tools_10.1.5.bb <http://tools_10.1.5.bb>
>>> > > > > > > <http://open-vm-tools_10.1.5.bb
>>> <http://open-vm-tools_10.1.5.bb>>
>>> > > > > > > --
>>> > > > > > > 2.1.4
>>> > > > > > >
>>> > > > > > >
>>> > > > > > > (ping)
>>> > > > > > >
>>> > > > > > >
>>> > > > > > >
>>> > > > > >
>>> > > > > >
>>> > > > >
>>> > > > >
>>> > > >
>>> > > >
>>> > >
>>> > >
>>>
>>>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe
[not found] <B110778A-770D-46DC-9394-09B1919F6C51@vmware.com>
@ 2017-06-19 22:02 ` Martin Kelly
0 siblings, 0 replies; 20+ messages in thread
From: Martin Kelly @ 2017-06-19 22:02 UTC (permalink / raw)
To: dvhart; +Cc: koen, openembedded-devel
On Fri, 2017-06-16 at 21:53 +0000, Darren Hart wrote:
> On 06/09/2017 03:22 PM, Martin Kelly wrote:
> > Hi all,
> >
> > This patch series adds a new recipe for Open VM Tools to meta-oe.
> > This recipe is invaluable for using Openembedded with VMWare, as
> > without the tools, performance is very slow.
> > More information about Open VM Tools can be found here:
> >
> >
> > https://github.com/vmware/open-vm-tools
> >
> >
> >
> > Please note that, as mentioned in the first commit, this recipe is
> > modified from the recipe originally found in the Open-Switch
> > repository. The first patch is directly from that repository, and
> > the following patches are modifications to it.
>
> Hi all,
>
> Please forgive me if this doesn’t land on the mailing list quite
> right. I am no longer subscribed to this list and replying from web
> archives can be hit and miss.
>
> I wanted to reach out and say it’s great to see this recipe being
> submitted to meta-oe, and nice work updating the recipe meta-data.
>
> If there is something we can do to help make this easier to maintain,
> support, etc, please don’t hesitate to reach out to me. I noticed,
> for example, there are a few patches to deal with deprecated library
> calls and the OE build environment.
>
Thanks, will do. There's a few patches that should probably go upstream
if they're not already present in some other form.
> Finally… as the author of send-pull-request, I have to confess a
> twinge of guilt when it failed you Martin. If you want to send me
> details on how you ran it and the details of the failure, I’d be
> happy to look into it.
>
> One possibility is that your local branch didn’t match the remote
> branch. Another possibility is that it isn’t parsing the GitHub
> repository location correctly, and that may need updating.
>
Thanks; as you may have seen, I need to make a few changes due to
issues that Martin Jansa found. I will try send-pull-request again and
send you details about any issues I hit.
> Thanks,
>
> --
> Darren Hart
> Director / Open Source Architect
> VMware Open Source Technology Center
>
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2017-06-23 23:51 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-09 22:22 [meta-oe][PATCH 00/14] new recipe: open-vm-tools recipe Martin Kelly
2017-06-15 16:36 ` Martin Kelly
2017-06-15 16:54 ` Martin Jansa
2017-06-15 17:07 ` Martin Kelly
2017-06-15 17:17 ` Martin Jansa
2017-06-15 17:22 ` Martin Kelly
2017-06-23 7:41 ` Paul Eggleton
2017-06-23 17:20 ` Darren Hart
2017-06-15 17:40 ` Martin Kelly
2017-06-15 17:50 ` Martin Jansa
2017-06-18 19:58 ` Martin Jansa
2017-06-18 20:28 ` Martin Jansa
2017-06-19 23:43 ` Martin Kelly
2017-06-22 17:15 ` Martin Kelly
2017-06-22 17:32 ` Martin Jansa
2017-06-22 18:21 ` Martin Kelly
2017-06-23 10:33 ` Martin Jansa
2017-06-23 23:51 ` Martin Kelly
2017-06-19 18:35 ` Martin Kelly
[not found] <B110778A-770D-46DC-9394-09B1919F6C51@vmware.com>
2017-06-19 22:02 ` Martin Kelly
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.