All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Praveen Kumar <kpraveen.lkml@gmail.com>
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
	George.Dunlap@eu.citrix.com, ian.jackson@eu.citrix.com,
	tim@xen.org, xen-devel@lists.xen.org, andrew.cooper3@citrix.com
Subject: Re: [PATCH v2 09/20] rbtree: adjust root color in rb_insert_color() only when necessary
Date: Tue, 20 Jun 2017 15:54:47 +0200	[thread overview]
Message-ID: <1497966887.7405.23.camel@citrix.com> (raw)
In-Reply-To: <5948EA34020000780016458A@prv-mh.provo.novell.com>


[-- Attachment #1.1: Type: text/plain, Size: 1730 bytes --]

On Tue, 2017-06-20 at 01:26 -0600, Jan Beulich wrote:
> > > > On 19.06.17 at 19:13, <dario.faggioli@citrix.com> wrote:
> > And here we are again. (I.e., in the cited Linux's commit, this is
> > being turned into 'while (true) {`.
> > 
> > So, I think we should gather others' opinion about how to deal with
> > these aspects of this series. So, I'll stop my review for now, and
> > chase feedback.
> 
> I fully second your opinion here. I even wonder whether we
> shouldn't convert the file back to be fully Linux style first thing,
> so that Linux changes can be applied (mostly) as is, specifically
> without having to convert tabs to spaces.
> 
That indeed would be good!

Praveen, this would mean having a patch, at the beginning of the
series, which converts the coding style of the files to Linux one.

Basically, that would mean using tabs for indentation, and undoing any
style change that may have been done in our tree, to make the file
adopt the Xen style.

In practise, the idea is ending up with something that is basically
identical to what was in Linux, before all the patches you are porting
were committed (and without the additional parts and features that we
don't need, of course).

At this point, even generating and applying the patches that you are
porting, in this very series, would be really easy, and less error
prone (as it can be almost entirely automated).

Are you up for this?

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-06-20 13:54 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-17  9:32 [PATCH v3] xen: common: rbtree: ported updates from Praveen Kumar
2017-06-17  9:32 ` [PATCH 01/20] rbtree: add const qualifier to some functions Praveen Kumar
2017-06-19 13:49   ` Jan Beulich
2017-06-19 14:09     ` Praveen Kumar
2017-06-19 14:47       ` Jan Beulich
2017-06-19 16:39   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH 02/20] lib/rbtree.c: optimize rb_erase() Praveen Kumar
2017-06-19 16:41   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 03/20] rb_tree: reorganize code in rb_erase() for additional changes Praveen Kumar
2017-06-19 16:45   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 04/20] rb_tree: make clear distinction between two different cases in rb_erase() Praveen Kumar
2017-06-19 16:47   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 05/20] rb_tree: remove redundant if()-condition " Praveen Kumar
2017-06-19 16:53   ` Dario Faggioli
2017-06-20  7:23     ` Jan Beulich
2017-06-17  9:32 ` [PATCH v2 06/20] rbtree: empty nodes have no color Praveen Kumar
2017-06-19 17:00   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 07/20] rbtree: move some implementation details from rbtree.h to rbtree.c Praveen Kumar
2017-06-19 17:05   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 08/20] rbtree: break out of rb_insert_color loop after tree rotation Praveen Kumar
2017-06-19 17:10   ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 09/20] rbtree: adjust root color in rb_insert_color() only when necessary Praveen Kumar
2017-06-19 17:13   ` Dario Faggioli
2017-06-20  7:26     ` Jan Beulich
2017-06-20 13:54       ` Dario Faggioli [this message]
2017-06-27 15:35         ` Praveen Kumar
2017-06-27 15:48           ` Dario Faggioli
2017-06-17  9:32 ` [PATCH v2 10/20] rbtree: low level optimizations in rb_insert_color() Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 11/20] rbtree: adjust node color in __rb_erase_color() only when necessary Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 12/20] rbtree: optimize case selection logic in __rb_erase_color() Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 13/20] rbtree: low level optimizations " Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 14/20] rbtree: coding style adjustments Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 15/20] rbtree: optimize fetching of sibling node Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 16/20] rbtree: add __rb_change_child() helper function Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 17/20] rbtree: place easiest case first in rb_erase() Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 18/20] rbtree: handle 1-child recoloring in rb_erase() instead of rb_erase_color() Praveen Kumar
2017-06-17  9:32 ` [PATCH v2 19/20] rbtree: low level optimizations in rb_erase() Praveen Kumar
2017-06-17  9:32 ` [PATCH 20/20] lib/rbtree.c: fix typo in comment of __rb_insert() Praveen Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497966887.7405.23.camel@citrix.com \
    --to=dario.faggioli@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=kpraveen.lkml@gmail.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.