* [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure
@ 2017-06-21 8:40 Bhumika Goyal
2017-06-28 11:49 ` Luca Coelho
0 siblings, 1 reply; 5+ messages in thread
From: Bhumika Goyal @ 2017-06-21 8:40 UTC (permalink / raw)
To: julia.lawall, johannes.berg, emmanuel.grumbach, luciano.coelho,
linuxwifi, kvalo, linux-wireless, netdev, linux-kernel
Cc: Bhumika Goyal
Declare thermal_cooling_device_ops structure as const as it is only passed
as an argument to the function thermal_cooling_device_register and this
argument is of type const. So, declare the structure as const.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
index 453a785..0b5a177 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
@@ -813,7 +813,7 @@ static int iwl_mvm_tcool_set_cur_state(struct thermal_cooling_device *cdev,
return ret;
}
-static struct thermal_cooling_device_ops tcooling_ops = {
+static const struct thermal_cooling_device_ops tcooling_ops = {
.get_max_state = iwl_mvm_tcool_get_max_state,
.get_cur_state = iwl_mvm_tcool_get_cur_state,
.set_cur_state = iwl_mvm_tcool_set_cur_state,
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure
2017-06-21 8:40 [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure Bhumika Goyal
@ 2017-06-28 11:49 ` Luca Coelho
0 siblings, 0 replies; 5+ messages in thread
From: Luca Coelho @ 2017-06-28 11:49 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, johannes.berg, emmanuel.grumbach,
linuxwifi, kvalo, linux-wireless, netdev, linux-kernel
On Wed, 2017-06-21 at 14:10 +0530, Bhumika Goyal wrote:
> Declare thermal_cooling_device_ops structure as const as it is only passed
> as an argument to the function thermal_cooling_device_register and this
> argument is of type const. So, declare the structure as const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
Thanks, we're reviewing this internally. It looks fine, but I need to
assess whether this will have any impacts in our backports project
before we can apply it.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure
@ 2017-06-28 11:49 ` Luca Coelho
0 siblings, 0 replies; 5+ messages in thread
From: Luca Coelho @ 2017-06-28 11:49 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, johannes.berg, emmanuel.grumbach,
linuxwifi, kvalo, linux-wireless, netdev, linux-kernel
On Wed, 2017-06-21 at 14:10 +0530, Bhumika Goyal wrote:
> Declare thermal_cooling_device_ops structure as const as it is only passed
> as an argument to the function thermal_cooling_device_register and this
> argument is of type const. So, declare the structure as const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
Thanks, we're reviewing this internally. It looks fine, but I need to
assess whether this will have any impacts in our backports project
before we can apply it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure
2017-06-28 11:49 ` Luca Coelho
@ 2017-06-29 17:08 ` Luca Coelho
-1 siblings, 0 replies; 5+ messages in thread
From: Luca Coelho @ 2017-06-29 17:08 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, johannes.berg, emmanuel.grumbach,
linuxwifi, kvalo, linux-wireless, netdev, linux-kernel
On Wed, 2017-06-28 at 14:49 +0300, Luca Coelho wrote:
> On Wed, 2017-06-21 at 14:10 +0530, Bhumika Goyal wrote:
> > Declare thermal_cooling_device_ops structure as const as it is only passed
> > as an argument to the function thermal_cooling_device_register and this
> > argument is of type const. So, declare the structure as const.
> >
> > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> > ---
>
> Thanks, we're reviewing this internally. It looks fine, but I need to
> assess whether this will have any impacts in our backports project
> before we can apply it.
This has been applied in our internal tree and will eventually land in
the mainline.
Thanks!
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure
@ 2017-06-29 17:08 ` Luca Coelho
0 siblings, 0 replies; 5+ messages in thread
From: Luca Coelho @ 2017-06-29 17:08 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, johannes.berg, emmanuel.grumbach,
linuxwifi, kvalo, linux-wireless, netdev, linux-kernel
On Wed, 2017-06-28 at 14:49 +0300, Luca Coelho wrote:
> On Wed, 2017-06-21 at 14:10 +0530, Bhumika Goyal wrote:
> > Declare thermal_cooling_device_ops structure as const as it is only passed
> > as an argument to the function thermal_cooling_device_register and this
> > argument is of type const. So, declare the structure as const.
> >
> > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> > ---
>
> Thanks, we're reviewing this internally. It looks fine, but I need to
> assess whether this will have any impacts in our backports project
> before we can apply it.
This has been applied in our internal tree and will eventually land in
the mainline.
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-29 17:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-21 8:40 [PATCH] iwlwifi: mvm: add const to thermal_cooling_device_ops structure Bhumika Goyal
2017-06-28 11:49 ` Luca Coelho
2017-06-28 11:49 ` Luca Coelho
2017-06-29 17:08 ` Luca Coelho
2017-06-29 17:08 ` Luca Coelho
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.