All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4] drm/exynos/dsi: Remove error handling for bridge_node DT parsing
       [not found] <CGME20170621105143epcas5p4b5c7fbbc0263c6190e69df6822e63699@epcas5p4.samsung.com>
@ 2017-06-21 10:51   ` Hoegeun Kwon
  0 siblings, 0 replies; 5+ messages in thread
From: Hoegeun Kwon @ 2017-06-21 10:51 UTC (permalink / raw)
  To: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk
  Cc: javier, a.hajda, tjakobi, dri-devel, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Hoegeun Kwon

Remove the error handling of bridge_node because the bridge_node is
optional.

For example, In case of Exynos SoC, a bridge device such as mDNIe and
MIC could be placed between Display Controller and MIPI DSI device but
the bridge device is optional.

Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
---

Hi all,

Thanks for Krzysztof's advice.

Changes for V4:
- Fixed the word('optional') from commit message.

Changes for V3:
- Removed the word('required') from commit message.

Changes for V2:
- Modified the commit message in more detail than before.

Best regards,
Hoegeun

 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index a11b795..6ee0dac 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
 		return ret;
 
 	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
-	if (!dsi->bridge_node)
-		return -EINVAL;
 
 	return 0;
 }
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH v4] drm/exynos/dsi: Remove error handling for bridge_node DT parsing
@ 2017-06-21 10:51   ` Hoegeun Kwon
  0 siblings, 0 replies; 5+ messages in thread
From: Hoegeun Kwon @ 2017-06-21 10:51 UTC (permalink / raw)
  To: linux-arm-kernel

Remove the error handling of bridge_node because the bridge_node is
optional.

For example, In case of Exynos SoC, a bridge device such as mDNIe and
MIC could be placed between Display Controller and MIPI DSI device but
the bridge device is optional.

Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
---

Hi all,

Thanks for Krzysztof's advice.

Changes for V4:
- Fixed the word('optional') from commit message.

Changes for V3:
- Removed the word('required') from commit message.

Changes for V2:
- Modified the commit message in more detail than before.

Best regards,
Hoegeun

 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index a11b795..6ee0dac 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
 		return ret;
 
 	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
-	if (!dsi->bridge_node)
-		return -EINVAL;
 
 	return 0;
 }
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH v4] drm/exynos/dsi: Remove error handling for bridge_node DT parsing
  2017-06-21 10:51   ` Hoegeun Kwon
  (?)
@ 2017-07-05  7:09     ` Hoegeun Kwon
  -1 siblings, 0 replies; 5+ messages in thread
From: Hoegeun Kwon @ 2017-07-05  7:09 UTC (permalink / raw)
  To: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk
  Cc: javier, a.hajda, tjakobi, dri-devel, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Hoegeun Kwon

Hi Inki,

Could you check this patch? :D

Best regards,
Hoegeun

On 06/21/2017 07:51 PM, Hoegeun Kwon wrote:
> Remove the error handling of bridge_node because the bridge_node is
> optional.
>
> For example, In case of Exynos SoC, a bridge device such as mDNIe and
> MIC could be placed between Display Controller and MIPI DSI device but
> the bridge device is optional.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> ---
>
> Hi all,
>
> Thanks for Krzysztof's advice.
>
> Changes for V4:
> - Fixed the word('optional') from commit message.
>
> Changes for V3:
> - Removed the word('required') from commit message.
>
> Changes for V2:
> - Modified the commit message in more detail than before.
>
> Best regards,
> Hoegeun
>
>   drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index a11b795..6ee0dac 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
>   		return ret;
>   
>   	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
> -	if (!dsi->bridge_node)
> -		return -EINVAL;
>   
>   	return 0;
>   }

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v4] drm/exynos/dsi: Remove error handling for bridge_node DT parsing
@ 2017-07-05  7:09     ` Hoegeun Kwon
  0 siblings, 0 replies; 5+ messages in thread
From: Hoegeun Kwon @ 2017-07-05  7:09 UTC (permalink / raw)
  To: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk
  Cc: linux-samsung-soc, tjakobi, linux-kernel, dri-devel, javier,
	Hoegeun Kwon, linux-arm-kernel

Hi Inki,

Could you check this patch? :D

Best regards,
Hoegeun

On 06/21/2017 07:51 PM, Hoegeun Kwon wrote:
> Remove the error handling of bridge_node because the bridge_node is
> optional.
>
> For example, In case of Exynos SoC, a bridge device such as mDNIe and
> MIC could be placed between Display Controller and MIPI DSI device but
> the bridge device is optional.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> ---
>
> Hi all,
>
> Thanks for Krzysztof's advice.
>
> Changes for V4:
> - Fixed the word('optional') from commit message.
>
> Changes for V3:
> - Removed the word('required') from commit message.
>
> Changes for V2:
> - Modified the commit message in more detail than before.
>
> Best regards,
> Hoegeun
>
>   drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index a11b795..6ee0dac 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
>   		return ret;
>   
>   	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
> -	if (!dsi->bridge_node)
> -		return -EINVAL;
>   
>   	return 0;
>   }

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH v4] drm/exynos/dsi: Remove error handling for bridge_node DT parsing
@ 2017-07-05  7:09     ` Hoegeun Kwon
  0 siblings, 0 replies; 5+ messages in thread
From: Hoegeun Kwon @ 2017-07-05  7:09 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Inki,

Could you check this patch? :D

Best regards,
Hoegeun

On 06/21/2017 07:51 PM, Hoegeun Kwon wrote:
> Remove the error handling of bridge_node because the bridge_node is
> optional.
>
> For example, In case of Exynos SoC, a bridge device such as mDNIe and
> MIC could be placed between Display Controller and MIPI DSI device but
> the bridge device is optional.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> ---
>
> Hi all,
>
> Thanks for Krzysztof's advice.
>
> Changes for V4:
> - Fixed the word('optional') from commit message.
>
> Changes for V3:
> - Removed the word('required') from commit message.
>
> Changes for V2:
> - Modified the commit message in more detail than before.
>
> Best regards,
> Hoegeun
>
>   drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index a11b795..6ee0dac 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
>   		return ret;
>   
>   	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
> -	if (!dsi->bridge_node)
> -		return -EINVAL;
>   
>   	return 0;
>   }

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-05  7:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20170621105143epcas5p4b5c7fbbc0263c6190e69df6822e63699@epcas5p4.samsung.com>
2017-06-21 10:51 ` [PATCH v4] drm/exynos/dsi: Remove error handling for bridge_node DT parsing Hoegeun Kwon
2017-06-21 10:51   ` Hoegeun Kwon
2017-07-05  7:09   ` Hoegeun Kwon
2017-07-05  7:09     ` Hoegeun Kwon
2017-07-05  7:09     ` Hoegeun Kwon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.