* [PATCH net-next] idsn: fix wrong skb_put() used
@ 2017-06-21 12:04 yuan linyu
2017-06-21 13:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: yuan linyu @ 2017-06-21 12:04 UTC (permalink / raw)
To: netdev; +Cc: David S . Miller, yuan linyu
From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
in my commit b952f4dff2751252db073c27c0f8a16a416a2ddc,
- *(u8 *)skb_put(skb_out, 1) = (u8)(accm >> 24); \
+ skb_put(skb_out, (u8)(accm >> 24)); \
it should skb_put_u8()
Fixes: b952f4dff275 ("net: manual clean code which call skb_put_[data:zero])")
Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
---
drivers/isdn/i4l/isdn_bsdcomp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/i4l/isdn_bsdcomp.c b/drivers/isdn/i4l/isdn_bsdcomp.c
index 5b64a13..99012c0 100644
--- a/drivers/isdn/i4l/isdn_bsdcomp.c
+++ b/drivers/isdn/i4l/isdn_bsdcomp.c
@@ -472,7 +472,7 @@ static int bsd_compress(void *state, struct sk_buff *skb_in, struct sk_buff *skb
accm |= ((ent) << bitno); \
do { \
if (skb_out && skb_tailroom(skb_out) > 0) \
- skb_put(skb_out, (u8)(accm >> 24)); \
+ skb_put_u8(skb_out, (u8)(accm >> 24)); \
accm <<= 8; \
bitno += 8; \
} while (bitno <= 24); \
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] idsn: fix wrong skb_put() used
2017-06-21 12:04 [PATCH net-next] idsn: fix wrong skb_put() used yuan linyu
@ 2017-06-21 13:52 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-06-21 13:52 UTC (permalink / raw)
To: cugyly; +Cc: netdev, Linyu.Yuan
From: yuan linyu <cugyly@163.com>
Date: Wed, 21 Jun 2017 20:04:40 +0800
> From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
>
> in my commit b952f4dff2751252db073c27c0f8a16a416a2ddc,
> - *(u8 *)skb_put(skb_out, 1) = (u8)(accm >> 24); \
> + skb_put(skb_out, (u8)(accm >> 24)); \
> it should skb_put_u8()
>
> Fixes: b952f4dff275 ("net: manual clean code which call skb_put_[data:zero])")
> Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-21 13:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-21 12:04 [PATCH net-next] idsn: fix wrong skb_put() used yuan linyu
2017-06-21 13:52 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.