* [i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU.
@ 2017-06-21 16:34 Anusha Srivatsa
2017-06-21 16:34 ` [i-g-t 2/3] lib/cfl: Add PCI IDs to H SKU in CFl Anusha Srivatsa
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Anusha Srivatsa @ 2017-06-21 16:34 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
From: anushasr <anusha.srivatsa@intel.com>
Just following the spec and adding these extra IDs.
v2: update IDs
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
lib/i915_pciids.h | 10 ++++++++++
lib/intel_device_info.c | 2 ++
2 files changed, 12 insertions(+)
diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
index 27e0dba..02f43d9 100644
--- a/lib/i915_pciids.h
+++ b/lib/i915_pciids.h
@@ -334,4 +334,14 @@
INTEL_KBL_GT3_IDS(info), \
INTEL_KBL_GT4_IDS(info)
+#define INTEL_CFL_S_IDS(info) \
+ INTEL_VGA_DEVICE(0x3E90, info), /* SRV GT1 */ \
+ INTEL_VGA_DEVICE(0x3E93, info), /* SRV GT1 */ \
+ INTEL_VGA_DEVICE(0x3E91, info), /* SRV GT2 */ \
+ INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
+ INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */
+
+#define INTEL_CFL_IDS(info) \
+ INTEL_CFL_S_IDS(info)
+
#endif /* _I915_PCIIDS_H */
diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
index 199fa2d..2c46aba 100644
--- a/lib/intel_device_info.c
+++ b/lib/intel_device_info.c
@@ -241,6 +241,8 @@ static const struct pci_id_match intel_device_match[] = {
INTEL_GLK_IDS(&intel_geminilake_info),
+ INTEL_CFL_IDS(&intel_coffeelake_info),
+
INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info),
};
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [i-g-t 2/3] lib/cfl: Add PCI IDs to H SKU in CFl
2017-06-21 16:34 [i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU Anusha Srivatsa
@ 2017-06-21 16:34 ` Anusha Srivatsa
2017-06-21 19:43 ` Clint Taylor
2017-06-21 16:34 ` [i-g-t 3/3] lib/cfl: Add PCI Ids for U " Anusha Srivatsa
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Anusha Srivatsa @ 2017-06-21 16:34 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
From: anushasr <anusha.srivatsa@intel.com>
Follow the spec and add the ID for H SKU in
CFL.
v2: Update IDs.
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
lib/i915_pciids.h | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
index 02f43d9..c319e37 100644
--- a/lib/i915_pciids.h
+++ b/lib/i915_pciids.h
@@ -341,7 +341,13 @@
INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */
+
+#define INTEL_CFL_H_IDS(info) \
+ INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
+ INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
+
#define INTEL_CFL_IDS(info) \
- INTEL_CFL_S_IDS(info)
+ INTEL_CFL_S_IDS(info), \
+ INTEL_CFL_H_IDS(info)
#endif /* _I915_PCIIDS_H */
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [i-g-t 3/3] lib/cfl: Add PCI Ids for U SKU in CFl
2017-06-21 16:34 [i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU Anusha Srivatsa
2017-06-21 16:34 ` [i-g-t 2/3] lib/cfl: Add PCI IDs to H SKU in CFl Anusha Srivatsa
@ 2017-06-21 16:34 ` Anusha Srivatsa
2017-06-21 19:48 ` Clint Taylor
2017-06-21 16:40 ` [i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU Chris Wilson
2017-06-21 19:44 ` Clint Taylor
3 siblings, 1 reply; 8+ messages in thread
From: Anusha Srivatsa @ 2017-06-21 16:34 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
From: anushasr <anusha.srivatsa@intel.com>
Follow the spec and add ID for U SKU
v2: Update IDs.
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
lib/i915_pciids.h | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
index c319e37..71cce60 100644
--- a/lib/i915_pciids.h
+++ b/lib/i915_pciids.h
@@ -346,8 +346,15 @@
INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
+#define INTEL_CFL_U_IDS(info) \
+ INTEL_VGA_DEVICE(0x3EA5, info), /* ULT GT3 */ \
+ INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \
+ INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
+ INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */
+
#define INTEL_CFL_IDS(info) \
INTEL_CFL_S_IDS(info), \
- INTEL_CFL_H_IDS(info)
+ INTEL_CFL_H_IDS(info), \
+ INTEL_CFL_U_IDS(info)
#endif /* _I915_PCIIDS_H */
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU.
2017-06-21 16:34 [i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU Anusha Srivatsa
2017-06-21 16:34 ` [i-g-t 2/3] lib/cfl: Add PCI IDs to H SKU in CFl Anusha Srivatsa
2017-06-21 16:34 ` [i-g-t 3/3] lib/cfl: Add PCI Ids for U " Anusha Srivatsa
@ 2017-06-21 16:40 ` Chris Wilson
2017-06-21 19:44 ` Clint Taylor
3 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2017-06-21 16:40 UTC (permalink / raw)
To: Anusha Srivatsa, intel-gfx; +Cc: Rodrigo Vivi
Quoting Anusha Srivatsa (2017-06-21 17:34:57)
> From: anushasr <anusha.srivatsa@intel.com>
>
> Just following the spec and adding these extra IDs.
i915_pciids.h is just a copy from the kernel. So copy across and cite
the upstream kernel commits.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [i-g-t 2/3] lib/cfl: Add PCI IDs to H SKU in CFl
2017-06-21 16:34 ` [i-g-t 2/3] lib/cfl: Add PCI IDs to H SKU in CFl Anusha Srivatsa
@ 2017-06-21 19:43 ` Clint Taylor
0 siblings, 0 replies; 8+ messages in thread
From: Clint Taylor @ 2017-06-21 19:43 UTC (permalink / raw)
To: intel-gfx
On 06/21/2017 09:34 AM, Anusha Srivatsa wrote:
> From: anushasr <anusha.srivatsa@intel.com>
>
> Follow the spec and add the ID for H SKU in
> CFL.
>
> v2: Update IDs.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
> lib/i915_pciids.h | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> index 02f43d9..c319e37 100644
> --- a/lib/i915_pciids.h
> +++ b/lib/i915_pciids.h
> @@ -341,7 +341,13 @@
> INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
> INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */
>
> +
> +#define INTEL_CFL_H_IDS(info) \
> + INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
> + INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
> +
Device ID's Matches current documentation
Reviewed-by: Clint Taylor <Clinton.A.Taylor@intel.com>
> #define INTEL_CFL_IDS(info) \
> - INTEL_CFL_S_IDS(info)
> + INTEL_CFL_S_IDS(info), \
> + INTEL_CFL_H_IDS(info)
>
> #endif /* _I915_PCIIDS_H */
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU.
2017-06-21 16:34 [i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU Anusha Srivatsa
` (2 preceding siblings ...)
2017-06-21 16:40 ` [i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU Chris Wilson
@ 2017-06-21 19:44 ` Clint Taylor
3 siblings, 0 replies; 8+ messages in thread
From: Clint Taylor @ 2017-06-21 19:44 UTC (permalink / raw)
To: intel-gfx
On 06/21/2017 09:34 AM, Anusha Srivatsa wrote:
> From: anushasr <anusha.srivatsa@intel.com>
>
> Just following the spec and adding these extra IDs.
>
> v2: update IDs
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
> lib/i915_pciids.h | 10 ++++++++++
> lib/intel_device_info.c | 2 ++
> 2 files changed, 12 insertions(+)
>
> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> index 27e0dba..02f43d9 100644
> --- a/lib/i915_pciids.h
> +++ b/lib/i915_pciids.h
> @@ -334,4 +334,14 @@
> INTEL_KBL_GT3_IDS(info), \
> INTEL_KBL_GT4_IDS(info)
>
> +#define INTEL_CFL_S_IDS(info) \
> + INTEL_VGA_DEVICE(0x3E90, info), /* SRV GT1 */ \
> + INTEL_VGA_DEVICE(0x3E93, info), /* SRV GT1 */ \
> + INTEL_VGA_DEVICE(0x3E91, info), /* SRV GT2 */ \
> + INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
> + INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */
> +
Matches current documentation
Reviewed-by: Clint Taylor <Clinton.A.Taylor@intel.com>
> +#define INTEL_CFL_IDS(info) \
> + INTEL_CFL_S_IDS(info)
> +
> #endif /* _I915_PCIIDS_H */
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index 199fa2d..2c46aba 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -241,6 +241,8 @@ static const struct pci_id_match intel_device_match[] = {
>
> INTEL_GLK_IDS(&intel_geminilake_info),
>
> + INTEL_CFL_IDS(&intel_coffeelake_info),
> +
> INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info),
> };
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [i-g-t 3/3] lib/cfl: Add PCI Ids for U SKU in CFl
2017-06-21 16:34 ` [i-g-t 3/3] lib/cfl: Add PCI Ids for U " Anusha Srivatsa
@ 2017-06-21 19:48 ` Clint Taylor
2017-06-21 21:19 ` Srivatsa, Anusha
0 siblings, 1 reply; 8+ messages in thread
From: Clint Taylor @ 2017-06-21 19:48 UTC (permalink / raw)
To: intel-gfx
On 06/21/2017 09:34 AM, Anusha Srivatsa wrote:
> From: anushasr <anusha.srivatsa@intel.com>
>
> Follow the spec and add ID for U SKU
>
> v2: Update IDs.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
> lib/i915_pciids.h | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> index c319e37..71cce60 100644
> --- a/lib/i915_pciids.h
> +++ b/lib/i915_pciids.h
> @@ -346,8 +346,15 @@
> INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
> INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
>
> +#define INTEL_CFL_U_IDS(info) \
> + INTEL_VGA_DEVICE(0x3EA5, info), /* ULT GT3 */ \
> + INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \
> + INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
> + INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */
0x3EA8 is marked as not POR in the current documentation.
-Clint
> +
> #define INTEL_CFL_IDS(info) \
> INTEL_CFL_S_IDS(info), \
> - INTEL_CFL_H_IDS(info)
> + INTEL_CFL_H_IDS(info), \
> + INTEL_CFL_U_IDS(info)
>
> #endif /* _I915_PCIIDS_H */
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [i-g-t 3/3] lib/cfl: Add PCI Ids for U SKU in CFl
2017-06-21 19:48 ` Clint Taylor
@ 2017-06-21 21:19 ` Srivatsa, Anusha
0 siblings, 0 replies; 8+ messages in thread
From: Srivatsa, Anusha @ 2017-06-21 21:19 UTC (permalink / raw)
To: Taylor, Clinton A, intel-gfx
>-----Original Message-----
>From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of
>Clint Taylor
>Sent: Wednesday, June 21, 2017 12:48 PM
>To: intel-gfx@lists.freedesktop.org
>Subject: Re: [Intel-gfx] [i-g-t 3/3] lib/cfl: Add PCI Ids for U SKU in CFl
>
>
>
>On 06/21/2017 09:34 AM, Anusha Srivatsa wrote:
>> From: anushasr <anusha.srivatsa@intel.com>
>>
>> Follow the spec and add ID for U SKU
>>
>> v2: Update IDs.
>>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>> ---
>> lib/i915_pciids.h | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h index
>> c319e37..71cce60 100644
>> --- a/lib/i915_pciids.h
>> +++ b/lib/i915_pciids.h
>> @@ -346,8 +346,15 @@
>> INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
>> INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
>>
>> +#define INTEL_CFL_U_IDS(info) \
>> + INTEL_VGA_DEVICE(0x3EA5, info), /* ULT GT3 */ \
>> + INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \
>> + INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
>> + INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */
>0x3EA8 is marked as not POR in the current documentation.
Wanted to match the IDs everywhere. The above list of IDs is the same even in kernel code and in libdrm .
Anusha
>-Clint
>
>
>> +
>> #define INTEL_CFL_IDS(info) \
>> INTEL_CFL_S_IDS(info), \
>> - INTEL_CFL_H_IDS(info)
>> + INTEL_CFL_H_IDS(info), \
>> + INTEL_CFL_U_IDS(info)
>>
>> #endif /* _I915_PCIIDS_H */
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-06-21 21:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-21 16:34 [i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU Anusha Srivatsa
2017-06-21 16:34 ` [i-g-t 2/3] lib/cfl: Add PCI IDs to H SKU in CFl Anusha Srivatsa
2017-06-21 19:43 ` Clint Taylor
2017-06-21 16:34 ` [i-g-t 3/3] lib/cfl: Add PCI Ids for U " Anusha Srivatsa
2017-06-21 19:48 ` Clint Taylor
2017-06-21 21:19 ` Srivatsa, Anusha
2017-06-21 16:40 ` [i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU Chris Wilson
2017-06-21 19:44 ` Clint Taylor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.