* [PATCH] siggen: Make calc_taskhash match get_taskhash for file checksums
@ 2017-06-02 13:02 Richard Purdie
2017-06-22 21:10 ` Matthew McClintock
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2017-06-02 13:02 UTC (permalink / raw)
To: bitbake-devel
The code in these two functions is meant to be equivlanet in behaviour
but isn't. Add in code to ensure files that don't exist are handled
consistently by both functions. Users did report being able to generate
tracebacks otherwise.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/siggen.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index 169756e..f71190a 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -667,7 +667,8 @@ def calc_taskhash(sigdata):
data = data + sigdata['runtaskhashes'][dep]
for c in sigdata['file_checksum_values']:
- data = data + c[1]
+ if c[1]:
+ data = data + c[1]
if 'taint' in sigdata:
if 'nostamp:' in sigdata['taint']:
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] siggen: Make calc_taskhash match get_taskhash for file checksums
2017-06-02 13:02 [PATCH] siggen: Make calc_taskhash match get_taskhash for file checksums Richard Purdie
@ 2017-06-22 21:10 ` Matthew McClintock
2017-06-22 22:29 ` akuster808
0 siblings, 1 reply; 6+ messages in thread
From: Matthew McClintock @ 2017-06-22 21:10 UTC (permalink / raw)
To: Richard Purdie; +Cc: bitbake-devel
Seeing this issue on some older (err, really olderrrr) versions of
bitbake. How far back could we backport?
-M
On Fri, Jun 2, 2017 at 8:02 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> The code in these two functions is meant to be equivlanet in behaviour
> but isn't. Add in code to ensure files that don't exist are handled
> consistently by both functions. Users did report being able to generate
> tracebacks otherwise.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> lib/bb/siggen.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
> index 169756e..f71190a 100644
> --- a/lib/bb/siggen.py
> +++ b/lib/bb/siggen.py
> @@ -667,7 +667,8 @@ def calc_taskhash(sigdata):
> data = data + sigdata['runtaskhashes'][dep]
>
> for c in sigdata['file_checksum_values']:
> - data = data + c[1]
> + if c[1]:
> + data = data + c[1]
>
> if 'taint' in sigdata:
> if 'nostamp:' in sigdata['taint']:
> --
> 2.7.4
>
> --
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] siggen: Make calc_taskhash match get_taskhash for file checksums
2017-06-22 21:10 ` Matthew McClintock
@ 2017-06-22 22:29 ` akuster808
2017-06-23 14:29 ` Matthew McClintock
0 siblings, 1 reply; 6+ messages in thread
From: akuster808 @ 2017-06-22 22:29 UTC (permalink / raw)
To: Matthew McClintock, Richard Purdie; +Cc: bitbake-devel
On 06/22/2017 02:10 PM, Matthew McClintock wrote:
> Seeing this issue on some older (err, really olderrrr) versions of
> bitbake. How far back could we backport?
Technically 1.34, 1.32 and 1.30 (krogoth). How far back is "olderrrr' ?
- armin
>
> -M
>
> On Fri, Jun 2, 2017 at 8:02 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>> The code in these two functions is meant to be equivlanet in behaviour
>> but isn't. Add in code to ensure files that don't exist are handled
>> consistently by both functions. Users did report being able to generate
>> tracebacks otherwise.
>>
>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>> ---
>> lib/bb/siggen.py | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
>> index 169756e..f71190a 100644
>> --- a/lib/bb/siggen.py
>> +++ b/lib/bb/siggen.py
>> @@ -667,7 +667,8 @@ def calc_taskhash(sigdata):
>> data = data + sigdata['runtaskhashes'][dep]
>>
>> for c in sigdata['file_checksum_values']:
>> - data = data + c[1]
>> + if c[1]:
>> + data = data + c[1]
>>
>> if 'taint' in sigdata:
>> if 'nostamp:' in sigdata['taint']:
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> bitbake-devel mailing list
>> bitbake-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/bitbake-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] siggen: Make calc_taskhash match get_taskhash for file checksums
2017-06-22 22:29 ` akuster808
@ 2017-06-23 14:29 ` Matthew McClintock
2017-06-23 14:57 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Matthew McClintock @ 2017-06-23 14:29 UTC (permalink / raw)
To: akuster808; +Cc: bitbake-devel
On Thu, Jun 22, 2017 at 5:29 PM, akuster808 <akuster808@gmail.com> wrote:
>
>
> On 06/22/2017 02:10 PM, Matthew McClintock wrote:
>>
>> Seeing this issue on some older (err, really olderrrr) versions of
>> bitbake. How far back could we backport?
>
> Technically 1.34, 1.32 and 1.30 (krogoth). How far back is "olderrrr' ?
I guess I'm seeing this on krogoth so that would be good.
-M
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] siggen: Make calc_taskhash match get_taskhash for file checksums
2017-06-23 14:29 ` Matthew McClintock
@ 2017-06-23 14:57 ` Richard Purdie
2017-06-23 15:17 ` Matthew McClintock
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2017-06-23 14:57 UTC (permalink / raw)
To: Matthew McClintock, akuster808; +Cc: bitbake-devel
On Fri, 2017-06-23 at 09:29 -0500, Matthew McClintock wrote:
> On Thu, Jun 22, 2017 at 5:29 PM, akuster808 <akuster808@gmail.com>
> wrote:
> > On 06/22/2017 02:10 PM, Matthew McClintock wrote:
> > >
> > >
> > > Seeing this issue on some older (err, really olderrrr) versions
> > > of
> > > bitbake. How far back could we backport?
> > Technically 1.34, 1.32 and 1.30 (krogoth). How far back is
> > "olderrrr' ?
> I guess I'm seeing this on krogoth so that would be good.
Did backporting the patch fix it? There are a variety of ways you could
hit this error and I want to confirm it was this specific issue you
were hitting...
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] siggen: Make calc_taskhash match get_taskhash for file checksums
2017-06-23 14:57 ` Richard Purdie
@ 2017-06-23 15:17 ` Matthew McClintock
0 siblings, 0 replies; 6+ messages in thread
From: Matthew McClintock @ 2017-06-23 15:17 UTC (permalink / raw)
To: Richard Purdie; +Cc: bitbake-devel, akuster808
On Fri, Jun 23, 2017 at 9:57 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2017-06-23 at 09:29 -0500, Matthew McClintock wrote:
>> On Thu, Jun 22, 2017 at 5:29 PM, akuster808 <akuster808@gmail.com>
>> wrote:
>> > On 06/22/2017 02:10 PM, Matthew McClintock wrote:
>> > >
>> > >
>> > > Seeing this issue on some older (err, really olderrrr) versions
>> > > of
>> > > bitbake. How far back could we backport?
>> > Technically 1.34, 1.32 and 1.30 (krogoth). How far back is
>> > "olderrrr' ?
>> I guess I'm seeing this on krogoth so that would be good.
>
> Did backporting the patch fix it? There are a variety of ways you could
> hit this error and I want to confirm it was this specific issue you
> were hitting...
Yes, we had an identical fix actually.
-M
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-23 15:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-02 13:02 [PATCH] siggen: Make calc_taskhash match get_taskhash for file checksums Richard Purdie
2017-06-22 21:10 ` Matthew McClintock
2017-06-22 22:29 ` akuster808
2017-06-23 14:29 ` Matthew McClintock
2017-06-23 14:57 ` Richard Purdie
2017-06-23 15:17 ` Matthew McClintock
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.