All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] protobuf protobuf-c: Remove COMPATIBLE_HOST
@ 2017-06-26  9:08 zhe.he
  2017-06-26 17:57 ` Mark Asselstine
  0 siblings, 1 reply; 3+ messages in thread
From: zhe.he @ 2017-06-26  9:08 UTC (permalink / raw)
  To: meta-virtualization

From: He Zhe <zhe.he@windriver.com>

protobuf and protobuf-c can actually work with all arches but they were
limited and merged upstream by 5e5e09a18199108de29bfee101c7b311ef094d94

This patch removes the COMPATIBLE_HOST to re-enable them to work with
other architectures.

Signed-off-by: He Zhe <zhe.he@windriver.com>
---
 recipes-devtools/protobuf/protobuf-c_1.2.1.bb | 2 --
 recipes-devtools/protobuf/protobuf_3.1.0.bb   | 2 --
 2 files changed, 4 deletions(-)

diff --git a/recipes-devtools/protobuf/protobuf-c_1.2.1.bb b/recipes-devtools/protobuf/protobuf-c_1.2.1.bb
index ff2499e..daba0ed 100644
--- a/recipes-devtools/protobuf/protobuf-c_1.2.1.bb
+++ b/recipes-devtools/protobuf/protobuf-c_1.2.1.bb
@@ -6,8 +6,6 @@ LICENSE = "Apache-2.0"
 
 LIC_FILES_CHKSUM = "file://LICENSE;md5=235c3195a3968524dc1524b4ebea0c0e"
 
-COMPATIBLE_HOST = "(x86_64|arm|aarch64).*-linux"
-
 DEPENDS = "protobuf protobuf-c-native"
 
 SRC_URI[md5sum] = "e544249c329391fff512c3874895cfbe"
diff --git a/recipes-devtools/protobuf/protobuf_3.1.0.bb b/recipes-devtools/protobuf/protobuf_3.1.0.bb
index 78b0d60..7d6698d 100644
--- a/recipes-devtools/protobuf/protobuf_3.1.0.bb
+++ b/recipes-devtools/protobuf/protobuf_3.1.0.bb
@@ -19,8 +19,6 @@ SRC_URI = "https://github.com/google/protobuf/archive/v3.1.0.tar.gz;downloadfile
 	        file://run-ptest \
             "
 
-COMPATIBLE_HOST = "(x86_64|arm|aarch64).*-linux"
-
 EXTRA_OECONF += " --with-protoc=${STAGING_BINDIR_NATIVE}/protoc"
 inherit autotools setuptools ptest
 
-- 
2.8.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] protobuf protobuf-c: Remove COMPATIBLE_HOST
  2017-06-26  9:08 [PATCH] protobuf protobuf-c: Remove COMPATIBLE_HOST zhe.he
@ 2017-06-26 17:57 ` Mark Asselstine
  2017-06-27 17:19   ` Bruce Ashfield
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Asselstine @ 2017-06-26 17:57 UTC (permalink / raw)
  To: zhe.he; +Cc: meta-virtualization

On Mon, Jun 26, 2017 at 5:08 AM,  <zhe.he@windriver.com> wrote:
> From: He Zhe <zhe.he@windriver.com>
>
> protobuf and protobuf-c can actually work with all arches but they were
> limited and merged upstream by 5e5e09a18199108de29bfee101c7b311ef094d94
>
> This patch removes the COMPATIBLE_HOST to re-enable them to work with
> other architectures.
>
> Signed-off-by: He Zhe <zhe.he@windriver.com>
> ---

Bruce, I had a look at this and the changes look fine and match what
is in meta-oe. Let me know if you are still in favour of removing
these to use the copies in meta-oe, something you have mentioned in
the past but we have yet to follow through with.

Mark

>  recipes-devtools/protobuf/protobuf-c_1.2.1.bb | 2 --
>  recipes-devtools/protobuf/protobuf_3.1.0.bb   | 2 --
>  2 files changed, 4 deletions(-)
>
> diff --git a/recipes-devtools/protobuf/protobuf-c_1.2.1.bb b/recipes-devtools/protobuf/protobuf-c_1.2.1.bb
> index ff2499e..daba0ed 100644
> --- a/recipes-devtools/protobuf/protobuf-c_1.2.1.bb
> +++ b/recipes-devtools/protobuf/protobuf-c_1.2.1.bb
> @@ -6,8 +6,6 @@ LICENSE = "Apache-2.0"
>
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=235c3195a3968524dc1524b4ebea0c0e"
>
> -COMPATIBLE_HOST = "(x86_64|arm|aarch64).*-linux"
> -
>  DEPENDS = "protobuf protobuf-c-native"
>
>  SRC_URI[md5sum] = "e544249c329391fff512c3874895cfbe"
> diff --git a/recipes-devtools/protobuf/protobuf_3.1.0.bb b/recipes-devtools/protobuf/protobuf_3.1.0.bb
> index 78b0d60..7d6698d 100644
> --- a/recipes-devtools/protobuf/protobuf_3.1.0.bb
> +++ b/recipes-devtools/protobuf/protobuf_3.1.0.bb
> @@ -19,8 +19,6 @@ SRC_URI = "https://github.com/google/protobuf/archive/v3.1.0.tar.gz;downloadfile
>                 file://run-ptest \
>              "
>
> -COMPATIBLE_HOST = "(x86_64|arm|aarch64).*-linux"
> -
>  EXTRA_OECONF += " --with-protoc=${STAGING_BINDIR_NATIVE}/protoc"
>  inherit autotools setuptools ptest
>
> --
> 2.8.1
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] protobuf protobuf-c: Remove COMPATIBLE_HOST
  2017-06-26 17:57 ` Mark Asselstine
@ 2017-06-27 17:19   ` Bruce Ashfield
  0 siblings, 0 replies; 3+ messages in thread
From: Bruce Ashfield @ 2017-06-27 17:19 UTC (permalink / raw)
  To: Mark Asselstine; +Cc: meta-virtualization

[-- Attachment #1: Type: text/plain, Size: 2874 bytes --]

On Mon, Jun 26, 2017 at 1:57 PM, Mark Asselstine <asselsm@gmail.com> wrote:

> On Mon, Jun 26, 2017 at 5:08 AM,  <zhe.he@windriver.com> wrote:
> > From: He Zhe <zhe.he@windriver.com>
> >
> > protobuf and protobuf-c can actually work with all arches but they were
> > limited and merged upstream by 5e5e09a18199108de29bfee101c7b311ef094d94
> >
> > This patch removes the COMPATIBLE_HOST to re-enable them to work with
> > other architectures.
> >
> > Signed-off-by: He Zhe <zhe.he@windriver.com>
> > ---
>
> Bruce, I had a look at this and the changes look fine and match what
> is in meta-oe. Let me know if you are still in favour of removing
> these to use the copies in meta-oe, something you have mentioned in
> the past but we have yet to follow through with.
>


I'm going to take the plunge and remove the recipes .. and we'll watch for
any
breakage.

So instead of this patch, I just git rm'd the protobuf recipes and will
push that
instead.

Bruce


>
> Mark
>
> >  recipes-devtools/protobuf/protobuf-c_1.2.1.bb | 2 --
> >  recipes-devtools/protobuf/protobuf_3.1.0.bb   | 2 --
> >  2 files changed, 4 deletions(-)
> >
> > diff --git a/recipes-devtools/protobuf/protobuf-c_1.2.1.bb
> b/recipes-devtools/protobuf/protobuf-c_1.2.1.bb
> > index ff2499e..daba0ed 100644
> > --- a/recipes-devtools/protobuf/protobuf-c_1.2.1.bb
> > +++ b/recipes-devtools/protobuf/protobuf-c_1.2.1.bb
> > @@ -6,8 +6,6 @@ LICENSE = "Apache-2.0"
> >
> >  LIC_FILES_CHKSUM = "file://LICENSE;md5=235c3195a3968524dc1524b4ebea0c
> 0e"
> >
> > -COMPATIBLE_HOST = "(x86_64|arm|aarch64).*-linux"
> > -
> >  DEPENDS = "protobuf protobuf-c-native"
> >
> >  SRC_URI[md5sum] = "e544249c329391fff512c3874895cfbe"
> > diff --git a/recipes-devtools/protobuf/protobuf_3.1.0.bb
> b/recipes-devtools/protobuf/protobuf_3.1.0.bb
> > index 78b0d60..7d6698d 100644
> > --- a/recipes-devtools/protobuf/protobuf_3.1.0.bb
> > +++ b/recipes-devtools/protobuf/protobuf_3.1.0.bb
> > @@ -19,8 +19,6 @@ SRC_URI = "https://github.com/google/
> protobuf/archive/v3.1.0.tar.gz;downloadfile
> >                 file://run-ptest \
> >              "
> >
> > -COMPATIBLE_HOST = "(x86_64|arm|aarch64).*-linux"
> > -
> >  EXTRA_OECONF += " --with-protoc=${STAGING_BINDIR_NATIVE}/protoc"
> >  inherit autotools setuptools ptest
> >
> > --
> > 2.8.1
> >
> > --
> > _______________________________________________
> > meta-virtualization mailing list
> > meta-virtualization@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-virtualization
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 5443 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-27 17:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-26  9:08 [PATCH] protobuf protobuf-c: Remove COMPATIBLE_HOST zhe.he
2017-06-26 17:57 ` Mark Asselstine
2017-06-27 17:19   ` Bruce Ashfield

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.