From: Gilad Ben-Yossef <gilad@benyossef.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: Ofir Drang <ofir.drang@arm.com> Subject: [PATCH 03/14] staging: ccree: fix else placement Date: Tue, 27 Jun 2017 10:27:15 +0300 [thread overview] Message-ID: <1498548449-10803-4-git-send-email-gilad@benyossef.com> (raw) In-Reply-To: <1498548449-10803-1-git-send-email-gilad@benyossef.com> Fix cases where the else clause was not located correctly after the if brace. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> --- drivers/staging/ccree/ssi_buffer_mgr.c | 3 +-- drivers/staging/ccree/ssi_pm.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c index 5c46145..3c74ae3 100644 --- a/drivers/staging/ccree/ssi_buffer_mgr.c +++ b/drivers/staging/ccree/ssi_buffer_mgr.c @@ -852,8 +852,7 @@ static inline int ssi_buffer_mgr_aead_chain_assoc( sg_index = current_sg->length; if (sg_index > size_of_assoc) { //the first entry in the scatter list contains all the associated data mapped_nents++; - } - else{ + } else { while (sg_index <= size_of_assoc) { current_sg = sg_next(current_sg); //if have reached the end of the sgl, then this is unexpected diff --git a/drivers/staging/ccree/ssi_pm.c b/drivers/staging/ccree/ssi_pm.c index c8c5875..ae1f7f0 100644 --- a/drivers/staging/ccree/ssi_pm.c +++ b/drivers/staging/ccree/ssi_pm.c @@ -110,8 +110,7 @@ int ssi_power_mgr_runtime_put_suspend(struct device *dev) (struct ssi_drvdata *)dev_get_drvdata(dev))) { pm_runtime_mark_last_busy(dev); rc = pm_runtime_put_autosuspend(dev); - } - else { + } else { /* Something wrong happens*/ BUG(); } -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: Gilad Ben-Yossef <gilad@benyossef.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: Ofir Drang <ofir.drang@arm.com> Subject: [PATCH 03/14] staging: ccree: fix else placement Date: Tue, 27 Jun 2017 10:27:15 +0300 [thread overview] Message-ID: <1498548449-10803-4-git-send-email-gilad@benyossef.com> (raw) In-Reply-To: <1498548449-10803-1-git-send-email-gilad@benyossef.com> Fix cases where the else clause was not located correctly after the if brace. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> --- drivers/staging/ccree/ssi_buffer_mgr.c | 3 +-- drivers/staging/ccree/ssi_pm.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c index 5c46145..3c74ae3 100644 --- a/drivers/staging/ccree/ssi_buffer_mgr.c +++ b/drivers/staging/ccree/ssi_buffer_mgr.c @@ -852,8 +852,7 @@ static inline int ssi_buffer_mgr_aead_chain_assoc( sg_index = current_sg->length; if (sg_index > size_of_assoc) { //the first entry in the scatter list contains all the associated data mapped_nents++; - } - else{ + } else { while (sg_index <= size_of_assoc) { current_sg = sg_next(current_sg); //if have reached the end of the sgl, then this is unexpected diff --git a/drivers/staging/ccree/ssi_pm.c b/drivers/staging/ccree/ssi_pm.c index c8c5875..ae1f7f0 100644 --- a/drivers/staging/ccree/ssi_pm.c +++ b/drivers/staging/ccree/ssi_pm.c @@ -110,8 +110,7 @@ int ssi_power_mgr_runtime_put_suspend(struct device *dev) (struct ssi_drvdata *)dev_get_drvdata(dev))) { pm_runtime_mark_last_busy(dev); rc = pm_runtime_put_autosuspend(dev); - } - else { + } else { /* Something wrong happens*/ BUG(); } -- 2.1.4 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2017-06-27 7:27 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-27 7:27 [PATCH 00/14] staging: ccree: coding style fixes Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-27 7:27 ` [PATCH 01/14] staging: ccree: fix missing or redundant spaces Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-27 7:27 ` [PATCH 02/14] staging: ccree: drop comparsion to true/false Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef [this message] 2017-06-27 7:27 ` [PATCH 03/14] staging: ccree: fix else placement Gilad Ben-Yossef 2017-06-27 7:27 ` [PATCH 04/14] staging: ccree: remove redundant blank lines Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-27 7:27 ` [PATCH 05/14] staging: ccree: no need for braces for single statements Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-27 7:27 ` [PATCH 06/14] staging: ccree: fix unmatched if/else braces Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-27 7:27 ` [PATCH 07/14] staging: ccree: remove comparisons to NULL Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-27 7:27 ` [PATCH 08/14] staging: ccree: fix pointer location Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-27 7:27 ` [PATCH 09/14] staging: ccree: remove custom type tdes_keys_t Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-27 7:27 ` [PATCH 10/14] staging: ccree: remove custom type ssi_fips_error_t Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-27 7:27 ` [PATCH 11/14] staging: ccree: remove custom type ssi_fips_state_t Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-27 7:27 ` [PATCH 12/14] staging: ccree: remove unused type CCFipsSyncStatus_t Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-27 7:27 ` [PATCH 13/14] staging: ccree: remove/add (un)needed blank lines Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-27 7:27 ` [PATCH 14/14] staging: ccree: fix block comment style Gilad Ben-Yossef 2017-06-27 7:27 ` Gilad Ben-Yossef 2017-06-29 14:38 ` Frans Klaver 2017-06-29 14:38 ` Frans Klaver 2017-06-29 14:38 ` Frans Klaver
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1498548449-10803-4-git-send-email-gilad@benyossef.com \ --to=gilad@benyossef.com \ --cc=devel@driverdev.osuosl.org \ --cc=driverdev-devel@linuxdriverproject.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ofir.drang@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.