* [PATCH] cifs: Do not modify mid entry after submitting I/O in cifs_call_async
@ 2017-06-28 17:50 ` Long Li
0 siblings, 0 replies; 2+ messages in thread
From: Long Li @ 2017-06-28 17:50 UTC (permalink / raw)
To: Steve French, linux-cifs-u79uwXL29TY76Z2rM5mHXA,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Long Li
From: Long Li <longli-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
In cifs_call_async, server response may return as soon as I/O is submitted.
Do not touch it after that.
Signed-off-by: Long Li <longli-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
---
fs/cifs/transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
index 47a125e..ba62aaf 100644
--- a/fs/cifs/transport.c
+++ b/fs/cifs/transport.c
@@ -537,10 +537,10 @@ cifs_call_async(struct TCP_Server_Info *server, struct smb_rqst *rqst,
spin_unlock(&GlobalMid_Lock);
+ cifs_save_when_sent(mid);
cifs_in_send_inc(server);
rc = smb_send_rqst(server, rqst, flags);
cifs_in_send_dec(server);
- cifs_save_when_sent(mid);
if (rc < 0) {
server->sequence_number -= 2;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] cifs: Do not modify mid entry after submitting I/O in cifs_call_async
@ 2017-06-28 17:50 ` Long Li
0 siblings, 0 replies; 2+ messages in thread
From: Long Li @ 2017-06-28 17:50 UTC (permalink / raw)
To: Steve French, linux-cifs, samba-technical, linux-kernel; +Cc: Long Li
From: Long Li <longli@microsoft.com>
In cifs_call_async, server response may return as soon as I/O is submitted.
Do not touch it after that.
Signed-off-by: Long Li <longli@microsoft.com>
---
fs/cifs/transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
index 47a125e..ba62aaf 100644
--- a/fs/cifs/transport.c
+++ b/fs/cifs/transport.c
@@ -537,10 +537,10 @@ cifs_call_async(struct TCP_Server_Info *server, struct smb_rqst *rqst,
spin_unlock(&GlobalMid_Lock);
+ cifs_save_when_sent(mid);
cifs_in_send_inc(server);
rc = smb_send_rqst(server, rqst, flags);
cifs_in_send_dec(server);
- cifs_save_when_sent(mid);
if (rc < 0) {
server->sequence_number -= 2;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-28 17:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-28 17:50 [PATCH] cifs: Do not modify mid entry after submitting I/O in cifs_call_async Long Li
2017-06-28 17:50 ` Long Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.