All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers/staging/media:  Prefer using  __func__ instead
@ 2017-06-29 11:29 Pushkar Jambhlekar
  2017-06-29 13:30 ` Joe Perches
  0 siblings, 1 reply; 2+ messages in thread
From: Pushkar Jambhlekar @ 2017-06-29 11:29 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, Greg Kroah-Hartman, Tamara Diaconita,
	Jasmin Jessich, Ralph Metzler, Pushkar Jambhlekar,
	Eva Rachel Retuya
  Cc: linux-media, devel, linux-kernel

Function name is hardcoded. replacing with __func__

Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
 drivers/staging/media/cxd2099/cxd2099.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/cxd2099/cxd2099.c b/drivers/staging/media/cxd2099/cxd2099.c
index f28916e..c866752 100644
--- a/drivers/staging/media/cxd2099/cxd2099.c
+++ b/drivers/staging/media/cxd2099/cxd2099.c
@@ -100,7 +100,7 @@ static int i2c_read_reg(struct i2c_adapter *adapter, u8 adr,
 				   .buf = val, .len = 1} };
 
 	if (i2c_transfer(adapter, msgs, 2) != 2) {
-		dev_err(&adapter->dev, "error in i2c_read_reg\n");
+		dev_err(&adapter->dev, "error in %s\n", __func__);
 		return -1;
 	}
 	return 0;
@@ -115,7 +115,7 @@ static int i2c_read(struct i2c_adapter *adapter, u8 adr,
 				   .buf = data, .len = n} };
 
 	if (i2c_transfer(adapter, msgs, 2) != 2) {
-		dev_err(&adapter->dev, "error in i2c_read\n");
+		dev_err(&adapter->dev, "error in %s\n",__func__);
 		return -1;
 	}
 	return 0;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/staging/media:  Prefer using  __func__ instead
  2017-06-29 11:29 [PATCH] drivers/staging/media: Prefer using __func__ instead Pushkar Jambhlekar
@ 2017-06-29 13:30 ` Joe Perches
  0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2017-06-29 13:30 UTC (permalink / raw)
  To: Pushkar Jambhlekar, Mauro Carvalho Chehab, Greg Kroah-Hartman,
	Tamara Diaconita, Jasmin Jessich, Ralph Metzler,
	Eva Rachel Retuya
  Cc: linux-media, devel, linux-kernel

On Thu, 2017-06-29 at 16:59 +0530, Pushkar Jambhlekar wrote:
> Function name is hardcoded. replacing with __func__

Please run your proposed patches through checkpatch
before you send them.

> diff --git a/drivers/staging/media/cxd2099/cxd2099.c b/drivers/staging/media/cxd2099/cxd2099.c
[]
> @@ -100,7 +100,7 @@ static int i2c_read_reg(struct i2c_adapter *adapter, u8 adr,
>  				   .buf = val, .len = 1} };
>  
>  	if (i2c_transfer(adapter, msgs, 2) != 2) {
> -		dev_err(&adapter->dev, "error in i2c_read_reg\n");
> +		dev_err(&adapter->dev, "error in %s\n", __func__);
>  		return -1;
>  	}
>  	return 0;
> @@ -115,7 +115,7 @@ static int i2c_read(struct i2c_adapter *adapter, u8 adr,
>  				   .buf = data, .len = n} };
>  
>  	if (i2c_transfer(adapter, msgs, 2) != 2) {
> -		dev_err(&adapter->dev, "error in i2c_read\n");
> +		dev_err(&adapter->dev, "error in %s\n",__func__);

There is a missing space before __func__.

As well, the form for listing a function name
is generally:

	print("%s: <error description>\n", __func__);

so ideally, these messages would be something like:

		dev_err(&adapter->dev, "%s: i2c_transfer error\n", __func__);

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-29 13:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-29 11:29 [PATCH] drivers/staging/media: Prefer using __func__ instead Pushkar Jambhlekar
2017-06-29 13:30 ` Joe Perches

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.