[PATCH 0/5] some devicetree changes for rk3288 boards

[PATCH 0/5] some devicetree changes for rk3288 boards

[Jacob Chen]

Since Guillaume have send patches for mali gpu node, let's enable it in more boards.

Jacob Chen (5):
  ARM: dts: rockchip: enable ARM Mali GPU on rk3288-tinker
  ARM: dts: rockchip: enable ARM Mali GPU on rk3288-evb
  ARM: dts: rockchip: enable ARM Mali GPU on rk3288-fennec
  ARM: dts: rockchip: enable saradc for rk3288-evb
  ARM: dts: rockchip: enable adc key for rk3288-evb

 arch/arm/boot/dts/rk3288-evb.dtsi   | 56 +++++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/rk3288-fennec.dts |  5 ++++
 arch/arm/boot/dts/rk3288-tinker.dts |  5 ++++
 3 files changed, 66 insertions(+)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/5] some devicetree changes for rk3288 boards

[Jacob Chen]

Since Guillaume have send patches for mali gpu node, let's enable it in more boards.

Jacob Chen (5):
  ARM: dts: rockchip: enable ARM Mali GPU on rk3288-tinker
  ARM: dts: rockchip: enable ARM Mali GPU on rk3288-evb
  ARM: dts: rockchip: enable ARM Mali GPU on rk3288-fennec
  ARM: dts: rockchip: enable saradc for rk3288-evb
  ARM: dts: rockchip: enable adc key for rk3288-evb

 arch/arm/boot/dts/rk3288-evb.dtsi   | 56 +++++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/rk3288-fennec.dts |  5 ++++
 arch/arm/boot/dts/rk3288-tinker.dts |  5 ++++
 3 files changed, 66 insertions(+)

-- 
2.7.4

[PATCH 1/5] ARM: dts: rockchip: enable ARM Mali GPU on rk3288-tinker

[Jacob Chen]

Add reference to the Mali GPU device tree node on rk3288-tinker.
Tested on Tinker board.

Signed-off-by: Jacob Chen <jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org>
---
 arch/arm/boot/dts/rk3288-tinker.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-tinker.dts b/arch/arm/boot/dts/rk3288-tinker.dts
index f601c78..ba0d0bf 100644
--- a/arch/arm/boot/dts/rk3288-tinker.dts
+++ b/arch/arm/boot/dts/rk3288-tinker.dts
@@ -156,6 +156,11 @@
 	status = "ok";
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu>;
+	status = "okay";
+};
+
 &hdmi {
 	ddc-i2c-bus = <&i2c5>;
 	status = "okay";
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/5] ARM: dts: rockchip: enable ARM Mali GPU on rk3288-tinker

[Jacob Chen]

Add reference to the Mali GPU device tree node on rk3288-tinker.
Tested on Tinker board.

Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com>
---
 arch/arm/boot/dts/rk3288-tinker.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-tinker.dts b/arch/arm/boot/dts/rk3288-tinker.dts
index f601c78..ba0d0bf 100644
--- a/arch/arm/boot/dts/rk3288-tinker.dts
+++ b/arch/arm/boot/dts/rk3288-tinker.dts
@@ -156,6 +156,11 @@
 	status = "ok";
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu>;
+	status = "okay";
+};
+
 &hdmi {
 	ddc-i2c-bus = <&i2c5>;
 	status = "okay";
-- 
2.7.4

[PATCH 2/5] ARM: dts: rockchip: enable ARM Mali GPU on rk3288-evb

[Jacob Chen]

Add reference to the Mali GPU device tree node on rk3288-evb.
Tested on rk3288-evb-act8846 board.

Signed-off-by: Jacob Chen <jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org>
---
 arch/arm/boot/dts/rk3288-evb.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
index 0dec94c..f226ca7 100644
--- a/arch/arm/boot/dts/rk3288-evb.dtsi
+++ b/arch/arm/boot/dts/rk3288-evb.dtsi
@@ -248,6 +248,11 @@
 	status = "ok";
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu>;
+	status = "okay";
+};
+
 &hdmi {
 	ddc-i2c-bus = <&i2c5>;
 	status = "okay";
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/5] ARM: dts: rockchip: enable ARM Mali GPU on rk3288-evb

[Jacob Chen]

Add reference to the Mali GPU device tree node on rk3288-evb.
Tested on rk3288-evb-act8846 board.

Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com>
---
 arch/arm/boot/dts/rk3288-evb.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
index 0dec94c..f226ca7 100644
--- a/arch/arm/boot/dts/rk3288-evb.dtsi
+++ b/arch/arm/boot/dts/rk3288-evb.dtsi
@@ -248,6 +248,11 @@
 	status = "ok";
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu>;
+	status = "okay";
+};
+
 &hdmi {
 	ddc-i2c-bus = <&i2c5>;
 	status = "okay";
-- 
2.7.4

[PATCH 3/5] ARM: dts: rockchip: enable ARM Mali GPU on rk3288-fennec

[Jacob Chen]

Add reference to the Mali GPU device tree node on rk3288-fennec
Tested on Fennec board.

Signed-off-by: Jacob Chen <jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org>
---
 arch/arm/boot/dts/rk3288-fennec.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-fennec.dts b/arch/arm/boot/dts/rk3288-fennec.dts
index 61d1c10..9ece328 100644
--- a/arch/arm/boot/dts/rk3288-fennec.dts
+++ b/arch/arm/boot/dts/rk3288-fennec.dts
@@ -99,6 +99,11 @@
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu>;
+	status = "okay";
+};
+
 &hdmi {
 	status = "okay";
 };
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/5] ARM: dts: rockchip: enable ARM Mali GPU on rk3288-fennec

[Jacob Chen]

Add reference to the Mali GPU device tree node on rk3288-fennec
Tested on Fennec board.

Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com>
---
 arch/arm/boot/dts/rk3288-fennec.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-fennec.dts b/arch/arm/boot/dts/rk3288-fennec.dts
index 61d1c10..9ece328 100644
--- a/arch/arm/boot/dts/rk3288-fennec.dts
+++ b/arch/arm/boot/dts/rk3288-fennec.dts
@@ -99,6 +99,11 @@
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu>;
+	status = "okay";
+};
+
 &hdmi {
 	status = "okay";
 };
-- 
2.7.4

[PATCH 4/5] ARM: dts: rockchip: enable saradc for rk3288-evb

[Jacob Chen]

saradc in rk3288-evb use 1.8v ref.

Signed-off-by: Jacob Chen <jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org>
---
 arch/arm/boot/dts/rk3288-evb.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
index f226ca7..9cee856 100644
--- a/arch/arm/boot/dts/rk3288-evb.dtsi
+++ b/arch/arm/boot/dts/rk3288-evb.dtsi
@@ -129,6 +129,15 @@
 		};
 	};
 
+	vccadc_ref: vccadc-ref {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc1v8_sys";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
+
 	/* This turns on USB vbus for both host0 (ehci) and host1 (dwc2) */
 	vcc_host: vcc-host-regulator {
 		compatible = "regulator-fixed";
@@ -218,6 +227,11 @@
 	status = "okay";
 };
 
+&saradc {
+	vref-supply = <&vccadc_ref>;
+	status = "okay";
+};
+
 &sdmmc {
 	bus-width = <4>;
 	cap-mmc-highspeed;
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 4/5] ARM: dts: rockchip: enable saradc for rk3288-evb

[Jacob Chen]

saradc in rk3288-evb use 1.8v ref.

Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com>
---
 arch/arm/boot/dts/rk3288-evb.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
index f226ca7..9cee856 100644
--- a/arch/arm/boot/dts/rk3288-evb.dtsi
+++ b/arch/arm/boot/dts/rk3288-evb.dtsi
@@ -129,6 +129,15 @@
 		};
 	};
 
+	vccadc_ref: vccadc-ref {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc1v8_sys";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
+
 	/* This turns on USB vbus for both host0 (ehci) and host1 (dwc2) */
 	vcc_host: vcc-host-regulator {
 		compatible = "regulator-fixed";
@@ -218,6 +227,11 @@
 	status = "okay";
 };
 
+&saradc {
+	vref-supply = <&vccadc_ref>;
+	status = "okay";
+};
+
 &sdmmc {
 	bus-width = <4>;
 	cap-mmc-highspeed;
-- 
2.7.4

[PATCH 5/5] ARM: dts: rockchip: enable adc key for rk3288-evb

[Jacob Chen]

rk3288-evb have many tablet-used adc buttons.

Signed-off-by: Jacob Chen <jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org>
---
 arch/arm/boot/dts/rk3288-evb.dtsi | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
index 9cee856..835ddb8 100644
--- a/arch/arm/boot/dts/rk3288-evb.dtsi
+++ b/arch/arm/boot/dts/rk3288-evb.dtsi
@@ -48,6 +48,43 @@
 		reg = <0x0 0x80000000>;
 	};
 
+	adc-keys {
+		compatible = "adc-keys";
+		io-channels = <&saradc 1>;
+		io-channel-names = "buttons";
+		keyup-threshold-microvolt = <1800000>;
+
+		button-up {
+			label = "Volume Up";
+			linux,code = <KEY_VOLUMEUP>;
+			press-threshold-microvolt = <100000>;
+		};
+
+		button-down {
+			label = "Volume Down";
+			linux,code = <KEY_VOLUMEDOWN>;
+			press-threshold-microvolt = <300000>;
+		};
+
+		menu {
+			label = "Menu";
+			linux,code = <KEY_MENU>;
+			press-threshold-microvolt = <640000>;
+		};
+
+		esc {
+			label = "Esc";
+			linux,code = <KEY_ESC>;
+			press-threshold-microvolt = <1000000>;
+		};
+
+		home  {
+			label = "Home";
+			linux,code = <KEY_HOME>;
+			press-threshold-microvolt = <1300000>;
+		};
+	};
+
 	backlight: backlight {
 		compatible = "pwm-backlight";
 		brightness-levels = <
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 5/5] ARM: dts: rockchip: enable adc key for rk3288-evb

[Jacob Chen]

rk3288-evb have many tablet-used adc buttons.

Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com>
---
 arch/arm/boot/dts/rk3288-evb.dtsi | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
index 9cee856..835ddb8 100644
--- a/arch/arm/boot/dts/rk3288-evb.dtsi
+++ b/arch/arm/boot/dts/rk3288-evb.dtsi
@@ -48,6 +48,43 @@
 		reg = <0x0 0x80000000>;
 	};
 
+	adc-keys {
+		compatible = "adc-keys";
+		io-channels = <&saradc 1>;
+		io-channel-names = "buttons";
+		keyup-threshold-microvolt = <1800000>;
+
+		button-up {
+			label = "Volume Up";
+			linux,code = <KEY_VOLUMEUP>;
+			press-threshold-microvolt = <100000>;
+		};
+
+		button-down {
+			label = "Volume Down";
+			linux,code = <KEY_VOLUMEDOWN>;
+			press-threshold-microvolt = <300000>;
+		};
+
+		menu {
+			label = "Menu";
+			linux,code = <KEY_MENU>;
+			press-threshold-microvolt = <640000>;
+		};
+
+		esc {
+			label = "Esc";
+			linux,code = <KEY_ESC>;
+			press-threshold-microvolt = <1000000>;
+		};
+
+		home  {
+			label = "Home";
+			linux,code = <KEY_HOME>;
+			press-threshold-microvolt = <1300000>;
+		};
+	};
+
 	backlight: backlight {
 		compatible = "pwm-backlight";
 		brightness-levels = <
-- 
2.7.4

Re: [PATCH 4/5] ARM: dts: rockchip: enable saradc for rk3288-evb

[Heiko Stuebner]

Hi Jacob,

Am Samstag, 1. Juli 2017, 10:02:46 CEST schrieb Jacob Chen:
> saradc in rk3288-evb use 1.8v ref.
> 
> Signed-off-by: Jacob Chen <jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org>
> ---
>  arch/arm/boot/dts/rk3288-evb.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
> index f226ca7..9cee856 100644
> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
> @@ -129,6 +129,15 @@
>  		};
>  	};
>  
> +	vccadc_ref: vccadc-ref {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc1v8_sys";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +	};

this looks wrong. Regulators should always be named with the name
used in schematics and also, according to the rk3288-evb schematics
I have here, the saradc uses vcc_18 directly which comes from either
the rk808 or act8846 pmics (depending on the board version).

> +
>  	/* This turns on USB vbus for both host0 (ehci) and host1 (dwc2) */
>  	vcc_host: vcc-host-regulator {
>  		compatible = "regulator-fixed";
> @@ -218,6 +227,11 @@
>  	status = "okay";
>  };
>  
> +&saradc {
> +	vref-supply = <&vccadc_ref>;

So taking the above into account
	vref-supply = <&vcc_18>; ?


Heiko

> +	status = "okay";
> +};
> +
>  &sdmmc {
>  	bus-width = <4>;
>  	cap-mmc-highspeed;
> 


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 4/5] ARM: dts: rockchip: enable saradc for rk3288-evb

[Heiko Stuebner]

Hi Jacob,

Am Samstag, 1. Juli 2017, 10:02:46 CEST schrieb Jacob Chen:
> saradc in rk3288-evb use 1.8v ref.
> 
> Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com>
> ---
>  arch/arm/boot/dts/rk3288-evb.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
> index f226ca7..9cee856 100644
> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
> @@ -129,6 +129,15 @@
>  		};
>  	};
>  
> +	vccadc_ref: vccadc-ref {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc1v8_sys";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +	};

this looks wrong. Regulators should always be named with the name
used in schematics and also, according to the rk3288-evb schematics
I have here, the saradc uses vcc_18 directly which comes from either
the rk808 or act8846 pmics (depending on the board version).

> +
>  	/* This turns on USB vbus for both host0 (ehci) and host1 (dwc2) */
>  	vcc_host: vcc-host-regulator {
>  		compatible = "regulator-fixed";
> @@ -218,6 +227,11 @@
>  	status = "okay";
>  };
>  
> +&saradc {
> +	vref-supply = <&vccadc_ref>;

So taking the above into account
	vref-supply = <&vcc_18>; ?


Heiko

> +	status = "okay";
> +};
> +
>  &sdmmc {
>  	bus-width = <4>;
>  	cap-mmc-highspeed;
> 

Re: [PATCH 4/5] ARM: dts: rockchip: enable saradc for rk3288-evb

[chen]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8; format=flowed, Size: 1691 bytes --]

Hi heiko,


Heiko Stuebner wrote on 2017年07月01日 19:06:
> Hi Jacob,
>
> Am Samstag, 1. Juli 2017, 10:02:46 CEST schrieb Jacob Chen:
>> saradc in rk3288-evb use 1.8v ref.
>>
>> Signed-off-by: Jacob Chen <jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org>
>> ---
>>   arch/arm/boot/dts/rk3288-evb.dtsi | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
>> index f226ca7..9cee856 100644
>> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
>> @@ -129,6 +129,15 @@
>>   		};
>>   	};
>>   
>> +	vccadc_ref: vccadc-ref {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vcc1v8_sys";
>> +		regulator-always-on;
>> +		regulator-boot-on;
>> +		regulator-min-microvolt = <1800000>;
>> +		regulator-max-microvolt = <1800000>;
>> +	};
> this looks wrong. Regulators should always be named with the name
> used in schematics and also, according to the rk3288-evb schematics
> I have here, the saradc uses vcc_18 directly which comes from either
> the rk808 or act8846 pmics (depending on the board version).
>

OK,  I don't have software to check that schematics...
Agree and i will send a new patch.

>> +
>>   	/* This turns on USB vbus for both host0 (ehci) and host1 (dwc2) */
>>   	vcc_host: vcc-host-regulator {
>>   		compatible = "regulator-fixed";
>> @@ -218,6 +227,11 @@
>>   	status = "okay";
>>   };
>>   
>> +&saradc {
>> +	vref-supply = <&vccadc_ref>;
> So taking the above into account
> 	vref-supply = <&vcc_18>; ?
>
>
> Heiko
>
>> +	status = "okay";
>> +};
>> +
>>   &sdmmc {
>>   	bus-width = <4>;
>>   	cap-mmc-highspeed;
>>
>
>


TÑ\v


[-- Attachment #2: Type: text/plain, Size: 200 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

[PATCH 4/5] ARM: dts: rockchip: enable saradc for rk3288-evb

[chen]

Hi heiko,


Heiko Stuebner wrote on 2017?07?01? 19:06:
> Hi Jacob,
>
> Am Samstag, 1. Juli 2017, 10:02:46 CEST schrieb Jacob Chen:
>> saradc in rk3288-evb use 1.8v ref.
>>
>> Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com>
>> ---
>>   arch/arm/boot/dts/rk3288-evb.dtsi | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
>> index f226ca7..9cee856 100644
>> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
>> @@ -129,6 +129,15 @@
>>   		};
>>   	};
>>   
>> +	vccadc_ref: vccadc-ref {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vcc1v8_sys";
>> +		regulator-always-on;
>> +		regulator-boot-on;
>> +		regulator-min-microvolt = <1800000>;
>> +		regulator-max-microvolt = <1800000>;
>> +	};
> this looks wrong. Regulators should always be named with the name
> used in schematics and also, according to the rk3288-evb schematics
> I have here, the saradc uses vcc_18 directly which comes from either
> the rk808 or act8846 pmics (depending on the board version).
>

OK,  I don't have software to check that schematics...
Agree and i will send a new patch.

>> +
>>   	/* This turns on USB vbus for both host0 (ehci) and host1 (dwc2) */
>>   	vcc_host: vcc-host-regulator {
>>   		compatible = "regulator-fixed";
>> @@ -218,6 +227,11 @@
>>   	status = "okay";
>>   };
>>   
>> +&saradc {
>> +	vref-supply = <&vccadc_ref>;
> So taking the above into account
> 	vref-supply = <&vcc_18>; ?
>
>
> Heiko
>
>> +	status = "okay";
>> +};
>> +
>>   &sdmmc {
>>   	bus-width = <4>;
>>   	cap-mmc-highspeed;
>>
>
>

Re: [PATCH 0/5] some devicetree changes for rk3288 boards

[Heiko Stuebner]

Am Samstag, 1. Juli 2017, 10:02:42 CEST schrieb Jacob Chen:
> Since Guillaume have send patches for mali gpu node, let's enable it in more boards.
> 
> Jacob Chen (5):
>   ARM: dts: rockchip: enable ARM Mali GPU on rk3288-tinker
>   ARM: dts: rockchip: enable ARM Mali GPU on rk3288-evb
>   ARM: dts: rockchip: enable ARM Mali GPU on rk3288-fennec
>   ARM: dts: rockchip: enable saradc for rk3288-evb
>   ARM: dts: rockchip: enable adc key for rk3288-evb

applied for 4.14, with the saradc patch replaced with your v2


Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/5] some devicetree changes for rk3288 boards

[Heiko Stuebner]

Am Samstag, 1. Juli 2017, 10:02:42 CEST schrieb Jacob Chen:
> Since Guillaume have send patches for mali gpu node, let's enable it in more boards.
> 
> Jacob Chen (5):
>   ARM: dts: rockchip: enable ARM Mali GPU on rk3288-tinker
>   ARM: dts: rockchip: enable ARM Mali GPU on rk3288-evb
>   ARM: dts: rockchip: enable ARM Mali GPU on rk3288-fennec
>   ARM: dts: rockchip: enable saradc for rk3288-evb
>   ARM: dts: rockchip: enable adc key for rk3288-evb

applied for 4.14, with the saradc patch replaced with your v2


Heiko