* [PATCH] netxen_nic: Remove unused pointer hdr in netxen_setup_minidump()
@ 2017-07-02 22:16 Christos Gkekas
2017-07-03 9:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Christos Gkekas @ 2017-07-02 22:16 UTC (permalink / raw)
To: Manish Chopra, Rahul Verma, Dept-GELinuxNICDev, netdev, linux-kernel
Cc: Christos Gkekas
Pointer hdr in netxen_setup_minidump() is set but never used, thus
should be removed.
Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c
index e306765..6cec2a6 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c
@@ -174,7 +174,6 @@ netxen_setup_minidump(struct netxen_adapter *adapter)
{
int err = 0, i;
u32 *template, *tmp_buf;
- struct netxen_minidump_template_hdr *hdr;
err = netxen_get_minidump_template_size(adapter);
if (err) {
adapter->mdump.fw_supports_md = 0;
@@ -218,8 +217,6 @@ netxen_setup_minidump(struct netxen_adapter *adapter)
template = (u32 *) adapter->mdump.md_template;
for (i = 0; i < adapter->mdump.md_template_size/sizeof(u32); i++)
*template++ = __le32_to_cpu(*tmp_buf++);
- hdr = (struct netxen_minidump_template_hdr *)
- adapter->mdump.md_template;
adapter->mdump.md_capture_buff = NULL;
adapter->mdump.fw_supports_md = 1;
adapter->mdump.md_enabled = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netxen_nic: Remove unused pointer hdr in netxen_setup_minidump()
2017-07-02 22:16 [PATCH] netxen_nic: Remove unused pointer hdr in netxen_setup_minidump() Christos Gkekas
@ 2017-07-03 9:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-07-03 9:38 UTC (permalink / raw)
To: chris.gekas
Cc: manish.chopra, rahul.verma, Dept-GELinuxNICDev, netdev, linux-kernel
From: Christos Gkekas <chris.gekas@gmail.com>
Date: Sun, 2 Jul 2017 23:16:11 +0100
> Pointer hdr in netxen_setup_minidump() is set but never used, thus
> should be removed.
>
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-03 9:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-02 22:16 [PATCH] netxen_nic: Remove unused pointer hdr in netxen_setup_minidump() Christos Gkekas
2017-07-03 9:38 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.