[PATCH 00/14] clean up drm_bridge_add

[PATCH 00/14] clean up drm_bridge_add

[Inki Dae]

This patch series changes return type of drm_bridge_add
function to void one and also removes unnecessary checking
of the return type from relevant drivers.

Ps. I had just build test so each maintainer may need to check this.

Inki Dae (14):
  drm/bridge: change return type of drm_bridge_add function
  drm/bridge: adv7511: clean up drm_bridge_add call
  drm/bridge: analogix-anx78xx: clean up drm_bridge_add call
  drm/bridge: vga-dac: clean up drm_bridge_add call
  drm/bridge: nxp-ptn3460: clean up drm_bridge_add call
  drm/bridge: panel: clean up drm_bridge_add call
  drm/bridge: ps8622: clean up drm_bridge_add call
  drm/bridge: sii902x: clean up drm_bridge_add call
  drm/bridge: synopsys: dw-hdmi: clean up drm_bridge_add call
  drm/bridge: tc358767: clean up drm_bridge_add call
  drm/bridge: ti-tfp410: clean up drm_bridge_add call
  drm/exynos: mic: clean up drm_bridge_add call
  drm/mediatek: hdmi: clean up drm_bridge_add call
  drm/sti: sti_vdo: clean up drm_bridge_add call

 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 +-----
 drivers/gpu/drm/bridge/analogix-anx78xx.c    | 6 +-----
 drivers/gpu/drm/bridge/dumb-vga-dac.c        | 9 +++------
 drivers/gpu/drm/bridge/nxp-ptn3460.c         | 6 +-----
 drivers/gpu/drm/bridge/panel.c               | 5 +----
 drivers/gpu/drm/bridge/parade-ps8622.c       | 6 +-----
 drivers/gpu/drm/bridge/sii902x.c             | 6 +-----
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c    | 7 +------
 drivers/gpu/drm/bridge/tc358767.c            | 6 +-----
 drivers/gpu/drm/bridge/ti-tfp410.c           | 6 +-----
 drivers/gpu/drm/drm_bridge.c                 | 7 +------
 drivers/gpu/drm/exynos/exynos_drm_mic.c      | 6 +-----
 drivers/gpu/drm/mediatek/mtk_hdmi.c          | 6 +-----
 drivers/gpu/drm/sti/sti_dvo.c                | 6 +-----
 include/drm/drm_bridge.h                     | 2 +-
 15 files changed, 17 insertions(+), 73 deletions(-)

-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 01/14] drm/bridge: change return type of drm_bridge_add function

[Inki Dae]

This patch changes return type of drm_bridge_add function.

This function never return negative value but returns only 0.
So it changes the return type of this function to void one.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/drm_bridge.c | 7 +------
 include/drm/drm_bridge.h     | 2 +-
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index dc8cdfe..1638bfe 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -67,17 +67,12 @@
  * drm_bridge_add - add the given bridge to the global bridge list
  *
  * @bridge: bridge control structure
- *
- * RETURNS:
- * Unconditionally returns Zero.
  */
-int drm_bridge_add(struct drm_bridge *bridge)
+void drm_bridge_add(struct drm_bridge *bridge)
 {
 	mutex_lock(&bridge_lock);
 	list_add_tail(&bridge->list, &bridge_list);
 	mutex_unlock(&bridge_lock);
-
-	return 0;
 }
 EXPORT_SYMBOL(drm_bridge_add);
 
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index 1dc94d5..4254423 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -245,7 +245,7 @@ struct drm_bridge {
 	void *driver_private;
 };
 
-int drm_bridge_add(struct drm_bridge *bridge);
+void drm_bridge_add(struct drm_bridge *bridge);
 void drm_bridge_remove(struct drm_bridge *bridge);
 struct drm_bridge *of_drm_find_bridge(struct device_node *np);
 int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 02/14] drm/bridge: adv7511: clean up drm_bridge_add call

[Inki Dae]

This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index f75ab62..ff9792d 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -1126,11 +1126,7 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
 	adv7511->bridge.funcs = &adv7511_bridge_funcs;
 	adv7511->bridge.of_node = dev->of_node;
 
-	ret = drm_bridge_add(&adv7511->bridge);
-	if (ret) {
-		dev_err(dev, "failed to add adv7511 bridge\n");
-		goto err_unregister_cec;
-	}
+	drm_bridge_add(&adv7511->bridge);
 
 	adv7511_audio_init(dev, adv7511);
 
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 03/14] drm/bridge: analogix-anx78xx: clean up drm_bridge_add call

[Inki Dae]

This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/bridge/analogix-anx78xx.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix-anx78xx.c
index 9006578..c2fac39 100644
--- a/drivers/gpu/drm/bridge/analogix-anx78xx.c
+++ b/drivers/gpu/drm/bridge/analogix-anx78xx.c
@@ -1438,11 +1438,7 @@ static int anx78xx_i2c_probe(struct i2c_client *client,
 
 	anx78xx->bridge.funcs = &anx78xx_bridge_funcs;
 
-	err = drm_bridge_add(&anx78xx->bridge);
-	if (err < 0) {
-		DRM_ERROR("Failed to add drm bridge: %d\n", err);
-		goto err_poweroff;
-	}
+	drm_bridge_add(&anx78xx->bridge);
 
 	/* If cable is pulled out, just poweroff and wait for HPD event */
 	if (!gpiod_get_value(anx78xx->pdata.gpiod_hpd))
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 04/14] drm/bridge: vga-dac: clean up drm_bridge_add call

[Inki Dae]

This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/bridge/dumb-vga-dac.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c
index 831a606..8a52539 100644
--- a/drivers/gpu/drm/bridge/dumb-vga-dac.c
+++ b/drivers/gpu/drm/bridge/dumb-vga-dac.c
@@ -177,7 +177,6 @@ static struct i2c_adapter *dumb_vga_retrieve_ddc(struct device *dev)
 static int dumb_vga_probe(struct platform_device *pdev)
 {
 	struct dumb_vga *vga;
-	int ret;
 
 	vga = devm_kzalloc(&pdev->dev, sizeof(*vga), GFP_KERNEL);
 	if (!vga)
@@ -186,7 +185,7 @@ static int dumb_vga_probe(struct platform_device *pdev)
 
 	vga->vdd = devm_regulator_get_optional(&pdev->dev, "vdd");
 	if (IS_ERR(vga->vdd)) {
-		ret = PTR_ERR(vga->vdd);
+		int ret = PTR_ERR(vga->vdd);
 		if (ret == -EPROBE_DEFER)
 			return -EPROBE_DEFER;
 		vga->vdd = NULL;
@@ -207,11 +206,9 @@ static int dumb_vga_probe(struct platform_device *pdev)
 	vga->bridge.funcs = &dumb_vga_bridge_funcs;
 	vga->bridge.of_node = pdev->dev.of_node;
 
-	ret = drm_bridge_add(&vga->bridge);
-	if (ret && !IS_ERR(vga->ddc))
-		i2c_put_adapter(vga->ddc);
+	drm_bridge_add(&vga->bridge);
 
-	return ret;
+	return 0;
 }
 
 static int dumb_vga_remove(struct platform_device *pdev)
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 05/14] drm/bridge: nxp-ptn3460: clean up drm_bridge_add call

[Inki Dae]

This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/bridge/nxp-ptn3460.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c
index 4f64e71..f0b5d0f 100644
--- a/drivers/gpu/drm/bridge/nxp-ptn3460.c
+++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c
@@ -332,11 +332,7 @@ static int ptn3460_probe(struct i2c_client *client,
 
 	ptn_bridge->bridge.funcs = &ptn3460_bridge_funcs;
 	ptn_bridge->bridge.of_node = dev->of_node;
-	ret = drm_bridge_add(&ptn_bridge->bridge);
-	if (ret) {
-		DRM_ERROR("Failed to add bridge\n");
-		return ret;
-	}
+	drm_bridge_add(&ptn_bridge->bridge);
 
 	i2c_set_clientdata(client, ptn_bridge);
 
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 06/14] drm/bridge: panel: clean up drm_bridge_add call

[Inki Dae]

This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/bridge/panel.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 99f9a4b..65ab28c 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -158,7 +158,6 @@ struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel,
 					u32 connector_type)
 {
 	struct panel_bridge *panel_bridge;
-	int ret;
 
 	if (!panel)
 		return ERR_PTR(EINVAL);
@@ -176,9 +175,7 @@ struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel,
 	panel_bridge->bridge.of_node = panel->dev->of_node;
 #endif
 
-	ret = drm_bridge_add(&panel_bridge->bridge);
-	if (ret)
-		return ERR_PTR(ret);
+	drm_bridge_add(&panel_bridge->bridge);
 
 	return &panel_bridge->bridge;
 }
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 07/14] drm/bridge: ps8622: clean up drm_bridge_add call

[Inki Dae]

This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/bridge/parade-ps8622.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
index 6f22f9f..4f7725d 100644
--- a/drivers/gpu/drm/bridge/parade-ps8622.c
+++ b/drivers/gpu/drm/bridge/parade-ps8622.c
@@ -598,11 +598,7 @@ static int ps8622_probe(struct i2c_client *client,
 
 	ps8622->bridge.funcs = &ps8622_bridge_funcs;
 	ps8622->bridge.of_node = dev->of_node;
-	ret = drm_bridge_add(&ps8622->bridge);
-	if (ret) {
-		DRM_ERROR("Failed to add bridge\n");
-		return ret;
-	}
+	drm_bridge_add(&ps8622->bridge);
 
 	i2c_set_clientdata(client, ps8622);
 
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 08/14] drm/bridge: sii902x: clean up drm_bridge_add call

[Inki Dae]

This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/bridge/sii902x.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index 9b87067..b8d10e5 100644
--- a/drivers/gpu/drm/bridge/sii902x.c
+++ b/drivers/gpu/drm/bridge/sii902x.c
@@ -418,11 +418,7 @@ static int sii902x_probe(struct i2c_client *client,
 
 	sii902x->bridge.funcs = &sii902x_bridge_funcs;
 	sii902x->bridge.of_node = dev->of_node;
-	ret = drm_bridge_add(&sii902x->bridge);
-	if (ret) {
-		dev_err(dev, "Failed to add drm_bridge\n");
-		return ret;
-	}
+	drm_bridge_add(&sii902x->bridge);
 
 	i2c_set_clientdata(client, sii902x);
 
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 09/14] drm/bridge: synopsys: dw-hdmi: clean up drm_bridge_add call

[Inki Dae]

This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index ead1124..de1308b 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -2485,17 +2485,12 @@ int dw_hdmi_probe(struct platform_device *pdev,
 		  const struct dw_hdmi_plat_data *plat_data)
 {
 	struct dw_hdmi *hdmi;
-	int ret;
 
 	hdmi = __dw_hdmi_probe(pdev, plat_data);
 	if (IS_ERR(hdmi))
 		return PTR_ERR(hdmi);
 
-	ret = drm_bridge_add(&hdmi->bridge);
-	if (ret < 0) {
-		__dw_hdmi_remove(hdmi);
-		return ret;
-	}
+	drm_bridge_add(&hdmi->bridge);
 
 	return 0;
 }
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 10/14] drm/bridge: tc358767: clean up drm_bridge_add call

[Inki Dae]

This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/bridge/tc358767.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 5c26488..12a35f9 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -1325,11 +1325,7 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id)
 
 	tc->bridge.funcs = &tc_bridge_funcs;
 	tc->bridge.of_node = dev->of_node;
-	ret = drm_bridge_add(&tc->bridge);
-	if (ret) {
-		dev_err(dev, "Failed to add drm_bridge: %d\n", ret);
-		goto err_unregister_aux;
-	}
+	drm_bridge_add(&tc->bridge);
 
 	i2c_set_clientdata(client, tc);
 
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 11/14] drm/bridge: ti-tfp410: clean up drm_bridge_add call

[Inki Dae]

This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/bridge/ti-tfp410.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
index eee4efd..7ea2a15 100644
--- a/drivers/gpu/drm/bridge/ti-tfp410.c
+++ b/drivers/gpu/drm/bridge/ti-tfp410.c
@@ -237,11 +237,7 @@ static int tfp410_init(struct device *dev)
 		}
 	}
 
-	ret = drm_bridge_add(&dvi->bridge);
-	if (ret) {
-		dev_err(dev, "drm_bridge_add() failed: %d\n", ret);
-		goto fail;
-	}
+	drm_bridge_add(&dvi->bridge);
 
 	return 0;
 fail:
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

[Inki Dae]

This patch removes unnecessary checking of return value.

Ps. this patch depends on below one,
	http://www.spinics.net/lists/dri-devel/msg145687.html

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
index 5ea6e3d..07bd7fc 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
@@ -458,11 +458,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
 	mic->bridge.funcs = &mic_bridge_funcs;
 	mic->bridge.of_node = dev->of_node;
 
-	ret = drm_bridge_add(&mic->bridge);
-	if (ret) {
-		DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
-		return ret;
-	}
+	drm_bridge_add(&mic->bridge);
 
 	pm_runtime_enable(dev);
 
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 13/14] drm/mediatek: hdmi: clean up drm_bridge_add call

[Inki Dae]

This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index 0a4ffd7..62652ee 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -1697,11 +1697,7 @@ static int mtk_drm_hdmi_probe(struct platform_device *pdev)
 
 	hdmi->bridge.funcs = &mtk_hdmi_bridge_funcs;
 	hdmi->bridge.of_node = pdev->dev.of_node;
-	ret = drm_bridge_add(&hdmi->bridge);
-	if (ret) {
-		dev_err(dev, "failed to add bridge, ret = %d\n", ret);
-		return ret;
-	}
+	drm_bridge_add(&hdmi->bridge);
 
 	ret = mtk_hdmi_clk_enable_audio(hdmi);
 	if (ret) {
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 14/14] drm/sti: sti_vdo: clean up drm_bridge_add call

[Inki Dae]

This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/sti/sti_dvo.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
index 24ebc6b..dcc2c22 100644
--- a/drivers/gpu/drm/sti/sti_dvo.c
+++ b/drivers/gpu/drm/sti/sti_dvo.c
@@ -464,11 +464,7 @@ static int sti_dvo_bind(struct device *dev, struct device *master, void *data)
 	bridge->driver_private = dvo;
 	bridge->funcs = &sti_dvo_bridge_funcs;
 	bridge->of_node = dvo->dev.of_node;
-	err = drm_bridge_add(bridge);
-	if (err) {
-		DRM_ERROR("Failed to add bridge\n");
-		return err;
-	}
+	drm_bridge_add(bridge);
 
 	err = drm_bridge_attach(encoder, bridge, NULL);
 	if (err) {
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 01/14] drm/bridge: change return type of drm_bridge_add function

[Emil Velikov]

Hi Inki,

On 3 July 2017 at 09:42, Inki Dae <inki.dae@samsung.com> wrote:
> This patch changes return type of drm_bridge_add function.
>
> This function never return negative value but returns only 0.
> So it changes the return type of this function to void one.
>
This patch should be the final in the series. Otherwise you'll get the
following build error for each call site.

"error: void value not ignored as it ought to be"

Regards,
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

[Archit Taneja]

On 07/03/2017 02:12 PM, Inki Dae wrote:
> This patch removes unnecessary checking of return value.
> 
> Ps. this patch depends on below one,
> 	http://www.spinics.net/lists/dri-devel/msg145687.html

Will this one^ go via the exynos pull req or drm-misc? If there won't
be any conflicts, we could get both the patches through drm-misc to
keep things simple.

Archit

> 
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
>   drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index 5ea6e3d..07bd7fc 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -458,11 +458,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>   	mic->bridge.funcs = &mic_bridge_funcs;
>   	mic->bridge.of_node = dev->of_node;
>   
> -	ret = drm_bridge_add(&mic->bridge);
> -	if (ret) {
> -		DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
> -		return ret;
> -	}
> +	drm_bridge_add(&mic->bridge);
>   
>   	pm_runtime_enable(dev);
>   
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 13/14] drm/mediatek: hdmi: clean up drm_bridge_add call

[Archit Taneja]

On 07/03/2017 02:12 PM, Inki Dae wrote:
> This patch removes unnecessary checking of return value.

Can I get an ack from the maintainers to get this pulled in
via drm-misc?

Thanks,
Archit

> 
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
>   drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 0a4ffd7..62652ee 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1697,11 +1697,7 @@ static int mtk_drm_hdmi_probe(struct platform_device *pdev)
>   
>   	hdmi->bridge.funcs = &mtk_hdmi_bridge_funcs;
>   	hdmi->bridge.of_node = pdev->dev.of_node;
> -	ret = drm_bridge_add(&hdmi->bridge);
> -	if (ret) {
> -		dev_err(dev, "failed to add bridge, ret = %d\n", ret);
> -		return ret;
> -	}
> +	drm_bridge_add(&hdmi->bridge);
>   
>   	ret = mtk_hdmi_clk_enable_audio(hdmi);
>   	if (ret) {
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

[Inki Dae]

2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글:
> 
> 
> On 07/03/2017 02:12 PM, Inki Dae wrote:
>> This patch removes unnecessary checking of return value.
>>
>> Ps. this patch depends on below one,
>>     http://www.spinics.net/lists/dri-devel/msg145687.html
> 
> Will this one^ go via the exynos pull req or drm-misc? If there won't
> be any conflicts, we could get both the patches through drm-misc to
> keep things simple.

exynos pull it would be better. I will pick this up. :)

Thanks,
Inki Dae

> 
> Archit
> 
>>
>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>> ---
>>   drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
>>   1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>> index 5ea6e3d..07bd7fc 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>> @@ -458,11 +458,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>>       mic->bridge.funcs = &mic_bridge_funcs;
>>       mic->bridge.of_node = dev->of_node;
>>   -    ret = drm_bridge_add(&mic->bridge);
>> -    if (ret) {
>> -        DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
>> -        return ret;
>> -    }
>> +    drm_bridge_add(&mic->bridge);
>>         pm_runtime_enable(dev);
>>  
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

[Archit Taneja]

On 07/05/2017 02:35 PM, Inki Dae wrote:
> 
> 
> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글:
>>
>>
>> On 07/03/2017 02:12 PM, Inki Dae wrote:
>>> This patch removes unnecessary checking of return value.
>>>
>>> Ps. this patch depends on below one,
>>>      http://www.spinics.net/lists/dri-devel/msg145687.html
>>
>> Will this one^ go via the exynos pull req or drm-misc? If there won't
>> be any conflicts, we could get both the patches through drm-misc to
>> keep things simple.
> 
> exynos pull it would be better. I will pick this up. :)

If patch # 1/14 goes through drm-misc, and the exynos patch goes through
exynos pull, the drm-misc branch would break. That's the reason I
preferred the exynos patches to go via misc.

Thanks,
Archit

> 
> Thanks,
> Inki Dae
> 
>>
>> Archit
>>
>>>
>>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>>> ---
>>>    drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
>>>    1 file changed, 1 insertion(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>> index 5ea6e3d..07bd7fc 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>> @@ -458,11 +458,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>>>        mic->bridge.funcs = &mic_bridge_funcs;
>>>        mic->bridge.of_node = dev->of_node;
>>>    -    ret = drm_bridge_add(&mic->bridge);
>>> -    if (ret) {
>>> -        DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
>>> -        return ret;
>>> -    }
>>> +    drm_bridge_add(&mic->bridge);
>>>          pm_runtime_enable(dev);
>>>   
>>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

[Emil Velikov]

On 5 July 2017 at 10:14, Archit Taneja <architt@codeaurora.org> wrote:
>
>
> On 07/05/2017 02:35 PM, Inki Dae wrote:
>>
>>
>>
>> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글:
>>>
>>>
>>>
>>> On 07/03/2017 02:12 PM, Inki Dae wrote:
>>>>
>>>> This patch removes unnecessary checking of return value.
>>>>
>>>> Ps. this patch depends on below one,
>>>>      http://www.spinics.net/lists/dri-devel/msg145687.html
>>>
>>>
>>> Will this one^ go via the exynos pull req or drm-misc? If there won't
>>> be any conflicts, we could get both the patches through drm-misc to
>>> keep things simple.
>>
>>
>> exynos pull it would be better. I will pick this up. :)
>
>
> If patch # 1/14 goes through drm-misc, and the exynos patch goes through
> exynos pull, the drm-misc branch would break. That's the reason I
> preferred the exynos patches to go via misc.
>
As mentioned in 1/14:

If 1/14 is applied before the rest of the series all the drivers
(addressed with 2-14) will fail to build.
I think...

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

[Archit Taneja]

On 07/05/2017 04:42 PM, Emil Velikov wrote:
> On 5 July 2017 at 10:14, Archit Taneja <architt@codeaurora.org> wrote:
>>
>>
>> On 07/05/2017 02:35 PM, Inki Dae wrote:
>>>
>>>
>>>
>>> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글:
>>>>
>>>>
>>>>
>>>> On 07/03/2017 02:12 PM, Inki Dae wrote:
>>>>>
>>>>> This patch removes unnecessary checking of return value.
>>>>>
>>>>> Ps. this patch depends on below one,
>>>>>       http://www.spinics.net/lists/dri-devel/msg145687.html
>>>>
>>>>
>>>> Will this one^ go via the exynos pull req or drm-misc? If there won't
>>>> be any conflicts, we could get both the patches through drm-misc to
>>>> keep things simple.
>>>
>>>
>>> exynos pull it would be better. I will pick this up. :)
>>
>>
>> If patch # 1/14 goes through drm-misc, and the exynos patch goes through
>> exynos pull, the drm-misc branch would break. That's the reason I
>> preferred the exynos patches to go via misc.
>>
> As mentioned in 1/14:
> 
> If 1/14 is applied before the rest of the series all the drivers
> (addressed with 2-14) will fail to build.
> I think...

Yeah, they would. We'd want to push 1/14 right at the end. Getting all
the ones from 2-14 via drm-misc would make life simpler.

Archit

> 
> -Emil
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 00/14] clean up drm_bridge_add

[Archit Taneja]

On 07/03/2017 02:12 PM, Inki Dae wrote:
> This patch series changes return type of drm_bridge_add
> function to void one and also removes unnecessary checking
> of the return type from relevant drivers.
> 
> Ps. I had just build test so each maintainer may need to check this.

I pushed all the bridge driver patches (2/14 to 11/14) to drm-misc-next. We'll
push the rest once we figure out which branch we want them to go through..

Archit

> 
> Inki Dae (14):
>    drm/bridge: change return type of drm_bridge_add function
>    drm/bridge: adv7511: clean up drm_bridge_add call
>    drm/bridge: analogix-anx78xx: clean up drm_bridge_add call
>    drm/bridge: vga-dac: clean up drm_bridge_add call
>    drm/bridge: nxp-ptn3460: clean up drm_bridge_add call
>    drm/bridge: panel: clean up drm_bridge_add call
>    drm/bridge: ps8622: clean up drm_bridge_add call
>    drm/bridge: sii902x: clean up drm_bridge_add call
>    drm/bridge: synopsys: dw-hdmi: clean up drm_bridge_add call
>    drm/bridge: tc358767: clean up drm_bridge_add call
>    drm/bridge: ti-tfp410: clean up drm_bridge_add call
>    drm/exynos: mic: clean up drm_bridge_add call
>    drm/mediatek: hdmi: clean up drm_bridge_add call
>    drm/sti: sti_vdo: clean up drm_bridge_add call
> 
>   drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 +-----
>   drivers/gpu/drm/bridge/analogix-anx78xx.c    | 6 +-----
>   drivers/gpu/drm/bridge/dumb-vga-dac.c        | 9 +++------
>   drivers/gpu/drm/bridge/nxp-ptn3460.c         | 6 +-----
>   drivers/gpu/drm/bridge/panel.c               | 5 +----
>   drivers/gpu/drm/bridge/parade-ps8622.c       | 6 +-----
>   drivers/gpu/drm/bridge/sii902x.c             | 6 +-----
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c    | 7 +------
>   drivers/gpu/drm/bridge/tc358767.c            | 6 +-----
>   drivers/gpu/drm/bridge/ti-tfp410.c           | 6 +-----
>   drivers/gpu/drm/drm_bridge.c                 | 7 +------
>   drivers/gpu/drm/exynos/exynos_drm_mic.c      | 6 +-----
>   drivers/gpu/drm/mediatek/mtk_hdmi.c          | 6 +-----
>   drivers/gpu/drm/sti/sti_dvo.c                | 6 +-----
>   include/drm/drm_bridge.h                     | 2 +-
>   15 files changed, 17 insertions(+), 73 deletions(-)
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 00/14] clean up drm_bridge_add

[Inki Dae]

Daniel, please ping~

2017년 07월 03일 17:42에 Inki Dae 이(가) 쓴 글:
> This patch series changes return type of drm_bridge_add
> function to void one and also removes unnecessary checking
> of the return type from relevant drivers.
> 
> Ps. I had just build test so each maintainer may need to check this.
> 
> Inki Dae (14):
>   drm/bridge: change return type of drm_bridge_add function
>   drm/bridge: adv7511: clean up drm_bridge_add call
>   drm/bridge: analogix-anx78xx: clean up drm_bridge_add call
>   drm/bridge: vga-dac: clean up drm_bridge_add call
>   drm/bridge: nxp-ptn3460: clean up drm_bridge_add call
>   drm/bridge: panel: clean up drm_bridge_add call
>   drm/bridge: ps8622: clean up drm_bridge_add call
>   drm/bridge: sii902x: clean up drm_bridge_add call
>   drm/bridge: synopsys: dw-hdmi: clean up drm_bridge_add call
>   drm/bridge: tc358767: clean up drm_bridge_add call
>   drm/bridge: ti-tfp410: clean up drm_bridge_add call
>   drm/exynos: mic: clean up drm_bridge_add call
>   drm/mediatek: hdmi: clean up drm_bridge_add call
>   drm/sti: sti_vdo: clean up drm_bridge_add call
> 
>  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 +-----
>  drivers/gpu/drm/bridge/analogix-anx78xx.c    | 6 +-----
>  drivers/gpu/drm/bridge/dumb-vga-dac.c        | 9 +++------
>  drivers/gpu/drm/bridge/nxp-ptn3460.c         | 6 +-----
>  drivers/gpu/drm/bridge/panel.c               | 5 +----
>  drivers/gpu/drm/bridge/parade-ps8622.c       | 6 +-----
>  drivers/gpu/drm/bridge/sii902x.c             | 6 +-----
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c    | 7 +------
>  drivers/gpu/drm/bridge/tc358767.c            | 6 +-----
>  drivers/gpu/drm/bridge/ti-tfp410.c           | 6 +-----
>  drivers/gpu/drm/drm_bridge.c                 | 7 +------
>  drivers/gpu/drm/exynos/exynos_drm_mic.c      | 6 +-----
>  drivers/gpu/drm/mediatek/mtk_hdmi.c          | 6 +-----
>  drivers/gpu/drm/sti/sti_dvo.c                | 6 +-----
>  include/drm/drm_bridge.h                     | 2 +-
>  15 files changed, 17 insertions(+), 73 deletions(-)
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 00/14] clean up drm_bridge_add

[Archit Taneja]

Hi,

On 08/08/2017 04:25 AM, Inki Dae wrote:
> Daniel, please ping~
> 
> 2017년 07월 03일 17:42에 Inki Dae 이(가) 쓴 글:
>> This patch series changes return type of drm_bridge_add
>> function to void one and also removes unnecessary checking
>> of the return type from relevant drivers.
>>
>> Ps. I had just build test so each maintainer may need to check this.

All the drm/bridge patches have been queued.

I wanted to queue the exynos/mediatek/sti patches via drm-misc-next,
so that "drm/bridge: change return type of drm_bridge_add function"
can go through without breaking anything, but I didn't get anyone's
ack.

Archit

>>
>> Inki Dae (14):
>>    drm/bridge: change return type of drm_bridge_add function
>>    drm/bridge: adv7511: clean up drm_bridge_add call
>>    drm/bridge: analogix-anx78xx: clean up drm_bridge_add call
>>    drm/bridge: vga-dac: clean up drm_bridge_add call
>>    drm/bridge: nxp-ptn3460: clean up drm_bridge_add call
>>    drm/bridge: panel: clean up drm_bridge_add call
>>    drm/bridge: ps8622: clean up drm_bridge_add call
>>    drm/bridge: sii902x: clean up drm_bridge_add call
>>    drm/bridge: synopsys: dw-hdmi: clean up drm_bridge_add call
>>    drm/bridge: tc358767: clean up drm_bridge_add call
>>    drm/bridge: ti-tfp410: clean up drm_bridge_add call
>>    drm/exynos: mic: clean up drm_bridge_add call
>>    drm/mediatek: hdmi: clean up drm_bridge_add call
>>    drm/sti: sti_vdo: clean up drm_bridge_add call
>>
>>   drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 +-----
>>   drivers/gpu/drm/bridge/analogix-anx78xx.c    | 6 +-----
>>   drivers/gpu/drm/bridge/dumb-vga-dac.c        | 9 +++------
>>   drivers/gpu/drm/bridge/nxp-ptn3460.c         | 6 +-----
>>   drivers/gpu/drm/bridge/panel.c               | 5 +----
>>   drivers/gpu/drm/bridge/parade-ps8622.c       | 6 +-----
>>   drivers/gpu/drm/bridge/sii902x.c             | 6 +-----
>>   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c    | 7 +------
>>   drivers/gpu/drm/bridge/tc358767.c            | 6 +-----
>>   drivers/gpu/drm/bridge/ti-tfp410.c           | 6 +-----
>>   drivers/gpu/drm/drm_bridge.c                 | 7 +------
>>   drivers/gpu/drm/exynos/exynos_drm_mic.c      | 6 +-----
>>   drivers/gpu/drm/mediatek/mtk_hdmi.c          | 6 +-----
>>   drivers/gpu/drm/sti/sti_dvo.c                | 6 +-----
>>   include/drm/drm_bridge.h                     | 2 +-
>>   15 files changed, 17 insertions(+), 73 deletions(-)
>>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 00/14] clean up drm_bridge_add

[Inki Dae]

2017년 08월 08일 07:55에 Inki Dae 이(가) 쓴 글:
> Daniel, please ping~

Sean, please ping~

> 
> 2017년 07월 03일 17:42에 Inki Dae 이(가) 쓴 글:
>> This patch series changes return type of drm_bridge_add
>> function to void one and also removes unnecessary checking
>> of the return type from relevant drivers.
>>
>> Ps. I had just build test so each maintainer may need to check this.
>>
>> Inki Dae (14):
>>   drm/bridge: change return type of drm_bridge_add function
>>   drm/bridge: adv7511: clean up drm_bridge_add call
>>   drm/bridge: analogix-anx78xx: clean up drm_bridge_add call
>>   drm/bridge: vga-dac: clean up drm_bridge_add call
>>   drm/bridge: nxp-ptn3460: clean up drm_bridge_add call
>>   drm/bridge: panel: clean up drm_bridge_add call
>>   drm/bridge: ps8622: clean up drm_bridge_add call
>>   drm/bridge: sii902x: clean up drm_bridge_add call
>>   drm/bridge: synopsys: dw-hdmi: clean up drm_bridge_add call
>>   drm/bridge: tc358767: clean up drm_bridge_add call
>>   drm/bridge: ti-tfp410: clean up drm_bridge_add call
>>   drm/exynos: mic: clean up drm_bridge_add call
>>   drm/mediatek: hdmi: clean up drm_bridge_add call
>>   drm/sti: sti_vdo: clean up drm_bridge_add call
>>
>>  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 +-----
>>  drivers/gpu/drm/bridge/analogix-anx78xx.c    | 6 +-----
>>  drivers/gpu/drm/bridge/dumb-vga-dac.c        | 9 +++------
>>  drivers/gpu/drm/bridge/nxp-ptn3460.c         | 6 +-----
>>  drivers/gpu/drm/bridge/panel.c               | 5 +----
>>  drivers/gpu/drm/bridge/parade-ps8622.c       | 6 +-----
>>  drivers/gpu/drm/bridge/sii902x.c             | 6 +-----
>>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c    | 7 +------
>>  drivers/gpu/drm/bridge/tc358767.c            | 6 +-----
>>  drivers/gpu/drm/bridge/ti-tfp410.c           | 6 +-----
>>  drivers/gpu/drm/drm_bridge.c                 | 7 +------
>>  drivers/gpu/drm/exynos/exynos_drm_mic.c      | 6 +-----
>>  drivers/gpu/drm/mediatek/mtk_hdmi.c          | 6 +-----
>>  drivers/gpu/drm/sti/sti_dvo.c                | 6 +-----
>>  include/drm/drm_bridge.h                     | 2 +-
>>  15 files changed, 17 insertions(+), 73 deletions(-)
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

[Inki Dae]

2017년 07월 03일 17:42에 Inki Dae 이(가) 쓴 글:
> This patch removes unnecessary checking of return value.
> 
> Ps. this patch depends on below one,
> 	http://www.spinics.net/lists/dri-devel/msg145687.html

Above patch has been already merged to mainline so no dependency, and can go through misc.

Acked-by: Inki Dae <inki.dae@samsung.com>

Thanks,
Inki Dae


> 
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index 5ea6e3d..07bd7fc 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -458,11 +458,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>  	mic->bridge.funcs = &mic_bridge_funcs;
>  	mic->bridge.of_node = dev->of_node;
>  
> -	ret = drm_bridge_add(&mic->bridge);
> -	if (ret) {
> -		DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
> -		return ret;
> -	}
> +	drm_bridge_add(&mic->bridge);
>  
>  	pm_runtime_enable(dev);
>  
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

[Inki Dae]

2017년 07월 05일 18:14에 Archit Taneja 이(가) 쓴 글:
> 
> 
> On 07/05/2017 02:35 PM, Inki Dae wrote:
>>
>>
>> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글:
>>>
>>>
>>> On 07/03/2017 02:12 PM, Inki Dae wrote:
>>>> This patch removes unnecessary checking of return value.
>>>>
>>>> Ps. this patch depends on below one,
>>>>      http://www.spinics.net/lists/dri-devel/msg145687.html
>>>
>>> Will this one^ go via the exynos pull req or drm-misc? If there won't
>>> be any conflicts, we could get both the patches through drm-misc to
>>> keep things simple.
>>
>> exynos pull it would be better. I will pick this up. :)
> 
> If patch # 1/14 goes through drm-misc, and the exynos patch goes through
> exynos pull, the drm-misc branch would break. That's the reason I
> preferred the exynos patches to go via misc.

Sorry for late. I missed checking your comment. Sorry for this.
As you commented, I left Acked-by so that this patch series can go to mainline through misc without build break.

Thanks,
Inki Dae

> 
> Thanks,
> Archit
> 
>>
>> Thanks,
>> Inki Dae
>>
>>>
>>> Archit
>>>
>>>>
>>>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>>>> ---
>>>>    drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
>>>>    1 file changed, 1 insertion(+), 5 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>>> index 5ea6e3d..07bd7fc 100644
>>>> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>>> @@ -458,11 +458,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>>>>        mic->bridge.funcs = &mic_bridge_funcs;
>>>>        mic->bridge.of_node = dev->of_node;
>>>>    -    ret = drm_bridge_add(&mic->bridge);
>>>> -    if (ret) {
>>>> -        DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
>>>> -        return ret;
>>>> -    }
>>>> +    drm_bridge_add(&mic->bridge);
>>>>          pm_runtime_enable(dev);
>>>>   
>>>
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

[Inki Dae]

2017년 07월 05일 20:12에 Emil Velikov 이(가) 쓴 글:
> On 5 July 2017 at 10:14, Archit Taneja <architt@codeaurora.org> wrote:
>>
>>
>> On 07/05/2017 02:35 PM, Inki Dae wrote:
>>>
>>>
>>>
>>> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글:
>>>>
>>>>
>>>>
>>>> On 07/03/2017 02:12 PM, Inki Dae wrote:
>>>>>
>>>>> This patch removes unnecessary checking of return value.
>>>>>
>>>>> Ps. this patch depends on below one,
>>>>>      http://www.spinics.net/lists/dri-devel/msg145687.html
>>>>
>>>>
>>>> Will this one^ go via the exynos pull req or drm-misc? If there won't
>>>> be any conflicts, we could get both the patches through drm-misc to
>>>> keep things simple.
>>>
>>>
>>> exynos pull it would be better. I will pick this up. :)
>>
>>
>> If patch # 1/14 goes through drm-misc, and the exynos patch goes through
>> exynos pull, the drm-misc branch would break. That's the reason I
>> preferred the exynos patches to go via misc.
>>
> As mentioned in 1/14:
> 
> If 1/14 is applied before the rest of the series all the drivers
> (addressed with 2-14) will fail to build.
> I think...

Indeed. :)

Thanks,
Inki Dae

> 
> -Emil
> 
> 
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 13/14] drm/mediatek: hdmi: clean up drm_bridge_add call

[Daniel Vetter]

On Wed, Jul 05, 2017 at 02:31:57PM +0530, Archit Taneja wrote:
> 
> 
> On 07/03/2017 02:12 PM, Inki Dae wrote:
> > This patch removes unnecessary checking of return value.
> 
> Can I get an ack from the maintainers to get this pulled in
> via drm-misc?

Almost two weeks of no replies, I'd say go ahead and assume the
maintainers are absent. That's what I generally do, otherwise it's pretty
much impossible to land such cleanups.
-Daniel

> 
> Thanks,
> Archit
> 
> > 
> > Signed-off-by: Inki Dae <inki.dae@samsung.com>
> > ---
> >   drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +-----
> >   1 file changed, 1 insertion(+), 5 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > index 0a4ffd7..62652ee 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > @@ -1697,11 +1697,7 @@ static int mtk_drm_hdmi_probe(struct platform_device *pdev)
> >   	hdmi->bridge.funcs = &mtk_hdmi_bridge_funcs;
> >   	hdmi->bridge.of_node = pdev->dev.of_node;
> > -	ret = drm_bridge_add(&hdmi->bridge);
> > -	if (ret) {
> > -		dev_err(dev, "failed to add bridge, ret = %d\n", ret);
> > -		return ret;
> > -	}
> > +	drm_bridge_add(&hdmi->bridge);
> >   	ret = mtk_hdmi_clk_enable_audio(hdmi);
> >   	if (ret) {
> > 
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 13/14] drm/mediatek: hdmi: clean up drm_bridge_add call

[CK Hu]

On Fri, 2017-08-18 at 10:54 +0200, Daniel Vetter wrote:
> On Wed, Jul 05, 2017 at 02:31:57PM +0530, Archit Taneja wrote:
> > 
> > 
> > On 07/03/2017 02:12 PM, Inki Dae wrote:
> > > This patch removes unnecessary checking of return value.
> > 
> > Can I get an ack from the maintainers to get this pulled in
> > via drm-misc?
> 
> Almost two weeks of no replies, I'd say go ahead and assume the
> maintainers are absent. That's what I generally do, otherwise it's pretty
> much impossible to land such cleanups.
> -Daniel

Yes, I'm absent, so go ahead.

Acked-by: CK Hu <ck.hu@mediatek.com>

> 
> > 
> > Thanks,
> > Archit
> > 
> > > 
> > > Signed-off-by: Inki Dae <inki.dae@samsung.com>
> > > ---
> > >   drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +-----
> > >   1 file changed, 1 insertion(+), 5 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > index 0a4ffd7..62652ee 100644
> > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> > > @@ -1697,11 +1697,7 @@ static int mtk_drm_hdmi_probe(struct platform_device *pdev)
> > >   	hdmi->bridge.funcs = &mtk_hdmi_bridge_funcs;
> > >   	hdmi->bridge.of_node = pdev->dev.of_node;
> > > -	ret = drm_bridge_add(&hdmi->bridge);
> > > -	if (ret) {
> > > -		dev_err(dev, "failed to add bridge, ret = %d\n", ret);
> > > -		return ret;
> > > -	}
> > > +	drm_bridge_add(&hdmi->bridge);
> > >   	ret = mtk_hdmi_clk_enable_audio(hdmi);
> > >   	if (ret) {
> > > 
> > 
> > -- 
> > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 14/14] drm/sti: sti_vdo: clean up drm_bridge_add call

[Sean Paul]

On Mon, Jul 3, 2017 at 4:42 AM, Inki Dae <inki.dae@samsung.com> wrote:
> This patch removes unnecessary checking of return value.
>
> Signed-off-by: Inki Dae <inki.dae@samsung.com>

Reviewed-by: Sean Paul <seanpaul@chromium.org>

> ---
>  drivers/gpu/drm/sti/sti_dvo.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
> index 24ebc6b..dcc2c22 100644
> --- a/drivers/gpu/drm/sti/sti_dvo.c
> +++ b/drivers/gpu/drm/sti/sti_dvo.c
> @@ -464,11 +464,7 @@ static int sti_dvo_bind(struct device *dev, struct device *master, void *data)
>         bridge->driver_private = dvo;
>         bridge->funcs = &sti_dvo_bridge_funcs;
>         bridge->of_node = dvo->dev.of_node;
> -       err = drm_bridge_add(bridge);
> -       if (err) {
> -               DRM_ERROR("Failed to add bridge\n");
> -               return err;
> -       }
> +       drm_bridge_add(bridge);
>
>         err = drm_bridge_attach(encoder, bridge, NULL);
>         if (err) {
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 00/14] clean up drm_bridge_add

[Archit Taneja]

On 08/08/2017 08:51 AM, Archit Taneja wrote:
> Hi,
> 
> On 08/08/2017 04:25 AM, Inki Dae wrote:
>> Daniel, please ping~
>>
>> 2017년 07월 03일 17:42에 Inki Dae 이(가) 쓴 글:
>>> This patch series changes return type of drm_bridge_add
>>> function to void one and also removes unnecessary checking
>>> of the return type from relevant drivers.
>>>
>>> Ps. I had just build test so each maintainer may need to check this.
> 
> All the drm/bridge patches have been queued.
> 
> I wanted to queue the exynos/mediatek/sti patches via drm-misc-next,
> so that "drm/bridge: change return type of drm_bridge_add function"
> can go through without breaking anything, but I didn't get anyone's
> ack.

Queued the pending patches (# 12,13,14 and 01) to drm-misc-next.

Thanks,
Archit

> 
> Archit
> 
>>>
>>> Inki Dae (14):
>>>    drm/bridge: change return type of drm_bridge_add function
>>>    drm/bridge: adv7511: clean up drm_bridge_add call
>>>    drm/bridge: analogix-anx78xx: clean up drm_bridge_add call
>>>    drm/bridge: vga-dac: clean up drm_bridge_add call
>>>    drm/bridge: nxp-ptn3460: clean up drm_bridge_add call
>>>    drm/bridge: panel: clean up drm_bridge_add call
>>>    drm/bridge: ps8622: clean up drm_bridge_add call
>>>    drm/bridge: sii902x: clean up drm_bridge_add call
>>>    drm/bridge: synopsys: dw-hdmi: clean up drm_bridge_add call
>>>    drm/bridge: tc358767: clean up drm_bridge_add call
>>>    drm/bridge: ti-tfp410: clean up drm_bridge_add call
>>>    drm/exynos: mic: clean up drm_bridge_add call
>>>    drm/mediatek: hdmi: clean up drm_bridge_add call
>>>    drm/sti: sti_vdo: clean up drm_bridge_add call
>>>
>>>   drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 +-----
>>>   drivers/gpu/drm/bridge/analogix-anx78xx.c    | 6 +-----
>>>   drivers/gpu/drm/bridge/dumb-vga-dac.c        | 9 +++------
>>>   drivers/gpu/drm/bridge/nxp-ptn3460.c         | 6 +-----
>>>   drivers/gpu/drm/bridge/panel.c               | 5 +----
>>>   drivers/gpu/drm/bridge/parade-ps8622.c       | 6 +-----
>>>   drivers/gpu/drm/bridge/sii902x.c             | 6 +-----
>>>   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c    | 7 +------
>>>   drivers/gpu/drm/bridge/tc358767.c            | 6 +-----
>>>   drivers/gpu/drm/bridge/ti-tfp410.c           | 6 +-----
>>>   drivers/gpu/drm/drm_bridge.c                 | 7 +------
>>>   drivers/gpu/drm/exynos/exynos_drm_mic.c      | 6 +-----
>>>   drivers/gpu/drm/mediatek/mtk_hdmi.c          | 6 +-----
>>>   drivers/gpu/drm/sti/sti_dvo.c                | 6 +-----
>>>   include/drm/drm_bridge.h                     | 2 +-
>>>   15 files changed, 17 insertions(+), 73 deletions(-)
>>>
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 00/14] clean up drm_bridge_add

[Inki Dae]

Hi Archit,

2017년 07월 06일 17:58에 Archit Taneja 이(가) 쓴 글:
> 
> 
> On 07/03/2017 02:12 PM, Inki Dae wrote:
>> This patch series changes return type of drm_bridge_add
>> function to void one and also removes unnecessary checking
>> of the return type from relevant drivers.
>>
>> Ps. I had just build test so each maintainer may need to check this.
> 
> I pushed all the bridge driver patches (2/14 to 11/14) to drm-misc-next. We'll
> push the rest once we figure out which branch we want them to go through..

Thanks. :)

Inki Dae

> 
> Archit
> 
>>
>> Inki Dae (14):
>>    drm/bridge: change return type of drm_bridge_add function
>>    drm/bridge: adv7511: clean up drm_bridge_add call
>>    drm/bridge: analogix-anx78xx: clean up drm_bridge_add call
>>    drm/bridge: vga-dac: clean up drm_bridge_add call
>>    drm/bridge: nxp-ptn3460: clean up drm_bridge_add call
>>    drm/bridge: panel: clean up drm_bridge_add call
>>    drm/bridge: ps8622: clean up drm_bridge_add call
>>    drm/bridge: sii902x: clean up drm_bridge_add call
>>    drm/bridge: synopsys: dw-hdmi: clean up drm_bridge_add call
>>    drm/bridge: tc358767: clean up drm_bridge_add call
>>    drm/bridge: ti-tfp410: clean up drm_bridge_add call
>>    drm/exynos: mic: clean up drm_bridge_add call
>>    drm/mediatek: hdmi: clean up drm_bridge_add call
>>    drm/sti: sti_vdo: clean up drm_bridge_add call
>>
>>   drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 +-----
>>   drivers/gpu/drm/bridge/analogix-anx78xx.c    | 6 +-----
>>   drivers/gpu/drm/bridge/dumb-vga-dac.c        | 9 +++------
>>   drivers/gpu/drm/bridge/nxp-ptn3460.c         | 6 +-----
>>   drivers/gpu/drm/bridge/panel.c               | 5 +----
>>   drivers/gpu/drm/bridge/parade-ps8622.c       | 6 +-----
>>   drivers/gpu/drm/bridge/sii902x.c             | 6 +-----
>>   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c    | 7 +------
>>   drivers/gpu/drm/bridge/tc358767.c            | 6 +-----
>>   drivers/gpu/drm/bridge/ti-tfp410.c           | 6 +-----
>>   drivers/gpu/drm/drm_bridge.c                 | 7 +------
>>   drivers/gpu/drm/exynos/exynos_drm_mic.c      | 6 +-----
>>   drivers/gpu/drm/mediatek/mtk_hdmi.c          | 6 +-----
>>   drivers/gpu/drm/sti/sti_dvo.c                | 6 +-----
>>   include/drm/drm_bridge.h                     | 2 +-
>>   15 files changed, 17 insertions(+), 73 deletions(-)
>>
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel