All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PULL v2 00/40] Block layer patches
@ 2017-07-10 11:27 Kevin Wolf
  2017-07-10 14:23 ` Peter Maydell
  0 siblings, 1 reply; 6+ messages in thread
From: Kevin Wolf @ 2017-07-10 11:27 UTC (permalink / raw)
  To: qemu-block; +Cc: kwolf, peter.maydell, qemu-devel

The following changes since commit 77d472291812cf04f97974dadbda767e59e31fde:

  Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20170707-tag' into staging (2017-07-10 10:29:11 +0100)

are available in the git repository at:


  git://repo.or.cz/qemu/kevin.git tags/for-upstream

for you to fetch changes up to 51b0a488882328f8f02519bb47ca7e0e7fbe12ff:

  block: Make bdrv_is_allocated_above() byte-based (2017-07-10 13:18:07 +0200)

----------------------------------------------------------------
Block layer patches

----------------------------------------------------------------
Daniel P. Berrange (1):
      qemu-img: drop -e and -6 options from the 'create' & 'convert' commands

Eric Blake (25):
      qemu-io: Don't die on second open
      block: Guarantee that *file is set on bdrv_get_block_status()
      block: Simplify use of BDRV_BLOCK_RAW
      blkdebug: Support .bdrv_co_get_block_status
      blockjob: Track job ratelimits via bytes, not sectors
      trace: Show blockjob actions via bytes, not sectors
      stream: Switch stream_populate() to byte-based
      stream: Drop reached_end for stream_complete()
      stream: Switch stream_run() to byte-based
      commit: Switch commit_populate() to byte-based
      commit: Switch commit_run() to byte-based
      mirror: Switch MirrorBlockJob to byte-based
      mirror: Switch mirror_do_zero_or_discard() to byte-based
      mirror: Update signature of mirror_clip_sectors()
      mirror: Switch mirror_cow_align() to byte-based
      mirror: Switch mirror_do_read() to byte-based
      mirror: Switch mirror_iteration() to byte-based
      block: Drop unused bdrv_round_sectors_to_clusters()
      backup: Switch BackupBlockJob to byte-based
      backup: Switch block_backup.h to byte-based
      backup: Switch backup_do_cow() to byte-based
      backup: Switch backup_run() to byte-based
      block: Make bdrv_is_allocated() byte-based
      block: Minimize raw use of bds->total_sectors
      block: Make bdrv_is_allocated_above() byte-based

Hervé Poussineau (13):
      vvfat: fix qemu-img map and qemu-img convert
      vvfat: replace tabs by 8 spaces
      vvfat: fix typos
      vvfat: rename useless enumeration values
      vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir
      vvfat: fix field names in FAT12/FAT16 and FAT32 boot sectors
      vvfat: always create . and .. entries at first and in that order
      vvfat: correctly create long names for non-ASCII filenames
      vvfat: correctly create base short names for non-ASCII filenames
      vvfat: correctly generate numeric-tail of short file names
      vvfat: limit number of entries in root directory in FAT12/FAT16
      vvfat: handle KANJI lead byte 0xe5
      vvfat: change OEM name to 'MSWIN4.1'

Thomas Huth (1):
      blockdev: Print a warning for legacy drive options that belong to -device

 block/backup.c               |  128 +--
 block/blkdebug.c             |   11 +
 block/commit.c               |   56 +-
 block/io.c                   |  102 +-
 block/mirror.c               |  310 +++---
 block/raw-format.c           |    2 +-
 block/replication.c          |   29 +-
 block/stream.c               |   37 +-
 block/trace-events           |   14 +-
 block/vpc.c                  |    2 +-
 block/vvfat.c                | 2336 ++++++++++++++++++++++--------------------
 blockdev.c                   |   14 +
 include/block/block.h        |   16 +-
 include/block/block_backup.h |   11 +-
 include/qemu/ratelimit.h     |    3 +-
 migration/block.c            |   16 +-
 qemu-img.c                   |   41 +-
 qemu-io-cmds.c               |   70 +-
 qemu-io.c                    |    7 +-
 qemu-options.hx              |    9 +-
 tests/qemu-iotests/060.out   |    1 +
 tests/qemu-iotests/114.out   |    5 +-
 tests/qemu-iotests/153.out   |    6 +
 tests/qemu-iotests/177       |    3 +
 tests/qemu-iotests/177.out   |    5 +
 25 files changed, 1675 insertions(+), 1559 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PULL v2 00/40] Block layer patches
  2017-07-10 11:27 [Qemu-devel] [PULL v2 00/40] Block layer patches Kevin Wolf
@ 2017-07-10 14:23 ` Peter Maydell
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2017-07-10 14:23 UTC (permalink / raw)
  To: Kevin Wolf; +Cc: Qemu-block, QEMU Developers

On 10 July 2017 at 12:27, Kevin Wolf <kwolf@redhat.com> wrote:
> The following changes since commit 77d472291812cf04f97974dadbda767e59e31fde:
>
>   Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20170707-tag' into staging (2017-07-10 10:29:11 +0100)
>
> are available in the git repository at:
>
>
>   git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 51b0a488882328f8f02519bb47ca7e0e7fbe12ff:
>
>   block: Make bdrv_is_allocated_above() byte-based (2017-07-10 13:18:07 +0200)
>
> ----------------------------------------------------------------
> Block layer patches
>
> ----------------------------------------------------------------

Applied, thanks.

-- PMM

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PULL v2 00/40] Block layer patches
  2015-11-11 15:35   ` Kevin Wolf
@ 2015-11-11 16:38     ` Eric Blake
  0 siblings, 0 replies; 6+ messages in thread
From: Eric Blake @ 2015-11-11 16:38 UTC (permalink / raw)
  To: Kevin Wolf, Peter Maydell; +Cc: QEMU Developers, Qemu-block

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

On 11/11/2015 08:35 AM, Kevin Wolf wrote:

>> Also some warnings:
>>
>> /Users/pm215/src/qemu-for-merges/qemu-io-cmds.c:772:56: warning:
>> format specifies type 'size_t' (aka 'unsigned long') but the argument
>> has type 'unsigned long lo
>> ng' [-Wformat]
>>         printf("length cannot exceed %zu, given %s\n", SIZE_MAX, argv[optind]);
>>                                      ~~~               ^~~~~~~~
>>                                      %llu
>> /usr/include/stdint.h:153:20: note: expanded from macro 'SIZE_MAX'
>> #define SIZE_MAX          UINT64_MAX
>>                           ^~~~~~~~~~
>> /usr/include/stdint.h:87:27: note: expanded from macro 'UINT64_MAX'
>> #define UINT64_MAX        18446744073709551615ULL
>>                           ^~~~~~~~~~~~~~~~~~~~~~~
> 
> Isn't that actually a bug in the system headers? If I understand the
> spec correctly, SIZE_MAX should be size_t. ("this expression shall have
> the same type as would an expression that is an object of the
> corresponding type converted according to the integer promotions.")

You are correct; the system headers are buggy.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PULL v2 00/40] Block layer patches
  2015-11-10 17:10 ` Peter Maydell
@ 2015-11-11 15:35   ` Kevin Wolf
  2015-11-11 16:38     ` Eric Blake
  0 siblings, 1 reply; 6+ messages in thread
From: Kevin Wolf @ 2015-11-11 15:35 UTC (permalink / raw)
  To: Peter Maydell; +Cc: QEMU Developers, Qemu-block

Am 10.11.2015 um 18:10 hat Peter Maydell geschrieben:
> On 10 November 2015 at 14:09, Kevin Wolf <kwolf@redhat.com> wrote:
> > The following changes since commit a8b4f9585a0bf5186fca793ce2c5d754cd8ec49a:
> >
> >   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-11-10' into staging (2015-11-10 09:39:24 +0000)
> >
> > are available in the git repository at:
> >
> >
> >   git://repo.or.cz/qemu/kevin.git tags/for-upstream
> >
> > for you to fetch changes up to c400bddb916268394e352f82809eb4728424a5b1:
> >
> >   Merge remote-tracking branch 'mreitz/tags/pull-block-for-kevin-2015-11-10' into queue-block (2015-11-10 14:59:26 +0100)
> >
> > ----------------------------------------------------------------
> >
> > Block layer patches
> 
> Fails to build on OSX :-(
> 
> /Users/pm215/src/qemu-for-merges/ui/cocoa.m:1121:40: error: too few
> arguments to function call, expected 7, have 5
>                                    &err);
>                                        ^
> ./qmp-commands.h:61:1: note: 'qmp_blockdev_change_medium' declared here
> void qmp_blockdev_change_medium(const char *device, const char
> *filename, bool has_format, const char *format, bool
> has_read_only_mode, BlockdevChangeReadOnlyMode read_only_mode, Error
> **errp);
> ^
> 1 error generated.
> 
> Also some warnings:
> 
> /Users/pm215/src/qemu-for-merges/qemu-io-cmds.c:772:56: warning:
> format specifies type 'size_t' (aka 'unsigned long') but the argument
> has type 'unsigned long lo
> ng' [-Wformat]
>         printf("length cannot exceed %zu, given %s\n", SIZE_MAX, argv[optind]);
>                                      ~~~               ^~~~~~~~
>                                      %llu
> /usr/include/stdint.h:153:20: note: expanded from macro 'SIZE_MAX'
> #define SIZE_MAX          UINT64_MAX
>                           ^~~~~~~~~~
> /usr/include/stdint.h:87:27: note: expanded from macro 'UINT64_MAX'
> #define UINT64_MAX        18446744073709551615ULL
>                           ^~~~~~~~~~~~~~~~~~~~~~~

Isn't that actually a bug in the system headers? If I understand the
spec correctly, SIZE_MAX should be size_t. ("this expression shall have
the same type as would an expression that is an object of the
corresponding type converted according to the integer promotions.")

Anyway, I'll squash in a workaround that explicitly casts to uint64_t.

Kevin

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PULL v2 00/40] Block layer patches
  2015-11-10 14:09 Kevin Wolf
@ 2015-11-10 17:10 ` Peter Maydell
  2015-11-11 15:35   ` Kevin Wolf
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2015-11-10 17:10 UTC (permalink / raw)
  To: Kevin Wolf; +Cc: QEMU Developers, Qemu-block

On 10 November 2015 at 14:09, Kevin Wolf <kwolf@redhat.com> wrote:
> The following changes since commit a8b4f9585a0bf5186fca793ce2c5d754cd8ec49a:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-11-10' into staging (2015-11-10 09:39:24 +0000)
>
> are available in the git repository at:
>
>
>   git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to c400bddb916268394e352f82809eb4728424a5b1:
>
>   Merge remote-tracking branch 'mreitz/tags/pull-block-for-kevin-2015-11-10' into queue-block (2015-11-10 14:59:26 +0100)
>
> ----------------------------------------------------------------
>
> Block layer patches

Fails to build on OSX :-(

/Users/pm215/src/qemu-for-merges/ui/cocoa.m:1121:40: error: too few
arguments to function call, expected 7, have 5
                                   &err);
                                       ^
./qmp-commands.h:61:1: note: 'qmp_blockdev_change_medium' declared here
void qmp_blockdev_change_medium(const char *device, const char
*filename, bool has_format, const char *format, bool
has_read_only_mode, BlockdevChangeReadOnlyMode read_only_mode, Error
**errp);
^
1 error generated.

Also some warnings:

/Users/pm215/src/qemu-for-merges/qemu-io-cmds.c:772:56: warning:
format specifies type 'size_t' (aka 'unsigned long') but the argument
has type 'unsigned long lo
ng' [-Wformat]
        printf("length cannot exceed %zu, given %s\n", SIZE_MAX, argv[optind]);
                                     ~~~               ^~~~~~~~
                                     %llu
/usr/include/stdint.h:153:20: note: expanded from macro 'SIZE_MAX'
#define SIZE_MAX          UINT64_MAX
                          ^~~~~~~~~~
/usr/include/stdint.h:87:27: note: expanded from macro 'UINT64_MAX'
#define UINT64_MAX        18446744073709551615ULL
                          ^~~~~~~~~~~~~~~~~~~~~~~
/Users/pm215/src/qemu-for-merges/qemu-io-cmds.c:1082:56: warning:
format specifies type 'size_t' (aka 'unsigned long') but the argument
has type 'unsigned long l
ong' [-Wformat]
        printf("length cannot exceed %zu, given %s\n", SIZE_MAX, argv[optind]);
                                     ~~~               ^~~~~~~~
                                     %llu
/usr/include/stdint.h:153:20: note: expanded from macro 'SIZE_MAX'
#define SIZE_MAX          UINT64_MAX
                          ^~~~~~~~~~
/usr/include/stdint.h:87:27: note: expanded from macro 'UINT64_MAX'
#define UINT64_MAX        18446744073709551615ULL
                          ^~~~~~~~~~~~~~~~~~~~~~~

thanks
-- PMM

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Qemu-devel] [PULL v2 00/40] Block layer patches
@ 2015-11-10 14:09 Kevin Wolf
  2015-11-10 17:10 ` Peter Maydell
  0 siblings, 1 reply; 6+ messages in thread
From: Kevin Wolf @ 2015-11-10 14:09 UTC (permalink / raw)
  To: qemu-block; +Cc: kwolf, qemu-devel

The following changes since commit a8b4f9585a0bf5186fca793ce2c5d754cd8ec49a:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-11-10' into staging (2015-11-10 09:39:24 +0000)

are available in the git repository at:


  git://repo.or.cz/qemu/kevin.git tags/for-upstream

for you to fetch changes up to c400bddb916268394e352f82809eb4728424a5b1:

  Merge remote-tracking branch 'mreitz/tags/pull-block-for-kevin-2015-11-10' into queue-block (2015-11-10 14:59:26 +0100)

----------------------------------------------------------------

Block layer patches

----------------------------------------------------------------
Alberto Garcia (17):
      block: Don't call blk_bs() twice in bdrv_lookup_bs()
      block: check for existing device IDs in external_snapshot_prepare()
      block: rename BlockdevSnapshot to BlockdevSnapshotSync
      block: support passing 'backing': '' to 'blockdev-add'
      block: add a 'blockdev-snapshot' QMP command
      block: add tests for the 'blockdev-snapshot' command
      commit: reopen overlay_bs before base
      qemu-iotests: Test the reopening of overlay_bs in 'block-commit'
      throttle: Check for pending requests in throttle_group_unregister_bs()
      throttle: Use bs->throttle_state instead of bs->io_limits_enabled
      block: Disallow snapshots if the overlay doesn't support backing files
      block: Remove inner quotation marks in iotest 085
      block: test 'blockdev-snapshot' using a file BDS as the overlay
      mirror: block all operations on the target image during the job
      block: Add blk_get_refcnt()
      block: Add 'x-blockdev-del' QMP command
      iotests: Add tests for the x-blockdev-del command

Jeff Cody (2):
      qemu-iotests: fix cleanup of background processes
      qemu-iotests: fix -valgrind option for check

John Snow (5):
      qcow2: avoid misaligned 64bit bswap
      qemu-img: add check for zero-length job len
      qemu-io: fix cvtnum lval types
      qemu-io: Check for trailing chars
      qemu-io: Correct error messages

Kevin Wolf (2):
      qcow2: Fix qcow2_get_cluster_offset() for zero clusters
      Merge remote-tracking branch 'mreitz/tags/pull-block-for-kevin-2015-11-10' into queue-block

Max Reitz (15):
      block: Add blk_remove_bs()
      block: Make bdrv_states public
      block: Add functions for inheriting a BBRS
      blockdev: Add blockdev-open-tray
      blockdev: Add blockdev-close-tray
      blockdev: Add blockdev-remove-medium
      blockdev: Add blockdev-insert-medium
      blockdev: Implement eject with basic operations
      blockdev: Implement change with basic operations
      block: Inquire tray state before tray-moved events
      qmp: Introduce blockdev-change-medium
      hmp: Use blockdev-change-medium for change command
      blockdev: read-only-mode for blockdev-change-medium
      hmp: Add read-only-mode option to change command
      iotests: Add test for change-related QMP commands

 block.c                          |  22 +-
 block/block-backend.c            |  61 +++-
 block/commit.c                   |   8 +-
 block/mirror.c                   |   4 +
 block/qapi.c                     |   2 +-
 block/qcow2-cluster.c            |  15 +-
 block/qcow2-refcount.c           |  11 +-
 block/throttle-groups.c          |   7 +
 blockdev.c                       | 527 ++++++++++++++++++++--------
 hmp-commands.hx                  |  20 +-
 hmp.c                            |  47 ++-
 include/block/block_int.h        |   7 +-
 include/sysemu/block-backend.h   |   4 +
 include/sysemu/blockdev.h        |   2 -
 qapi-schema.json                 |  10 +-
 qapi/block-core.json             | 192 ++++++++++-
 qemu-img.c                       |   3 +-
 qemu-io-cmds.c                   | 185 +++++++---
 qmp-commands.hx                  | 317 ++++++++++++++++-
 qmp.c                            |   3 +-
 tests/qemu-iotests/039.out       |  30 +-
 tests/qemu-iotests/040           |  30 ++
 tests/qemu-iotests/040.out       |   4 +-
 tests/qemu-iotests/058           |  12 +-
 tests/qemu-iotests/061.out       |  12 +-
 tests/qemu-iotests/085           | 120 ++++++-
 tests/qemu-iotests/085.out       |  38 ++-
 tests/qemu-iotests/118           | 720 +++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/118.out       |   5 +
 tests/qemu-iotests/137.out       |   6 +-
 tests/qemu-iotests/139           | 414 ++++++++++++++++++++++
 tests/qemu-iotests/139.out       |   5 +
 tests/qemu-iotests/common        |   9 +-
 tests/qemu-iotests/common.config |  32 +-
 tests/qemu-iotests/common.qemu   |  18 +-
 tests/qemu-iotests/common.rc     |  18 +-
 tests/qemu-iotests/group         |   2 +
 ui/cocoa.m                       |  10 +-
 38 files changed, 2621 insertions(+), 311 deletions(-)
 create mode 100755 tests/qemu-iotests/118
 create mode 100644 tests/qemu-iotests/118.out
 create mode 100644 tests/qemu-iotests/139
 create mode 100644 tests/qemu-iotests/139.out

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-10 14:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-10 11:27 [Qemu-devel] [PULL v2 00/40] Block layer patches Kevin Wolf
2017-07-10 14:23 ` Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2015-11-10 14:09 Kevin Wolf
2015-11-10 17:10 ` Peter Maydell
2015-11-11 15:35   ` Kevin Wolf
2015-11-11 16:38     ` Eric Blake

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.