* [PATCH 0/2] HSI: ssi_protocol: Adjustments for two function implementations
@ 2018-02-02 20:08 ` SF Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2018-02-02 20:08 UTC (permalink / raw)
To: kernel-janitors, Dan Carpenter, David S. Miller, Kees Cook,
Sebastian Reichel, Thomas Gleixner
Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Feb 2018 21:03:45 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation in ssi_protocol_probe()
Fix a typo in two comment lines
drivers/hsi/clients/ssi_protocol.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
--
2.16.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/2] HSI: ssi_protocol: Adjustments for two function implementations
@ 2018-02-02 20:08 ` SF Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2018-02-02 20:08 UTC (permalink / raw)
To: kernel-janitors, Dan Carpenter, David S. Miller, Kees Cook,
Sebastian Reichel, Thomas Gleixner
Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Feb 2018 21:03:45 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation in ssi_protocol_probe()
Fix a typo in two comment lines
drivers/hsi/clients/ssi_protocol.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
--
2.16.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] HSI: ssi_protocol: Delete an error message for a failed memory allocation in ssi_protocol_probe()
2018-02-02 20:08 ` SF Markus Elfring
@ 2018-02-02 20:09 ` SF Markus Elfring
-1 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2018-02-02 20:09 UTC (permalink / raw)
To: kernel-janitors, Dan Carpenter, David S. Miller, Kees Cook,
Sebastian Reichel, Thomas Gleixner
Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Feb 2018 20:02:17 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/hsi/clients/ssi_protocol.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
index 9b167bc6eee4..0bccea2fa119 100644
--- a/drivers/hsi/clients/ssi_protocol.c
+++ b/drivers/hsi/clients/ssi_protocol.c
@@ -1088,10 +1088,8 @@ static int ssi_protocol_probe(struct device *dev)
int err;
ssi = kzalloc(sizeof(*ssi), GFP_KERNEL);
- if (!ssi) {
- dev_err(dev, "No memory for ssi protocol\n");
+ if (!ssi)
return -ENOMEM;
- }
spin_lock_init(&ssi->lock);
timer_setup(&ssi->rx_wd, ssip_rx_wd, TIMER_DEFERRABLE);
--
2.16.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/2] HSI: ssi_protocol: Delete an error message for a failed memory allocation in ssi_protoco
@ 2018-02-02 20:09 ` SF Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2018-02-02 20:09 UTC (permalink / raw)
To: kernel-janitors, Dan Carpenter, David S. Miller, Kees Cook,
Sebastian Reichel, Thomas Gleixner
Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Feb 2018 20:02:17 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/hsi/clients/ssi_protocol.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
index 9b167bc6eee4..0bccea2fa119 100644
--- a/drivers/hsi/clients/ssi_protocol.c
+++ b/drivers/hsi/clients/ssi_protocol.c
@@ -1088,10 +1088,8 @@ static int ssi_protocol_probe(struct device *dev)
int err;
ssi = kzalloc(sizeof(*ssi), GFP_KERNEL);
- if (!ssi) {
- dev_err(dev, "No memory for ssi protocol\n");
+ if (!ssi)
return -ENOMEM;
- }
spin_lock_init(&ssi->lock);
timer_setup(&ssi->rx_wd, ssip_rx_wd, TIMER_DEFERRABLE);
--
2.16.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] HSI: ssi_protocol: Fix a typo in two comment lines
2018-02-02 20:08 ` SF Markus Elfring
@ 2018-02-02 20:11 ` SF Markus Elfring
-1 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2018-02-02 20:11 UTC (permalink / raw)
To: kernel-janitors, Dan Carpenter, David S. Miller, Kees Cook,
Sebastian Reichel, Thomas Gleixner
Cc: LKML, trivial
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Feb 2018 20:57:23 +0100
Adjust two words in this description.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/hsi/clients/ssi_protocol.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
index 0bccea2fa119..6dbead863d07 100644
--- a/drivers/hsi/clients/ssi_protocol.c
+++ b/drivers/hsi/clients/ssi_protocol.c
@@ -993,8 +993,8 @@ static int ssip_pn_xmit(struct sk_buff *skb, struct net_device *dev)
goto inc_dropped;
/*
- * Modem sends Phonet messages over SSI with its own endianess...
- * Assume that modem has the same endianess as we do.
+ * Modem sends Phonet messages over SSI with its own endianness.
+ * Assume that modem has the same endianness as we do.
*/
if (skb_cow_head(skb, 0))
goto drop;
--
2.16.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] HSI: ssi_protocol: Fix a typo in two comment lines
@ 2018-02-02 20:11 ` SF Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2018-02-02 20:11 UTC (permalink / raw)
To: kernel-janitors, Dan Carpenter, David S. Miller, Kees Cook,
Sebastian Reichel, Thomas Gleixner
Cc: LKML, trivial
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Feb 2018 20:57:23 +0100
Adjust two words in this description.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/hsi/clients/ssi_protocol.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
index 0bccea2fa119..6dbead863d07 100644
--- a/drivers/hsi/clients/ssi_protocol.c
+++ b/drivers/hsi/clients/ssi_protocol.c
@@ -993,8 +993,8 @@ static int ssip_pn_xmit(struct sk_buff *skb, struct net_device *dev)
goto inc_dropped;
/*
- * Modem sends Phonet messages over SSI with its own endianess...
- * Assume that modem has the same endianess as we do.
+ * Modem sends Phonet messages over SSI with its own endianness.
+ * Assume that modem has the same endianness as we do.
*/
if (skb_cow_head(skb, 0))
goto drop;
--
2.16.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-02 20:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-02 20:08 [PATCH 0/2] HSI: ssi_protocol: Adjustments for two function implementations SF Markus Elfring
2018-02-02 20:08 ` SF Markus Elfring
2018-02-02 20:09 ` [PATCH 1/2] HSI: ssi_protocol: Delete an error message for a failed memory allocation in ssi_protocol_probe() SF Markus Elfring
2018-02-02 20:09 ` [PATCH 1/2] HSI: ssi_protocol: Delete an error message for a failed memory allocation in ssi_protoco SF Markus Elfring
2018-02-02 20:11 ` [PATCH 2/2] HSI: ssi_protocol: Fix a typo in two comment lines SF Markus Elfring
2018-02-02 20:11 ` SF Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.