* [PATCH] mwifiex: Fix invalid port issue
@ 2017-04-04 4:46 Ganapathi Bhat
2017-04-05 10:52 ` Kalle Valo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ganapathi Bhat @ 2017-04-04 4:46 UTC (permalink / raw)
To: linux-wireless; +Cc: Cathy Luo, Nishant Sarmukadam, Ganapathi Bhat
We have to use start port, for TX/RX of single packet,
instead of current aggregating port. This will fix SDIO
CMD53(TX/RX) returning -ETIMEDOUT and halting the data path.
fixes: 0cb52aac4 ('mwifiex: do not set multiport flag for tx/rx single packet')
Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index 58d3da0..369450a 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -1380,7 +1380,7 @@ static int mwifiex_sdio_card_to_host_mp_aggr(struct mwifiex_adapter *adapter,
}
if (card->mpa_rx.pkt_cnt == 1)
- mport = adapter->ioport + port;
+ mport = adapter->ioport + card->mpa_rx.start_port;
if (mwifiex_read_data_sync(adapter, card->mpa_rx.buf,
card->mpa_rx.buf_len, mport, 1))
@@ -1813,7 +1813,7 @@ static int mwifiex_host_to_card_mp_aggr(struct mwifiex_adapter *adapter,
}
if (card->mpa_tx.pkt_cnt == 1)
- mport = adapter->ioport + port;
+ mport = adapter->ioport + card->mpa_tx.start_port;
ret = mwifiex_write_data_to_card(adapter, card->mpa_tx.buf,
card->mpa_tx.buf_len, mport);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: mwifiex: Fix invalid port issue
2017-04-04 4:46 [PATCH] mwifiex: Fix invalid port issue Ganapathi Bhat
@ 2017-04-05 10:52 ` Kalle Valo
[not found] ` <20170405105212.BA68F60DC7@smtp.codeaurora.org>
2017-04-13 14:05 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2017-04-05 10:52 UTC (permalink / raw)
To: Ganapathi Bhat
Cc: linux-wireless, Cathy Luo, Nishant Sarmukadam, Ganapathi Bhat
Ganapathi Bhat <gbhat@marvell.com> wrote:
> We have to use start port, for TX/RX of single packet,
> instead of current aggregating port. This will fix SDIO
> CMD53(TX/RX) returning -ETIMEDOUT and halting the data path.
>
> fixes: 0cb52aac4 ('mwifiex: do not set multiport flag for tx/rx single packet')
> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
The correct format is:
Fixes: 0cb52aac4d19 ("mwifiex: do not set multiport flag for tx/rx single packet")
I can fix that. (no pun intended)
--
https://patchwork.kernel.org/patch/9660845/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] Re: mwifiex: Fix invalid port issue
[not found] ` <20170405105212.BA68F60DC7@smtp.codeaurora.org>
@ 2017-04-05 11:17 ` Ganapathi Bhat
0 siblings, 0 replies; 4+ messages in thread
From: Ganapathi Bhat @ 2017-04-05 11:17 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, Cathy Luo, Nishant Sarmukadam
PiBGcm9tOiBLYWxsZSBWYWxvIFttYWlsdG86a3ZhbG9AY29kZWF1cm9yYS5vcmddDQo+IFNlbnQ6
IFdlZG5lc2RheSwgQXByaWwgMDUsIDIwMTcgNDoyMiBQTQ0KPiBUbzogR2FuYXBhdGhpIEJoYXQN
Cj4gQ2M6IGxpbnV4LXdpcmVsZXNzQHZnZXIua2VybmVsLm9yZzsgQ2F0aHkgTHVvOyBOaXNoYW50
IFNhcm11a2FkYW07DQo+IEdhbmFwYXRoaSBCaGF0DQo+IFN1YmplY3Q6IFtFWFRdIFJlOiBtd2lm
aWV4OiBGaXggaW52YWxpZCBwb3J0IGlzc3VlDQo+IA0KPiBHYW5hcGF0aGkgQmhhdCA8Z2JoYXRA
bWFydmVsbC5jb20+IHdyb3RlOg0KPiA+IFdlIGhhdmUgdG8gdXNlIHN0YXJ0IHBvcnQsIGZvciBU
WC9SWCBvZiBzaW5nbGUgcGFja2V0LCBpbnN0ZWFkIG9mDQo+ID4gY3VycmVudCBhZ2dyZWdhdGlu
ZyBwb3J0LiBUaGlzIHdpbGwgZml4IFNESU8NCj4gPiBDTUQ1MyhUWC9SWCkgcmV0dXJuaW5nIC1F
VElNRURPVVQgYW5kIGhhbHRpbmcgdGhlIGRhdGEgcGF0aC4NCj4gPg0KPiA+IGZpeGVzOiAwY2I1
MmFhYzQgKCdtd2lmaWV4OiBkbyBub3Qgc2V0IG11bHRpcG9ydCBmbGFnIGZvciB0eC9yeA0KPiBz
aW5nbGUNCj4gPiBwYWNrZXQnKQ0KPiA+IFNpZ25lZC1vZmYtYnk6IEdhbmFwYXRoaSBCaGF0IDxn
YmhhdEBtYXJ2ZWxsLmNvbT4NCj4gDQo+IFRoZSBjb3JyZWN0IGZvcm1hdCBpczoNCj4gDQo+IEZp
eGVzOiAwY2I1MmFhYzRkMTkgKCJtd2lmaWV4OiBkbyBub3Qgc2V0IG11bHRpcG9ydCBmbGFnIGZv
ciB0eC9yeA0KPiBzaW5nbGUgcGFja2V0IikNCj4gDQo+IEkgY2FuIGZpeCB0aGF0LiAobm8gcHVu
IGludGVuZGVkKQ0KDQpUaGFua3MgS2FsbGUuIEkgd2lsbCBmb2xsb3cgdGhlIHNhbWUgaW4gZnV0
dXJlLg0KDQo+IA0KPiAtLQ0KPiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzk2
NjA4NDUvDQo+IA0KPiBodHRwczovL3dpcmVsZXNzLndpa2kua2VybmVsLm9yZy9lbi9kZXZlbG9w
ZXJzL2RvY3VtZW50YXRpb24vc3VibWl0dGluZw0KPiBwYXRjaGVzDQoNCg0KUmVnYXJkcywNCkdh
bmFwYXRoaQ0K
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: mwifiex: Fix invalid port issue
2017-04-04 4:46 [PATCH] mwifiex: Fix invalid port issue Ganapathi Bhat
2017-04-05 10:52 ` Kalle Valo
[not found] ` <20170405105212.BA68F60DC7@smtp.codeaurora.org>
@ 2017-04-13 14:05 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2017-04-13 14:05 UTC (permalink / raw)
To: Ganapathi Bhat
Cc: linux-wireless, Cathy Luo, Nishant Sarmukadam, Ganapathi Bhat
Ganapathi Bhat <gbhat@marvell.com> wrote:
> We have to use start port, for TX/RX of single packet,
> instead of current aggregating port. This will fix SDIO
> CMD53(TX/RX) returning -ETIMEDOUT and halting the data path.
>
> Fixes: 0cb52aac4d19 ("mwifiex: do not set multiport flag for tx/rx single packet")
> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
Patch applied to wireless-drivers-next.git, thanks.
ecd7eb7c2bcf mwifiex: Fix invalid port issue
--
https://patchwork.kernel.org/patch/9660845/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-13 14:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04 4:46 [PATCH] mwifiex: Fix invalid port issue Ganapathi Bhat
2017-04-05 10:52 ` Kalle Valo
[not found] ` <20170405105212.BA68F60DC7@smtp.codeaurora.org>
2017-04-05 11:17 ` [EXT] " Ganapathi Bhat
2017-04-13 14:05 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.