* [PATCH v2 1/4] Staging: vt6655: Modify line over 80 characters
2019-03-05 16:31 [PATCH v2 0/4] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
@ 2019-03-05 16:31 ` Madhumitha Prabakaran
2019-03-05 16:31 ` [PATCH v2 2/4] Staging: vt6655: Fix " Madhumitha Prabakaran
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 16:31 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Fix the warning issued by checkpatch.pl
WARNING: line over 80 characters
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/card.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
index d71022aa3f86..6bbbbe1314d5 100644
--- a/drivers/staging/vt6655/card.h
+++ b/drivers/staging/vt6655/card.h
@@ -44,7 +44,8 @@ struct vnt_private;
void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type);
void CARDvUpdateBasicTopRate(struct vnt_private *priv);
bool CARDbIsOFDMinBasicRate(struct vnt_private *priv);
-void CARDvSetLoopbackMode(struct vnt_private *priv, unsigned short wLoopbackMode);
+void CARDvSetLoopbackMode(struct vnt_private *priv,
+ unsigned short wLoopbackMode);
bool CARDbSoftwareReset(struct vnt_private *priv);
void CARDvSetFirstNextTBTT(struct vnt_private *priv,
unsigned short wBeaconInterval);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/4] Staging: vt6655: Fix line over 80 characters
2019-03-05 16:31 [PATCH v2 0/4] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
2019-03-05 16:31 ` [PATCH v2 1/4] Staging: vt6655: Modify line over 80 characters Madhumitha Prabakaran
@ 2019-03-05 16:31 ` Madhumitha Prabakaran
2019-03-06 9:20 ` Greg KH
2019-03-05 16:31 ` [PATCH v2 3/4] Staging: vt6655: Fix spelling mistake Madhumitha Prabakaran
2019-03-05 16:31 ` [PATCH v2 4/4] Staging: vt6655: Fix space around binary operator Madhumitha Prabakaran
3 siblings, 1 reply; 6+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 16:31 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Fix the warning by checkpatch.pl
WARNING: line over 80 characters
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/card.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
index 6bbbbe1314d5..490cecf8fb9d 100644
--- a/drivers/staging/vt6655/card.h
+++ b/drivers/staging/vt6655/card.h
@@ -62,6 +62,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv);
bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type);
bool CARDbUpdateTSF(struct vnt_private *priv, unsigned char byRxRate,
u64 qwBSSTimestamp);
-bool CARDbSetBeaconPeriod(struct vnt_private *priv, unsigned short wBeaconInterval);
+bool CARDbSetBeaconPeriod(struct vnt_private *priv,
+ unsigned short wBeaconInterval);
#endif /* __CARD_H__ */
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/4] Staging: vt6655: Fix line over 80 characters
2019-03-05 16:31 ` [PATCH v2 2/4] Staging: vt6655: Fix " Madhumitha Prabakaran
@ 2019-03-06 9:20 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2019-03-06 9:20 UTC (permalink / raw)
To: Madhumitha Prabakaran; +Cc: forest, outreachy-kernel
On Tue, Mar 05, 2019 at 10:31:56AM -0600, Madhumitha Prabakaran wrote:
> Fix the warning by checkpatch.pl
> WARNING: line over 80 characters
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> drivers/staging/vt6655/card.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
This should be merged with patch 1/4 of this series. Don't do the same
thing to the same file one line at a time. You can do the same single
"type" of change to a whole file at once.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 3/4] Staging: vt6655: Fix spelling mistake
2019-03-05 16:31 [PATCH v2 0/4] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
2019-03-05 16:31 ` [PATCH v2 1/4] Staging: vt6655: Modify line over 80 characters Madhumitha Prabakaran
2019-03-05 16:31 ` [PATCH v2 2/4] Staging: vt6655: Fix " Madhumitha Prabakaran
@ 2019-03-05 16:31 ` Madhumitha Prabakaran
2019-03-05 16:31 ` [PATCH v2 4/4] Staging: vt6655: Fix space around binary operator Madhumitha Prabakaran
3 siblings, 0 replies; 6+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 16:31 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Fix the check for spelling mistake
CHECK: 'Regsiter' may be misspelled - perhaps 'Register'
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/rf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index 03b0d56dbe9e..825b6ab5c0de 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -163,7 +163,7 @@ static const unsigned long dwAL7230InitTable[CB_AL7230_INIT_SEQ] = {
0x841FF200 + (BY_AL7230_REG_LEN << 3) + IFREGCTL_REGW, /* Need modify for 11a: 451FE2 */
0x3FDFA300 + (BY_AL7230_REG_LEN << 3) + IFREGCTL_REGW, /* Need modify for 11a: 5FDFA3 */
0x7FD78400 + (BY_AL7230_REG_LEN << 3) + IFREGCTL_REGW, /* 11b/g // Need modify for 11a */
- /* RoberYu:20050113, Rev0.47 Regsiter Setting Guide */
+ /* RoberYu:20050113, Rev0.47 Register Setting Guide */
0x802B5500 + (BY_AL7230_REG_LEN << 3) + IFREGCTL_REGW, /* Need modify for 11a: 8D1B55 */
0x56AF3600 + (BY_AL7230_REG_LEN << 3) + IFREGCTL_REGW,
0xCE020700 + (BY_AL7230_REG_LEN << 3) + IFREGCTL_REGW, /* Need modify for 11a: 860207 */
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 4/4] Staging: vt6655: Fix space around binary operator
2019-03-05 16:31 [PATCH v2 0/4] Staging: vt6655: Fix checkpatch.pl issues Madhumitha Prabakaran
` (2 preceding siblings ...)
2019-03-05 16:31 ` [PATCH v2 3/4] Staging: vt6655: Fix spelling mistake Madhumitha Prabakaran
@ 2019-03-05 16:31 ` Madhumitha Prabakaran
3 siblings, 0 replies; 6+ messages in thread
From: Madhumitha Prabakaran @ 2019-03-05 16:31 UTC (permalink / raw)
To: forest, gregkh, outreachy-kernel; +Cc: Madhumitha Prabakaran
Fix the check as per Linux kernel style for use of spaces
CHECK: spaces preferred around that '-'
Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
drivers/staging/vt6655/rf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index 825b6ab5c0de..fd09b9771cf5 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -792,7 +792,7 @@ bool RFbSetPower(
byDec = byPwr + 10;
if (byDec >= priv->byMaxPwrLevel)
- byDec = priv->byMaxPwrLevel-1;
+ byDec = priv->byMaxPwrLevel - 1;
byPwr = byDec;
break;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread