All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] constify infiniband pci_device_id.
@ 2017-07-16  6:30 ` Arvind Yadav
  0 siblings, 0 replies; 7+ messages in thread
From: Arvind Yadav @ 2017-07-16  6:30 UTC (permalink / raw)
  To: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA, aditr-pghWNbHTmq7QT0dZR+AlfA,
	pv-drivers-pghWNbHTmq7QT0dZR+AlfA,
	sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
	dledford-H+wXaHxf7aLQT0dZR+AlfA,
	hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Arvind Yadav (3):
  [PATCH 1/3] infiniband: mthca: constify pci_device_id.
  [PATCH 2/3] infiniband: nes: constify pci_device_id.
  [PATCH 3/3] infiniband: pvrdma: constify pci_device_id.

 drivers/infiniband/hw/mthca/mthca_main.c       | 2 +-
 drivers/infiniband/hw/nes/nes.c                | 2 +-
 drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 0/3] constify infiniband pci_device_id.
@ 2017-07-16  6:30 ` Arvind Yadav
  0 siblings, 0 replies; 7+ messages in thread
From: Arvind Yadav @ 2017-07-16  6:30 UTC (permalink / raw)
  To: linux-kernel, linux-rdma, aditr, pv-drivers, sean.hefty,
	dledford, hal.rosenstock

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Arvind Yadav (3):
  [PATCH 1/3] infiniband: mthca: constify pci_device_id.
  [PATCH 2/3] infiniband: nes: constify pci_device_id.
  [PATCH 3/3] infiniband: pvrdma: constify pci_device_id.

 drivers/infiniband/hw/mthca/mthca_main.c       | 2 +-
 drivers/infiniband/hw/nes/nes.c                | 2 +-
 drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 1/3] infiniband: mthca: constify pci_device_id.
  2017-07-16  6:30 ` Arvind Yadav
  (?)
@ 2017-07-16  6:30 ` Arvind Yadav
  -1 siblings, 0 replies; 7+ messages in thread
From: Arvind Yadav @ 2017-07-16  6:30 UTC (permalink / raw)
  To: linux-kernel, linux-rdma, aditr, pv-drivers, sean.hefty,
	dledford, hal.rosenstock

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  13067	    805	      4	  13876	   3634	infiniband/hw/mthca/mthca_main.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  13419	    453	      4	  13876	   3634	infiniband/hw/mthca/mthca_main.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/infiniband/hw/mthca/mthca_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mthca/mthca_main.c b/drivers/infiniband/hw/mthca/mthca_main.c
index c309e5c..5695cda 100644
--- a/drivers/infiniband/hw/mthca/mthca_main.c
+++ b/drivers/infiniband/hw/mthca/mthca_main.c
@@ -1162,7 +1162,7 @@ static void mthca_remove_one(struct pci_dev *pdev)
 	mutex_unlock(&mthca_device_mutex);
 }
 
-static struct pci_device_id mthca_pci_table[] = {
+static const struct pci_device_id mthca_pci_table[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_TAVOR),
 	  .driver_data = TAVOR },
 	{ PCI_DEVICE(PCI_VENDOR_ID_TOPSPIN, PCI_DEVICE_ID_MELLANOX_TAVOR),
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 2/3] infiniband: nes: constify pci_device_id.
  2017-07-16  6:30 ` Arvind Yadav
  (?)
  (?)
@ 2017-07-16  6:30 ` Arvind Yadav
  -1 siblings, 0 replies; 7+ messages in thread
From: Arvind Yadav @ 2017-07-16  6:30 UTC (permalink / raw)
  To: linux-kernel, linux-rdma, aditr, pv-drivers, sean.hefty,
	dledford, hal.rosenstock

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  10429	    780	     33	  11242	   2bea	drivers/infiniband/hw/nes/nes.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  10541	    668	     33	  11242	   2bea	drivers/infiniband/hw/nes/nes.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/infiniband/hw/nes/nes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c
index a30aa65..a47595c 100644
--- a/drivers/infiniband/hw/nes/nes.c
+++ b/drivers/infiniband/hw/nes/nes.c
@@ -102,7 +102,7 @@ static unsigned int ee_flsh_adapter;
 static unsigned int sysfs_nonidx_addr;
 static unsigned int sysfs_idx_addr;
 
-static struct pci_device_id nes_pci_table[] = {
+static const struct pci_device_id nes_pci_table[] = {
 	{ PCI_VDEVICE(NETEFFECT, PCI_DEVICE_ID_NETEFFECT_NE020), },
 	{ PCI_VDEVICE(NETEFFECT, PCI_DEVICE_ID_NETEFFECT_NE020_KR), },
 	{0}
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH 3/3] infiniband: pvrdma: constify pci_device_id.
  2017-07-16  6:30 ` Arvind Yadav
                   ` (2 preceding siblings ...)
  (?)
@ 2017-07-16  6:30 ` Arvind Yadav
  -1 siblings, 0 replies; 7+ messages in thread
From: Arvind Yadav @ 2017-07-16  6:30 UTC (permalink / raw)
  To: linux-kernel, linux-rdma, aditr, pv-drivers, sean.hefty,
	dledford, hal.rosenstock

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  10774	   1872	      8	  12654	   316e infiniband/hw/vmw_pvrdma/pvrdma_main.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  10838	   1808	      8	  12654	   316e infiniband/hw/vmw_pvrdma/pvrdma_main.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
index 34ebc76..2b83530 100644
--- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
+++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
@@ -1078,7 +1078,7 @@ static void pvrdma_pci_remove(struct pci_dev *pdev)
 	pci_set_drvdata(pdev, NULL);
 }
 
-static struct pci_device_id pvrdma_pci_table[] = {
+static const struct pci_device_id pvrdma_pci_table[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_VMWARE, PCI_DEVICE_ID_VMWARE_PVRDMA), },
 	{ 0 },
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH 0/3] constify infiniband pci_device_id.
  2017-07-16  6:30 ` Arvind Yadav
@ 2017-08-18 16:03     ` Doug Ledford
  -1 siblings, 0 replies; 7+ messages in thread
From: Doug Ledford @ 2017-08-18 16:03 UTC (permalink / raw)
  To: Arvind Yadav, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA, aditr-pghWNbHTmq7QT0dZR+AlfA,
	pv-drivers-pghWNbHTmq7QT0dZR+AlfA,
	sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
	hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w

On Sun, 2017-07-16 at 12:00 +0530, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> Arvind Yadav (3):
>   [PATCH 1/3] infiniband: mthca: constify pci_device_id.
>   [PATCH 2/3] infiniband: nes: constify pci_device_id.
>   [PATCH 3/3] infiniband: pvrdma: constify pci_device_id.
> 
>  drivers/infiniband/hw/mthca/mthca_main.c       | 2 +-
>  drivers/infiniband/hw/nes/nes.c                | 2 +-
>  drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

Thanks, series applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 0/3] constify infiniband pci_device_id.
@ 2017-08-18 16:03     ` Doug Ledford
  0 siblings, 0 replies; 7+ messages in thread
From: Doug Ledford @ 2017-08-18 16:03 UTC (permalink / raw)
  To: Arvind Yadav, linux-kernel, linux-rdma, aditr, pv-drivers,
	sean.hefty, hal.rosenstock

On Sun, 2017-07-16 at 12:00 +0530, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> Arvind Yadav (3):
>   [PATCH 1/3] infiniband: mthca: constify pci_device_id.
>   [PATCH 2/3] infiniband: nes: constify pci_device_id.
>   [PATCH 3/3] infiniband: pvrdma: constify pci_device_id.
> 
>  drivers/infiniband/hw/mthca/mthca_main.c       | 2 +-
>  drivers/infiniband/hw/nes/nes.c                | 2 +-
>  drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

Thanks, series applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-08-18 16:03 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-16  6:30 [PATCH 0/3] constify infiniband pci_device_id Arvind Yadav
2017-07-16  6:30 ` Arvind Yadav
2017-07-16  6:30 ` [PATCH 1/3] infiniband: mthca: constify pci_device_id Arvind Yadav
2017-07-16  6:30 ` [PATCH 2/3] infiniband: nes: " Arvind Yadav
2017-07-16  6:30 ` [PATCH 3/3] infiniband: pvrdma: " Arvind Yadav
     [not found] ` <1500186646-28815-1-git-send-email-arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-18 16:03   ` [PATCH 0/3] constify infiniband pci_device_id Doug Ledford
2017-08-18 16:03     ` Doug Ledford

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.