* [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices
@ 2017-07-17 5:34 Qiming Yang
2017-07-17 6:09 ` Yang, Zhiyong
2017-07-18 2:28 ` [PATCH v2] " Qiming Yang
0 siblings, 2 replies; 6+ messages in thread
From: Qiming Yang @ 2017-07-17 5:34 UTC (permalink / raw)
To: dev; +Cc: stable, wenzhuo.lu, Qiming Yang
x550 devices not do interrupt vector mapping before
enable Rx/Tx queue interrupt, makes interrupt mode
can't work neither with igb_uio or VFIO.
Fixes: d2e72774e58c ("ixgbe/base: support X550")
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 9b06ac1..8432482 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -5611,7 +5611,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t direction,
tmp |= (msix_vector << (8 * (queue & 0x3)));
IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
- (hw->mac.type == ixgbe_mac_X540)) {
+ (hw->mac.type == ixgbe_mac_X540)
+ (hw->mac.type == ixgbe_mac_X550)) {
if (direction == -1) {
/* other causes */
idx = ((queue & 1) * 8);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices
2017-07-17 5:34 [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices Qiming Yang
@ 2017-07-17 6:09 ` Yang, Zhiyong
2017-07-18 2:27 ` Yang, Qiming
2017-07-18 2:28 ` [PATCH v2] " Qiming Yang
1 sibling, 1 reply; 6+ messages in thread
From: Yang, Zhiyong @ 2017-07-17 6:09 UTC (permalink / raw)
To: Yang, Qiming, dev; +Cc: stable, Lu, Wenzhuo, Yang, Qiming
Hi，Qiming:
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
> Sent: Monday, July 17, 2017 1:35 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550
> devices
>
> x550 devices not do interrupt vector mapping before enable Rx/Tx queue
> interrupt, makes interrupt mode can't work neither with igb_uio or VFIO.
>
> Fixes: d2e72774e58c ("ixgbe/base: support X550")
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 9b06ac1..8432482 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -5611,7 +5611,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t
> direction,
> tmp |= (msix_vector << (8 * (queue & 0x3)));
> IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
> } else if ((hw->mac.type == ixgbe_mac_82599EB) ||
> - (hw->mac.type == ixgbe_mac_X540)) {
> + (hw->mac.type == ixgbe_mac_X540)
> + (hw->mac.type == ixgbe_mac_X550)) {
It looks like that you forget to add "||"
Thanks
Zhiyong
> if (direction == -1) {
> /* other causes */
> idx = ((queue & 1) * 8);
> --
> 2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices
2017-07-17 6:09 ` Yang, Zhiyong
@ 2017-07-18 2:27 ` Yang, Qiming
0 siblings, 0 replies; 6+ messages in thread
From: Yang, Qiming @ 2017-07-18 2:27 UTC (permalink / raw)
To: Yang, Zhiyong, dev; +Cc: stable, Lu, Wenzhuo
Yes, thanks. I'll send another patch with both fixed other issue.
> -----Original Message-----
> From: Yang, Zhiyong
> Sent: Monday, July 17, 2017 2:09 PM
> To: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550
> devices
>
> Hi，Qiming:
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
> > Sent: Monday, July 17, 2017 1:35 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> > <qiming.yang@intel.com>
> > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for
> > x550 devices
> >
> > x550 devices not do interrupt vector mapping before enable Rx/Tx queue
> > interrupt, makes interrupt mode can't work neither with igb_uio or VFIO.
> >
> > Fixes: d2e72774e58c ("ixgbe/base: support X550")
> >
> > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index 9b06ac1..8432482 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -5611,7 +5611,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t
> > direction,
> > tmp |= (msix_vector << (8 * (queue & 0x3)));
> > IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
> > } else if ((hw->mac.type == ixgbe_mac_82599EB) ||
> > - (hw->mac.type == ixgbe_mac_X540)) {
> > + (hw->mac.type == ixgbe_mac_X540)
> > + (hw->mac.type == ixgbe_mac_X550)) {
>
> It looks like that you forget to add "||"
>
> Thanks
> Zhiyong
>
> > if (direction == -1) {
> > /* other causes */
> > idx = ((queue & 1) * 8);
> > --
> > 2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices
2017-07-17 5:34 [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices Qiming Yang
2017-07-17 6:09 ` Yang, Zhiyong
@ 2017-07-18 2:28 ` Qiming Yang
2017-07-19 9:22 ` Dai, Wei
1 sibling, 1 reply; 6+ messages in thread
From: Qiming Yang @ 2017-07-18 2:28 UTC (permalink / raw)
To: dev; +Cc: stable, wenzhuo.lu, Qiming Yang
x550 devices not do interrupt vector mapping before
enable Rx/Tx queue interrupt, makes interrupt mode
can't work neither with igb_uio or VFIO.
Fixes: d2e72774e58c ("ixgbe/base: support X550")
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
v2 changes:
* fixed other cause interrupt vector map and typo issue
---
drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 9b06ac1..0caafd5 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -5611,7 +5611,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t direction,
tmp |= (msix_vector << (8 * (queue & 0x3)));
IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
- (hw->mac.type == ixgbe_mac_X540)) {
+ (hw->mac.type == ixgbe_mac_X540) ||
+ (hw->mac.type == ixgbe_mac_X550)) {
if (direction == -1) {
/* other causes */
idx = ((queue & 1) * 8);
@@ -5719,6 +5720,7 @@ ixgbe_configure_msix(struct rte_eth_dev *dev)
break;
case ixgbe_mac_82599EB:
case ixgbe_mac_X540:
+ case ixgbe_mac_X550:
ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID);
break;
default:
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices
2017-07-18 2:28 ` [PATCH v2] " Qiming Yang
@ 2017-07-19 9:22 ` Dai, Wei
2017-07-19 10:12 ` [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Dai, Wei @ 2017-07-19 9:22 UTC (permalink / raw)
To: Yang, Qiming, dev; +Cc: stable, Lu, Wenzhuo, Yang, Qiming
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
> Sent: Tuesday, July 18, 2017 10:29 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix Rx/Tx queue interrupt for x550
> devices
>
> x550 devices not do interrupt vector mapping before enable Rx/Tx queue
> interrupt, makes interrupt mode can't work neither with igb_uio or VFIO.
>
> Fixes: d2e72774e58c ("ixgbe/base: support X550")
>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Have looked through datasheet of 82599, X540 and X550.
Acked-by: Wei Dai <wei.dai@intel.com>
> ---
> v2 changes:
> * fixed other cause interrupt vector map and typo issue
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 9b06ac1..0caafd5 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -5611,7 +5611,8 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t
> direction,
> tmp |= (msix_vector << (8 * (queue & 0x3)));
> IXGBE_WRITE_REG(hw, IXGBE_IVAR(idx), tmp);
> } else if ((hw->mac.type == ixgbe_mac_82599EB) ||
> - (hw->mac.type == ixgbe_mac_X540)) {
> + (hw->mac.type == ixgbe_mac_X540) ||
> + (hw->mac.type == ixgbe_mac_X550)) {
> if (direction == -1) {
> /* other causes */
> idx = ((queue & 1) * 8);
> @@ -5719,6 +5720,7 @@ ixgbe_configure_msix(struct rte_eth_dev *dev)
> break;
> case ixgbe_mac_82599EB:
> case ixgbe_mac_X540:
> + case ixgbe_mac_X550:
> ixgbe_set_ivar_map(hw, -1, 1, IXGBE_MISC_VEC_ID);
> break;
> default:
> --
> 2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH v2] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices
2017-07-19 9:22 ` Dai, Wei
@ 2017-07-19 10:12 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2017-07-19 10:12 UTC (permalink / raw)
To: Dai, Wei, Yang, Qiming, dev; +Cc: stable, Lu, Wenzhuo
On 7/19/2017 10:22 AM, Dai, Wei wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
>> Sent: Tuesday, July 18, 2017 10:29 AM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
>> <qiming.yang@intel.com>
>> Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix Rx/Tx queue interrupt for x550
>> devices
>>
>> x550 devices not do interrupt vector mapping before enable Rx/Tx queue
>> interrupt, makes interrupt mode can't work neither with igb_uio or VFIO.
>>
>> Fixes: d2e72774e58c ("ixgbe/base: support X550")
>>
>> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> Have looked through datasheet of 82599, X540 and X550.
> Acked-by: Wei Dai <wei.dai@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-19 10:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-17 5:34 [PATCH] net/ixgbe: fix Rx/Tx queue interrupt for x550 devices Qiming Yang
2017-07-17 6:09 ` Yang, Zhiyong
2017-07-18 2:27 ` Yang, Qiming
2017-07-18 2:28 ` [PATCH v2] " Qiming Yang
2017-07-19 9:22 ` Dai, Wei
2017-07-19 10:12 ` [dpdk-stable] " Ferruh Yigit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.