All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Redfearn <matt.redfearn@imgtec.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: <linux-mips@linux-mips.org>, <akpm@linux-foundation.org>,
	<kbuild-all@01.org>, <arnd@arndb.de>,
	Matt Redfearn <matt.redfearn@imgtec.com>
Subject: [PATCH] CLOCKSOURCE: Fix CLKSRC_PISTACHIO dependencies
Date: Mon, 17 Jul 2017 10:58:09 +0100	[thread overview]
Message-ID: <1500285489-31044-1-git-send-email-matt.redfearn@imgtec.com> (raw)
In-Reply-To: <d5581fe0-2420-655b-3c3c-25c316f05576@mev.co.uk>

In v4.13, CLKSRC_PISTACHIO can select TIMER_OF on architectures without
GENERIC_CLOCKEVENTS, resulting in a struct clock_event_device missing
some required features.
Fix this by depending on GENERIC_CLOCKEVENTS. Additionally, since
Pistachio is a MIPS based SoC, also depend on the MIPS architecture.

Thanks to kbuild test robot for finding this error
(https://lkml.org/lkml/2017/7/16/249)

Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
---

 drivers/clocksource/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index fcae5ca6ac92..40ebb117709b 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -262,7 +262,8 @@ config CLKSRC_LPC32XX
 
 config CLKSRC_PISTACHIO
 	bool "Clocksource for Pistachio SoC" if COMPILE_TEST
-	depends on HAS_IOMEM
+	depends on GENERIC_CLOCKEVENTS && HAS_IOMEM
+	depends on MIPS
 	select TIMER_OF
 	help
 	  Enables the clocksource for the Pistachio SoC.
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Matt Redfearn <matt.redfearn@imgtec.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-mips@linux-mips.org, akpm@linux-foundation.org,
	kbuild-all@01.org, arnd@arndb.de,
	Matt Redfearn <matt.redfearn@imgtec.com>
Subject: [PATCH] CLOCKSOURCE: Fix CLKSRC_PISTACHIO dependencies
Date: Mon, 17 Jul 2017 10:58:09 +0100	[thread overview]
Message-ID: <1500285489-31044-1-git-send-email-matt.redfearn@imgtec.com> (raw)
Message-ID: <20170717095809.4cg3Qy8Ww0drPb-Z6-4wqJlg1P6_LBcURdmChKSvhjI@z> (raw)
In-Reply-To: <d5581fe0-2420-655b-3c3c-25c316f05576@mev.co.uk>

In v4.13, CLKSRC_PISTACHIO can select TIMER_OF on architectures without
GENERIC_CLOCKEVENTS, resulting in a struct clock_event_device missing
some required features.
Fix this by depending on GENERIC_CLOCKEVENTS. Additionally, since
Pistachio is a MIPS based SoC, also depend on the MIPS architecture.

Thanks to kbuild test robot for finding this error
(https://lkml.org/lkml/2017/7/16/249)

Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
---

 drivers/clocksource/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index fcae5ca6ac92..40ebb117709b 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -262,7 +262,8 @@ config CLKSRC_LPC32XX
 
 config CLKSRC_PISTACHIO
 	bool "Clocksource for Pistachio SoC" if COMPILE_TEST
-	depends on HAS_IOMEM
+	depends on GENERIC_CLOCKEVENTS && HAS_IOMEM
+	depends on MIPS
 	select TIMER_OF
 	help
 	  Enables the clocksource for the Pistachio SoC.
-- 
2.7.4

  reply	other threads:[~2017-07-17  9:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-16  3:24 include/linux/kernel.h:860:32: error: dereferencing pointer to incomplete type 'struct clock_event_device' kbuild test robot
2017-07-16 13:50 ` Ian Abbott
2017-07-16 13:50   ` Ian Abbott
2017-07-16 14:14   ` Ian Abbott
2017-07-16 14:14     ` Ian Abbott
2017-07-16 14:23     ` Ian Abbott
2017-07-16 14:23       ` Ian Abbott
2017-07-17  9:58       ` Matt Redfearn [this message]
2017-07-17  9:58         ` [PATCH] CLOCKSOURCE: Fix CLKSRC_PISTACHIO dependencies Matt Redfearn
2017-07-17 10:41         ` James Hogan
2017-07-18  8:25       ` [PATCH v2] " Matt Redfearn
2017-07-18  8:25         ` Matt Redfearn
2017-08-01 12:19         ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500285489-31044-1-git-send-email-matt.redfearn@imgtec.com \
    --to=matt.redfearn@imgtec.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=daniel.lezcano@linaro.org \
    --cc=kbuild-all@01.org \
    --cc=linux-mips@linux-mips.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.