All of lore.kernel.org
 help / color / mirror / Atom feed
From: Smitha T Murthy <smitha.t@samsung.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com,
	a.hajda@samsung.com, mchehab@kernel.org,
	pankaj.dubey@samsung.com, krzk@kernel.org,
	m.szyprowski@samsung.com, s.nawrocki@samsung.com
Subject: Re: [Patch v5 06/12] [media] v4l2-ioctl: add HEVC format description
Date: Mon, 24 Jul 2017 09:58:45 +0530	[thread overview]
Message-ID: <1500870525.16819.1817.camel@smitha-fedora> (raw)
In-Reply-To: <e6e75cae-f195-af56-652e-37c3e51ad70f@xs4all.nl>

On Thu, 2017-07-20 at 15:07 +0200, Hans Verkuil wrote:
> On 19/06/17 07:10, Smitha T Murthy wrote:
> > HEVC is a video coding format
> > 
> > Signed-off-by: Smitha T Murthy <smitha.t@samsung.com>
> > ---
> >  drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> > index e5a2187..4f6f8d9 100644
> > --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> > @@ -1257,6 +1257,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> >  		case V4L2_PIX_FMT_VC1_ANNEX_L:	descr = "VC-1 (SMPTE 412M Annex L)"; break;
> >  		case V4L2_PIX_FMT_VP8:		descr = "VP8"; break;
> >  		case V4L2_PIX_FMT_VP9:		descr = "VP9"; break;
> > +		case V4L2_PIX_FMT_HEVC:		descr = "HEVC"; break;
> 
> Add a little comment at the end of the line: /* aka H.265 */
> 
> After that you can add my:
> 
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> 
> Regards,
> 
> 	Hans
> 
Ok I will make the change. Thanks for the review.

Regards,
Smitha

> >  		case V4L2_PIX_FMT_CPIA1:	descr = "GSPCA CPiA YUV"; break;
> >  		case V4L2_PIX_FMT_WNVA:		descr = "WNVA"; break;
> >  		case V4L2_PIX_FMT_SN9C10X:	descr = "GSPCA SN9C10X"; break;
> > 
> 
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: smitha.t@samsung.com (Smitha T Murthy)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v5 06/12] [media] v4l2-ioctl: add HEVC format description
Date: Mon, 24 Jul 2017 09:58:45 +0530	[thread overview]
Message-ID: <1500870525.16819.1817.camel@smitha-fedora> (raw)
In-Reply-To: <e6e75cae-f195-af56-652e-37c3e51ad70f@xs4all.nl>

On Thu, 2017-07-20 at 15:07 +0200, Hans Verkuil wrote:
> On 19/06/17 07:10, Smitha T Murthy wrote:
> > HEVC is a video coding format
> > 
> > Signed-off-by: Smitha T Murthy <smitha.t@samsung.com>
> > ---
> >  drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> > index e5a2187..4f6f8d9 100644
> > --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> > @@ -1257,6 +1257,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> >  		case V4L2_PIX_FMT_VC1_ANNEX_L:	descr = "VC-1 (SMPTE 412M Annex L)"; break;
> >  		case V4L2_PIX_FMT_VP8:		descr = "VP8"; break;
> >  		case V4L2_PIX_FMT_VP9:		descr = "VP9"; break;
> > +		case V4L2_PIX_FMT_HEVC:		descr = "HEVC"; break;
> 
> Add a little comment at the end of the line: /* aka H.265 */
> 
> After that you can add my:
> 
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> 
> Regards,
> 
> 	Hans
> 
Ok I will make the change. Thanks for the review.

Regards,
Smitha

> >  		case V4L2_PIX_FMT_CPIA1:	descr = "GSPCA CPiA YUV"; break;
> >  		case V4L2_PIX_FMT_WNVA:		descr = "WNVA"; break;
> >  		case V4L2_PIX_FMT_SN9C10X:	descr = "GSPCA SN9C10X"; break;
> > 
> 
> 
> 

  reply	other threads:[~2017-07-24  4:52 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170619052453epcas1p426ebca32768cee57390f39b53d835e81@epcas1p4.samsung.com>
2017-06-19  5:10 ` [Patch v5 00/12] Add MFC v10.10 support Smitha T Murthy
2017-06-19  5:10   ` Smitha T Murthy
     [not found]   ` <CGME20170619052455epcas5p3b0c71e840af3b9022bf69d1058cc94e5@epcas5p3.samsung.com>
2017-06-19  5:10     ` [Patch v5 01/12] [media] s5p-mfc: Rename IS_MFCV8 macro Smitha T Murthy
2017-06-19  5:10       ` Smitha T Murthy
     [not found]   ` <CGME20170619052458epcas5p3ffbe45cb390e87df6bb11980cd7498aa@epcas5p3.samsung.com>
2017-06-19  5:10     ` [Patch v5 02/12] [media] s5p-mfc: Adding initial support for MFC v10.10 Smitha T Murthy
2017-06-19  5:10       ` Smitha T Murthy
     [not found]   ` <CGME20170619052500epcas1p477df788aee11a5a0d3e2defac97e9ae3@epcas1p4.samsung.com>
2017-06-19  5:10     ` [Patch v5 03/12] [media] s5p-mfc: Use min scratch buffer size as provided by F/W Smitha T Murthy
2017-06-19  5:10       ` Smitha T Murthy
     [not found]   ` <CGME20170619052502epcas1p41e0ba072755ca63278f2d4cfdc03ed06@epcas1p4.samsung.com>
2017-06-19  5:10     ` [Patch v5 04/12] [media] s5p-mfc: Support MFCv10.10 buffer requirements Smitha T Murthy
2017-06-19  5:10       ` Smitha T Murthy
2017-06-27 20:30       ` Kamil Debski
2017-06-27 20:30         ` Kamil Debski
2017-06-28  5:06         ` Smitha T Murthy
2017-06-28  5:06           ` Smitha T Murthy
     [not found]   ` <CGME20170619052505epcas5p33a78ee709263cc9ae33cd9383794ca06@epcas5p3.samsung.com>
2017-06-19  5:10     ` [Patch v5 05/12] [media] videodev2.h: Add v4l2 definition for HEVC Smitha T Murthy
2017-06-19  5:10       ` Smitha T Murthy
2017-07-07 14:56       ` Stanimir Varbanov
2017-07-07 14:56         ` Stanimir Varbanov
2017-07-17 11:12         ` Smitha T Murthy
2017-07-17 11:12           ` Smitha T Murthy
2017-07-20 13:07       ` Hans Verkuil
2017-07-20 13:07         ` Hans Verkuil
2017-07-24  4:29         ` Smitha T Murthy
2017-07-24  4:29           ` Smitha T Murthy
     [not found]   ` <CGME20170619052507epcas1p406fa9f6d84baa9c11050b1998021788a@epcas1p4.samsung.com>
2017-06-19  5:10     ` [Patch v5 06/12] [media] v4l2-ioctl: add HEVC format description Smitha T Murthy
2017-06-19  5:10       ` Smitha T Murthy
2017-07-20 13:07       ` Hans Verkuil
2017-07-20 13:07         ` Hans Verkuil
2017-07-24  4:28         ` Smitha T Murthy [this message]
2017-07-24  4:28           ` Smitha T Murthy
     [not found]   ` <CGME20170619052509epcas1p4841f9c3733280a232d35c8624fe80576@epcas1p4.samsung.com>
2017-06-19  5:10     ` [Patch v5 07/12] Documentation: v4l: Documentation for HEVC v4l2 definition Smitha T Murthy
2017-06-19  5:10       ` Smitha T Murthy
     [not found]   ` <CGME20170619052511epcas1p4e79efd3c9f0f8062eeac1ab4884b709e@epcas1p4.samsung.com>
2017-06-19  5:10     ` [Patch v5 08/12] [media] s5p-mfc: Add support for HEVC decoder Smitha T Murthy
2017-06-19  5:10       ` Smitha T Murthy
     [not found]   ` <CGME20170619052514epcas1p45d4b590d673a0ff2a3cf0117d55e656a@epcas1p4.samsung.com>
2017-06-19  5:10     ` [Patch v5 09/12] [media] s5p-mfc: Add VP9 decoder support Smitha T Murthy
2017-06-19  5:10       ` Smitha T Murthy
     [not found]   ` <CGME20170619052516epcas5p349b080cc6c242444d2db1f3c0e1c6f68@epcas5p3.samsung.com>
2017-06-19  5:10     ` [Patch v5 10/12] [media] v4l2: Add v4l2 control IDs for HEVC encoder Smitha T Murthy
2017-06-19  5:10       ` Smitha T Murthy
2017-07-20 13:13       ` Hans Verkuil
2017-07-20 13:13         ` Hans Verkuil
2017-07-24  4:30         ` Smitha T Murthy
2017-07-24  4:30           ` Smitha T Murthy
     [not found]   ` <CGME20170619052519epcas5p3bacba6c01bf2f135e5cd628226f8d24b@epcas5p3.samsung.com>
2017-06-19  5:10     ` [Patch v5 11/12] [media] s5p-mfc: Add support " Smitha T Murthy
2017-06-19  5:10       ` Smitha T Murthy
2017-07-20 13:32       ` Hans Verkuil
2017-07-20 13:32         ` Hans Verkuil
2017-07-24  4:40         ` Smitha T Murthy
2017-07-24  4:40           ` Smitha T Murthy
     [not found]   ` <CGME20170619052521epcas5p36a0bc384d10809dcfe775e6da87ed37b@epcas5p3.samsung.com>
2017-06-19  5:10     ` [Patch v5 12/12] Documention: v4l: Documentation for HEVC CIDs Smitha T Murthy
2017-06-19  5:10       ` Smitha T Murthy
2017-06-28 20:04       ` Kamil Debski
2017-06-28 20:04         ` Kamil Debski
2017-06-30  3:24         ` Smitha T Murthy
2017-06-30  3:24           ` Smitha T Murthy
2017-07-07 14:59       ` Stanimir Varbanov
2017-07-07 14:59         ` Stanimir Varbanov
2017-07-17 11:18         ` Smitha T Murthy
2017-07-17 11:18           ` Smitha T Murthy
2017-07-20 15:46           ` Stanimir Varbanov
2017-07-20 15:46             ` Stanimir Varbanov
2017-07-25  4:53             ` Smitha T Murthy
2017-07-25  4:53               ` Smitha T Murthy
2017-08-17 14:43           ` Stanimir Varbanov
2017-08-17 14:43             ` Stanimir Varbanov
2017-07-20 14:50       ` Hans Verkuil
2017-07-20 14:50         ` Hans Verkuil
2017-07-25  4:48         ` Smitha T Murthy
2017-07-25  4:48           ` Smitha T Murthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500870525.16819.1817.camel@smitha-fedora \
    --to=smitha.t@samsung.com \
    --cc=a.hajda@samsung.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jtp.park@samsung.com \
    --cc=kamil@wypas.org \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mchehab@kernel.org \
    --cc=pankaj.dubey@samsung.com \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.