From: Jerome Brunet <jbrunet@baylibre.com> To: Stephen Boyd <sboyd@codeaurora.org>, Peter De Schrijver <pdeschrijver@nvidia.com> Cc: Michael Turquette <mturquette@baylibre.com>, linux-clk@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>, linux-amlogic@lists.infradead.org, Russell King <linux@armlinux.org.uk>, Linus Walleij <linus.walleij@linaro.org>, Boris Brezillon <boris.brezillon@free-electrons.com> Subject: Re: [PATCH v3 07/10] clk: rollback set_rate_range changes on failure Date: Wed, 26 Jul 2017 19:22:29 +0200 [thread overview] Message-ID: <1501089749.2401.31.camel@baylibre.com> (raw) In-Reply-To: <20170712020233.GV22780@codeaurora.org> On Tue, 2017-07-11 at 19:02 -0700, Stephen Boyd wrote: > On 06/12, Jerome Brunet wrote: > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > > There should be some commit text here describing the problem. > Also a Fixes: tag and please put this earlier in the series. Fixes added but as explained, I dropped this patch after thinking about Peter's observations. The new candidate patch would be [0]. I suggest we discuss this out of the clock protect thread to avoid mixing issues. [0]: https://github.com/jeromebrunet/linux/commit/235e477f346a9e8d115dda257f9f73 834151bd7f > > > --- > > drivers/clk/clk.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > index d91236e70a04..253f1d3f0971 100644 > > --- a/drivers/clk/clk.c > > +++ b/drivers/clk/clk.c > > @@ -1864,6 +1864,7 @@ EXPORT_SYMBOL_GPL(clk_set_rate_protect); > > int clk_set_rate_range(struct clk *clk, unsigned long min, unsigned long > > max) > > { > > int ret = 0; > > + unsigned int old_min, old_max; > > > > if (!clk) > > return 0; > > @@ -1881,9 +1882,16 @@ int clk_set_rate_range(struct clk *clk, unsigned long > > min, unsigned long max) > > clk_core_rate_unprotect(clk->core); > > > > if (min != clk->min_rate || max != clk->max_rate) { > > + old_min = clk->min_rate; > > + old_max = clk->max_rate; > > clk->min_rate = min; > > clk->max_rate = max; > > ret = clk_core_set_rate_nolock(clk->core, clk->core- > > >req_rate); > > + if (ret) { > > + /* undo changes */ > > + clk->min_rate = old_min; > > + clk->max_rate = old_max; > > + } > > } > > > > if (clk->protect_count) > >
WARNING: multiple messages have this Message-ID (diff)
From: jbrunet@baylibre.com (Jerome Brunet) To: linus-amlogic@lists.infradead.org Subject: [PATCH v3 07/10] clk: rollback set_rate_range changes on failure Date: Wed, 26 Jul 2017 19:22:29 +0200 [thread overview] Message-ID: <1501089749.2401.31.camel@baylibre.com> (raw) In-Reply-To: <20170712020233.GV22780@codeaurora.org> On Tue, 2017-07-11 at 19:02 -0700, Stephen Boyd wrote: > On 06/12, Jerome Brunet wrote: > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > > There should be some commit text here describing the problem. > Also a Fixes: tag and please put this earlier in the series. Fixes added but as explained, I dropped this patch after thinking about Peter's observations. The new candidate patch would be [0]. I suggest we discuss this out of the clock protect thread to avoid mixing issues. [0]: https://github.com/jeromebrunet/linux/commit/235e477f346a9e8d115dda257f9f73 834151bd7f > > > --- > > ?drivers/clk/clk.c | 8 ++++++++ > > ?1 file changed, 8 insertions(+) > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > index d91236e70a04..253f1d3f0971 100644 > > --- a/drivers/clk/clk.c > > +++ b/drivers/clk/clk.c > > @@ -1864,6 +1864,7 @@ EXPORT_SYMBOL_GPL(clk_set_rate_protect); > > ?int clk_set_rate_range(struct clk *clk, unsigned long min, unsigned long > > max) > > ?{ > > ? int ret = 0; > > + unsigned int old_min, old_max; > > ? > > ? if (!clk) > > ? return 0; > > @@ -1881,9 +1882,16 @@ int clk_set_rate_range(struct clk *clk, unsigned long > > min, unsigned long max) > > ? clk_core_rate_unprotect(clk->core); > > ? > > ? if (min != clk->min_rate || max != clk->max_rate) { > > + old_min = clk->min_rate; > > + old_max = clk->max_rate; > > ? clk->min_rate = min; > > ? clk->max_rate = max; > > ? ret = clk_core_set_rate_nolock(clk->core, clk->core- > > >req_rate); > > + if (ret) { > > + /* undo changes */ > > + clk->min_rate = old_min; > > + clk->max_rate = old_max; > > + } > > ? } > > ? > > ? if (clk->protect_count) > >
next prev parent reply other threads:[~2017-07-26 17:22 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-12 19:44 [PATCH v3 00/10] clk: implement clock rate protection mechanism Jerome Brunet 2017-06-12 19:44 ` Jerome Brunet 2017-06-12 19:44 ` [PATCH v3 01/10] clk: take the prepare lock out of clk_core_set_parent Jerome Brunet 2017-06-12 19:44 ` Jerome Brunet 2017-07-12 1:21 ` Stephen Boyd 2017-07-12 1:21 ` Stephen Boyd 2017-06-12 19:44 ` [PATCH v3 02/10] clk: add clk_core_set_phase_nolock function Jerome Brunet 2017-06-12 19:44 ` Jerome Brunet 2017-07-12 1:22 ` Stephen Boyd 2017-07-12 1:22 ` Stephen Boyd 2017-06-12 19:44 ` [PATCH v3 03/10] clk: rework calls to round and determine rate callbacks Jerome Brunet 2017-06-12 19:44 ` Jerome Brunet 2017-07-12 1:49 ` Stephen Boyd 2017-07-12 1:49 ` Stephen Boyd 2017-06-12 19:44 ` [PATCH v3 04/10] clk: use round rate to bail out early in set_rate Jerome Brunet 2017-06-12 19:44 ` Jerome Brunet 2017-07-12 2:00 ` Stephen Boyd 2017-07-12 2:00 ` Stephen Boyd 2017-07-26 17:13 ` Jerome Brunet 2017-07-26 17:13 ` Jerome Brunet 2017-08-04 0:32 ` Stephen Boyd 2017-08-04 0:32 ` Stephen Boyd 2017-06-12 19:44 ` [PATCH v3 05/10] clk: add support for clock protection Jerome Brunet 2017-06-12 19:44 ` Jerome Brunet 2017-07-26 0:12 ` Stephen Boyd 2017-07-26 0:12 ` Stephen Boyd 2017-07-26 17:18 ` Jerome Brunet 2017-07-26 17:18 ` Jerome Brunet 2017-08-04 0:18 ` Stephen Boyd 2017-08-04 0:18 ` Stephen Boyd 2017-08-08 22:37 ` Michael Turquette 2017-08-08 22:37 ` Michael Turquette 2017-08-09 2:19 ` Stephen Boyd 2017-08-09 2:19 ` Stephen Boyd 2017-08-09 11:45 ` Russell King - ARM Linux 2017-08-09 11:45 ` Russell King - ARM Linux 2017-08-09 13:34 ` Jerome Brunet 2017-08-09 13:34 ` Jerome Brunet 2017-08-09 13:40 ` Russell King - ARM Linux 2017-08-09 13:40 ` Russell King - ARM Linux 2017-08-09 13:45 ` Jerome Brunet 2017-08-09 13:45 ` Jerome Brunet 2017-08-10 16:48 ` Michael Turquette 2017-08-10 16:48 ` Michael Turquette 2017-08-10 16:46 ` Michael Turquette 2017-08-10 16:46 ` Michael Turquette 2017-08-09 13:07 ` Jerome Brunet 2017-08-09 13:07 ` Jerome Brunet 2017-08-09 12:18 ` Jerome Brunet 2017-08-09 12:18 ` Jerome Brunet 2017-08-10 16:54 ` Michael Turquette 2017-08-10 16:54 ` Michael Turquette 2017-06-12 19:44 ` [PATCH v3 06/10] clk: add clk_set_rate_protect Jerome Brunet 2017-06-12 19:44 ` Jerome Brunet 2017-07-26 0:59 ` Stephen Boyd 2017-07-26 0:59 ` Stephen Boyd 2017-06-12 19:44 ` [PATCH v3 07/10] clk: rollback set_rate_range changes on failure Jerome Brunet 2017-06-12 19:44 ` Jerome Brunet 2017-07-12 2:02 ` Stephen Boyd 2017-07-12 2:02 ` Stephen Boyd 2017-07-26 17:22 ` Jerome Brunet [this message] 2017-07-26 17:22 ` Jerome Brunet 2017-06-12 19:44 ` [PATCH v3 08/10] clk: cosmetic changes to clk_summary debugfs entry Jerome Brunet 2017-06-12 19:44 ` Jerome Brunet 2017-07-12 2:02 ` Stephen Boyd 2017-07-12 2:02 ` Stephen Boyd 2017-06-12 19:44 ` [PATCH v3 09/10] clk: fix incorrect usage of ENOSYS Jerome Brunet 2017-06-12 19:44 ` Jerome Brunet 2017-07-12 2:03 ` Stephen Boyd 2017-07-12 2:03 ` Stephen Boyd 2017-06-12 19:44 ` [PATCH v3 10/10] clk: fix CLK_SET_RATE_GATE with clock rate protection Jerome Brunet 2017-06-12 19:44 ` Jerome Brunet 2017-06-20 9:07 ` [PATCH v3 00/10] clk: implement clock rate protection mechanism Linus Walleij 2017-06-20 9:07 ` Linus Walleij 2017-06-20 10:50 ` Jerome Brunet 2017-06-20 10:50 ` Jerome Brunet 2017-06-20 11:54 ` Linus Walleij 2017-06-20 11:54 ` Linus Walleij 2017-06-20 12:32 ` Jerome Brunet 2017-06-20 12:32 ` Jerome Brunet 2017-06-20 12:47 ` Boris Brezillon 2017-06-20 12:47 ` Boris Brezillon 2017-06-22 7:07 ` Quentin Schulz 2017-06-22 7:07 ` Quentin Schulz 2017-06-22 10:09 ` Jerome Brunet 2017-06-22 10:09 ` Jerome Brunet 2017-06-20 15:29 ` Linus Walleij 2017-06-20 15:29 ` Linus Walleij 2017-06-21 13:15 ` Jerome Brunet 2017-06-21 13:15 ` Jerome Brunet 2017-07-12 1:16 ` Stephen Boyd 2017-07-12 1:16 ` Stephen Boyd 2017-07-26 17:05 ` Jerome Brunet 2017-07-26 17:05 ` Jerome Brunet 2017-07-27 22:44 ` Stephen Boyd 2017-07-27 22:44 ` Stephen Boyd 2017-08-08 22:40 ` Michael Turquette 2017-08-08 22:40 ` Michael Turquette 2017-08-09 12:14 ` Jerome Brunet 2017-08-09 12:14 ` Jerome Brunet 2017-07-11 21:04 ` Jerome Brunet 2017-07-11 21:04 ` Jerome Brunet
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1501089749.2401.31.camel@baylibre.com \ --to=jbrunet@baylibre.com \ --cc=boris.brezillon@free-electrons.com \ --cc=khilman@baylibre.com \ --cc=linus.walleij@linaro.org \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mturquette@baylibre.com \ --cc=pdeschrijver@nvidia.com \ --cc=sboyd@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.