* [PATCH 01/10] agp: uninorth: constify pci_device_id.
2017-08-01 16:01 [PATCH 00/10] constify char pci_device_id Arvind Yadav
@ 2017-08-01 16:01 ` Arvind Yadav
2017-08-04 7:01 ` Dave Airlie
2017-08-01 16:01 ` [PATCH 02/10] agp: amd-k7: " Arvind Yadav
` (8 subsequent siblings)
9 siblings, 1 reply; 12+ messages in thread
From: Arvind Yadav @ 2017-08-01 16:01 UTC (permalink / raw)
To: airlied, gregkh; +Cc: linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/char/agp/uninorth-agp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
index fdced54..c381c8e 100644
--- a/drivers/char/agp/uninorth-agp.c
+++ b/drivers/char/agp/uninorth-agp.c
@@ -679,7 +679,7 @@ static void agp_uninorth_remove(struct pci_dev *pdev)
agp_put_bridge(bridge);
}
-static struct pci_device_id agp_uninorth_pci_table[] = {
+static const struct pci_device_id agp_uninorth_pci_table[] = {
{
.class = (PCI_CLASS_BRIDGE_HOST << 8),
.class_mask = ~0,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 01/10] agp: uninorth: constify pci_device_id.
2017-08-01 16:01 ` [PATCH 01/10] agp: uninorth: constify pci_device_id Arvind Yadav
@ 2017-08-04 7:01 ` Dave Airlie
0 siblings, 0 replies; 12+ messages in thread
From: Dave Airlie @ 2017-08-04 7:01 UTC (permalink / raw)
To: Arvind Yadav; +Cc: gregkh, linux-kernel
On Tue, 1 Aug 2017, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
I've merged all the agp ones into drm-next.
Dave.
> ---
> drivers/char/agp/uninorth-agp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
> index fdced54..c381c8e 100644
> --- a/drivers/char/agp/uninorth-agp.c
> +++ b/drivers/char/agp/uninorth-agp.c
> @@ -679,7 +679,7 @@ static void agp_uninorth_remove(struct pci_dev *pdev)
> agp_put_bridge(bridge);
> }
>
> -static struct pci_device_id agp_uninorth_pci_table[] = {
> +static const struct pci_device_id agp_uninorth_pci_table[] = {
> {
> .class = (PCI_CLASS_BRIDGE_HOST << 8),
> .class_mask = ~0,
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 02/10] agp: amd-k7: constify pci_device_id.
2017-08-01 16:01 [PATCH 00/10] constify char pci_device_id Arvind Yadav
2017-08-01 16:01 ` [PATCH 01/10] agp: uninorth: constify pci_device_id Arvind Yadav
@ 2017-08-01 16:01 ` Arvind Yadav
2017-08-01 16:01 ` [PATCH 03/10] agp: intel: " Arvind Yadav
` (7 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-08-01 16:01 UTC (permalink / raw)
To: airlied, gregkh; +Cc: linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/char/agp/amd-k7-agp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/agp/amd-k7-agp.c b/drivers/char/agp/amd-k7-agp.c
index 5fbd333..b450544 100644
--- a/drivers/char/agp/amd-k7-agp.c
+++ b/drivers/char/agp/amd-k7-agp.c
@@ -21,7 +21,7 @@
#define AMD_TLBFLUSH 0x0c /* In mmio region (32-bit register) */
#define AMD_CACHEENTRY 0x10 /* In mmio region (32-bit register) */
-static struct pci_device_id agp_amdk7_pci_table[];
+static const struct pci_device_id agp_amdk7_pci_table[];
struct amd_page_map {
unsigned long *real;
@@ -508,7 +508,7 @@ static int agp_amdk7_resume(struct pci_dev *pdev)
#endif /* CONFIG_PM */
/* must be the same order as name table above */
-static struct pci_device_id agp_amdk7_pci_table[] = {
+static const struct pci_device_id agp_amdk7_pci_table[] = {
{
.class = (PCI_CLASS_BRIDGE_HOST << 8),
.class_mask = ~0,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 03/10] agp: intel: constify pci_device_id.
2017-08-01 16:01 [PATCH 00/10] constify char pci_device_id Arvind Yadav
2017-08-01 16:01 ` [PATCH 01/10] agp: uninorth: constify pci_device_id Arvind Yadav
2017-08-01 16:01 ` [PATCH 02/10] agp: amd-k7: " Arvind Yadav
@ 2017-08-01 16:01 ` Arvind Yadav
2017-08-01 16:01 ` [PATCH 04/10] agp: ali: " Arvind Yadav
` (6 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-08-01 16:01 UTC (permalink / raw)
To: airlied, gregkh; +Cc: linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/char/agp/intel-agp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
index 0a21dae..9e4f27a 100644
--- a/drivers/char/agp/intel-agp.c
+++ b/drivers/char/agp/intel-agp.c
@@ -828,7 +828,7 @@ static int agp_intel_resume(struct pci_dev *pdev)
}
#endif
-static struct pci_device_id agp_intel_pci_table[] = {
+static const struct pci_device_id agp_intel_pci_table[] = {
#define ID(x) \
{ \
.class = (PCI_CLASS_BRIDGE_HOST << 8), \
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 04/10] agp: ali: constify pci_device_id.
2017-08-01 16:01 [PATCH 00/10] constify char pci_device_id Arvind Yadav
` (2 preceding siblings ...)
2017-08-01 16:01 ` [PATCH 03/10] agp: intel: " Arvind Yadav
@ 2017-08-01 16:01 ` Arvind Yadav
2017-08-01 16:01 ` [PATCH 05/10] agp: ati: " Arvind Yadav
` (5 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-08-01 16:01 UTC (permalink / raw)
To: airlied, gregkh; +Cc: linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/char/agp/ali-agp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/agp/ali-agp.c b/drivers/char/agp/ali-agp.c
index dcbbb4e..89527ba 100644
--- a/drivers/char/agp/ali-agp.c
+++ b/drivers/char/agp/ali-agp.c
@@ -381,7 +381,7 @@ static void agp_ali_remove(struct pci_dev *pdev)
agp_put_bridge(bridge);
}
-static struct pci_device_id agp_ali_pci_table[] = {
+static const struct pci_device_id agp_ali_pci_table[] = {
{
.class = (PCI_CLASS_BRIDGE_HOST << 8),
.class_mask = ~0,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 05/10] agp: ati: constify pci_device_id.
2017-08-01 16:01 [PATCH 00/10] constify char pci_device_id Arvind Yadav
` (3 preceding siblings ...)
2017-08-01 16:01 ` [PATCH 04/10] agp: ali: " Arvind Yadav
@ 2017-08-01 16:01 ` Arvind Yadav
2017-08-01 16:01 ` [PATCH 06/10] agp: efficeon: " Arvind Yadav
` (4 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-08-01 16:01 UTC (permalink / raw)
To: airlied, gregkh; +Cc: linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/char/agp/ati-agp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/agp/ati-agp.c b/drivers/char/agp/ati-agp.c
index 0b5ec7a..88b4cbe 100644
--- a/drivers/char/agp/ati-agp.c
+++ b/drivers/char/agp/ati-agp.c
@@ -540,7 +540,7 @@ static void agp_ati_remove(struct pci_dev *pdev)
agp_put_bridge(bridge);
}
-static struct pci_device_id agp_ati_pci_table[] = {
+static const struct pci_device_id agp_ati_pci_table[] = {
{
.class = (PCI_CLASS_BRIDGE_HOST << 8),
.class_mask = ~0,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 06/10] agp: efficeon: constify pci_device_id.
2017-08-01 16:01 [PATCH 00/10] constify char pci_device_id Arvind Yadav
` (4 preceding siblings ...)
2017-08-01 16:01 ` [PATCH 05/10] agp: ati: " Arvind Yadav
@ 2017-08-01 16:01 ` Arvind Yadav
2017-08-01 16:01 ` [PATCH 07/10] agp: sis: " Arvind Yadav
` (3 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-08-01 16:01 UTC (permalink / raw)
To: airlied, gregkh; +Cc: linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/char/agp/efficeon-agp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/agp/efficeon-agp.c b/drivers/char/agp/efficeon-agp.c
index 533cb6d..7f88490 100644
--- a/drivers/char/agp/efficeon-agp.c
+++ b/drivers/char/agp/efficeon-agp.c
@@ -427,7 +427,7 @@ static int agp_efficeon_resume(struct pci_dev *pdev)
}
#endif
-static struct pci_device_id agp_efficeon_pci_table[] = {
+static const struct pci_device_id agp_efficeon_pci_table[] = {
{
.class = (PCI_CLASS_BRIDGE_HOST << 8),
.class_mask = ~0,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 07/10] agp: sis: constify pci_device_id.
2017-08-01 16:01 [PATCH 00/10] constify char pci_device_id Arvind Yadav
` (5 preceding siblings ...)
2017-08-01 16:01 ` [PATCH 06/10] agp: efficeon: " Arvind Yadav
@ 2017-08-01 16:01 ` Arvind Yadav
2017-08-01 16:01 ` [PATCH 08/10] agp: amd64: " Arvind Yadav
` (2 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-08-01 16:01 UTC (permalink / raw)
To: airlied, gregkh; +Cc: linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/char/agp/sis-agp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/agp/sis-agp.c b/drivers/char/agp/sis-agp.c
index 2c74038..14909fc 100644
--- a/drivers/char/agp/sis-agp.c
+++ b/drivers/char/agp/sis-agp.c
@@ -237,7 +237,7 @@ static int agp_sis_resume(struct pci_dev *pdev)
#endif /* CONFIG_PM */
-static struct pci_device_id agp_sis_pci_table[] = {
+static const struct pci_device_id agp_sis_pci_table[] = {
{
.class = (PCI_CLASS_BRIDGE_HOST << 8),
.class_mask = ~0,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 08/10] agp: amd64: constify pci_device_id.
2017-08-01 16:01 [PATCH 00/10] constify char pci_device_id Arvind Yadav
` (6 preceding siblings ...)
2017-08-01 16:01 ` [PATCH 07/10] agp: sis: " Arvind Yadav
@ 2017-08-01 16:01 ` Arvind Yadav
2017-08-01 16:01 ` [PATCH 09/10] agp: nvidia: " Arvind Yadav
2017-08-01 16:01 ` [PATCH 10/10] applicom: " Arvind Yadav
9 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-08-01 16:01 UTC (permalink / raw)
To: airlied, gregkh; +Cc: linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/char/agp/amd64-agp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
index c99cd19..e50c29c 100644
--- a/drivers/char/agp/amd64-agp.c
+++ b/drivers/char/agp/amd64-agp.c
@@ -610,7 +610,7 @@ static int agp_amd64_resume(struct pci_dev *pdev)
#endif /* CONFIG_PM */
-static struct pci_device_id agp_amd64_pci_table[] = {
+static const struct pci_device_id agp_amd64_pci_table[] = {
{
.class = (PCI_CLASS_BRIDGE_HOST << 8),
.class_mask = ~0,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 09/10] agp: nvidia: constify pci_device_id.
2017-08-01 16:01 [PATCH 00/10] constify char pci_device_id Arvind Yadav
` (7 preceding siblings ...)
2017-08-01 16:01 ` [PATCH 08/10] agp: amd64: " Arvind Yadav
@ 2017-08-01 16:01 ` Arvind Yadav
2017-08-01 16:01 ` [PATCH 10/10] applicom: " Arvind Yadav
9 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-08-01 16:01 UTC (permalink / raw)
To: airlied, gregkh; +Cc: linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/char/agp/nvidia-agp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/agp/nvidia-agp.c b/drivers/char/agp/nvidia-agp.c
index 6c8d39c..828b344 100644
--- a/drivers/char/agp/nvidia-agp.c
+++ b/drivers/char/agp/nvidia-agp.c
@@ -420,7 +420,7 @@ static int agp_nvidia_resume(struct pci_dev *pdev)
#endif
-static struct pci_device_id agp_nvidia_pci_table[] = {
+static const struct pci_device_id agp_nvidia_pci_table[] = {
{
.class = (PCI_CLASS_BRIDGE_HOST << 8),
.class_mask = ~0,
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 10/10] applicom: constify pci_device_id.
2017-08-01 16:01 [PATCH 00/10] constify char pci_device_id Arvind Yadav
` (8 preceding siblings ...)
2017-08-01 16:01 ` [PATCH 09/10] agp: nvidia: " Arvind Yadav
@ 2017-08-01 16:01 ` Arvind Yadav
9 siblings, 0 replies; 12+ messages in thread
From: Arvind Yadav @ 2017-08-01 16:01 UTC (permalink / raw)
To: airlied, gregkh; +Cc: linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/char/applicom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/applicom.c b/drivers/char/applicom.c
index b67263d..c0a5b1f 100644
--- a/drivers/char/applicom.c
+++ b/drivers/char/applicom.c
@@ -67,7 +67,7 @@ static char *applicom_pci_devnames[] = {
"PCI2000PFB"
};
-static struct pci_device_id applicom_pci_tbl[] = {
+static const struct pci_device_id applicom_pci_tbl[] = {
{ PCI_VDEVICE(APPLICOM, PCI_DEVICE_ID_APPLICOM_PCIGENERIC) },
{ PCI_VDEVICE(APPLICOM, PCI_DEVICE_ID_APPLICOM_PCI2000IBS_CAN) },
{ PCI_VDEVICE(APPLICOM, PCI_DEVICE_ID_APPLICOM_PCI2000PFB) },
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread