* [PATCH 0/2] constify atm attribute_group structures.
@ 2017-08-03 8:01 Arvind Yadav
2017-08-03 8:01 ` [PATCH 1/2] atm: solos-pci: constify " Arvind Yadav
2017-08-03 8:01 ` [PATCH 2/2] atm: adummy: " Arvind Yadav
0 siblings, 2 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-08-03 8:01 UTC (permalink / raw)
To: davem, 3chas3; +Cc: linux-atm-general, linux-kernel
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.
Arvind Yadav (2):
[PATCH 1/2] atm: solos-pci: constify attribute_group structures.
[PATCH 2/2] atm: adummy: constify attribute_group structures.
drivers/atm/adummy.c | 2 +-
drivers/atm/solos-pci.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] atm: solos-pci: constify attribute_group structures.
2017-08-03 8:01 [PATCH 0/2] constify atm attribute_group structures Arvind Yadav
@ 2017-08-03 8:01 ` Arvind Yadav
2017-08-03 8:01 ` [PATCH 2/2] atm: adummy: " Arvind Yadav
1 sibling, 0 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-08-03 8:01 UTC (permalink / raw)
To: davem, 3chas3; +Cc: linux-atm-general, linux-kernel
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/atm/solos-pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index c8f2ca6..3f9c37d 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -611,7 +611,7 @@ static ssize_t hardware_show(struct device *dev, struct device_attribute *attr,
NULL
};
-static struct attribute_group solos_attr_group = {
+static const struct attribute_group solos_attr_group = {
.attrs = solos_attrs,
.name = "parameters",
};
@@ -628,7 +628,7 @@ static ssize_t hardware_show(struct device *dev, struct device_attribute *attr,
NULL
};
-static struct attribute_group gpio_attr_group = {
+static const struct attribute_group gpio_attr_group = {
.attrs = gpio_attrs,
.name = "gpio",
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] atm: adummy: constify attribute_group structures.
2017-08-03 8:01 [PATCH 0/2] constify atm attribute_group structures Arvind Yadav
2017-08-03 8:01 ` [PATCH 1/2] atm: solos-pci: constify " Arvind Yadav
@ 2017-08-03 8:01 ` Arvind Yadav
1 sibling, 0 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-08-03 8:01 UTC (permalink / raw)
To: davem, 3chas3; +Cc: linux-atm-general, linux-kernel
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/atm/adummy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/adummy.c b/drivers/atm/adummy.c
index 1fd25e8..da27ddf 100644
--- a/drivers/atm/adummy.c
+++ b/drivers/atm/adummy.c
@@ -71,7 +71,7 @@ static ssize_t __show_signal(struct device *dev,
NULL
};
-static struct attribute_group adummy_group_attrs = {
+static const struct attribute_group adummy_group_attrs = {
.name = NULL, /* We want them in dev's root folder */
.attrs = adummy_attrs
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-03 8:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-03 8:01 [PATCH 0/2] constify atm attribute_group structures Arvind Yadav
2017-08-03 8:01 ` [PATCH 1/2] atm: solos-pci: constify " Arvind Yadav
2017-08-03 8:01 ` [PATCH 2/2] atm: adummy: " Arvind Yadav
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.