All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] net: fman: add support RGMII_TXID to memac
@ 2017-08-04  6:14 Madalin Bucur
  2017-08-04 15:57 ` Joe Hershberger
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Madalin Bucur @ 2017-08-04  6:14 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
 drivers/net/fm/memac.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/fm/memac.c b/drivers/net/fm/memac.c
index 1b5779c..ea50ed3 100644
--- a/drivers/net/fm/memac.c
+++ b/drivers/net/fm/memac.c
@@ -84,6 +84,7 @@ static void memac_set_interface_mode(struct fsl_enet_mac *mac,
 		if_mode |= IF_MODE_GMII;
 		break;
 	case PHY_INTERFACE_MODE_RGMII:
+	case PHY_INTERFACE_MODE_RGMII_TXID:
 		if_mode |= (IF_MODE_GMII | IF_MODE_RG);
 		break;
 	case PHY_INTERFACE_MODE_RMII:
@@ -106,7 +107,8 @@ static void memac_set_interface_mode(struct fsl_enet_mac *mac,
 	if (type != PHY_INTERFACE_MODE_XGMII)
 		if_mode |= IF_MODE_EN_AUTO;
 
-	if (type == PHY_INTERFACE_MODE_RGMII) {
+	if (type == PHY_INTERFACE_MODE_RGMII ||
+	    type == PHY_INTERFACE_MODE_RGMII_TXID) {
 		if_mode &= ~IF_MODE_EN_AUTO;
 		if_mode &= ~IF_MODE_SETSP_MASK;
 		switch (speed) {
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] net: fman: add support RGMII_TXID to memac
  2017-08-04  6:14 [U-Boot] [PATCH] net: fman: add support RGMII_TXID to memac Madalin Bucur
@ 2017-08-04 15:57 ` Joe Hershberger
  2017-08-04 16:03 ` York Sun
  2017-08-14 17:49 ` [U-Boot] " Joe Hershberger
  2 siblings, 0 replies; 4+ messages in thread
From: Joe Hershberger @ 2017-08-04 15:57 UTC (permalink / raw)
  To: u-boot

On Fri, Aug 4, 2017 at 1:14 AM, Madalin Bucur <madalin.bucur@nxp.com> wrote:
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] net: fman: add support RGMII_TXID to memac
  2017-08-04  6:14 [U-Boot] [PATCH] net: fman: add support RGMII_TXID to memac Madalin Bucur
  2017-08-04 15:57 ` Joe Hershberger
@ 2017-08-04 16:03 ` York Sun
  2017-08-14 17:49 ` [U-Boot] " Joe Hershberger
  2 siblings, 0 replies; 4+ messages in thread
From: York Sun @ 2017-08-04 16:03 UTC (permalink / raw)
  To: u-boot

On 08/03/2017 11:15 PM, Madalin Bucur wrote:
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
> ---
>   drivers/net/fm/memac.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/fm/memac.c b/drivers/net/fm/memac.c
> index 1b5779c..ea50ed3 100644
> --- a/drivers/net/fm/memac.c
> +++ b/drivers/net/fm/memac.c
> @@ -84,6 +84,7 @@ static void memac_set_interface_mode(struct fsl_enet_mac *mac,
>   		if_mode |= IF_MODE_GMII;
>   		break;
>   	case PHY_INTERFACE_MODE_RGMII:
> +	case PHY_INTERFACE_MODE_RGMII_TXID:
>   		if_mode |= (IF_MODE_GMII | IF_MODE_RG);
>   		break;
>   	case PHY_INTERFACE_MODE_RMII:
> @@ -106,7 +107,8 @@ static void memac_set_interface_mode(struct fsl_enet_mac *mac,
>   	if (type != PHY_INTERFACE_MODE_XGMII)
>   		if_mode |= IF_MODE_EN_AUTO;
>   
> -	if (type == PHY_INTERFACE_MODE_RGMII) {
> +	if (type == PHY_INTERFACE_MODE_RGMII ||
> +	    type == PHY_INTERFACE_MODE_RGMII_TXID) {
>   		if_mode &= ~IF_MODE_EN_AUTO;
>   		if_mode &= ~IF_MODE_SETSP_MASK;
>   		switch (speed) {
> 

Madalin,

This patch doesn't fix the RGMII port (FM1 at DTSEC3) issue I found on 
LS1043ARDB.
Reverting 5a78a472f6660a72b9343a93791353ac879eeed0 makes this port working.

York

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [U-Boot] net: fman: add support RGMII_TXID to memac
  2017-08-04  6:14 [U-Boot] [PATCH] net: fman: add support RGMII_TXID to memac Madalin Bucur
  2017-08-04 15:57 ` Joe Hershberger
  2017-08-04 16:03 ` York Sun
@ 2017-08-14 17:49 ` Joe Hershberger
  2 siblings, 0 replies; 4+ messages in thread
From: Joe Hershberger @ 2017-08-14 17:49 UTC (permalink / raw)
  To: u-boot

Hi Madalin,

https://patchwork.ozlabs.org/patch/797657/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-14 17:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-04  6:14 [U-Boot] [PATCH] net: fman: add support RGMII_TXID to memac Madalin Bucur
2017-08-04 15:57 ` Joe Hershberger
2017-08-04 16:03 ` York Sun
2017-08-14 17:49 ` [U-Boot] " Joe Hershberger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.