* [U-Boot] [Patch v2] QE: Set QE_IRAM_READY after uploading firmware
@ 2017-08-14 2:22 Zhao Qiang
2017-09-13 2:17 ` York Sun
0 siblings, 1 reply; 2+ messages in thread
From: Zhao Qiang @ 2017-08-14 2:22 UTC (permalink / raw)
To: u-boot
QE_IRAM_READY should be set only after successfully uploading the
firmware.
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2:
- modify commit msg to make it more understandable
drivers/qe/qe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c
index 24e764d..8151068 100644
--- a/drivers/qe/qe.c
+++ b/drivers/qe/qe.c
@@ -225,8 +225,8 @@ void u_qe_init(void)
flush_cache((ulong)addr, cnt * 512);
}
#endif
- u_qe_upload_firmware(addr);
- out_be32(&qe_immr->iram.iready, QE_IRAM_READY);
+ if (!u_qe_upload_firmware(addr))
+ out_be32(&qe_immr->iram.iready, QE_IRAM_READY);
#ifdef CONFIG_SYS_QE_FMAN_FW_IN_MMC
free(addr);
#endif
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [Patch v2] QE: Set QE_IRAM_READY after uploading firmware
2017-08-14 2:22 [U-Boot] [Patch v2] QE: Set QE_IRAM_READY after uploading firmware Zhao Qiang
@ 2017-09-13 2:17 ` York Sun
0 siblings, 0 replies; 2+ messages in thread
From: York Sun @ 2017-09-13 2:17 UTC (permalink / raw)
To: u-boot
On 08/13/2017 07:39 PM, Zhao Qiang wrote:
> QE_IRAM_READY should be set only after successfully uploading the
> firmware.
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2:
> - modify commit msg to make it more understandable
Applied to fsl-qoriq master. Thanks.
York
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-13 2:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-14 2:22 [U-Boot] [Patch v2] QE: Set QE_IRAM_READY after uploading firmware Zhao Qiang
2017-09-13 2:17 ` York Sun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.