* [PATCH 0/2] [media]: make snd_kcontrol_new const
@ 2017-08-16 9:17 Bhumika Goyal
2017-08-16 9:17 ` [PATCH 1/2] [media] cx88: " Bhumika Goyal
2017-08-16 9:17 ` [PATCH 2/2] [media] solo6x10: " Bhumika Goyal
0 siblings, 2 replies; 4+ messages in thread
From: Bhumika Goyal @ 2017-08-16 9:17 UTC (permalink / raw)
To: julia.lawall, mchehab, maintainers, andrey.utkin, ismael,
linux-media, linux-kernel
Cc: Bhumika Goyal
Make these const. Done using Coccinelle.
Bhumika Goyal (2):
[media] cx88: make snd_kcontrol_new const
[media] solo6x10: make snd_kcontrol_new const
drivers/media/pci/cx88/cx88-alsa.c | 2 +-
drivers/media/pci/solo6x10/solo6x10-g723.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] [media] cx88: make snd_kcontrol_new const
2017-08-16 9:17 [PATCH 0/2] [media]: make snd_kcontrol_new const Bhumika Goyal
@ 2017-08-16 9:17 ` Bhumika Goyal
2017-08-16 9:17 ` [PATCH 2/2] [media] solo6x10: " Bhumika Goyal
1 sibling, 0 replies; 4+ messages in thread
From: Bhumika Goyal @ 2017-08-16 9:17 UTC (permalink / raw)
To: julia.lawall, mchehab, maintainers, andrey.utkin, ismael,
linux-media, linux-kernel
Cc: Bhumika Goyal
Make this const as it only passed as the 1st argument to the function
snd_ctl_new1, which is of type const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/media/pci/cx88/cx88-alsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx88/cx88-alsa.c b/drivers/media/pci/cx88/cx88-alsa.c
index c81fe46..9740326 100644
--- a/drivers/media/pci/cx88/cx88-alsa.c
+++ b/drivers/media/pci/cx88/cx88-alsa.c
@@ -799,7 +799,7 @@ static int snd_cx88_alc_put(struct snd_kcontrol *kcontrol,
return 0;
}
-static struct snd_kcontrol_new snd_cx88_alc_switch = {
+static const struct snd_kcontrol_new snd_cx88_alc_switch = {
.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
.name = "Line-In ALC Switch",
.info = snd_ctl_boolean_mono_info,
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] [media] solo6x10: make snd_kcontrol_new const
2017-08-16 9:17 [PATCH 0/2] [media]: make snd_kcontrol_new const Bhumika Goyal
2017-08-16 9:17 ` [PATCH 1/2] [media] cx88: " Bhumika Goyal
@ 2017-08-16 9:17 ` Bhumika Goyal
2017-08-21 12:13 ` Ismael Luceno
1 sibling, 1 reply; 4+ messages in thread
From: Bhumika Goyal @ 2017-08-16 9:17 UTC (permalink / raw)
To: julia.lawall, mchehab, maintainers, andrey.utkin, ismael,
linux-media, linux-kernel
Cc: Bhumika Goyal
Make this const as it is only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/media/pci/solo6x10/solo6x10-g723.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/solo6x10/solo6x10-g723.c b/drivers/media/pci/solo6x10/solo6x10-g723.c
index 3ca9470..81be1b8 100644
--- a/drivers/media/pci/solo6x10/solo6x10-g723.c
+++ b/drivers/media/pci/solo6x10/solo6x10-g723.c
@@ -319,7 +319,7 @@ static int snd_solo_capture_volume_put(struct snd_kcontrol *kcontrol,
return 1;
}
-static struct snd_kcontrol_new snd_solo_capture_volume = {
+static const struct snd_kcontrol_new snd_solo_capture_volume = {
.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
.name = "Capture Volume",
.info = snd_solo_capture_volume_info,
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] [media] solo6x10: make snd_kcontrol_new const
2017-08-16 9:17 ` [PATCH 2/2] [media] solo6x10: " Bhumika Goyal
@ 2017-08-21 12:13 ` Ismael Luceno
0 siblings, 0 replies; 4+ messages in thread
From: Ismael Luceno @ 2017-08-21 12:13 UTC (permalink / raw)
To: Bhumika Goyal
Cc: julia.lawall, mchehab, maintainers, andrey.utkin, linux-media,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On 16/Aug/2017 14:47, Bhumika Goyal wrote:
> Make this const as it is only used during a copy operation.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/media/pci/solo6x10/solo6x10-g723.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-g723.c b/drivers/media/pci/solo6x10/solo6x10-g723.c
> index 3ca9470..81be1b8 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-g723.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-g723.c
> @@ -319,7 +319,7 @@ static int snd_solo_capture_volume_put(struct snd_kcontrol *kcontrol,
> return 1;
> }
>
> -static struct snd_kcontrol_new snd_solo_capture_volume = {
> +static const struct snd_kcontrol_new snd_solo_capture_volume = {
> .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
> .name = "Capture Volume",
> .info = snd_solo_capture_volume_info,
> --
> 1.9.1
>
Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-21 12:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-16 9:17 [PATCH 0/2] [media]: make snd_kcontrol_new const Bhumika Goyal
2017-08-16 9:17 ` [PATCH 1/2] [media] cx88: " Bhumika Goyal
2017-08-16 9:17 ` [PATCH 2/2] [media] solo6x10: " Bhumika Goyal
2017-08-21 12:13 ` Ismael Luceno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.