* [PATCH] drivers: video: Fix 80 character limit and remove unnecessary space
@ 2017-08-21 14:03 ` Himanshu Jha
2017-08-23 16:12 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 5+ messages in thread
From: Himanshu Jha @ 2017-08-21 14:03 UTC (permalink / raw)
To: b.zolnierkie; +Cc: linux-kernel, Himanshu Jha
Fixes the following checkpatch warnings:
WARNING: line over 80 characters
WARNING: space prohibited between function name and open parenthesis '('
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/video/vgastate.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video/vgastate.c b/drivers/video/vgastate.c
index 548c751..a52283d 100644
--- a/drivers/video/vgastate.c
+++ b/drivers/video/vgastate.c
@@ -31,8 +31,9 @@ struct regstate {
__u8 misc;
};
-static inline unsigned char vga_rcrtcs(void __iomem *regbase, unsigned short iobase,
- unsigned char reg)
+static inline unsigned char vga_rcrtcs(void __iomem *regbase,
+ unsigned short iobase,
+ unsigned char reg)
{
vga_w(regbase, iobase + 0x4, reg);
return vga_r(regbase, iobase + 0x5);
@@ -454,8 +455,9 @@ int save_vga(struct vgastate *state)
}
return 0;
}
+EXPORT_SYMBOL(save_vga);
-int restore_vga (struct vgastate *state)
+int restore_vga(struct vgastate *state)
{
if (state->vidstate == NULL)
return 1;
@@ -480,8 +482,6 @@ int restore_vga (struct vgastate *state)
vga_cleanup(state);
return 0;
}
-
-EXPORT_SYMBOL(save_vga);
EXPORT_SYMBOL(restore_vga);
MODULE_AUTHOR("James Simmons <jsimmons@users.sf.net>");
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: video: Fix 80 character limit and remove unnecessary space
2017-08-21 14:03 ` [PATCH] drivers: video: Fix 80 character limit and remove unnecessary space Himanshu Jha
@ 2017-08-23 16:12 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-23 16:12 UTC (permalink / raw)
To: Himanshu Jha; +Cc: linux-kernel, linux-fbdev
Hi,
Please use a more descriptive patch subject, i.e.
"fbdev: vgastate: fix checkpatch.pl reported warnings".
Please also cc: fbdev mailing list (linux-fbdev@vger.kernel.org
on fbdev patches).
On Monday, August 21, 2017 07:33:51 PM Himanshu Jha wrote:
> Fixes the following checkpatch warnings:
> WARNING: line over 80 characters
> WARNING: space prohibited between function name and open parenthesis '('
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
> drivers/video/vgastate.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/vgastate.c b/drivers/video/vgastate.c
> index 548c751..a52283d 100644
> --- a/drivers/video/vgastate.c
> +++ b/drivers/video/vgastate.c
> @@ -31,8 +31,9 @@ struct regstate {
> __u8 misc;
> };
>
> -static inline unsigned char vga_rcrtcs(void __iomem *regbase, unsigned short iobase,
> - unsigned char reg)
> +static inline unsigned char vga_rcrtcs(void __iomem *regbase,
> + unsigned short iobase,
> + unsigned char reg)
This is not an improvement and doesn't conform to the kernel CodingStyle.
It should be:
static inline unsigned char vga_rcrtcs(void __iomem *regbase,
unsigned short iobase,
unsigned char reg)
> {
> vga_w(regbase, iobase + 0x4, reg);
> return vga_r(regbase, iobase + 0x5);
> @@ -454,8 +455,9 @@ int save_vga(struct vgastate *state)
> }
> return 0;
> }
> +EXPORT_SYMBOL(save_vga);
>
> -int restore_vga (struct vgastate *state)
> +int restore_vga(struct vgastate *state)
> {
> if (state->vidstate == NULL)
> return 1;
> @@ -480,8 +482,6 @@ int restore_vga (struct vgastate *state)
> vga_cleanup(state);
> return 0;
> }
> -
> -EXPORT_SYMBOL(save_vga);
> EXPORT_SYMBOL(restore_vga);
>
> MODULE_AUTHOR("James Simmons <jsimmons@users.sf.net>");
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: video: Fix 80 character limit and remove unnecessary space
@ 2017-08-23 16:12 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-08-23 16:12 UTC (permalink / raw)
To: Himanshu Jha; +Cc: linux-kernel, linux-fbdev
Hi,
Please use a more descriptive patch subject, i.e.
"fbdev: vgastate: fix checkpatch.pl reported warnings".
Please also cc: fbdev mailing list (linux-fbdev@vger.kernel.org
on fbdev patches).
On Monday, August 21, 2017 07:33:51 PM Himanshu Jha wrote:
> Fixes the following checkpatch warnings:
> WARNING: line over 80 characters
> WARNING: space prohibited between function name and open parenthesis '('
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
> drivers/video/vgastate.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/vgastate.c b/drivers/video/vgastate.c
> index 548c751..a52283d 100644
> --- a/drivers/video/vgastate.c
> +++ b/drivers/video/vgastate.c
> @@ -31,8 +31,9 @@ struct regstate {
> __u8 misc;
> };
>
> -static inline unsigned char vga_rcrtcs(void __iomem *regbase, unsigned short iobase,
> - unsigned char reg)
> +static inline unsigned char vga_rcrtcs(void __iomem *regbase,
> + unsigned short iobase,
> + unsigned char reg)
This is not an improvement and doesn't conform to the kernel CodingStyle.
It should be:
static inline unsigned char vga_rcrtcs(void __iomem *regbase,
unsigned short iobase,
unsigned char reg)
> {
> vga_w(regbase, iobase + 0x4, reg);
> return vga_r(regbase, iobase + 0x5);
> @@ -454,8 +455,9 @@ int save_vga(struct vgastate *state)
> }
> return 0;
> }
> +EXPORT_SYMBOL(save_vga);
>
> -int restore_vga (struct vgastate *state)
> +int restore_vga(struct vgastate *state)
> {
> if (state->vidstate = NULL)
> return 1;
> @@ -480,8 +482,6 @@ int restore_vga (struct vgastate *state)
> vga_cleanup(state);
> return 0;
> }
> -
> -EXPORT_SYMBOL(save_vga);
> EXPORT_SYMBOL(restore_vga);
>
> MODULE_AUTHOR("James Simmons <jsimmons@users.sf.net>");
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: video: Fix 80 character limit and remove unnecessary space
2017-08-23 16:12 ` Bartlomiej Zolnierkiewicz
@ 2017-08-23 21:32 ` Joe Perches
-1 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2017-08-23 21:32 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Himanshu Jha; +Cc: linux-kernel, linux-fbdev
On Wed, 2017-08-23 at 18:12 +0200, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> Please use a more descriptive patch subject, i.e.
> "fbdev: vgastate: fix checkpatch.pl reported warnings".
>
> Please also cc: fbdev mailing list (linux-fbdev@vger.kernel.org
> on fbdev patches).
>
> On Monday, August 21, 2017 07:33:51 PM Himanshu Jha wrote:
> > Fixes the following checkpatch warnings:
> > WARNING: line over 80 characters
> > WARNING: space prohibited between function name and open parenthesis '('
> > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
[]
> > diff --git a/drivers/video/vgastate.c b/drivers/video/vgastate.c
[]
> > @@ -31,8 +31,9 @@ struct regstate {
> > __u8 misc;
> > };
> >
> > -static inline unsigned char vga_rcrtcs(void __iomem *regbase, unsigned short iobase,
> > - unsigned char reg)
> > +static inline unsigned char vga_rcrtcs(void __iomem *regbase,
> > + unsigned short iobase,
> > + unsigned char reg)
>
> This is not an improvement and doesn't conform to the kernel CodingStyle.
>
> It should be:
>
> static inline unsigned char vga_rcrtcs(void __iomem *regbase,
> unsigned short iobase,
> unsigned char reg)
>
> > {
> > vga_w(regbase, iobase + 0x4, reg);
> > return vga_r(regbase, iobase + 0x5);
Better to remove the inline and let the compiler decide too.
Perhaps:
static unsigned char vga_rcrtcs(void __iomem *regbase, unsigned short iobase,
unsigned char reg)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers: video: Fix 80 character limit and remove unnecessary space
@ 2017-08-23 21:32 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2017-08-23 21:32 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Himanshu Jha; +Cc: linux-kernel, linux-fbdev
On Wed, 2017-08-23 at 18:12 +0200, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> Please use a more descriptive patch subject, i.e.
> "fbdev: vgastate: fix checkpatch.pl reported warnings".
>
> Please also cc: fbdev mailing list (linux-fbdev@vger.kernel.org
> on fbdev patches).
>
> On Monday, August 21, 2017 07:33:51 PM Himanshu Jha wrote:
> > Fixes the following checkpatch warnings:
> > WARNING: line over 80 characters
> > WARNING: space prohibited between function name and open parenthesis '('
> > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
[]
> > diff --git a/drivers/video/vgastate.c b/drivers/video/vgastate.c
[]
> > @@ -31,8 +31,9 @@ struct regstate {
> > __u8 misc;
> > };
> >
> > -static inline unsigned char vga_rcrtcs(void __iomem *regbase, unsigned short iobase,
> > - unsigned char reg)
> > +static inline unsigned char vga_rcrtcs(void __iomem *regbase,
> > + unsigned short iobase,
> > + unsigned char reg)
>
> This is not an improvement and doesn't conform to the kernel CodingStyle.
>
> It should be:
>
> static inline unsigned char vga_rcrtcs(void __iomem *regbase,
> unsigned short iobase,
> unsigned char reg)
>
> > {
> > vga_w(regbase, iobase + 0x4, reg);
> > return vga_r(regbase, iobase + 0x5);
Better to remove the inline and let the compiler decide too.
Perhaps:
static unsigned char vga_rcrtcs(void __iomem *regbase, unsigned short iobase,
unsigned char reg)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-23 23:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170821140419epcas1p44df6f964a3977e1305cd4845cfcef783@epcas1p4.samsung.com>
2017-08-21 14:03 ` [PATCH] drivers: video: Fix 80 character limit and remove unnecessary space Himanshu Jha
2017-08-23 16:12 ` Bartlomiej Zolnierkiewicz
2017-08-23 16:12 ` Bartlomiej Zolnierkiewicz
2017-08-23 21:32 ` Joe Perches
2017-08-23 21:32 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.