* [PATCH u-boot v2016.07-aspeed-openbmc] Add MTD and UBI support to ast-g5
@ 2017-08-16 2:09 Adriana Kobylak
2017-08-21 11:03 ` Joel Stanley
2017-08-24 1:34 ` Andrew Jeffery
0 siblings, 2 replies; 9+ messages in thread
From: Adriana Kobylak @ 2017-08-16 2:09 UTC (permalink / raw)
To: joel, raltherr, maxims, miltonm; +Cc: openbmc, Adriana Kobylak
Add MTD and UBI support to the default g5 include, conditioned to
having MTDPARTS_DEFAULT defined.
This allows platforms to enable this support if desired without
adding it by default since it increases the size of u-boot.
Signed-off-by: Adriana Kobylak <anoo@linux.vnet.ibm.com>
---
include/configs/ast-g5-ncsi.h | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/include/configs/ast-g5-ncsi.h b/include/configs/ast-g5-ncsi.h
index 12d6684..b126e6e 100644
--- a/include/configs/ast-g5-ncsi.h
+++ b/include/configs/ast-g5-ncsi.h
@@ -28,4 +28,14 @@
#define CONFIG_HW_WATCHDOG
+/* MTD and UBI */
+#ifdef MTDPARTS_DEFAULT
+#define CONFIG_FLASH_CFI_MTD
+#define CONFIG_CMD_UBI
+#define CONFIG_RBTREE
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+#endif
+
#endif /* __AST_G5_NCSI_CONFIG_H */
--
1.8.2.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH u-boot v2016.07-aspeed-openbmc] Add MTD and UBI support to ast-g5
2017-08-16 2:09 [PATCH u-boot v2016.07-aspeed-openbmc] Add MTD and UBI support to ast-g5 Adriana Kobylak
@ 2017-08-21 11:03 ` Joel Stanley
2017-08-21 14:28 ` anoo
2017-08-24 1:34 ` Andrew Jeffery
1 sibling, 1 reply; 9+ messages in thread
From: Joel Stanley @ 2017-08-21 11:03 UTC (permalink / raw)
To: Adriana Kobylak
Cc: Rick Altherr, Maxim Sloyko, Milton Miller II, OpenBMC Maillist
On Wed, Aug 16, 2017 at 11:39 AM, Adriana Kobylak
<anoo@linux.vnet.ibm.com> wrote:
> Add MTD and UBI support to the default g5 include, conditioned to
> having MTDPARTS_DEFAULT defined.
Can you explain what we're planning on using mtdparts for? As I
understand it this is for specifying the mtd partitions on the command
line.
Are you proposing to move away from the device tree description?
> This allows platforms to enable this support if desired without
> adding it by default since it increases the size of u-boot.
Do you have numbers? It's good to keep track in case we need to go
back and save space in the future.
> Signed-off-by: Adriana Kobylak <anoo@linux.vnet.ibm.com>
> ---
> include/configs/ast-g5-ncsi.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/include/configs/ast-g5-ncsi.h b/include/configs/ast-g5-ncsi.h
> index 12d6684..b126e6e 100644
> --- a/include/configs/ast-g5-ncsi.h
> +++ b/include/configs/ast-g5-ncsi.h
> @@ -28,4 +28,14 @@
>
> #define CONFIG_HW_WATCHDOG
>
> +/* MTD and UBI */
> +#ifdef MTDPARTS_DEFAULT
> +#define CONFIG_FLASH_CFI_MTD
> +#define CONFIG_CMD_UBI
I thought Milton mentioned today that we didn't need to enable the UBI
command in u-boot, but I may have misunderstood.
> +#define CONFIG_RBTREE
> +#define CONFIG_MTD_DEVICE
> +#define CONFIG_MTD_PARTITIONS
> +#define CONFIG_CMD_MTDPARTS
> +#endif
> +
> #endif /* __AST_G5_NCSI_CONFIG_H */
> --
> 1.8.2.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH u-boot v2016.07-aspeed-openbmc] Add MTD and UBI support to ast-g5
2017-08-21 11:03 ` Joel Stanley
@ 2017-08-21 14:28 ` anoo
0 siblings, 0 replies; 9+ messages in thread
From: anoo @ 2017-08-21 14:28 UTC (permalink / raw)
To: Joel Stanley
Cc: Rick Altherr, Maxim Sloyko, Milton Miller II, OpenBMC Maillist,
joel.stan
Thanks Joel, answers inline below.
On 2017-08-21 06:03, Joel Stanley wrote:
> On Wed, Aug 16, 2017 at 11:39 AM, Adriana Kobylak
> <anoo@linux.vnet.ibm.com> wrote:
>> Add MTD and UBI support to the default g5 include, conditioned to
>> having MTDPARTS_DEFAULT defined.
>
> Can you explain what we're planning on using mtdparts for? As I
> understand it this is for specifying the mtd partitions on the command
> line.
>
> Are you proposing to move away from the device tree description?
mtdparts is needed by u-boot to find the kernel in a ubi volume, for
example
the u-boot command "ubi part" requires it.
Implementing the device tree in u-boot could be a future possibility but
the current version of u-boot in openbmc can't read from any other chips
besides the bmc, so we need to duplicate the device tree layout of the
bmc
chip in u-boot for now.
>
>> This allows platforms to enable this support if desired without
>> adding it by default since it increases the size of u-boot.
>
> Do you have numbers? It's good to keep track in case we need to go
> back and save space in the future.
After you mentioned that you saw u-boot increasing by 122kB with an
earlier
patch, I removed UBIFS since it wasn't needed, bringing the increase
down
by 50kB. The new size is 302kB (increase of 72kB over current size).
>
>> Signed-off-by: Adriana Kobylak <anoo@linux.vnet.ibm.com>
>> ---
>> include/configs/ast-g5-ncsi.h | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/include/configs/ast-g5-ncsi.h
>> b/include/configs/ast-g5-ncsi.h
>> index 12d6684..b126e6e 100644
>> --- a/include/configs/ast-g5-ncsi.h
>> +++ b/include/configs/ast-g5-ncsi.h
>> @@ -28,4 +28,14 @@
>>
>> #define CONFIG_HW_WATCHDOG
>>
>> +/* MTD and UBI */
>> +#ifdef MTDPARTS_DEFAULT
>> +#define CONFIG_FLASH_CFI_MTD
>> +#define CONFIG_CMD_UBI
>
> I thought Milton mentioned today that we didn't need to enable the UBI
> command in u-boot, but I may have misunderstood.
It is needed since the kernel is in ubi volume.
>
>> +#define CONFIG_RBTREE
>> +#define CONFIG_MTD_DEVICE
>> +#define CONFIG_MTD_PARTITIONS
>> +#define CONFIG_CMD_MTDPARTS
>> +#endif
>> +
>> #endif /* __AST_G5_NCSI_CONFIG_H */
>> --
>> 1.8.2.2
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH u-boot v2016.07-aspeed-openbmc] Add MTD and UBI support to ast-g5
2017-08-16 2:09 [PATCH u-boot v2016.07-aspeed-openbmc] Add MTD and UBI support to ast-g5 Adriana Kobylak
2017-08-21 11:03 ` Joel Stanley
@ 2017-08-24 1:34 ` Andrew Jeffery
2017-08-24 2:01 ` [PATCH u-boot v2016.07-aspeed-openbmc] Add optional MTD and UBI support to ast-g4 and ast-g5 Adriana Kobylak
1 sibling, 1 reply; 9+ messages in thread
From: Andrew Jeffery @ 2017-08-24 1:34 UTC (permalink / raw)
To: Adriana Kobylak, joel, raltherr, maxims, miltonm; +Cc: openbmc
[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]
On Tue, 2017-08-15 at 21:09 -0500, Adriana Kobylak wrote:
> Add MTD and UBI support to the default g5 include, conditioned to
> having MTDPARTS_DEFAULT defined.
>
> This allows platforms to enable this support if desired without
> adding it by default since it increases the size of u-boot.
>
> Signed-off-by: Adriana Kobylak <anoo@linux.vnet.ibm.com>
> ---
> include/configs/ast-g5-ncsi.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/include/configs/ast-g5-ncsi.h b/include/configs/ast-g5-
> ncsi.h
> index 12d6684..b126e6e 100644
> --- a/include/configs/ast-g5-ncsi.h
> +++ b/include/configs/ast-g5-ncsi.h
I suggest we make this common to all platforms to reduce the configuration
headache. Putting the #defines in ast-g5-ncsi doesn't isolate the change to
Witherspoon, and I think we should avoid further fragmentation e.g. by
introducing a Witherspoon-specific configuration.
If other platforms need to recover the extra space required we can deal with
that on an as-needed basis in the future.
Cheers,
Andrew
> @@ -28,4 +28,14 @@
>
> #define CONFIG_HW_WATCHDOG
>
> +/* MTD and UBI */
> +#ifdef MTDPARTS_DEFAULT
> +#define CONFIG_FLASH_CFI_MTD
> +#define CONFIG_CMD_UBI
> +#define CONFIG_RBTREE
> +#define CONFIG_MTD_DEVICE
> +#define CONFIG_MTD_PARTITIONS
> +#define CONFIG_CMD_MTDPARTS
> +#endif
> +
> #endif /* __AST_G5_NCSI_CONFIG_H */
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH u-boot v2016.07-aspeed-openbmc] Add optional MTD and UBI support to ast-g4 and ast-g5
2017-08-24 1:34 ` Andrew Jeffery
@ 2017-08-24 2:01 ` Adriana Kobylak
2017-08-24 2:31 ` Andrew Jeffery
0 siblings, 1 reply; 9+ messages in thread
From: Adriana Kobylak @ 2017-08-24 2:01 UTC (permalink / raw)
To: andrew, joel; +Cc: openbmc, Adriana Kobylak
Add MTD and UBI support conditioned to having MTDPARTS_DEFAULT defined.
This allows platforms to enable this support if desired without
adding it by default since it increases the size of u-boot by about 70kB.
Signed-off-by: Adriana Kobylak <anoo@linux.vnet.ibm.com>
---
include/configs/ast-g4-ncsi.h | 10 ++++++++++
include/configs/ast-g4-phy.h | 10 ++++++++++
include/configs/ast-g5-ncsi.h | 10 ++++++++++
include/configs/ast-g5-phy.h | 10 ++++++++++
4 files changed, 40 insertions(+)
diff --git a/include/configs/ast-g4-ncsi.h b/include/configs/ast-g4-ncsi.h
index 8191dfc..0ba5a43 100644
--- a/include/configs/ast-g4-ncsi.h
+++ b/include/configs/ast-g4-ncsi.h
@@ -26,4 +26,14 @@
#define CONFIG_CPU_420 1
#define CONFIG_DRAM_528 1
+/* Optional MTD and UBI */
+#ifdef MTDPARTS_DEFAULT
+#define CONFIG_FLASH_CFI_MTD
+#define CONFIG_CMD_UBI
+#define CONFIG_RBTREE
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+#endif
+
#endif /* __AST_G4_NCSI_CONFIG_H */
diff --git a/include/configs/ast-g4-phy.h b/include/configs/ast-g4-phy.h
index baa522f..8b26fa6 100644
--- a/include/configs/ast-g4-phy.h
+++ b/include/configs/ast-g4-phy.h
@@ -28,4 +28,14 @@
#define CONFIG_CPU_420 1
#define CONFIG_DRAM_528 1
+/* Optional MTD and UBI */
+#ifdef MTDPARTS_DEFAULT
+#define CONFIG_FLASH_CFI_MTD
+#define CONFIG_CMD_UBI
+#define CONFIG_RBTREE
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+#endif
+
#endif /* __AST_G4_NCSI_CONFIG_H */
diff --git a/include/configs/ast-g5-ncsi.h b/include/configs/ast-g5-ncsi.h
index 12d6684..167835f 100644
--- a/include/configs/ast-g5-ncsi.h
+++ b/include/configs/ast-g5-ncsi.h
@@ -28,4 +28,14 @@
#define CONFIG_HW_WATCHDOG
+/* Optional MTD and UBI */
+#ifdef MTDPARTS_DEFAULT
+#define CONFIG_FLASH_CFI_MTD
+#define CONFIG_CMD_UBI
+#define CONFIG_RBTREE
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+#endif
+
#endif /* __AST_G5_NCSI_CONFIG_H */
diff --git a/include/configs/ast-g5-phy.h b/include/configs/ast-g5-phy.h
index 62ddb84..c3e2552 100644
--- a/include/configs/ast-g5-phy.h
+++ b/include/configs/ast-g5-phy.h
@@ -30,4 +30,14 @@
/* platform.S */
#define CONFIG_DRAM_ECC_SIZE 0x10000000
+/* Optional MTD and UBI */
+#ifdef MTDPARTS_DEFAULT
+#define CONFIG_FLASH_CFI_MTD
+#define CONFIG_CMD_UBI
+#define CONFIG_RBTREE
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+#endif
+
#endif /* __AST_G5_PHY_CONFIG_H */
--
1.8.2.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH u-boot v2016.07-aspeed-openbmc] Add optional MTD and UBI support to ast-g4 and ast-g5
2017-08-24 2:01 ` [PATCH u-boot v2016.07-aspeed-openbmc] Add optional MTD and UBI support to ast-g4 and ast-g5 Adriana Kobylak
@ 2017-08-24 2:31 ` Andrew Jeffery
2017-08-24 3:18 ` Adriana Kobylak
2017-08-24 3:20 ` [PATCH u-boot v2016.07-aspeed-openbmc] Add optional MTD and UBI support to ast-common Adriana Kobylak
0 siblings, 2 replies; 9+ messages in thread
From: Andrew Jeffery @ 2017-08-24 2:31 UTC (permalink / raw)
To: Adriana Kobylak, joel; +Cc: openbmc
[-- Attachment #1: Type: text/plain, Size: 3448 bytes --]
On Wed, 2017-08-23 at 21:01 -0500, Adriana Kobylak wrote:
> Add MTD and UBI support conditioned to having MTDPARTS_DEFAULT defined.
> This allows platforms to enable this support if desired without
> adding it by default since it increases the size of u-boot by about 70kB.
>
> > Signed-off-by: Adriana Kobylak <anoo@linux.vnet.ibm.com>
> ---
> include/configs/ast-g4-ncsi.h | 10 ++++++++++
> include/configs/ast-g4-phy.h | 10 ++++++++++
> include/configs/ast-g5-ncsi.h | 10 ++++++++++
> include/configs/ast-g5-phy.h | 10 ++++++++++
> 4 files changed, 40 insertions(+)
So my understanding is instead of duplicating the additions we can put
the them once in include/configs/ast-common.h:
$ grep 'ast-common.h' include/configs/ast*
include/configs/ast-g4-ncsi.h:#include <configs/ast-common.h>
include/configs/ast-g4-phy.h:#include <configs/ast-common.h>
include/configs/ast-g5-ncsi.h:#include <configs/ast-common.h>
include/configs/ast-g5-phy.h:#include <configs/ast-common.h>
Sorry for the back-and-forth, but I think that would be a cleaner
solution.
Cheers,
Andrew
>
> diff --git a/include/configs/ast-g4-ncsi.h b/include/configs/ast-g4-ncsi.h
> index 8191dfc..0ba5a43 100644
> --- a/include/configs/ast-g4-ncsi.h
> +++ b/include/configs/ast-g4-ncsi.h
> @@ -26,4 +26,14 @@
> > #define CONFIG_CPU_420 1
> > #define CONFIG_DRAM_528 1
>
> +/* Optional MTD and UBI */
> +#ifdef MTDPARTS_DEFAULT
> +#define CONFIG_FLASH_CFI_MTD
> +#define CONFIG_CMD_UBI
> +#define CONFIG_RBTREE
> +#define CONFIG_MTD_DEVICE
> +#define CONFIG_MTD_PARTITIONS
> +#define CONFIG_CMD_MTDPARTS
> +#endif
> +
> > #endif /* __AST_G4_NCSI_CONFIG_H */
> diff --git a/include/configs/ast-g4-phy.h b/include/configs/ast-g4-phy.h
> index baa522f..8b26fa6 100644
> --- a/include/configs/ast-g4-phy.h
> +++ b/include/configs/ast-g4-phy.h
> @@ -28,4 +28,14 @@
> > #define CONFIG_CPU_420 1
> > #define CONFIG_DRAM_528 1
>
> +/* Optional MTD and UBI */
> +#ifdef MTDPARTS_DEFAULT
> +#define CONFIG_FLASH_CFI_MTD
> +#define CONFIG_CMD_UBI
> +#define CONFIG_RBTREE
> +#define CONFIG_MTD_DEVICE
> +#define CONFIG_MTD_PARTITIONS
> +#define CONFIG_CMD_MTDPARTS
> +#endif
> +
> > #endif /* __AST_G4_NCSI_CONFIG_H */
> diff --git a/include/configs/ast-g5-ncsi.h b/include/configs/ast-g5-ncsi.h
> index 12d6684..167835f 100644
> --- a/include/configs/ast-g5-ncsi.h
> +++ b/include/configs/ast-g5-ncsi.h
> @@ -28,4 +28,14 @@
>
> #define CONFIG_HW_WATCHDOG
>
> +/* Optional MTD and UBI */
> +#ifdef MTDPARTS_DEFAULT
> +#define CONFIG_FLASH_CFI_MTD
> +#define CONFIG_CMD_UBI
> +#define CONFIG_RBTREE
> +#define CONFIG_MTD_DEVICE
> +#define CONFIG_MTD_PARTITIONS
> +#define CONFIG_CMD_MTDPARTS
> +#endif
> +
> > #endif /* __AST_G5_NCSI_CONFIG_H */
> diff --git a/include/configs/ast-g5-phy.h b/include/configs/ast-g5-phy.h
> index 62ddb84..c3e2552 100644
> --- a/include/configs/ast-g5-phy.h
> +++ b/include/configs/ast-g5-phy.h
> @@ -30,4 +30,14 @@
> /* platform.S */
> > > #define CONFIG_DRAM_ECC_SIZE 0x10000000
>
> +/* Optional MTD and UBI */
> +#ifdef MTDPARTS_DEFAULT
> +#define CONFIG_FLASH_CFI_MTD
> +#define CONFIG_CMD_UBI
> +#define CONFIG_RBTREE
> +#define CONFIG_MTD_DEVICE
> +#define CONFIG_MTD_PARTITIONS
> +#define CONFIG_CMD_MTDPARTS
> +#endif
> +
> > #endif /* __AST_G5_PHY_CONFIG_H */
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH u-boot v2016.07-aspeed-openbmc] Add optional MTD and UBI support to ast-g4 and ast-g5
2017-08-24 2:31 ` Andrew Jeffery
@ 2017-08-24 3:18 ` Adriana Kobylak
2017-08-24 3:20 ` [PATCH u-boot v2016.07-aspeed-openbmc] Add optional MTD and UBI support to ast-common Adriana Kobylak
1 sibling, 0 replies; 9+ messages in thread
From: Adriana Kobylak @ 2017-08-24 3:18 UTC (permalink / raw)
To: Andrew Jeffery; +Cc: joel, openbmc
> On Aug 23, 2017, at 9:31 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
>
> On Wed, 2017-08-23 at 21:01 -0500, Adriana Kobylak wrote:
>> Add MTD and UBI support conditioned to having MTDPARTS_DEFAULT defined.
>> This allows platforms to enable this support if desired without
>> adding it by default since it increases the size of u-boot by about 70kB.
>>
>>> Signed-off-by: Adriana Kobylak <anoo@linux.vnet.ibm.com>
>> ---
>> include/configs/ast-g4-ncsi.h | 10 ++++++++++
>> include/configs/ast-g4-phy.h | 10 ++++++++++
>> include/configs/ast-g5-ncsi.h | 10 ++++++++++
>> include/configs/ast-g5-phy.h | 10 ++++++++++
>> 4 files changed, 40 insertions(+)
>
> So my understanding is instead of duplicating the additions we can put
> the them once in include/configs/ast-common.h:
>
> $ grep 'ast-common.h' include/configs/ast*
> include/configs/ast-g4-ncsi.h:#include <configs/ast-common.h>
> include/configs/ast-g4-phy.h:#include <configs/ast-common.h>
> include/configs/ast-g5-ncsi.h:#include <configs/ast-common.h>
> include/configs/ast-g5-phy.h:#include <configs/ast-common.h>
>
> Sorry for the back-and-forth, but I think that would be a cleaner
> solution.
>
Yep, agree. Thanks Andrew for the feedback, better to do it right the first time. Will be sending a new patch in a min.
> Cheers,
>
> Andrew
>
>>
>> diff --git a/include/configs/ast-g4-ncsi.h b/include/configs/ast-g4-ncsi.h
>> index 8191dfc..0ba5a43 100644
>> --- a/include/configs/ast-g4-ncsi.h
>> +++ b/include/configs/ast-g4-ncsi.h
>> @@ -26,4 +26,14 @@
>>> #define CONFIG_CPU_420 1
>>> #define CONFIG_DRAM_528 1
>>
>> +/* Optional MTD and UBI */
>> +#ifdef MTDPARTS_DEFAULT
>> +#define CONFIG_FLASH_CFI_MTD
>> +#define CONFIG_CMD_UBI
>> +#define CONFIG_RBTREE
>> +#define CONFIG_MTD_DEVICE
>> +#define CONFIG_MTD_PARTITIONS
>> +#define CONFIG_CMD_MTDPARTS
>> +#endif
>> +
>>> #endif /* __AST_G4_NCSI_CONFIG_H */
>> diff --git a/include/configs/ast-g4-phy.h b/include/configs/ast-g4-phy.h
>> index baa522f..8b26fa6 100644
>> --- a/include/configs/ast-g4-phy.h
>> +++ b/include/configs/ast-g4-phy.h
>> @@ -28,4 +28,14 @@
>>> #define CONFIG_CPU_420 1
>>> #define CONFIG_DRAM_528 1
>>
>> +/* Optional MTD and UBI */
>> +#ifdef MTDPARTS_DEFAULT
>> +#define CONFIG_FLASH_CFI_MTD
>> +#define CONFIG_CMD_UBI
>> +#define CONFIG_RBTREE
>> +#define CONFIG_MTD_DEVICE
>> +#define CONFIG_MTD_PARTITIONS
>> +#define CONFIG_CMD_MTDPARTS
>> +#endif
>> +
>>> #endif /* __AST_G4_NCSI_CONFIG_H */
>> diff --git a/include/configs/ast-g5-ncsi.h b/include/configs/ast-g5-ncsi.h
>> index 12d6684..167835f 100644
>> --- a/include/configs/ast-g5-ncsi.h
>> +++ b/include/configs/ast-g5-ncsi.h
>> @@ -28,4 +28,14 @@
>>
>> #define CONFIG_HW_WATCHDOG
>>
>> +/* Optional MTD and UBI */
>> +#ifdef MTDPARTS_DEFAULT
>> +#define CONFIG_FLASH_CFI_MTD
>> +#define CONFIG_CMD_UBI
>> +#define CONFIG_RBTREE
>> +#define CONFIG_MTD_DEVICE
>> +#define CONFIG_MTD_PARTITIONS
>> +#define CONFIG_CMD_MTDPARTS
>> +#endif
>> +
>>> #endif /* __AST_G5_NCSI_CONFIG_H */
>> diff --git a/include/configs/ast-g5-phy.h b/include/configs/ast-g5-phy.h
>> index 62ddb84..c3e2552 100644
>> --- a/include/configs/ast-g5-phy.h
>> +++ b/include/configs/ast-g5-phy.h
>> @@ -30,4 +30,14 @@
>> /* platform.S */
>>>> #define CONFIG_DRAM_ECC_SIZE 0x10000000
>>
>> +/* Optional MTD and UBI */
>> +#ifdef MTDPARTS_DEFAULT
>> +#define CONFIG_FLASH_CFI_MTD
>> +#define CONFIG_CMD_UBI
>> +#define CONFIG_RBTREE
>> +#define CONFIG_MTD_DEVICE
>> +#define CONFIG_MTD_PARTITIONS
>> +#define CONFIG_CMD_MTDPARTS
>> +#endif
>> +
>>> #endif /* __AST_G5_PHY_CONFIG_H */
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH u-boot v2016.07-aspeed-openbmc] Add optional MTD and UBI support to ast-common
2017-08-24 2:31 ` Andrew Jeffery
2017-08-24 3:18 ` Adriana Kobylak
@ 2017-08-24 3:20 ` Adriana Kobylak
2017-08-24 5:14 ` Andrew Jeffery
1 sibling, 1 reply; 9+ messages in thread
From: Adriana Kobylak @ 2017-08-24 3:20 UTC (permalink / raw)
To: andrew, joel; +Cc: openbmc, Adriana Kobylak
Add MTD and UBI support conditioned to having MTDPARTS_DEFAULT defined.
This allows platforms to enable this support if desired without
adding it by default since it increases the size of u-boot by about 70kB.
Signed-off-by: Adriana Kobylak <anoo@linux.vnet.ibm.com>
---
include/configs/ast-common.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/include/configs/ast-common.h b/include/configs/ast-common.h
index 110c780..29551ef 100644
--- a/include/configs/ast-common.h
+++ b/include/configs/ast-common.h
@@ -84,6 +84,18 @@
#define CONFIG_SYS_MAXARGS 16
#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
+/*
+ * Optional MTD and UBI support
+ */
+#ifdef MTDPARTS_DEFAULT
+#define CONFIG_FLASH_CFI_MTD
+#define CONFIG_CMD_UBI
+#define CONFIG_RBTREE
+#define CONFIG_MTD_DEVICE
+#define CONFIG_MTD_PARTITIONS
+#define CONFIG_CMD_MTDPARTS
+#endif
+
#define CONFIG_BOOTARGS "console=ttyS4,115200n8 root=/dev/ram rw"
#define CONFIG_AST_SPI_NOR /* AST SPI NOR Flash */
--
1.8.2.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH u-boot v2016.07-aspeed-openbmc] Add optional MTD and UBI support to ast-common
2017-08-24 3:20 ` [PATCH u-boot v2016.07-aspeed-openbmc] Add optional MTD and UBI support to ast-common Adriana Kobylak
@ 2017-08-24 5:14 ` Andrew Jeffery
0 siblings, 0 replies; 9+ messages in thread
From: Andrew Jeffery @ 2017-08-24 5:14 UTC (permalink / raw)
To: Adriana Kobylak, joel; +Cc: openbmc
[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]
On Wed, 2017-08-23 at 22:20 -0500, Adriana Kobylak wrote:
> Add MTD and UBI support conditioned to having MTDPARTS_DEFAULT defined.
> This allows platforms to enable this support if desired without
> adding it by default since it increases the size of u-boot by about 70kB.
>
> Signed-off-by: Adriana Kobylak <anoo@linux.vnet.ibm.com>
Applied to v2016.07-aspeed-openbmc.
Thanks,
Andrew
> ---
> include/configs/ast-common.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/configs/ast-common.h b/include/configs/ast-common.h
> index 110c780..29551ef 100644
> --- a/include/configs/ast-common.h
> +++ b/include/configs/ast-common.h
> @@ -84,6 +84,18 @@
> > #define CONFIG_SYS_MAXARGS 16
> > #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
>
> +/*
> + * Optional MTD and UBI support
> + */
> +#ifdef MTDPARTS_DEFAULT
> +#define CONFIG_FLASH_CFI_MTD
> +#define CONFIG_CMD_UBI
> +#define CONFIG_RBTREE
> +#define CONFIG_MTD_DEVICE
> +#define CONFIG_MTD_PARTITIONS
> +#define CONFIG_CMD_MTDPARTS
> +#endif
> +
> > #define CONFIG_BOOTARGS "console=ttyS4,115200n8 root=/dev/ram rw"
>
> #define CONFIG_AST_SPI_NOR /* AST SPI NOR Flash */
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-08-24 5:14 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-16 2:09 [PATCH u-boot v2016.07-aspeed-openbmc] Add MTD and UBI support to ast-g5 Adriana Kobylak
2017-08-21 11:03 ` Joel Stanley
2017-08-21 14:28 ` anoo
2017-08-24 1:34 ` Andrew Jeffery
2017-08-24 2:01 ` [PATCH u-boot v2016.07-aspeed-openbmc] Add optional MTD and UBI support to ast-g4 and ast-g5 Adriana Kobylak
2017-08-24 2:31 ` Andrew Jeffery
2017-08-24 3:18 ` Adriana Kobylak
2017-08-24 3:20 ` [PATCH u-boot v2016.07-aspeed-openbmc] Add optional MTD and UBI support to ast-common Adriana Kobylak
2017-08-24 5:14 ` Andrew Jeffery
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.