[PATCH i-g-t 0/2] Fixing make install

[PATCH i-g-t 0/2] Fixing make install

[Petri Latvala]

This series makes a 'make install'ed IGT runnable with piglit. One
issue is that piglit expects test-list.txt and test-list-full.txt to
be in the same directory as the test binaries. Another is that the
testlist files were not installed.

Petri Latvala (2):
  tests/Makefile.am: Install test-list*.txt to libexecdir
  intel-ci: Install testlist files to pkgdata dir

 tests/Makefile.am          | 12 ++++++++++--
 tests/intel-ci/Makefile.am |  2 +-
 2 files changed, 11 insertions(+), 3 deletions(-)

-- 
2.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH i-g-t 1/2] tests/Makefile.am: Install test-list*.txt to libexecdir

[Petri Latvala]

Piglit expects test-list*.txt files to be in the same directory as the
test binaries. Installing non-executable files to libexecdir requires
going around some of autotools' sanity checks.

This change should make 'make install':ed IGT runnable with piglit.

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 tests/Makefile.am | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 726e2b2..b96e96a 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -50,6 +50,16 @@ pkglibexec_PROGRAMS = \
 	$(TESTS_progs_X) \
 	$(NULL)
 
+# Piglit expects test-list*.txt to be in the same directory as the
+# tests. pkglibexec_DATA is an invalid combo to autotools, so work
+# around that by defining a new directory variable that is the same as
+# libexec directory and install the .txt files there.
+wrap_libexecdir = $(pkglibexecdir)
+wrap_libexec_DATA = \
+	test-list.txt \
+	test-list-full.txt \
+	$(NULL)
+
 dist_pkglibexec_SCRIPTS = \
 	$(TESTS_scripts) \
 	$(scripts) \
@@ -63,8 +73,6 @@ all-local: .gitignore
 .gitignore: Makefile.sources
 	@echo "$(pkglibexec_PROGRAMS) $(HANG) test-list.txt test-list-full.txt /.gitignore" | sed 's/\s\+/\n/g' | sort > $@
 
-pkgdata_DATA = test-list.txt test-list-full.txt
-
 EXTRA_PROGRAMS = $(HANG)
 EXTRA_DIST = $(common_files) $(check_SCRIPTS)
 
-- 
2.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH i-g-t 2/2] intel-ci: Install testlist files to pkgdata dir

[Petri Latvala]

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 tests/intel-ci/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/intel-ci/Makefile.am b/tests/intel-ci/Makefile.am
index 2e9cca7..b3aff97 100644
--- a/tests/intel-ci/Makefile.am
+++ b/tests/intel-ci/Makefile.am
@@ -1,4 +1,4 @@
-EXTRA_DIST = \
+dist_pkgdata_DATA = \
 	fast-feedback.testlist \
 	fast-feedback-simulation.testlist \
 	meta.testlist \
-- 
2.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for Fixing make install

[Patchwork]

== Series Details ==

Series: Fixing make install
URL   : https://patchwork.freedesktop.org/series/29338/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
29d488034a50cd6fbad792cae61321995f0ab51c aubdump: Log some information about the execbuf calls

with latest DRM-Tip kernel build CI_DRM_3001
068cd5b2db68 drm-tip: 2017y-08m-24d-22h-49m-38s UTC integration manifest

Test gem_ringfill:
        Subgroup basic-default-hang:
                incomplete -> DMESG-WARN (fi-pnv-d510) fdo#101600
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                fail       -> PASS       (fi-snb-2600) fdo#100215 +1
Test prime_vgem:
        Subgroup basic-fence-flip:
                incomplete -> SKIP       (fi-kbl-7560u)

fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215

fi-bdw-5557u     total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:451s
fi-bdw-gvtdvm    total:279  pass:265  dwarn:0   dfail:0   fail:0   skip:14  time:441s
fi-blb-e6850     total:279  pass:224  dwarn:1   dfail:0   fail:0   skip:54  time:364s
fi-bsw-n3050     total:279  pass:243  dwarn:0   dfail:0   fail:0   skip:36  time:554s
fi-bwr-2160      total:279  pass:184  dwarn:0   dfail:0   fail:0   skip:95  time:252s
fi-bxt-j4205     total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:518s
fi-byt-j1900     total:279  pass:254  dwarn:1   dfail:0   fail:0   skip:24  time:526s
fi-byt-n2820     total:279  pass:250  dwarn:1   dfail:0   fail:0   skip:28  time:514s
fi-elk-e7500     total:279  pass:230  dwarn:0   dfail:0   fail:0   skip:49  time:442s
fi-glk-2a        total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:612s
fi-hsw-4770      total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:442s
fi-hsw-4770r     total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:423s
fi-ilk-650       total:279  pass:229  dwarn:0   dfail:0   fail:0   skip:50  time:428s
fi-ivb-3520m     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:500s
fi-ivb-3770      total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:475s
fi-kbl-7500u     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:482s
fi-kbl-7560u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:600s
fi-kbl-r         total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:601s
fi-pnv-d510      total:279  pass:223  dwarn:1   dfail:0   fail:0   skip:55  time:524s
fi-skl-6260u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:472s
fi-skl-6700k     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:487s
fi-skl-6770hq    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:485s
fi-skl-gvtdvm    total:279  pass:266  dwarn:0   dfail:0   fail:0   skip:13  time:442s
fi-skl-x1585l    total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:482s
fi-snb-2520m     total:279  pass:251  dwarn:0   dfail:0   fail:0   skip:28  time:555s
fi-snb-2600      total:279  pass:250  dwarn:0   dfail:0   fail:0   skip:29  time:406s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_98/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.IGT: warning for Fixing make install

[Patchwork]

== Series Details ==

Series: Fixing make install
URL   : https://patchwork.freedesktop.org/series/29338/
State : warning

== Summary ==

Test vgem_basic:
        Subgroup unload:
                pass       -> SKIP       (shard-hsw)

shard-hsw        total:2230 pass:1230 dwarn:0   dfail:0   fail:18  skip:982 time:9623s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_98/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.IGT: warning for Fixing make install

[Daniel Vetter]

On Fri, Aug 25, 2017 at 02:08:33PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: Fixing make install
> URL   : https://patchwork.freedesktop.org/series/29338/
> State : warning
> 
> == Summary ==
> 
> Test vgem_basic:
>         Subgroup unload:
>                 pass       -> SKIP       (shard-hsw)

Also happens on snb, kbl&apl, so looks very real. Please investigate
before pushing.
-Daniel

> 
> shard-hsw        total:2230 pass:1230 dwarn:0   dfail:0   fail:18  skip:982 time:9623s
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_98/shards.html
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.IGT: warning for Fixing make install

[Petri Latvala]

On 08/25/2017 08:20 PM, Daniel Vetter wrote:
> On Fri, Aug 25, 2017 at 02:08:33PM -0000, Patchwork wrote:
>> == Series Details ==
>>
>> Series: Fixing make install
>> URL   : https://patchwork.freedesktop.org/series/29338/
>> State : warning
>>
>> == Summary ==
>>
>> Test vgem_basic:
>>          Subgroup unload:
>>                  pass       -> SKIP       (shard-hsw)
> Also happens on snb, kbl&apl, so looks very real. Please investigate
> before pushing.
>

Is very real, but happens with or without this series.

https://intel-gfx-ci.01.org/tree/drm-tip/shards.html



-- 
Petri Latvala

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 0/2] Fixing make install

[Arkadiusz Hiler]

On Fri, Aug 25, 2017 at 01:13:50PM +0300, Petri Latvala wrote:
> This series makes a 'make install'ed IGT runnable with piglit. One
> issue is that piglit expects test-list.txt and test-list-full.txt to
> be in the same directory as the test binaries. Another is that the
> testlist files were not installed.
> 
> Petri Latvala (2):
>   tests/Makefile.am: Install test-list*.txt to libexecdir
>   intel-ci: Install testlist files to pkgdata dir
> 
>  tests/Makefile.am          | 12 ++++++++++--
>  tests/intel-ci/Makefile.am |  2 +-
>  2 files changed, 11 insertions(+), 3 deletions(-)

Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Tested-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

-- 
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 0/2] Fixing make install

[Petri Latvala]

On Fri, Sep 22, 2017 at 12:03:39PM +0300, Arkadiusz Hiler wrote:
> On Fri, Aug 25, 2017 at 01:13:50PM +0300, Petri Latvala wrote:
> > This series makes a 'make install'ed IGT runnable with piglit. One
> > issue is that piglit expects test-list.txt and test-list-full.txt to
> > be in the same directory as the test binaries. Another is that the
> > testlist files were not installed.
> > 
> > Petri Latvala (2):
> >   tests/Makefile.am: Install test-list*.txt to libexecdir
> >   intel-ci: Install testlist files to pkgdata dir
> > 
> >  tests/Makefile.am          | 12 ++++++++++--
> >  tests/intel-ci/Makefile.am |  2 +-
> >  2 files changed, 11 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Tested-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>


Thanks, pushed the series.


-- 
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx