[15/16] e752x_edac: get rid of polling debug message

[15/16] e752x_edac: get rid of polling debug message

[Aristeu Rozanski]

From: Aristeu Rozanski <aris@redhat.com>

It's noisy and not generally useful, even at low debug priority.

Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
Cc: Mark Gross <mark.gross@intel.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 drivers/edac/e752x_edac.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/edac/e752x_edac.c b/drivers/edac/e752x_edac.c
index 1a352ca..50a623a 100644
--- a/drivers/edac/e752x_edac.c
+++ b/drivers/edac/e752x_edac.c
@@ -981,7 +981,6 @@ static void e752x_check(struct mem_ctl_info *mci)
 {
 	struct e752x_error_info info;
 
-	edac_dbg(3, "\n");
 	e752x_get_error_info(mci, &info);
 	e752x_process_error_info(mci, &info, 1);
 }

[15/16] e752x_edac: get rid of polling debug message

[Gross, Mark]

I don't mind at all.

-mark

> -----Original Message-----
> From: aris@redhat.com [mailto:aris@redhat.com]
> Sent: Friday, August 25, 2017 8:38 AM
> To: Gross, Mark <mark.gross@intel.com>
> Cc: linux-edac@vger.kernel.org; Borislav Petkov <bp@alien8.de>; Mauro
> Carvalho Chehab <mchehab@kernel.org>
> Subject: Re: [PATCH 15/16] e752x_edac: get rid of polling debug message
> 
> Hi Mark,
> On Fri, Aug 25, 2017 at 03:31:07PM +0000, Gross, Mark wrote:
> > Looks ok to me but, there are other debug trace edac_dbg calls all over that
> file.  Why nuke just one?
> >
> > Line 311, 337, 396, 1390, 1404,  all look pretty silly to me too.  (the others
> look ok to me FWIW)
> >
> > Should we clean those out as well while we are at it?
> 
> I'd rather have that fixed in a different patchset, if you don't mind.
> 
> --
> Aristeu
---
To unsubscribe from this list: send the line "unsubscribe linux-edac" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[15/16] e752x_edac: get rid of polling debug message

[Borislav Petkov]

On Fri, Aug 25, 2017 at 11:38:16AM -0400, aris@redhat.com wrote:
> I'd rather have that fixed in a different patchset, if you don't mind.

So you split it into patches for each maintainer to decide and now you
want to fix the remaining ones in a different patchset.

Please do one fix only, per driver, which removes those debug printks in
one go, as the maintainer prefers. Or leave it to the maintainer. But I
don't want patches removing single debug printks.

[15/16] e752x_edac: get rid of polling debug message

[Aristeu Rozanski]

Hi Mark,
On Fri, Aug 25, 2017 at 03:31:07PM +0000, Gross, Mark wrote:
> Looks ok to me but, there are other debug trace edac_dbg calls all over that file.  Why nuke just one?
> 
> Line 311, 337, 396, 1390, 1404,  all look pretty silly to me too.  (the others look ok to me FWIW)
> 
> Should we clean those out as well while we are at it?

I'd rather have that fixed in a different patchset, if you don't mind.

[15/16] e752x_edac: get rid of polling debug message

[Gross, Mark]

Looks ok to me but, there are other debug trace edac_dbg calls all over that file.  Why nuke just one?

Line 311, 337, 396, 1390, 1404,  all look pretty silly to me too.  (the others look ok to me FWIW)

Should we clean those out as well while we are at it?

--mark

> -----Original Message-----
> From: aris@redhat.com [mailto:aris@redhat.com]
> Sent: Friday, August 25, 2017 8:15 AM
> To: linux-edac@vger.kernel.org
> Cc: Aristeu Rozanski <arozansk@redhat.com>; Gross, Mark
> <mark.gross@intel.com>; Borislav Petkov <bp@alien8.de>; Mauro Carvalho
> Chehab <mchehab@kernel.org>
> Subject: [PATCH 15/16] e752x_edac: get rid of polling debug message
> 
> From: Aristeu Rozanski <aris@redhat.com>
> 
> It's noisy and not generally useful, even at low debug priority.
> 
> Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
> Cc: Mark Gross <mark.gross@intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  drivers/edac/e752x_edac.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/edac/e752x_edac.c b/drivers/edac/e752x_edac.c index
> 1a352ca..50a623a 100644
> --- a/drivers/edac/e752x_edac.c
> +++ b/drivers/edac/e752x_edac.c
> @@ -981,7 +981,6 @@ static void e752x_check(struct mem_ctl_info *mci)  {
>  	struct e752x_error_info info;
> 
> -	edac_dbg(3, "\n");
>  	e752x_get_error_info(mci, &info);
>  	e752x_process_error_info(mci, &info, 1);  }
> --
> 1.8.3.1
---
To unsubscribe from this list: send the line "unsubscribe linux-edac" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html