Re: FW: [PATCH 2/3] iommu: mtk: constify iommu_ops

Re: FW: [PATCH 2/3] iommu: mtk: constify iommu_ops

[Yong Wu]

> From: Linux-mediatek [mailto:linux-mediatek-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org] On Behalf Of Arvind Yadav
> Sent: Monday, August 28, 2017 8:12 PM
> To: m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org; joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org; kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; gerald.schaefer-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org
> Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org; linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> Subject: [PATCH 2/3] iommu: mtk: constify iommu_ops
> 
> iommu_ops are not supposed to change at runtime.
> Functions 'iommu_device_set_ops' and 'bus_set_iommu' working with
> const iommu_ops provided by <linux/iommu.h>. So mark the non-const
> structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>


Thanks.

Reviewed-by: Yong Wu <yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

nit, the title should be: iommu/mediatek:xxx

Also, the file mtk_iommu.c may need rebase on[1].

[1]https://lists.linuxfoundation.org/pipermail/iommu/2017-August/023847.html

RE: [PATCH 2/3] iommu: mtk: constify iommu_ops

[Yong Wu]

Hi Arvind,

     This patch looks lost. Could you help resend it after changing the
title to "iommu/mediatek:xxx"?

Thanks.

On Fri, 2018-09-07 at 14:21 +0800, Yong Wu (吴勇) wrote:
> From: Linux-mediatek [mailto:linux-mediatek-bounces@lists.infradead.org] On Behalf Of Arvind Yadav
> Sent: Monday, August 28, 2017 8:12 PM
> To: m.szyprowski@samsung.com; joro@8bytes.org; kgene@kernel.org; krzk@kernel.org; matthias.bgg@gmail.com; gerald.schaefer@de.ibm.com
> Cc: iommu@lists.linux-foundation.org; linux-mediatek@lists.infradead.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: [PATCH 2/3] iommu: mtk: constify iommu_ops
> 
> iommu_ops are not supposed to change at runtime.
> Functions 'iommu_device_set_ops' and 'bus_set_iommu' working with const iommu_ops provided by <linux/iommu.h>. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/iommu/mtk_iommu.c    | 4 ++--
>  drivers/iommu/mtk_iommu_v1.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 91c6d36..eac99a3 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -102,7 +102,7 @@ struct mtk_iommu_domain {
>  	struct iommu_domain		domain;
>  };
>  
> -static struct iommu_ops mtk_iommu_ops;
> +static const struct iommu_ops mtk_iommu_ops;
>  
>  static struct mtk_iommu_domain *to_mtk_domain(struct iommu_domain *dom)  { @@ -437,7 +437,7 @@ static int mtk_iommu_of_xlate(struct device *dev, struct of_phandle_args *args)
>  	return iommu_fwspec_add_ids(dev, args->args, 1);  }
>  
> -static struct iommu_ops mtk_iommu_ops = {
> +static const struct iommu_ops mtk_iommu_ops = {
>  	.domain_alloc	= mtk_iommu_domain_alloc,
>  	.domain_free	= mtk_iommu_domain_free,
>  	.attach_dev	= mtk_iommu_attach_device,
> diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c index bc1efbf..40b231f 100644
> --- a/drivers/iommu/mtk_iommu_v1.c
> +++ b/drivers/iommu/mtk_iommu_v1.c
> @@ -363,7 +363,7 @@ static phys_addr_t mtk_iommu_iova_to_phys(struct iommu_domain *domain,
>  	return pa;
>  }
>  
> -static struct iommu_ops mtk_iommu_ops;
> +static const struct iommu_ops mtk_iommu_ops;
>  
>  /*
>   * MTK generation one iommu HW only support one iommu domain, and all the client @@ -536,7 +536,7 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data *data)
>  	return 0;
>  }
>  
> -static struct iommu_ops mtk_iommu_ops = {
> +static const struct iommu_ops mtk_iommu_ops = {
>  	.domain_alloc	= mtk_iommu_domain_alloc,
>  	.domain_free	= mtk_iommu_domain_free,
>  	.attach_dev	= mtk_iommu_attach_device,
> --
> 1.9.1
> 
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek


_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu